[Bug gold/14570] New: Gold is broken for x32

2012-09-12 Thread hjl.tools at gmail dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=14570

 Bug #: 14570
   Summary: Gold is broken for x32
   Product: binutils
   Version: 2.24 (HEAD)
Status: NEW
  Severity: normal
  Priority: P2
 Component: gold
AssignedTo: i...@airs.com
ReportedBy: hjl.to...@gmail.com
CC: ccout...@google.com
Classification: Unclassified


This commit:

http://sourceware.org/git/?p=binutils.git;a=commit;h=f1a44d332b9e891b517c6397f76d06dfd47abbdd

has

@@ -1409,19 +1414,24 @@ Output_data_got::Got_entry::write(unsigned char* pov) const

 default:
   {
-   const Relobj* object = this->u_.object;
+   const Sized_relobj_file* object
+ = static_cast*>(this->u_.object);
 const unsigned int lsi = this->local_sym_index_;

But Output_data_got is declared as:

template
class Output_data_got : public Output_data_got_base
{
 public:
  typedef typename elfcpp::Elf_types::Elf_Addr Valtype;

The template size parameter is for GOT size, which
is independent of the template size parameter for

// A regular object file.  This is size and endian specific.

template
class Sized_relobj_file : public Sized_relobj
{

It is wrong to use GOT size a template parameter for Sized_relobj_file.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug gold/14570] Gold is broken for x32

2012-09-12 Thread cvs-commit at gcc dot gnu.org 
http://sourceware.org/bugzilla/show_bug.cgi?id=14570

--- Comment #1 from cvs-commit at gcc dot gnu.org  2012-09-12 18:29:24 UTC ---
CVSROOT:/cvs/src
Module name:src
Changes by:i...@sourceware.org2012-09-12 18:29:19

Modified files:
gold   : ChangeLog incremental.h object.h output.cc 

Log message:
PR gold/14570
* output.cc: Rename Output_data_got template parameter from size
to got_size for all functions.  Compile all variants of
Output_data_got.
(Output_data_got::Got_entry::write): Correct use of size for
symbol value.  Use local_is_tls rather than casting to
Sized_relobj_file.
* object.h (class Object): Add local_is_tls and do_local_is_tls.
(class Sized_relobj_file): Add do_local_is_tls.
* incremental.h (class Sized_relobj_incr): Add do_local_is_tls.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/ChangeLog.diff?cvsroot=src&r1=1.957&r2=1.958
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/incremental.h.diff?cvsroot=src&r1=1.32&r2=1.33
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/object.h.diff?cvsroot=src&r1=1.119&r2=1.120
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gold/output.cc.diff?cvsroot=src&r1=1.173&r2=1.174

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug gold/14570] Gold is broken for x32

2012-09-12 Thread hjl.tools at gmail dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=14570

H.J. Lu  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from H.J. Lu  2012-09-12 19:14:28 
UTC ---
Fixed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug gas/14575] New: gas/arm errors on ldralt

2012-09-12 Thread raj.khem at gmail dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=14575

 Bug #: 14575
   Summary: gas/arm errors on ldralt
   Product: binutils
   Version: 2.23
Status: NEW
  Severity: normal
  Priority: P2
 Component: gas
AssignedTo: unassig...@sourceware.org
ReportedBy: raj.k...@gmail.com
Classification: Unclassified


With trunk as well 2.23 gas is erroring out on assembling a valid ldrt
instruction with 'al' conditional code

testcase

/tmp/as.s

ldralt r5,[r1],#4

$ ./gas/as-new -march=armv5te /tmp/a.s
/tmp/a.s: Assembler messages:
/tmp/a.s:1: Error: selected processor does not support ARM mode `ldralt
r5,[r1],#4'


The below commit is the casue of this error

Author: mgretton 
Date:   Fri Aug 24 08:03:38 2012 +

* gas/config/tc-arm.c (do_rm_rn): New function.
(do_strlex): Likewise.
(do_t_strlex): Likewise.
(insns): Add support for LDRA/STRL instructions.
* gas/testsuite/gas/arm/armv8-a-bad.l: Update testcase.
* gas/testsuite/gas/arm/armv8-a-bad.s: Likewise.
* gas/testsuite/gas/arm/armv8-a.d: Likewise.
* gas/testsuite/gas/arm/armv8-a.s: Likewise.
* opcodes/arm-dis.c (arm_opcodes): Add LDRA/STRL instructions.
(thumb32_opcodes): Likewise.
(print_arm_insn): Add support for %<>T formatter.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils

[Bug gas/14575] gas/arm errors on ldralt

2012-09-12 Thread raj.khem at gmail dot com 
http://sourceware.org/bugzilla/show_bug.cgi?id=14575

Khem Raj  changed:

   What|Removed |Added

 CC||Matthew.Gretton-Dann at arm
   ||dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
bug-binutils mailing list
bug-binutils@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-binutils