Hi,
first thank you for this extensive review.
I think that currently we always use i18n macro _("xx") for all our strings -
or we are supposed to.
As you have noticed, this is sometimes useless, particularly when the string is
not subject to
translation.
Maintainers, must we not use _() macro for non-translatable string ?
I don't know if there was such a rule, but this is not clear at least to me.
Tristan.
On Sep 24, 2011, at 9:08 PM, Jorma Karvonen wrote:
> Hi,
>
> I have picked some errors from the source code or from the
> binutils.pot file. I'm sure there will be more bugs, if I have browsed
> the whole source code for binutils (missing translations).
>
> Best regards,
>
> Jorma Karvonen
>
> #: addr2line.c:271
> #, c-format
> msgid " at "
>
> Is this "at" an address or a function or something? It is difficult to
> translate due to missing context.
>
> #: addr2line.c:296
> #, c-format
> msgid " (inlined by) "
>
> by who ? Missing context here too.
>
> ar.c:1024
>bfd_fatal ("could not create temporary file whilst writing archive");
>
> should be:
>bfd_fatal (_("could not create temporary file whilst writing archive"));
>
> , I think.
>
> The following three should be:
>
> bucomm.c:228
>case BFD_ENDIAN_BIG: return _("big endian");
> bucomm.c:229
>case BFD_ENDIAN_LITTLE: return _("little endian");
> bucomm.c:230
>default: return _("endianness unknown");
>
> , I think.
>
> The following should be:
>
> bucomm.c:251
> printf (_("%s\n (header %s, data %s)\n"), p->name,
>
> , I think.
>
> I wonder, if setlocale could be used here:
>
> bucomm.c:430
> const char *ctime_result = (const char *) ctime (&when);
>
> /* POSIX format: skip weekday and seconds from ctime output. */
> sprintf (timebuf, "%.12s %.4s", ctime_result + 4, ctime_result + 20);
>
> The following shoud maybe be:
>
> coffdump.c:130
> printf (_("size %d "), p->size);
> coffdump.c:135
> printf (_("section definition at %x size %x\n"),
> coffdump.c:141
> /* Pointer is pointing to coff_pointer_type */
> printf (_("pointer to"));
> coffdump.c:146
> /* a coff_type array */
> printf (_("array [%d] of"), p->u.array.dim);
> coffdump.c:151
> printf (_("function returning"));
> coffdump.c:155
> printf (_("arguments"));
> coffdump.c:159
> printf (_("code"));
> coffdump.c:165
> printf (_("structure definition"));
> coffdump.c:171
> printf (_("structure ref to UNKNOWN struct"));
> coffdump.c:173
> printf (_("structure ref to %s"), p->u.aenumref.ref->name);
> coffdump.c:176
> printf (_("enum ref to %s"), p->u.astructref.ref->name);
> coffdump.c:179
> printf (_("enum definition"));
> coffdump.c:252
> printf (_("Stack offset %x"), p->offset);
> coffdump.c:255
> printf (_("Memory section %s+%x"), p->section->name, p->offset);
> coffdump.c:258
> printf (_("Register %d"), p->offset);
> coffdump.c:261
> printf (_("Struct Member offset %x"), p->offset);
> coffdump.c:264
> printf (_("Enum Member offset %x"), p->offset);
> coffdump.c:267
> printf (_("Undefined symbol"));
> coffdump.c:334
> printf (_("List of symbols"));
> coffdump.c:341
> printf (_("Symbol %s, tag %d, number %d"), p->name, p->tag, p->number);
> coffdump.c:345
> printf (_("Type"));
> coffdump.c:350
> printf (_("Where"));
> coffdump.c:354
> printf (_("Visible"));
> coffdump.c:369
> printf (_("List of blocks"));
> printf (" %" BFD_VMA_FMT "x ",(bfd_vma) (uintptr_t) p);
> coffdump.c:384
> /* number of symbols */
> printf (_("vars %d"), p->nvars);
> coffdump.c:385
> printf (_("blocks"));
> coffdump.c:403
> printf (_("List of source files"));
> coffdump.c:409
> printf (_("Source file %s"), p->name);
> coffdump.c:423
> /* nrelocs is the number of the coff_reloc structs in a coff_section */
> printf (_("section %s %d %d address %x size %x number %d nrelocs %d"),
> coffdump.c:446
> printf (_("Coff dump"));
> coffdump.c:448
> printf (_("#sources %d"), ptr->nsources);
>
> sysdump.c:66
>return _("*undefined*");
> sysdump.c:503
> printf (_("GOT A %x\n"), c);
> sysdump.c:503
> printf (_("WANTED %x!!\n"), x);
> sysdump.c:539
> tab (1, _("SYMBOL INFO"));
> sysdump.c:557
> tab (1, _("DERIVED TYPE"));
> sysdump.c:614
> tab (1, _("MODULE***\n"));
>
> dlltool.c:1266
> printf (_("VERSION %d.%d\n"), major, minor);
> dlltool.c:1314
> inform (_("run: %s %s"), what, args);
>
> dllwrap.c:417
> warn (_("wait: %s"), strerror (errno));
>
> dwarf.c:132
> error (_("Wrong size in print_dwarf_vma"));
> dwarf.c:356,360,364
> printf (_("(%s"), <-- PLS, REMOVE THIS
>
> In the following should be "UNKNOWN", not "UNKNOW":
> dwarf.c:370
> printf (_("UNKNOW DW_LNE_HP_SFC opcode (%u)\n"), opc);
> dwarf.c:1075
> printf (_("size: %s "),
> dwarf.c:1098
> printf ("DW_OP_GNU_push_tls_address ");
> printf (_("o
