[Bug binutils/11700] 'UPAGES' undeclared in compiling trad-core.c

2010-06-16 Thread nickc at redhat dot com

--- Additional Comments From nickc at redhat dot com  2010-06-16 14:17 
---
Hi Harry,

  I am not sure that this is really a binutils problem.  The three constants:
UPAGES, HOST_TEXT_START_ADDR and HOST_STACK_END_ADDR should all be defined in
the system header file sys/user.h.  To me it sounds as though you need to find
out why they are missing from the version of sys/user.h that you have in your
sysroot.

Cheers
  Nick


-- 
   What|Removed |Added

 Status|NEW |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=11700

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11700] 'UPAGES' undeclared in compiling trad-core.c

2010-06-16 Thread schwab at linux-m68k dot org

--- Additional Comments From schwab at linux-m68k dot org  2010-06-16 14:24 
---
http://sourceware.org/git/?p=glibc-
ports.git;a=commit;h=08b1b36387286ed1ba48c56a32e52429b5ef6963

-- 
   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution||INVALID


http://sourceware.org/bugzilla/show_bug.cgi?id=11700

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


Re: windres bug in -I/--input-dir option

2010-06-16 Thread Nick Clifton

Hi Anthony,


If you specify "res" as an include directory via the "-I"
or "--include-dir=" options, windres mistakenly assumes
this to be the output format (and issues a warning saying
to use "-J" instead). The workaround if you have such an
input directory named "res" is to specify it as "./res",
though this really shouldn't be necessary.


I am not sure if this important enough to be worth fixing.  Especially 
there is a simple workaround as you have mentioned.  I have a patch that 
will correct the behaviour (attached) but it has the potential to 
confuse users used to the old, deprecated, behaviour.  If you really 
feel that this feature needs to be corrected in the sources please open 
a bug report on the binutils bugzilla system and I will make the patch 
official:


  http://sourceware.org/bugzilla

Cheers
  Nick Clifton



Index: binutils/windres.c
===
RCS file: /cvs/src/src/binutils/windres.c,v
retrieving revision 1.41
diff -c -3 -p -r1.41 windres.c
*** binutils/windres.c	16 Nov 2009 11:12:37 -	1.41
--- binutils/windres.c	16 Jun 2010 14:43:23 -
***
*** 45,50 
--- 45,51 
  #include "safe-ctype.h"
  #include "obstack.h"
  #include "windres.h"
+ #include 
  
  /* Used by resrc.c at least.  */
  
*** main (int argc, char **argv)
*** 918,927 
  	  input_format_tmp = format_from_name (optarg, 0);
  	  if (input_format_tmp != RES_FORMAT_UNKNOWN)
  	{
! 	  fprintf (stderr,
! 	  	   _("Option -I is deprecated for setting the input format, please use -J instead.\n"));
! 	  input_format = input_format_tmp;
! 	  break;
  	}
  
  	  if (preprocargs == NULL)
--- 919,941 
  	  input_format_tmp = format_from_name (optarg, 0);
  	  if (input_format_tmp != RES_FORMAT_UNKNOWN)
  	{
! 	  struct stat statbuf;
! 	  char modebuf[11];
! 	  
! 	  if (stat (optarg, & statbuf) == 0
! 		  /* Coded this way to avoid importing knowledge of S_ISDIR into this file.  */
! 		  && (mode_string (statbuf.st_mode, modebuf), modebuf[0] == 'd'))
! 		/* We have a -I option with a directory name that just happens
! 		   to match a format name as well.  eg: -I res  Assume that the
! 		   user knows what they are doing and do not complain.  */
! 		;
! 	  else
! 		{
! 		  fprintf (stderr,
! 			   _("Option -I is deprecated for setting the input format, please use -J instead.\n"));
! 		  input_format = input_format_tmp;
! 		  break;
! 		}
  	}
  
  	  if (preprocargs == NULL)
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11676] objdump -d forget 0e float prefix

2010-06-16 Thread nickc at redhat dot com

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2010-06-16 
15:13 ---
Subject: Bug 11676

CVSROOT:/cvs/src
Module name:src
Changes by: ni...@sourceware.org2010-06-16 15:12:51

Modified files:
opcodes: ChangeLog m68k-dis.c 
gas/testsuite  : ChangeLog 
gas/testsuite/gas/m68k: all.exp 
Added files:
gas/testsuite/gas/m68k: pr11676.d pr11676.s 

Log message:
2010-06-16  Vincent Rivire  

PR binutils/11676
* m68k-dis.c (print_insn_arg): Prefix float constants with #0e.

2010-06-16  Nick Clifton  

PR binutils/11676
* gas/m68k/pr11676.s: New test.
* gas/m68k/pr11676.d: Expected disassembly.
* gas/m68k/all.exp: Run the new test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog.diff?cvsroot=src&r1=1.1595&r2=1.1596
http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/m68k-dis.c.diff?cvsroot=src&r1=1.36&r2=1.37
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1677&r2=1.1678
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/m68k/pr11676.d.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/m68k/pr11676.s.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/m68k/all.exp.diff?cvsroot=src&r1=1.20&r2=1.21


--- Additional Comments From nickc at redhat dot com  2010-06-16 15:13 
---
Hi Vincent,

  Thanks for reporting this problem.  I have applied your patch and created a
gas testcase for it as well.

Cheers
  Nick


-- 
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11676

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/11675] -- oformat binary or srec broken

2010-06-16 Thread nickc at redhat dot com

--- Additional Comments From nickc at redhat dot com  2010-06-16 16:18 
---
Hi Vincent,

  I am unable to reproduce this problem.  Please could you provide a small test
case that demonstrates it ?  (Note - I did run the ld-srec tests but although
the tests failed to link there were no segmentation faults.  This was with a
m68k-elf targeted toolchain running on an i686-pc-linux-gnu host).

Cheers
  Nick


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=11675

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug ld/11675] -- oformat binary or srec broken

2010-06-16 Thread nickc at redhat dot com


-- 
   What|Removed |Added

 Status|NEW |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=11675

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug gas/11673] move.l #1,2(a0) should fail on isab

2010-06-16 Thread nickc at redhat dot com

--- Additional Comments From cvs-commit at gcc dot gnu dot org  2010-06-16 
16:28 ---
Subject: Bug 11673

CVSROOT:/cvs/src
Module name:src
Changes by: ni...@sourceware.org2010-06-16 16:27:38

Modified files:
opcodes: ChangeLog m68k-opc.c 
gas/testsuite  : ChangeLog 
gas/testsuite/gas/m68k: all.exp 

Log message:
PR gas/11673
* m68k-opc.c (m68k_opcodes): Remove move.l for isab and later.

* gas/m68k/p11673.s: New test.
* gas/m68k/all.exp: Run the new test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/ChangeLog.diff?cvsroot=src&r1=1.1596&r2=1.1597
http://sourceware.org/cgi-bin/cvsweb.cgi/src/opcodes/m68k-opc.c.diff?cvsroot=src&r1=1.33&r2=1.34
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1678&r2=1.1679
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/testsuite/gas/m68k/all.exp.diff?cvsroot=src&r1=1.21&r2=1.22


--- Additional Comments From nickc at redhat dot com  2010-06-16 16:29 
---
Hi Vincent,

  Thank you for the bug report and patch.  I have applied your patch and created
a couple of ChangeLog entries to go along with them.  (For future reference it
helps if you can supply these yourself when you create a patch).

  Your patch include an extra file: gas/testsuite/gas/m68k/my.exp which I assume
was extraneous, so I did not include it in the check-in.

Cheers
  Nick


-- 
   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11673

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


[Bug binutils/11711] New: directory names conflict with windres include directories

2010-06-16 Thread anthony dot penniston at hotmail dot com
When specifying include directories for windres via the "-I" or "--include-dir="
options that also happen to match input formats (i.e. a directory named "res"),
windres assumes they are the latter and outputs a warning. This obscure
backwards-compatibility reference causes confusion and is only briefly mentioned
in the windres manual which still does not explain the following problems:

1) The warning is emitted even if including a -J option which explicitly
specifies the input format. I.E. "windres -J res -I res" should make it obvious
that the -I option refers to an input directory and not an input format.

2) Using the "--include-dir=" should also make it explicit that
"--include-dir=res" is specifying an include dir named "res" and not an input
format.

3) Quoting the the input directory as in "-I "res"" should also make it explicit
that a directory is being provided rather than an input format.

4) Any gains in backwards-compat. surely out-weigh those lost in forwards- and
cross-compatibility (i.e. see the "/I" option in RC:
http://msdn.microsoft.com/en-us/library/aa381055%28VS.85%29.aspx)

If it's the case that backwards-compat. trumps all, then in the least, problem
#2 should be fixed (i.e. "--include-dir=res" should include directory "res").
Another developer from the mailing list has notified that he has a patch ready
to address this issue.

-- 
   Summary: directory names conflict with windres include
directories
   Product: binutils
   Version: 2.21 (HEAD)
Status: NEW
  Severity: minor
  Priority: P2
 Component: binutils
AssignedTo: unassigned at sources dot redhat dot com
ReportedBy: anthony dot penniston at hotmail dot com
CC: anthony dot penniston at hotmail dot com,bug-binutils at
gnu dot org,nickc at redhat dot com
 GCC build triplet: all
  GCC host triplet: all
GCC target triplet: all


http://sourceware.org/bugzilla/show_bug.cgi?id=11711

--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils


RE: windres bug in -I/--input-dir option

2010-06-16 Thread Anthony Penniston

Okay Nick, I've gone ahead and reported it here:
http://sourceware.org/bugzilla/show_bug.cgi?id=11711
(added you to the CC list - I hope you don't mind.)

I note there that if backwards-compatibility is necessary, then at least
 "--include-dir=res" can behave as expected. I agree, it's barely noteworthy; 
but if you have a patch on the ready, we may as well take the opportunity to 
make good software better.

Cheers.
Anthony

p.s. would be nice if GCC and binutils bugzilla user accounts were merged, so 
only one registration is needed.


> Date: Wed, 16 Jun 2010 15:50:12 +0100
> From: ni...@redhat.com
> To: anthony.pennis...@hotmail.com
> CC: bug-binutils@gnu.org
> Subject: Re: windres bug in -I/--input-dir option
>
> Hi Anthony,
>
>> If you specify "res" as an include directory via the "-I"
>> or "--include-dir=" options, windres mistakenly assumes
>> this to be the output format (and issues a warning saying
>> to use "-J" instead). The workaround if you have such an
>> input directory named "res" is to specify it as "./res",
>> though this really shouldn't be necessary.
>
> I am not sure if this important enough to be worth fixing. Especially
> there is a simple workaround as you have mentioned. I have a patch that
> will correct the behaviour (attached) but it has the potential to
> confuse users used to the old, deprecated, behaviour. If you really
> feel that this feature needs to be corrected in the sources please open
> a bug report on the binutils bugzilla system and I will make the patch
> official:
>
> http://sourceware.org/bugzilla
>
> Cheers
> Nick Clifton
>
>
>
  
_
Game on: Challenge friends to great games on Messenger
http://go.microsoft.com/?linkid=9734387
___
bug-binutils mailing list
bug-binutils@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-binutils