bash-5.2.9 lib/readline/input.c fix for Tru64
Hi, In bash-5.2.9 if HAVE_SELECT is set but HAVE_PSELECT is not, we still need the "fd_set readfds;" at line 808 in lib/readline/input.c. Found on Tru64 5.1. Also this platform doesn't have strtoimax but config.h is still setting #define HAVE_DECL_STRTOIMAX 1 #define HAVE_DECL_STRTOLL 1 #define HAVE_DECL_STRTOULL 1 #define HAVE_DECL_STRTOUMAX 1 even though later on it correctly realizes that HAVE_STRTOLL, HAVE_STRTOULL, HAVE_STRTOIMAX, and HAVE_STRTOUMAX should not be set. This is because the Tru64 linker will still produce an executable and return true even if the executable contains unresolved symbols. I'm not immediately sure of a fix for that one. -Henry
Re: bash-5.2.9 lib/readline/input.c fix for Tru64
On Tue, 15 Nov 2022 at 10:11, Chet Ramey wrote: > On 11/14/22 10:01 PM, Koichi Murase wrote: > > > I think someone needs to finally check the fixed version actually > > compiles in a real Tru64 machine. I attach a possible patch > > [202211-0044.HAVE_PSELECT-in-True64.patch] but haven't tested it in > > Tru64, so I'm not sure if this is all. > > I don't have a Tru64 machine either. Machines that don't have pselect() > are becoming increasingly scarce. > There is a free Alpha emulator here: http://www.migrationspecialties.com/FreeAXP.html . I haven't used it extensively since I have real hardware but it seems to work reasonably well. -Henry
Re: bash-5.2.9 lib/readline/input.c fix for Tru64
On Tue, 15 Nov 2022 at 20:02, Koichi Murase wrote: > 2022年11月16日(水) 9:36 Koichi Murase : > > > > 2022年11月16日(水) 0:18 Henry Bent : > > > There is a free Alpha emulator here: > > > http://www.migrationspecialties.com/FreeAXP.html . I haven't used > > > it extensively since I have real hardware but it seems to work > > > reasonably well. > > > > Thank you for the information. I tried to install Tru64 5.1b in > > FreeAXP, but it seems to fail in the middle of the installation. > > Sorry, I realized that I need to prepare a disk image properly > partitioned for Tru64 by myself in advance. I'll try it later if I > have time. > That site has some pre-partitioned disks near the bottom of the page. The RZ27 is the largest, 1.6GB. Your v2 patch successfully fixes the HAVE_SELECT/HAVE_PSELECT issues. Thank you for your work on this. I'm working on testing a full build from scratch on a clean system (system compiler, system make, no extra GNU tools) to see if there are any other issues I can shake out. So far all I can report is that a full autoreconf with autoconf 2.69 doesn't fix the HAVE_DECL_STRTOx issue. Running configure with --enable-static-link also doesn't fix the issue, and neither does setting CC to "cc -non_shared". -Henry
5.1 locale.c typos?
locale.c: In function 'set_default_locale': locale.c:94:3: error: 'local_shiftstates' undeclared (first use in this function) local_shiftstates = 0; ^ locale.c:94:3: note: each undeclared identifier is reported only once for each function it appears in locale.c: In function 'set_default_locale_vars': locale.c:120:7: error: 'local_shiftstates' undeclared (first use in this function) local_shiftstates = 0; ^ locale.c: In function 'set_locale_var': locale.c:229:7: error: 'local_shiftstates' undeclared (first use in this function) local_shiftstates = 0; ^ locale.c: In function 'reset_locale_vars': locale.c:394:3: error: 'local_shiftstates' undeclared (first use in this function) local_shiftstates = 0; ^ These were supposed to be locale_shiftstates, no? -Henry
Re: 5.1 locale.c typos?
On Tue, Jan 12, 2021, 08:58 Chet Ramey wrote: > On 1/11/21 8:07 PM, Henry Bent wrote: > > locale.c: In function 'set_default_locale': > > locale.c:94:3: error: 'local_shiftstates' undeclared (first use in this > > function) > > local_shiftstates = 0; > > Thanks for the report. I guess it just shows how rare non-multibyte systems > are these days. > > Chet > Well, I can report that I have a working bash 5.1 patch 4 on sparc-sun-solaris2.5.1, where this report is from, as well as Irix 4.0.5H and Tru64 V5.1B-6. None required anything other than trivial fixes. -Henry
