build disabling alias (patch)

2023-09-21 Thread Mike Jonkmans
On devel (94bce520):
./configure --disable-alias; make
chokes on pcomplete.c:
pcomplete.c:371:9: error: ‘alias_list’ undeclared (first use in this 
function); did you mean ‘alias_t’?
371 |   free (alias_list);

Easy fix attached.

This statement has been introduced 12 years ago in devel
(10 years ago in master, bash 4.3).
Since then nobody disabled aliases or took the trouble of reporting.

Wouldn't it be opportune to remove the `--enable-alias' option?
Saves a couple of #ifdef's too.

-- 
Regards, Mike Jonkmans
 pcomplete.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git i/pcomplete.c w/pcomplete.c
index e6c21600..aa6a0440 100644
--- i/pcomplete.c
+++ w/pcomplete.c
@@ -365,10 +365,10 @@ it_init_aliases (ITEMLIST *itp)
   sl->list[n] = (char *)NULL;
   sl->list_size = sl->list_len = n;
   itp->slist = sl;
-#else
-  itp->slist = (STRINGLIST *)NULL;
-#endif
   free (alias_list);
+#else
+  itp->slist = (STRINGLIST *)NULL;
+#endif
   return 1;
 }
 


Re: build disabling alias (patch)

2023-09-21 Thread Chet Ramey

On 9/21/23 5:35 AM, Mike Jonkmans wrote:

On devel (94bce520):
./configure --disable-alias; make
chokes on pcomplete.c:
pcomplete.c:371:9: error: ‘alias_list’ undeclared (first use in this 
function); did you mean ‘alias_t’?
371 |   free (alias_list);

Easy fix attached.


Thanks for the report.

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/