Re: [PATCH] Add active mark, face support; activate mark on paste

2020-04-13 Thread gentoo_eshoes--- via Bug reports for the GNU Bourne Again SHell 




Apr 13, 2020, 05:04 by dan...@dancol.org:

>
>
> FWIW, for debugging the kinds of issues we're discussing here, rr(1) is 
> _incredibly_ helpful.
>
I can't use 'rr' due to system requirements: 
https://github.com/mozilla/rr#system-requirements

$ sudo sysctl kernel.perf_event_paranoid=1; rr record ./bash  ; sudo sysctl 
kernel.perf_event_paranoid=2
[sudo] password for user: 
kernel.perf_event_paranoid = 1
[FATAL ../src/PerfCounters.cc:247:get_cpu_microarch()] AMD CPUs not supported.
For Ryzen, see https://github.com/mozilla/rr/issues/2034.
For post-Ryzen CPUs, please file a Github issue.
kernel.perf_event_paranoid = 2

Re: [PATCH] Add active mark, face support; activate mark on paste

2020-04-13 Thread Chet Ramey 
On 4/12/20 11:04 PM, Daniel Colascione wrote:
> On 4/12/20 6:23 PM, Chet Ramey wrote:
>> On 4/12/20 2:15 PM, gentoo_esh...@tutanota.com wrote:
>>
>>> There is one more/different 'face' issue: if I paste a line and then
>>> press Enter (as opposed to any alphanumeric key or arrow keys) then the
>>> highlight remains(highlighted), possibly because the ^M is echoed and
>>> thus moves the cursor one line up(?) before the highlight is attempted
>>> to be removed. But I'm just guessing.
>>
>> Unsurprising. The highlights are added and removed in readline's redisplay.
>> Once you enter newline (or any key bound to accept-line), readline returns
>> the line immediately without any redisplay, so the line remains as is.
> 
> Is that a regression relative to my original patch? I could have sworn I
> made command submission deactivate the mark and redisplay, but maybe I'm
> recalling incorrectly. In any case, isn't that the right thing to do?

I'll look. In the meantime, what do you think about the behavior when
pasting more than a screenful of text?

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://tiswww.cwru.edu/~chet/