Re: dabbrev-expand completions are sorted

2017-03-16 Thread Chet Ramey
On 3/15/17 4:25 PM, Roee Bar wrote:
> Also, not as serious as the bug below, if you have 'set show-all-if-ambiguous 
> on’ on your .inputrc, it shows all matching on dabbrev-expand as well (I 
> don’t think it should).

I think it should.  If you have that variable enabled, you want it to act
consistently for all completions.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Re: dabbrev-expand completions are sorted

2017-03-16 Thread Roee Bar
There is no ambiguous in dabbrev-expand - it is well defined what the 
completion should be: each key press cycles through the matches from most 
recent to oldest match. This is different than TAB completion, where it is 
possible to have several matches so it makes sense to display them. That is 
also the dabbrev-expand behaviour in tcsh when ‘autolist’ (i.e. 
'show-all-if-ambiguous’ ) is set.

Also, have you succeeded reproducing the original dabbrev-expand bug with 
completion-ignore-case set?


> On Mar 16, 2017, at 08:56, Chet Ramey  wrote:
> 
> On 3/15/17 4:25 PM, Roee Bar wrote:
>> Also, not as serious as the bug below, if you have 'set 
>> show-all-if-ambiguous on’ on your .inputrc, it shows all matching on 
>> dabbrev-expand as well (I don’t think it should).
> 
> I think it should.  If you have that variable enabled, you want it to act
> consistently for all completions.
> 
> -- 
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
>``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, UTech, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/




Re: dabbrev-expand completions are sorted

2017-03-16 Thread Chet Ramey
On 3/15/17 1:56 PM, Roee Bar wrote:
> Thanks Chet.
> 
> I found out it happens only when I have this one is in my .inputrc:
> set completion-ignore-case on

OK, that helped me find it.  It will be fixed in the next devel branch
push. Thanks.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Re: dabbrev-expand completions are sorted

2017-03-16 Thread Chet Ramey
On 3/16/17 1:49 PM, Roee Bar wrote:
> There is no ambiguous in dabbrev-expand - it is well defined what the 
> completion should be: each key press cycles through the matches from most 
> recent to oldest match. This is different than TAB completion, where it is 
> possible to have several matches so it makes sense to display them. That is 
> also the dabbrev-expand behaviour in tcsh when ‘autolist’ (i.e. 
> 'show-all-if-ambiguous’ ) is set.

When show-all-if-ambiguous is set, readline displays the matches if
there is more than one possible completion. It doesn't matter which
completion function you're using; the behavior of the variable is consistent.

In bash's case, dabbrev-expand (which first appeared in bash-4.0) is built
on top of readline's menu completion function, and inherits its behavior.
That means that dabbrev-expand has always honored show-all-if-ambiguous,
since menu completion has honored it since before dabbrev-expand was
introduced. I'm reluctant to change it now.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/