extra \1 in declare -p

2015-07-20 Thread isabella parakiss
Hi, about this bug:
http://lists.gnu.org/archive/html/bug-bash/2003-03/msg00093.html

The fix was to add this in lib/sh/shquote.c
  else if (c == CTLESC || c == CTLNUL)
*r++ = CTLESC;

I think the fix it was applied twice, it should only check this in the
prompt string, right?


Now declare -p produces output that can't be eval'ed.

$ var=$'x\1y\177z'; declare -p var | sed -n l
declare -- var="x\001\001y\001\177z"$


Removing lines 151-152 (from the 4.4 alpha branch) seems to fix this.
The duplicate code keeps checking the prompt in lines 297-298.
(${var@P} is expanded by that part so it should be fine...)
I hope it won't cause other problems.


---
xoxo iza



Permission errors testing with /tmp/xx

2015-07-20 Thread James Chang
Hello bash community,

I recently ran into an odd issue running the testsuite for bash. After
running the scripts, /tmp/xx isn't deleted, and another user can't run the
testsuite due to permission errors. Is it possible to specify bash not to
use /tmp/xx?

Thanks,

James


Permission errors testing with /tmp/xx

2015-07-20 Thread James Chang
Hello bash community,

I recently ran into an odd issue running the testsuite for bash. After
running the scripts, /tmp/xx isn't deleted, and another user can't run the
testsuite due to permission errors. Is it possible to specify bash not to
use /tmp/xx?

Thanks,

James


Re: Permission errors testing with /tmp/xx

2015-07-20 Thread Chet Ramey
On 7/20/15 11:57 AM, James Chang wrote:
> Hello bash community,
> 
> I recently ran into an odd issue running the testsuite for bash. After
> running the scripts, /tmp/xx isn't deleted, and another user can't run the
> testsuite due to permission errors. Is it possible to specify bash not to
> use /tmp/xx?

If it's a problem for you, you can add `rm /tmp/xx' to the end of
tests/run-all without waiting for me to make a change.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Re: Permission errors testing with /tmp/xx

2015-07-20 Thread James Chang
On Mon, Jul 20, 2015 at 1:55 PM, Chet Ramey  wrote:

> On 7/20/15 11:57 AM, James Chang wrote:
> > Hello bash community,
> >
> > I recently ran into an odd issue running the testsuite for bash. After
> > running the scripts, /tmp/xx isn't deleted, and another user can't run
> the
> > testsuite due to permission errors. Is it possible to specify bash not to
> > use /tmp/xx?
>
> If it's a problem for you, you can add `rm /tmp/xx' to the end of
> tests/run-all without waiting for me to make a change.
>

Patched and fixed the issue, but are there actually plans to change the
tests using /tmp/xx?

-- James


> --
> ``The lyf so short, the craft so long to lerne.'' - Chaucer
>  ``Ars longa, vita brevis'' - Hippocrates
> Chet Ramey, ITS, CWRUc...@case.edu
> http://cnswww.cns.cwru.edu/~chet/
>