Re: Loadables fail to build in devel branch

2013-05-28 Thread Chet Ramey
On 5/25/13 4:48 PM, Geir Hauge wrote:
> The code for the cut and getconf loadables under examples/loadables has
> apparently been removed, but the Makefile hasn't been updated accordingly.
> See attached patch.

Thanks for the report.  Those files, plus about 110 other examples, were
removed at the FSF's request due to copyright and provenance issues.  I
need to update examples/loadables/Makefile.in.

Chet
-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Looking for a specific fix

2013-05-28 Thread Jean Delvare
Hi all,

There are a few changelog files seemingly related to bash on the web
with the following entry:

- change reset_job_indices to avoid infinite looping when js.j_firstj
  == 0 or js.j_firstj == js.j_jobslots upon function entry.  Fixes
  bug reported by osi...@post.cz


For example in that file:
http://www.askapache.com/pub/bash/ChangeLog

I need to find the code change which corresponds to this fix. It seems
it happened between versions 3.2 and 4.0 of bash. However the git
repository doesn't seem to contain individual commits. I also couldn't
find the above entry in the CHANGES file of bash-4.0.

So I have a hard time figuring out if this corresponds to an actual fix
in bash. Can anyone shed some light on this, and ideally point me to the
code change if it exists somewhere?

Thanks,
-- 
Jean Delvare
Suse L3




Re: Looking for a specific fix

2013-05-28 Thread Jean Delvare
Le Tuesday 28 May 2013 à 18:27 +0200, Jean Delvare a écrit :
> Hi all,
> 
> There are a few changelog files seemingly related to bash on the web
> with the following entry:
> 
> - change reset_job_indices to avoid infinite looping when js.j_firstj
>   == 0 or js.j_firstj == js.j_jobslots upon function entry.  Fixes
>   bug reported by osi...@post.cz
> 
> 
> For example in that file:
> http://www.askapache.com/pub/bash/ChangeLog
> 
> I need to find the code change which corresponds to this fix. It seems
> it happened between versions 3.2 and 4.0 of bash. However the git
> repository doesn't seem to contain individual commits. I also couldn't
> find the above entry in the CHANGES file of bash-4.0.
> 
> So I have a hard time figuring out if this corresponds to an actual fix
> in bash. Can anyone shed some light on this, and ideally point me to the
> code change if it exists somewhere?

Ah, that would be bash-3.2-patches/bash32-018. I didn't catch it because
the description is different but the code change matches. Sorry for the
noise.

-- 
Jean Delvare
Suse L3




Re: Looking for a specific fix

2013-05-28 Thread Chet Ramey
On 5/28/13 12:27 PM, Jean Delvare wrote:
> Hi all,
> 
> There are a few changelog files seemingly related to bash on the web
> with the following entry:
> 
> - change reset_job_indices to avoid infinite looping when js.j_firstj
>   == 0 or js.j_firstj == js.j_jobslots upon function entry.  Fixes
>   bug reported by osi...@post.cz
> 
> 
> For example in that file:
> http://www.askapache.com/pub/bash/ChangeLog
> 
> I need to find the code change which corresponds to this fix.

Why, out of curiosity?  What do you need to know?

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Re: [PATCH] Fix argument inversion in call to sh_makepath() from sh_realpath()

2013-05-28 Thread Chet Ramey
On 5/27/13 6:21 PM, Julien Thomas wrote:
> In function sh_realpath() defined in lib/sh/pathphys.c, the arguments
> passed to sh_makepath() are inverted. This makes the sh_realpath()
> fail when  is not an absolute path because the expected
> concatenation is /, not the reverse.

Thanks for the report and fix.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/



Re: Looking for a specific fix

2013-05-28 Thread Jean Delvare
Hi Chet,

Le Tuesday 28 May 2013 à 15:31 -0400, Chet Ramey a écrit :
> On 5/28/13 12:27 PM, Jean Delvare wrote:
> > Hi all,
> > 
> > There are a few changelog files seemingly related to bash on the web
> > with the following entry:
> > 
> > - change reset_job_indices to avoid infinite looping when js.j_firstj
> >   == 0 or js.j_firstj == js.j_jobslots upon function entry.  Fixes
> >   bug reported by osi...@post.cz
> > 
> > 
> > For example in that file:
> > http://www.askapache.com/pub/bash/ChangeLog
> > 
> > I need to find the code change which corresponds to this fix.
> 
> Why, out of curiosity?  What do you need to know?

I need to fix that bug on an old product of ours which uses bash 3.1.

But it's OK, I found the fix (see my self-reply) and it applies fine on
top of bash 3.1.17 so I think I'm set.

Thanks,
-- 
Jean Delvare
Suse L3




Re: Looking for a specific fix

2013-05-28 Thread Chet Ramey
On 5/28/13 3:51 PM, Jean Delvare wrote:
> Hi Chet,
> 
> Le Tuesday 28 May 2013 à 15:31 -0400, Chet Ramey a écrit :
>> On 5/28/13 12:27 PM, Jean Delvare wrote:
>>> Hi all,
>>>
>>> There are a few changelog files seemingly related to bash on the web
>>> with the following entry:
>>>
>>> - change reset_job_indices to avoid infinite looping when js.j_firstj
>>>   == 0 or js.j_firstj == js.j_jobslots upon function entry.  Fixes
>>>   bug reported by osi...@post.cz
>>>
>>>
>>> For example in that file:
>>> http://www.askapache.com/pub/bash/ChangeLog
>>>
>>> I need to find the code change which corresponds to this fix.
>>
>> Why, out of curiosity?  What do you need to know?
> 
> I need to fix that bug on an old product of ours which uses bash 3.1.

OK, I saw your reply.  I was just wondering whether you were running into
a specific problem.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRUc...@case.eduhttp://cnswww.cns.cwru.edu/~chet/