Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Harry Wentland
On 2025-02-21 11:42, Simon Ser wrote: > On Friday, February 21st, 2025 at 17:18, Harry Wentland > wrote: > >> I did a brief survey of other enum properties and noticed >> that this isn't well documented for others, such as the Content >> Protection connector property, or the COLOR_RANGE and C

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Harry Wentland
On 2025-02-15 09:40, Simon Ser wrote: > On Monday, February 10th, 2025 at 23:03, Harry Wentland > wrote: > + * DOC: overview + * + * A colorop represents a single color operation. Colorops are chained + * via the NEXT property and make up color pipelines. Color pipelines >

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Simon Ser
On Friday, February 21st, 2025 at 19:41, Harry Wentland wrote: > > Other people have argued that strings make it easier for user-space to > > start using a new KMS property without deploying new kernel uAPI headers. > > I don't understand this argument. You would either need to define the > str

Re: [V7 34/45] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT

2025-02-21 Thread Harry Wentland
On 2025-02-12 18:44, Leo Li wrote: > > > On 2024-12-19 23:33, Alex Hung wrote: >> This patch adds colorops for custom 1D LUTs in the SHAPER and >> BLND HW blocks. >> >> With this change the following IGT tests pass: >> kms_colorop --run plane-XR30-XR30-srgb_inv_eotf_lut >> kms_colorop --run pl

Re: [V7 08/45] Documentation/gpu: document drm_colorop

2025-02-21 Thread Simon Ser
On Friday, February 21st, 2025 at 17:18, Harry Wentland wrote: > I did a brief survey of other enum properties and noticed > that this isn't well documented for others, such as the Content > Protection connector property, or the COLOR_RANGE and COLOR_ENCODING > plane properties. Isn't the Conte

Re: [V7 42/45] drm/amd/display: add 3D LUT colorop

2025-02-21 Thread Harry Wentland
On 2025-02-13 13:21, Leo Li wrote: > > > > On 2024-12-19 23:33, Alex Hung wrote: >> This adds support for a 3D LUT. >> >> The color pipeline now consists of the following colorops: >> 1. 1D curve colorop >> 2. Multiplier >> 3. 3x4 CTM >> 4. 1D curve colorop >> 5. 1D LUT >> 6. 3D LUT >> 7. 1D