[tcpdump-workers] clean exit from tcpdump with asan

2020-10-14 Thread enh via tcpdump-workers
--- Begin Message --- i haven't reproduced it myself yet (though i'll try shortly) but we got an automated crash report from tcpdump on Android via [gwp-asan](https://developer.android.com/ndk/guides/gwp-asan). the bug is a use-after-free, specifically when pcap_breakloop() tries to write to the a

Re: [tcpdump-workers] clean exit from tcpdump with asan

2020-10-19 Thread enh via tcpdump-workers
--- Begin Message --- this patch fixes the use-after-free of `pd`, and also fixes the leak of `device`. let me know if you need this uploaded to github instead... diff --git a/tcpdump.c b/tcpdump.c index 658d8b34..4fa390fd 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -2239,8 +2239,12 @@ main(int argc

Re: [tcpdump-workers] clean exit from tcpdump with asan

2020-10-27 Thread enh via tcpdump-workers
--- Begin Message --- On Tue, Oct 27, 2020 at 5:42 AM Michael Richardson wrote: > > > enh via tcpdump-workers wrote: > > this patch fixes the use-after-free of `pd`, and also fixes the leak > > of `device`. let me know if you need this uploaded to github >

Re: [tcpdump-workers] So which is cooler - tcpdump on your wrist or tcpdump on your Mac's Touch Bar?

2021-01-06 Thread enh via tcpdump-workers
--- Begin Message --- i don't know about iOS, but on Android tcpdump is only on engineering builds ("userdebug" and "eng" builds, for those familiar with such things), not shipped on production devices ("user builds"). (at least not by default. an OEM could change that, but they tend to lean in th