Re: [tcpdump-workers] [RFC PATCH] Add new `pcap_set_buffer_size1` API.

2019-10-03 Thread Guy Harris
On Oct 2, 2019, at 6:40 PM, Mario Rugiero wrote: > El mié., 2 oct. 2019 a las 19:48, Mario Rugiero () > escribió: >> I used '1' because that's what Linux does when advertising newer >> versions of syscalls. >> '_ext' does look better, I think I'd go with that. > On the other hand, numeric versio

Re: [tcpdump-workers] [RFC PATCH] Add new `pcap_set_buffer_size1` API.

2019-10-03 Thread Guy Harris
On Oct 2, 2019, at 3:48 PM, Mario Rugiero wrote: > > El mié., 2 oct. 2019 a las 18:46, Guy Harris () escribió: > >> There should probably be an API to get the maximum buffer size as well, for >> the benefit of 1) programs that want "the biggest buffer they can get" and >> 2) GUI programs that

Re: [tcpdump-workers] [RFC PATCH] Add new `pcap_set_buffer_size1` API.

2019-10-03 Thread Mario Rugiero
El jue., 3 oct. 2019 a las 4:28, Guy Harris () escribió: > > We might want to have another API to supply the *minimum* buffer size. For > BSD-style BPF, we could use BPF_MINBUFSIZE if it's defined in . > That sounds good. Should we still allow passing buffers below that minimum with the original

[tcpdump-workers] Legacy Linux kernel support

2019-10-03 Thread Mario Rugiero
The 'pcap-linux.c' implementation is plagued by #ifdefs and special cases aiming to support kernels as old as the 2.0.x family era. The oldest version supported by upstream is 3.16.74. The most 'bleeding-edge' supported family has been there since the 2.6.y times, almost 10 years ago, so I think we