Re: [tcpdump-workers] [tcpdump] Keep win32/prj/GNUmakefile ?

On 16/04/2019 17:14, Francois-Xavier Le Bail wrote: > 39 printers are missing in win32/prj/GNUmakefile. Someone use it ? keep it ? If no one uses it, we will delete it. ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.san

[tcpdump-workers] GET_BYTES() macro, doing a bounds check and a memcpy()?

Commit e150c713a2ea333e9ab173e062b447dd65c9a4ee added some ND_TCHECK_LEN() calls before doing a memcpy. Should we have a function static inline void get_bytes(netdissect_options *ndo, u_char *dst, const u_char *p, size_t len) { if (!ND_TCHECK_LEN(p, len))

Re: [tcpdump-workers] GET_BYTES() macro, doing a bounds check and a memcpy()?

On 03/05/2019 19:08, Guy Harris wrote: > Should we have a function > > static inline void > get_bytes(netdissect_options *ndo, u_char *dst, const u_char *p, size_t > len) > { > if (!ND_TCHECK_LEN(p, len)) > longjmp(ndo->ndo_truncated, 1); >