[tcpdump-workers] -W options to gcc

2013-03-28 Thread Michael Richardson
While I'll bet that 95% of *nix systems that compile tcpdump regularly are using gcc, I know that there remain other compilers in use. If one wants to add -W options to the standard build, I'm wondering what the right autoconf magic is to enable such a thing. fxlb suggested: "-Wunused -Wunused-

[tcpdump-workers] [Patch] pcap-dos.c

2013-03-28 Thread Gisle Vanem
This file has fallen behind since pcap_create() was put in pcap.c long time ago (a more generic create-function). Hence: --- Git-Latest\pcap-dos.c Wed Nov 28 23:41:44 2012 +++ pcap-dos.c Thu Nov 29 00:00:12 2012 @@ -143,7 +143,7 @@ return handle_to_device [fd-1]; } -pcap_t *pcap_create

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Gisle Vanem
"Michael Richardson" wrote: If one wants to add -W options to the standard build, I'm wondering what the right autoconf magic is to enable such a thing. fxlb suggested: "-Wunused -Wunused-parameter" I compile using MingW (gcc 4.7.2) and normally I use -Wall -W. But this gives tons of warni

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Michael Richardson
> "Gisle" == Gisle Vanem writes: Gisle> I compile using MingW (gcc 4.7.2) and normally I use Gisle> -Wall -W. sure, I'd like to get to -Wall -Werror at some point, but for the moment, I want to know how to include -Wgcc-things when we are using gcc, and omit when we aren't. -- ]

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Denis Ovsienko
28.03.2013, 17:55, "Michael Richardson" : >>  "Gisle" == Gisle Vanem writes: > > Gisle> I compile using MingW (gcc 4.7.2) and normally I use > Gisle> -Wall -W. > > sure, I'd like to get to -Wall -Werror at some point, but for the > moment, I want to know how to include -Wgcc-things whe

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread David Laight
> > "Gisle" == Gisle Vanem writes: > Gisle> I compile using MingW (gcc 4.7.2) and normally I use > Gisle> -Wall -W. > > sure, I'd like to get to -Wall -Werror at some point, but for the > moment, I want to know how to include -Wgcc-things when we are using > gcc, and omit when we aren

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Guy Harris
On Mar 28, 2013, at 5:37 AM, Michael Richardson wrote: > > While I'll bet that 95% of *nix systems that compile tcpdump regularly > are using gcc, I know that there remain other compilers in use. ...at least some of which may support -W options, and at least one of which (clang) supports most

Re: [tcpdump-workers] [Patch] pcap-dos.c

2013-03-28 Thread Guy Harris
On Mar 28, 2013, at 5:53 AM, Gisle Vanem wrote: > This file has fallen behind since pcap_create() was put in > pcap.c long time ago (a more generic create-function). Hence: Checked into the trunk and the 1.4 branch. ___ tcpdump-workers mailing list t

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Michael Richardson
> "Guy" == Guy Harris writes: Guy> Wireshark's configure script checks whether the GCC shell Guy> variable is "yes" or the CC shell variable is "clang" and, if Guy> true, sets a flag saying "this compiler supports -W options". Cooll.. can we copy and paste :-) Guy> There's

Re: [tcpdump-workers] -W options to gcc

2013-03-28 Thread Guy Harris
On Mar 28, 2013, at 4:41 PM, Michael Richardson wrote: > >> "Guy" == Guy Harris writes: >Guy> Wireshark's configure script checks whether the GCC shell >Guy> variable is "yes" or the CC shell variable is "clang" and, if >Guy> true, sets a flag saying "this compiler supports -W