Re: [PATCH net-next v7] ptp: Add support for the AMZNC10C 'vmclock' device

2024-10-14 Thread Jakub Kicinski
On Mon, 14 Oct 2024 08:25:35 +0100 David Woodhouse wrote: > On Wed, 2024-10-09 at 17:32 -0700, Jakub Kicinski wrote: > > On Sun, 06 Oct 2024 08:17:58 +0100 David Woodhouse wrote: > > > +config PTP_1588_CLOCK_VMCLOCK > > > +   tristate "Virtual machine PTP clock" > > > +   depends on X86_T

Re: [PATCH v3 09/20] target/hppa: Fix priority of T, D, and B page faults

2024-10-14 Thread Richard Henderson
On 10/14/24 11:02, Michael Tokarev wrote: On 09.10.2024 03:04, Richard Henderson wrote: Drop the 'else' so that ret is overridden with the highest priority fault. Fixes: d8bc1381250 ("target/hppa: Implement PSW_X") Reviewed-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: R

Re: [PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD

2024-10-14 Thread Michael Tokarev
On 14.10.2024 18:15, Daniel P. Berrangé wrote: These two lines are the only place in the code that uses the char response[40]; so even better than switching to snprintf, how about just taking buffer size out of the picture: g_autofree *response = g_strdup_printf("\033[%d;%dR",

[PATCH] plugins: fix qemu_plugin_reset

2024-10-14 Thread Pierrick Bouvier
34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the last plugin active, we stopped reinitializing tcg_ctx->plugin_insn, which leads to memory callbacks b

Re: [RFC v3 2/2] target/riscv: rvv: improve performance of RISC-V vector loads and stores on large amounts of data.

2024-10-14 Thread Richard Henderson
On 10/14/24 15:01, Paolo Savini wrote: This patch optimizes the emulation of unit-stride load/store RVV instructions when the data being loaded/stored per iteration amounts to 64 bytes or more. The optimization consists of calling __builtin_memcpy on chunks of data of 128 bytes between the memory

[PATCH] target/mips: Remove unused MEMOP_IDX() macro

2024-10-14 Thread Philippe Mathieu-Daudé
MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips: Use cpu_*_data_ra for msa load/store"), remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/msa_helper.c | 8 1 file changed, 8 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_he

Re: [PATCH v2 10/16] target/mips: Replace MO_TE by mo_endian()

2024-10-14 Thread Richard Henderson
On 10/14/24 15:18, Philippe Mathieu-Daudé wrote: On 13/10/24 13:05, Richard Henderson wrote: On 10/10/24 14:50, Philippe Mathieu-Daudé wrote: +++ b/target/mips/tcg/msa_helper.c @@ -8213,7 +8213,7 @@ void helper_msa_ffint_u_df(CPUMIPSState *env, uint32_t df, uint32_t wd,   #if !defined(CONFIG_

Re: [PATCH] plugins: fix qemu_plugin_reset

2024-10-14 Thread Richard Henderson
On 10/14/24 15:33, Pierrick Bouvier wrote: 34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the last plugin active, we stopped reinitializing tcg_ctx->p

Re: [PATCH v2 1/3] include/exec: Improve probe_access_full{, _mmu} documentation

2024-10-14 Thread Pierrick Bouvier
On 10/13/24 11:47, Richard Henderson wrote: Suggested-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 72240

Re: [PATCH] plugins: fix qemu_plugin_reset

2024-10-14 Thread Pierrick Bouvier
Sent a v2 to fix a leak issue with tcg_ctx->plugin_tb. On 10/14/24 15:33, Pierrick Bouvier wrote: 34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the

[PATCH v2] plugins: fix qemu_plugin_reset

2024-10-14 Thread Pierrick Bouvier
34e5e1 refactored the plugin context initialization. After this change, tcg_ctx->plugin_insn is not reset inconditionnally anymore, but only if one plugin at least is active. When uninstalling the last plugin active, we stopped reinitializing tcg_ctx->plugin_insn, which leads to memory callbacks b

[PATCH] target/i386: Use only 16 and 32-bit operands for IN/OUT

2024-10-14 Thread Richard Henderson
The REX.W prefix is ignored for these instructions. Mirror the solution already used for INS/OUTS: X86_SIZE_z. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2581 Signed-off-by: Richard Henderson --- target/i386/tcg/decode-new.c.inc | 8 1 file changed, 4 insertions(+), 4 delet

[PATCH] linux-user: Emulate /proc/self/maps under mmap_lock

2024-10-14 Thread Ilya Leoshkevich
If one thread modifies the mappings and another thread prints them, a situation may occur that the printer thread sees a guest mapping without a corresponding host mapping, leading to a crash in open_self_maps_2(). Cc: qemu-sta...@nongnu.org Fixes: 7b7a3366e142 ("linux-user: Use walk_memory_region

Re: Rust BoF and maintainer minutes and planning the roadmap to Rust

2024-10-14 Thread Warner Losh
[[ sorry for the lag $LIFE has been over-full lately ]] On Thu, Oct 3, 2024 at 3:56 AM Alex Bennée wrote: > Warner Losh writes: > > > On Thu, Oct 3, 2024 at 2:53 AM Warner Losh wrote: > > > > On Thu, Sep 26, 2024 at 8:24 AM Alex Bennée > wrote: > > > > One output from this discussion should

Re: [PATCH v3 09/20] target/hppa: Fix priority of T, D, and B page faults

2024-10-14 Thread Michael Tokarev
On 14.10.2024 22:31, Richard Henderson wrote: On 10/14/24 11:02, Michael Tokarev wrote: On 09.10.2024 03:04, Richard Henderson wrote: Drop the 'else' so that ret is overridden with the highest priority fault. Fixes: d8bc1381250 ("target/hppa: Implement PSW_X") Reviewed-by: Helge Deller Review

[PATCH V1 0/4] Arch agnostic ACPI changes to support vCPU Hotplug (on Archs like ARM)

2024-10-14 Thread Salil Mehta via
Certain CPU architecture specifications [1][2][3] prohibit changes to the CPUs *presence* after the kernel has booted. This is because many system initializations depend on the exact CPU count at boot time and do not expect it to change afterward. For example, components like interrupt controllers

[PATCH V1 1/4] hw/acpi: Initialize ACPI Hotplug CPU Status with Support for vCPU `Persistence`

2024-10-14 Thread Salil Mehta via
Certain CPU architecture specifications [1][2][3] prohibit changes to CPU presence after the kernel has booted. This limitation exists because many system initializations rely on the exact CPU count at boot time and do not expect it to change later. For example, components like interrupt controller

[PATCH V1 2/4] hw/acpi: Update ACPI CPU Status `is_{present, enabled}` during vCPU hot(un)plug

2024-10-14 Thread Salil Mehta via
Update the `AcpiCpuStatus` for `is_enabled` and `is_present` accordingly when vCPUs are hot-plugged or hot-unplugged, taking into account the *persistence* of the vCPUs. Signed-off-by: Salil Mehta --- hw/acpi/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/cpu.c b/hw/acp

[PATCH V1 3/4] hw/acpi: Reflect ACPI vCPU {present, enabled} states in ACPI _STA.{PRES, ENA} Bits

2024-10-14 Thread Salil Mehta via
Reflect the ACPI CPU hotplug `is_{present, enabled}` states in the `_STA.PRES` (presence) and `_STA.ENA` (enabled) bits when the guest kernel evaluates the ACPI `_STA` method during initialization, as well as when vCPUs are hot-plugged or hot-unplugged. The presence of unplugged vCPUs may need to b

[PATCH V1 4/4] hw/acpi: Populate vCPU Hotplug VMSD to migrate `is_{present, enabled}` states

2024-10-14 Thread Salil Mehta via
The ACPI CPU hotplug states `is_{present, enabled}` must be migrated alongside other vCPU hotplug states to the destination VM. Therefore, they should be integrated into the existing CPU Hotplug VM State Description (VMSD) table. Depending on the architecture and its implementation of CPU hotplug e

Re: [PATCH v2 5/7] target/i386/cpu: Improve errors for out of bounds property values

2024-10-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/10/24 16:25, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 10/10/24 12:01, Markus Armbruster wrote: The error message for a "stepping" value that is out of bounds is a bit odd: $ qemu-system-x86_64 -cpu qemu64,st

Re: [PATCH] ui/console-vc: Silence warning about sprintf() on OpenBSD

2024-10-14 Thread Marc-André Lureau
On Mon, Oct 14, 2024 at 7:10 PM Thomas Huth wrote: > > The linker on OpenBSD complains: > > ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]): > warning: sprintf() is often misused, please use snprintf() > > Using snprintf() is certainly better here, so let's switch to that > fun

RE: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with CPU scan

2024-10-14 Thread Salil Mehta via
Hi Bibo, > From: maobibo > Sent: Monday, October 14, 2024 9:53 AM > To: qemu-devel@nongnu.org; Salil Mehta > Cc: Michael S. Tsirkin ; Peter Maydell > ; Salil Mehta ; > zhukeqian ; Jonathan Cameron > ; Gavin Shan ; > Vishnu Pajjuri ; Xianglai Li > ; Miguel Luis ; Shaoqin > Huang ; Zhao

RE: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with CPU scan

2024-10-14 Thread Salil Mehta via
Hi Igor, > From: qemu-devel-bounces+salil.mehta=huawei@nongnu.org devel-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor > Mammedov > Sent: Monday, October 14, 2024 10:38 AM > > On Mon, 14 Oct 2024 16:52:55 +0800 > maobibo wrote: > > > Hi Salil, > > > > When I debug

[PATCH v2 1/6] ui/sdl2: Restore original context after new context creation

2024-10-14 Thread Dmitry Osipenko
SDL API changes GL context to a newly created GL context, which differs from other GL providers that don't switch context. Change SDL backend to restore the original GL context. This allows Qemu's virtio-gpu to support new virglrenderer async-fencing feature for Virgl contexts, otherwise virglrende

[PATCH v2 0/6] Support virtio-gpu DRM native context

2024-10-14 Thread Dmitry Osipenko
This patchset adds DRM native context support to VirtIO-GPU on Qemu. It's based on the pending Venus v17 patches [1] that bring host blobs support to virtio-gpu-gl device. Based-on: 20240822185110.1757429-1-dmitry.osipe...@collabora.com [1] https://lore.kernel.org/qemu-devel/20240822185110.17574

[PATCH v2 2/6] ui/sdl2: Implement dpy dmabuf functions

2024-10-14 Thread Dmitry Osipenko
From: Pierre-Eric Pelloux-Prayer If EGL is used, we can rely on dmabuf to import textures without doing copies. To get this working on X11, we use the existing SDL hint: SDL_HINT_VIDEO_X11_FORCE_EGL (because dmabuf can't be used with GLX). Signed-off-by: Pierre-Eric Pelloux-Prayer Signed-off-b

[PATCH v2 3/6] linux-headers: Update to Linux v6.12-rc1

2024-10-14 Thread Dmitry Osipenko
Update kernel headers to bring new VirtIO-GPU DRM capset. Signed-off-by: Dmitry Osipenko --- include/standard-headers/drm/drm_fourcc.h | 43 include/standard-headers/linux/const.h| 17 ++ include/standard-headers/linux/ethtool.h | 226 ++ include/standard-

[PATCH v2 5/6] virtio-gpu: Support asynchronous fencing

2024-10-14 Thread Dmitry Osipenko
Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mode isn't supported for DRM contexts in virglre

[PATCH v2 6/6] virtio-gpu: Support DRM native context

2024-10-14 Thread Dmitry Osipenko
Add support for DRM native contexts to VirtIO-GPU. DRM context is enabled using a new virtio-gpu-gl device option "drm=on". Unlike Virgl and Venus contexts that operate on application API level, DRM native contexts work on a kernel UAPI level. This lower level results in a lightweight context impl

[PATCH v2 4/6] virtio-gpu: Handle virgl fence creation errors

2024-10-14 Thread Dmitry Osipenko
Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-v

Re: [RFC QEMU PATCH v7 1/1] xen/pci: get gsi for passthrough devices

2024-10-14 Thread Chen, Jiqian
On 2024/10/15 03:34, Stewart Hildebrand wrote: > +Edgar > > On 5/16/24 06:13, Jiqian Chen wrote: >> In PVH dom0, it uses the linux local interrupt mechanism, >> when it allocs irq for a gsi, it is dynamic, and follow >> the principle of applying first, distributing first. And >> the irq number is

[PATCH] Fix negative lost clock causing VM crash

2024-10-14 Thread shenjiatong
Under situation where virtual machine is running in a deployment where the system time is unstable, there is a chance that legacy OpenStack Windows machines without stimer enabled will crash if system time moves backwards and diftfix=slew is enabled. This primarily caused by the fact the system tim

Re: [RFC QEMU PATCH v7 1/1] xen/pci: get gsi for passthrough devices

2024-10-14 Thread Stewart Hildebrand
+Edgar On 5/16/24 06:13, Jiqian Chen wrote: > In PVH dom0, it uses the linux local interrupt mechanism, > when it allocs irq for a gsi, it is dynamic, and follow > the principle of applying first, distributing first. And > the irq number is alloced from small to large, but the > applying gsi numbe

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-14 Thread Andrew Jeffery
On Sat, 2024-10-12 at 08:20 +0200, Cédric Le Goater wrote: > + Aspeed reviewers. Sorry about that. All good. Seems sensible in concept and from a cursory glance, so if you want to tack it on: Acked-by: Andrew Jeffery

Re: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with CPU scan

2024-10-14 Thread maobibo
Hi Salil, On 2024/10/15 上午3:59, Salil Mehta wrote: Hi Bibo, From: maobibo Sent: Monday, October 14, 2024 9:53 AM To: qemu-devel@nongnu.org; Salil Mehta Cc: Michael S. Tsirkin ; Peter Maydell ; Salil Mehta ; zhukeqian ; Jonathan Cameron ; Gavin Shan ; Vishnu Pajjuri ; Xianglai

[RFC v3 0/2] target/riscv: add endianness checks and atomicity guarantees.

2024-10-14 Thread Paolo Savini
This version 3 of the patch adds endianness safety to both the optimizations brought by the patch set. It also adds some conditions that allow the __builtin_memcpy to be executed on chunks of 16 bytes with guarantee of atomicity. Changes from V2: - patch 1: - add condition for the host not to be

[RFC v3 1/2] target/riscv: rvv: reduce the overhead for simple RISC-V vector unit-stride loads and stores

2024-10-14 Thread Paolo Savini
From: Helene CHELIN This patch improves the performance of the emulation of the RVV unit-stride loads and stores in the following cases: - when the data being loaded/stored per iteration amounts to 8 bytes or less. - when the vector length is 16 bytes (VLEN=128) and there's no grouping of the

[RFC v3 2/2] target/riscv: rvv: improve performance of RISC-V vector loads and stores on large amounts of data.

2024-10-14 Thread Paolo Savini
This patch optimizes the emulation of unit-stride load/store RVV instructions when the data being loaded/stored per iteration amounts to 64 bytes or more. The optimization consists of calling __builtin_memcpy on chunks of data of 128 bytes between the memory address of the simulated vector register

Re: [PATCH] tcg: remove singlestep_enabled from DisasContextBase

2024-10-14 Thread Philippe Mathieu-Daudé
On 10/10/24 05:36, Paolo Bonzini wrote: It is used in a couple of places only, both within the same target. Those can use the cflags just as well, so remove the separate field. Signed-off-by: Paolo Bonzini --- include/exec/translator.h | 2 -- accel/tcg/translator.c | 1 - target/mi

Re: [PATCH v2 3/3] target/i386: Remove ra parameter from ptw_translate

2024-10-14 Thread Philippe Mathieu-Daudé
On 13/10/24 15:47, Richard Henderson wrote: This argument is no longer used. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/tcg/sysemu/excp_helper.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathie

Re: [PATCH v2 10/16] target/mips: Replace MO_TE by mo_endian()

2024-10-14 Thread Philippe Mathieu-Daudé
On 13/10/24 13:05, Richard Henderson wrote: On 10/10/24 14:50, Philippe Mathieu-Daudé wrote: +++ b/target/mips/tcg/msa_helper.c @@ -8213,7 +8213,7 @@ void helper_msa_ffint_u_df(CPUMIPSState *env, uint32_t df, uint32_t wd,   #if !defined(CONFIG_USER_ONLY)   #define MEMOP_IDX(DF)   

Re: [PATCH] target/mips: Remove unused MEMOP_IDX() macro

2024-10-14 Thread Richard Henderson
On 10/14/24 16:22, Philippe Mathieu-Daudé wrote: MEMOP_IDX() is unused since commit 948f88661c6 ("target/mips: Use cpu_*_data_ra for msa load/store"), remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tcg/msa_helper.c | 8 1 file changed, 8 deletions(-) Reviewed-by:

Re: [RFC PATCH 00/23] accel/tcg: Convert victim tlb to IntervalTree

2024-10-14 Thread Richard Henderson
On 10/9/24 17:50, Pierrick Bouvier wrote: Eventually fixing the page size > TARGET_PAGE_SIZE performance issues. E.g. with a 16k or 64k aarch64 guest kernel, we still have TARGET_PAGE_SIZE at 4k, so all guest pages are "large", and so run into our current behaviour of flushing the entire tlb t

Re: [PATCH V1 0/4] Arch agnostic ACPI changes to support vCPU Hotplug (on Archs like ARM)

2024-10-14 Thread maobibo
With cpu-add/cpu-del command tested on LoongArch system, no migration tested. There is no negative influence with LoongArch cpu hotplug. Regards Bibo Mao On 2024/10/15 上午3:22, Salil Mehta via wrote: Certain CPU architecture specifications [1][2][3] prohibit changes to the CPUs *presence* after

Re: [PATCH] migration: Remove interface query-migrationthreads

2024-10-14 Thread Daniel P . Berrangé
On Fri, Oct 11, 2024 at 11:34:17AM -0400, Peter Xu wrote: > This reverts two commits: > > 671326201dac8fe91222ba0045709f04a8ec3af4 > 1b1f4ab69c41279a45ccd0d3178e83471e6e4ec1 > > Meanwhile it adds an entry to removed-features.rst for the > query-migrationthreads QMP command. > > This patch origin

[RFC PATCH 4/4] tests/tcg/aarch64: add system test for FEAT_XS

2024-10-14 Thread Manos Pitsidianakis
Add system test to make sure FEAT_XS is enabled for max cpu emulation and that QEMU doesn't crash when encountering an NXS instruction variant. Signed-off-by: Manos Pitsidianakis --- tests/tcg/aarch64/system/feat-xs.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

[RFC PATCH 1/4] arm: Add FEAT_XS's TLBI NXS variants

2024-10-14 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- target/arm/cpu-features.h | 5 + target/arm/helper.c | 366 +++--- 2 files changed, 218 insertions(+), 153 deletions(-) diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h index 04ce2818263e2c3

[RFC PATCH 0/4] No-op support for Arm FEAT_XS, feedback needed

2024-10-14 Thread Manos Pitsidianakis
This series is an initial incomplete attempt at adding support for the FEAT_XS feature in aarch64 TCG. This feature was introduced in ARMv8.7: it adds a new memory attribute XS which indicates that a memory access could take longer than usual to complete and also adds instruction variants for TLBI

[RFC PATCH 3/4] arm/tcg/cpu64: add FEAT_XS feat in max cpu

2024-10-14 Thread Manos Pitsidianakis
Add FEAT_XS feature report value in max cpu's ID_AA64ISAR1 sys register. Signed-off-by: Manos Pitsidianakis --- target/arm/tcg/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c index 0168920828651492b1114d66ab0fc72c20dda2a8..8c8f88d84151

[RFC PATCH 2/4] arm/tcg: add decodetree entry for DSB nXS variant

2024-10-14 Thread Manos Pitsidianakis
The DSB nXS variant is always both a reads and writes request type. Ignore the domain field like we do in plain DSB and perform a full system barrier operation. The DSB nXS variant is part of FEAT_XS made mandatory from Armv8.7. Signed-off-by: Manos Pitsidianakis --- target/arm/tcg/a64.decode

Re: [EXT] Re: [PATCH v1] hw/cxl: Fix background completion percentage calculation

2024-10-14 Thread ajay . opensrc
>On Mon, 14 Oct 2024 10:32 +0530 > wrote: > >On Sat, 14 Sep 2024 16:50:21 +0530 > wrote: > >> From: Ajay Joshi >> >> The current completion percentage calculation >> does not account for the relative time since >> the start of the background activity, this leads >> to showing incorrect start perc

Re: possible bug in recent crypto patches in master branch

2024-10-14 Thread Daniel P . Berrangé
On Sun, Oct 13, 2024 at 10:32:36PM +0600, Dorjoy Chowdhury wrote: > Hi, > I think there maybe some bugs caused by the recent crypto patches that got > merged to master. ref: > https://lore.kernel.org/qemu-devel/cafeaca-e_1wflun2hpttt2bszxksmbnxkak_uzuhwrh_fb6...@mail.gmail.com/T/#t > > I think bef

Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 11:12, Peter Maydell wrote: > > On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini wrote: > > v2->v3: new patches > > - scripts/archive-source: find directory name for subprojects > > - docs: fix invalid footnote syntax > > - docs: avoid footnotes consisting of just URLs > > - doc

Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

2024-10-14 Thread Paolo Bonzini
On Mon, Oct 14, 2024 at 12:40 PM Peter Maydell wrote: > > On Mon, 14 Oct 2024 at 11:12, Peter Maydell wrote: > > > > On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini wrote: > > > v2->v3: new patches > > > - scripts/archive-source: find directory name for subprojects > > > - docs: fix invalid footnote

Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

2024-10-14 Thread Manos Pitsidianakis
On Mon, 14 Oct 2024 13:40, Peter Maydell wrote: >On Mon, 14 Oct 2024 at 11:12, Peter Maydell wrote: >> >> On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini wrote: >> > v2->v3: new patches >> > - scripts/archive-source: find directory name for subprojects >> > - docs: fix invalid footnote syntax >> > -

[PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Paolo Bonzini
If the defaults for --enable-rust ($rust in configure) and Meson's rust option are out of sync, incremental builds will pick Meson's default. This happens because, on an incremental build, configure does not run Meson, Make does instead. Meson then gets the command line options from either coreda

Re: [PULL v3 00/18] Rust initial PoC + meson changes for 2024-10-07

2024-10-14 Thread Daniel P . Berrangé
On Mon, Oct 14, 2024 at 11:40:11AM +0100, Peter Maydell wrote: > On Mon, 14 Oct 2024 at 11:12, Peter Maydell wrote: > > > > On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini wrote: > > > v2->v3: new patches > > > - scripts/archive-source: find directory name for subprojects > > > - docs: fix invalid fo

Re: [PATCH -qemu] hw/cxl: Support get/set mctp response payload size

2024-10-14 Thread Jonathan Cameron via
On Thu, 10 Oct 2024 16:08:51 -0700 Fan Ni wrote: > On Wed, Oct 09, 2024 at 06:41:57PM -0700, Davidlohr Bueso wrote: > > Add Get/Set Response Message Limit commands. > > > > Signed-off-by: Davidlohr Bueso > > The commit log may include the cxl spec reference. Otherwise, > > Reviewed-by: Fan

[PATCH v3 1/8] target/riscv: Add Ssdbltrp CSRs handling

2024-10-14 Thread Clément Léger
Add ext_ssdbltrp in RISCVCPUConfig and implement MSTATUS.SDT, {H|M}ENVCFG.DTE and modify the availability of MTVAL2 based on the presence of the Ssdbltrp ISA extension. Signed-off-by: Clément Léger Reviewed-by: Alistair Francis --- target/riscv/cpu.h| 1 + target/riscv/cpu_bits.h |

[PATCH v3 4/8] target/riscv: Add Ssdbltrp ISA extension enable switch

2024-10-14 Thread Clément Léger
Add the switch to enable the Ssdbltrp ISA extension. Signed-off-by: Clément Léger --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 65347ccd5a..4a146bb637 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -190,6 +

[PATCH v3 8/8] target/riscv: Add Smdbltrp ISA extension enable switch

2024-10-14 Thread Clément Léger
Add the switch to enable the Smdbltrp ISA extension. Signed-off-by: Clément Léger --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 53e3bb6b37..6e22bfe37d 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -183,6 +

[PATCH v3 2/8] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-10-14 Thread Clément Léger
When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning to VU from HS. Signed-off-by: Clément Léger --- target/riscv/op_helper.c | 35 +

[PATCH v3 5/8] target/riscv: Add Smdbltrp CSRs handling

2024-10-14 Thread Clément Léger
Add `ext_smdbltrp`in RISCVCPUConfig and implement MSTATUS.MDT behavior. Also set MDT to 1 at reset according to the specification. Signed-off-by: Clément Léger --- target/riscv/cpu.c | 3 +++ target/riscv/cpu_bits.h | 1 + target/riscv/cpu_cfg.h | 1 + target/riscv/csr.c | 15 +

[PATCH v3 0/8] target/riscv: Add support for Smdbltrp and Ssdbltrp extensions

2024-10-14 Thread Clément Léger
A double trap typically arises during a sensitive phase in trap handling operations — when an exception or interrupt occurs while the trap handler (the component responsible for managing these events) is in a non-reentrant state. This non-reentrancy usually occurs in the early phase of trap handlin

[PATCH v3 3/8] target/riscv: Implement Ssdbltrp exception handling

2024-10-14 Thread Clément Léger
When the Ssdbltrp ISA extension is enabled, if a trap happens in S-mode while SSTATUS.SDT isn't cleared, generate a double trap exception to M-mode. Signed-off-by: Clément Léger --- target/riscv/cpu.c| 2 +- target/riscv/cpu_bits.h | 1 + target/riscv/cpu_helper.c | 42 ++

[PATCH v3 7/8] target/riscv: Implement Smdbltrp behavior

2024-10-14 Thread Clément Léger
When the Smsdbltrp ISA extension is enabled, if a trap happens while MSTATUS.MDT is already set, it will trigger an abort or an NMI is the Smrnmi extension is available. Signed-off-by: Clément Léger --- target/riscv/cpu_helper.c | 35 ++- 1 file changed, 26 insert

[PATCH v3 6/8] target/riscv: Implement Smdbltrp sret, mret and mnret behavior

2024-10-14 Thread Clément Léger
When the Ssdbltrp extension is enabled, SSTATUS.MDT field is cleared when executing sret if executed in M-mode. When executing mret/mnret, SSTATUS.MDT is cleared. Signed-off-by: Clément Léger --- target/riscv/op_helper.c | 12 1 file changed, 12 insertions(+) diff --git a/target/ri

Re: [QEMU RFC] hw/mem/cxl_type3: add guard to avoid event log overflow during a DC extent add/release request

2024-10-14 Thread Jonathan Cameron via
On Fri, 11 Oct 2024 13:24:50 -0700 nifan@gmail.com wrote: > From: Fan Ni > > One DC extent add/release request can take multiple DC extents. > For each extent in the request, one DC event record will be generated and > isnerted into the event log. All the event records for the request will b

Re: [PATCH net-next v7] ptp: Add support for the AMZNC10C 'vmclock' device

2024-10-14 Thread David Woodhouse
On Wed, 2024-10-09 at 17:32 -0700, Jakub Kicinski wrote: > On Sun, 06 Oct 2024 08:17:58 +0100 David Woodhouse wrote: > > +config PTP_1588_CLOCK_VMCLOCK > > +   tristate "Virtual machine PTP clock" > > +   depends on X86_TSC || ARM_ARCH_TIMER > > +   depends on PTP_1588_CLOCK && ACPI &&

Re: [PATCH v6 0/5] target/riscv: Add Smrnmi support.

2024-10-14 Thread Clément Léger
On 11/10/2024 13:38, Daniel Henrique Barboza wrote: > Hi Tommy, > > > Do you plan to send a new version of this work soon? This series is a > prerequisite > of "target/riscv: Add support for Smdbltrp and Ssdbltrp extensions" and > we need > this series merged first. We have minor comments from

Re: [PATCH v2 3/8] target/riscv: Implement Ssdbltrp exception handling

2024-10-14 Thread Clément Léger
On 11/10/2024 05:22, Alistair Francis wrote: > On Wed, Sep 25, 2024 at 9:59 PM Clément Léger wrote: >> >> When the Ssdbltrp ISA extension is enabled, if a trap happens in S-mode >> while SSTATUS.SDT isn't cleared, generate a double trap exception to >> M-mode. >> >> Signed-off-by: Clément Léger

Re: [PATCH v2 4/8] target/riscv: Add Ssdbltrp ISA extension enable switch

2024-10-14 Thread Clément Léger
On 11/10/2024 05:24, Alistair Francis wrote: > On Wed, Sep 25, 2024 at 9:59 PM Clément Léger wrote: >> >> Add the switch to enable the Ssdbltrp ISA extension. >> >> Signed-off-by: Clément Léger >> --- >> target/riscv/cpu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/target/r

Re: [PATCH v6 0/3] hw/{i2c,nvme}: mctp endpoint, nvme management interface model

2024-10-14 Thread Jonathan Cameron via
On Wed, 20 Sep 2023 09:36:34 -0500 Corey Minyard wrote: > On Wed, Sep 20, 2023 at 06:31:25AM -0700, Klaus Jensen wrote: > > On Sep 20 07:54, Corey Minyard wrote: > > > On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote: > > > > On Thu, 14 Sep 2023 11:53:40 +0200 > > > > Klau

Re: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with CPU scan

2024-10-14 Thread Igor Mammedov
On Mon, 14 Oct 2024 16:52:55 +0800 maobibo wrote: > Hi Salil, > > When I debug cpu hotplug on LoongArch system, It reports error like this: > ACPI BIOS Error (bug): Could not resolve symbol [\_SB.GED.CSCN], > AE_NOT_FOUND > ACPI Error: Aborting method \_SB.GED._EVT due to previous err

Re: [PATCH v16 04/13] s390x/pci: Avoid creating zpci for VFs

2024-10-14 Thread Cédric Le Goater
Hello Akihiko, On 10/12/24 13:05, Akihiko Odaki wrote: On 2024/10/11 0:44, Cédric Le Goater wrote: Hello Akihiko, Sorry for the late reply. On 9/18/24 17:32, Akihiko Odaki wrote: On 2024/09/18 17:02, Cédric Le Goater wrote: Hello, On 9/13/24 05:44, Akihiko Odaki wrote: VFs are automatical

Re: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with CPU scan

2024-10-14 Thread maobibo
Hi Salil, When I debug cpu hotplug on LoongArch system, It reports error like this: ACPI BIOS Error (bug): Could not resolve symbol [\_SB.GED.CSCN], AE_NOT_FOUND ACPI Error: Aborting method \_SB.GED._EVT due to previous error (AE_NOT_FOUND) acpi-ged ACPI0013:00: IRQ method executio

Re: [PATCH RESEND v4 0/4] target/i386: Various Hyper-V related fixes

2024-10-14 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Vitaly Kuznetsov writes: > >> Changes since '[PATCH RESEND v3 0/3] i386: Fix Hyper-V Gen1 guests stuck >> on boot with 'hv-passthrough': >> >> - Added "target/i386: Make sure SynIC state is really updated before >> KVM_RUN" >> to the set. >> >> This is a long pe

Re: [PATCH v6 0/5] target/riscv: Add Smrnmi support.

2024-10-14 Thread Frank Chang
Clément Léger 於 2024年10月14日 週一 下午3:36寫道: > > > > On 11/10/2024 13:38, Daniel Henrique Barboza wrote: > > Hi Tommy, > > > > > > Do you plan to send a new version of this work soon? This series is a > > prerequisite > > of "target/riscv: Add support for Smdbltrp and Ssdbltrp extensions" and > > we n

Re: ALSA support in qemu-user?

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 02:13, Andrew Randrianasulu wrote: > > some 8 years ago this patch was sent to qemu-devel: > > https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05333.html > "[Qemu-devel] [PATCH 7/7] Add ALSA ioctls" > > I wonder why it was rejected, may be as part of series? Hard

Re: [PATCH] ppc/pnv: Add support for TPM with SPI interface

2024-10-14 Thread Cédric Le Goater
Hello Dan, On 10/14/24 02:08, dan tan wrote: Hi Cédric, Thank you for the review comments. Please see my response below. thank you, --- dan tan power simulation phone:+1.7373.099.138 email:dan...@linux.ibm.com On 2024-09-12 12:20, Cédric Le Goater wrote: Hello Dan, On 9/12/24 18:09, dan ta

Re: ALSA support in qemu-user?

2024-10-14 Thread Thomas Huth
On 14/10/2024 11.06, Peter Maydell wrote: On Mon, 14 Oct 2024 at 02:13, Andrew Randrianasulu wrote: some 8 years ago this patch was sent to qemu-devel: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg05333.html "[Qemu-devel] [PATCH 7/7] Add ALSA ioctls" I wonder why it was rejected

Re: [PULL 08/20] virtio-net: Add only one queue pair when realizing

2024-10-14 Thread Laurent Vivier
Hi Akihiko, On 04/06/2024 09:37, Jason Wang wrote: From: Akihiko Odaki Multiqueue usage is not negotiated yet when realizing. If more than one queue is added and the guest never requests to enable multiqueue, the extra queues will not be deleted when unrealizing and leak. Fixes: f9d6dbf0bf6e

Re: [PATCH v4] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-10-14 Thread Alberto Garcia
ping On Tue, Jul 30, 2024 at 04:15:52PM +0200, Alberto Garcia wrote: > This tool converts a disk image to qcow2, writing the result directly > to stdout. This can be used for example to send the generated file > over the network.

[PATCH 6/8] chardev/mux: switch mux frontends management to bitset

2024-10-14 Thread Roman Penyaev
Frontends can be attached and detached during run-time (although detach is not implemented, but will follow). Counter variable of muxes is not enough for proper attach/detach management, so this patch implements bitset: if bit is set for the `mux_bitset` variable, then frontend device can be found

[PATCH 4/8] chardev/mux: convert size members to unsigned int

2024-10-14 Thread Roman Penyaev
There is no sense to keep `focus`, `mux_cnt`, `prod`, `cons` and `tag` variables as signed, those represent either size, either position in array, which both are unsigned. `focus` member of `MuxChardev` is kept signed, because initially set to -1. Signed-off-by: Roman Penyaev Cc: "Marc-André Lur

[PATCH 3/8] chardev/mux: use bool type for `linestart` and `term_got_escape`

2024-10-14 Thread Roman Penyaev
Those are boolean variables, not signed integers. Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- chardev/char-mux.c | 10 +- chardev/chardev-internal.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/chardev/char-mux.

Re: [PATCH] configure, meson: synchronize defaults for configure and Meson Rust options

2024-10-14 Thread Peter Maydell
On Mon, 14 Oct 2024 at 12:01, Paolo Bonzini wrote: > > If the defaults for --enable-rust ($rust in configure) and Meson's rust > option are out of sync, incremental builds will pick Meson's default. > > This happens because, on an incremental build, configure does not run > Meson, Make does instea

Re: [PATCH 1/1] chardev/char: fix qemu_chr_is_busy() check

2024-10-14 Thread Roman Penyaev
Hi Marc-André, On Thu, Oct 10, 2024 at 12:20 PM Marc-André Lureau wrote: > > Hi Roman > > On Thu, Oct 10, 2024 at 1:28 PM Roman Penyaev wrote: >> >> `mux_cnt` struct member never goes negative or decrements, >> so mux chardev can be !busy only when there are no >> frontends attached. This patch

[PATCH 0/8] chardev/mux: implement frontend detach

2024-10-14 Thread Roman Penyaev
Frontend device can be detached in run-time, which can lead to a "Chardev 'MUX' is busy" error (see the last patch with the test case implementation). This series implements frontend detach for the multiplexer based on bitset, which provides the ability to attach or detach frontend devices in any o

[PATCH 1/8] chardev/char: fix qemu_chr_is_busy() check

2024-10-14 Thread Roman Penyaev
`mux_cnt` struct member never goes negative or decrements, so mux chardev can be !busy only when there are no frontends attached. This patch fixes the always-true check. Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend") Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc:

[PATCH 8/8] tests/unit/test-char: implement a few mux remove test cases

2024-10-14 Thread Roman Penyaev
This patch tests: 1. feasibility of removing mux which does not have frontends attached or frontends were prior detached. 2. inability to remove mux which has frontends attached (mux is "busy") Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- tests/unit/tes

[PATCH 2/8] chardev/chardev-internal: remove unused `max_size` struct member

2024-10-14 Thread Roman Penyaev
Clean up forgotten leftovers. Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- chardev/chardev-internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/chardev/chardev-internal.h b/chardev/chardev-internal.h index 4e03af31476c..c3024b51fdda 100644 --- a/ch

[PATCH 5/8] chardev/mux: introduce `mux_chr_attach_frontend() call

2024-10-14 Thread Roman Penyaev
Move away logic which attaches frontend device to a mux from `char-fe.c` to actual `char-mux.c` implementation and make it a separate function. No logic changes are made. Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- chardev/char-fe.c | 9 +---

[PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Roman Penyaev
With bitset management now it becomes feasible to implement the logic of detaching frontends from multiplexer. Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- chardev/char-fe.c | 2 +- chardev/char-mux.c | 20 +--- chardev/cha

Re: [PATCH 1/1] hw/cxl/cxl-mailbox-utils: Fix for device DDR5 ECS control feature tables

2024-10-14 Thread Jonathan Cameron via
On Mon, 14 Oct 2024 11:09:12 +0100 Jonathan Cameron via wrote: > On Fri, 27 Sep 2024 10:17:43 +0100 > wrote: > > > From: Shiju Jose > > > > CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub (ECS) > > control feature. > > > > ECS log capabilities field in following ECS ta

Re: [PULL 00/27] tcg + linux patch queue

2024-10-14 Thread Peter Maydell
On Sun, 13 Oct 2024 at 23:20, Richard Henderson wrote: > > The following changes since commit 7e3b6d8063f245d27eecce5aabe624b5785f2a77: > > Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu > into staging (2024-10-10 18:05:43 +0100) > > are available in the Git repositor

[PATCH qemu 1/7] hw/cxl: Fix uint32 overflow cxl-mailbox-utils.c

2024-10-14 Thread Jonathan Cameron via
From: Dmitry Frolov The sum offset + length may overflow uint32. Since this sum is compared with uint64_t return value of get_lsa_size(), it makes sense to choose uint64_t type for offset and length. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 3ebe676a3463 ("hw/cxl/

[PATCH qemu 3/7] mem/cxl_type3: Fix overlapping region validation error

2024-10-14 Thread Jonathan Cameron via
From: Yao Xingtao When injecting a new poisoned region through qmp_cxl_inject_poison(), the newly injected region should not overlap with existing poisoned regions. The current validation method does not consider the following overlapping region: ┌───┬───┬───┐ │a │ b(a) │a │ └───┴───┴

[PATCH qemu 2/7] hw/cxl: Fix background completion percentage calculation

2024-10-14 Thread Jonathan Cameron via
From: Ajay Joshi The current completion percentage calculation does not account for the relative time since the start of the background activity, this leads to showing incorrect start percentage vs what has actually been completed. This patch calculates the percentage based on the actual elapsed

  1   2   3   >