Re: [Python-Dev] PEP 574 (pickle 5) implementation and backport available

2018-05-25 Thread Olivier Grisel
I tried this implementation to add no-copy pickling for large numpy arrays and seems to work as expected (for a simple contiguous array). I took some notes on the numpy tracker to advertise this PEP to the numpy developers: https://github.com/numpy/numpy/issues/11161 -- Olivier ​ ___

Re: [Python-Dev] PEP 574 (pickle 5) implementation and backport available

2018-05-26 Thread Olivier Grisel
+1 for not adding in-pickle compression as it is already very easy to handle compression externally (for instance by passing a compressing file object as an argument to the pickler). Furthermore, as PEP 574 makes it possible to stream the buffer bytes directly to the file-object without any tempora

Re: [Python-Dev] PEP 574 -- Pickle protocol 5 with out-of-band data

2018-07-09 Thread Olivier Grisel
Hi Serhiy, Do you have any bug / issue to track the work you want to do to add native pickling support for locally defined function and classes by serializing the code objects like cloudpickle does? Is this work public on some git branch on GitHub or somewhere else? Cheers, -- Olivier ​ __