[Python-Dev] Review request: issue 27350, compact ordered dict

2016-08-09 Thread INADA Naoki
Hi, devs. I've implemented compact and ordered dictionary [1], which PyPy implemented in 2015 [2]. Since it is my first large patch, I would like to have enough time for review cycle by Python 3.6 beta1. Could someone review it? [1] http://bugs.python.org/issue27350 [2] https://morepypy.blogsp

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Nick Coghlan
On 9 August 2016 at 06:18, Guido van Rossum wrote: > I think Nick would be interested in understanding why this is the case. > What does the decorator do that could be so expensive? > Reviewing https://hg.python.org/cpython/file/default/Lib/contextlib.py#l57, Chris's analysis seems plausible to

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Nick Coghlan
On 9 August 2016 at 23:26, Nick Coghlan wrote: > On 9 August 2016 at 06:18, Guido van Rossum wrote: > >> I think Nick would be interested in understanding why this is the case. >> What does the decorator do that could be so expensive? >> > > Reviewing https://hg.python.org/cpython/file/default/L

Re: [Python-Dev] Python parser performance optimizations

2016-08-09 Thread Artyom Skrobov
Hello, This is a monthly ping to get a review on http://bugs.python.org/issue26415 -- "Excessive peak memory consumption by the Python parser". Following the comments from July, the patches now include updating Misc/NEWS and compiler.rst to describe the change. The code change itself is still

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Giampaolo Rodola'
On Mon, Aug 8, 2016 at 11:59 PM, Chris Angelico wrote: > On Tue, Aug 9, 2016 at 7:14 AM, Wolfgang Maier > wrote: > > Right, I think a fairer comparison would be to: > > > > class ctx2: > > def __enter__(self): > > self.it = iter(self) > > return next(self.it) > > > > def

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Giampaolo Rodola'
On Tue, Aug 9, 2016 at 3:30 PM, Nick Coghlan wrote: > On 9 August 2016 at 23:26, Nick Coghlan wrote: > >> On 9 August 2016 at 06:18, Guido van Rossum wrote: >> >>> I think Nick would be interested in understanding why this is the case. >>> What does the decorator do that could be so expensive?

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Chris Angelico
On Wed, Aug 10, 2016 at 4:43 AM, Giampaolo Rodola' wrote: > -return self.__class__(self.func, self.args, self.kwds) > +func, args, kwds = self.funcak > +return self.__class__(func, args, kwds) return self.__class__(*self.funcak) > @wraps(func) > def helper(*args

Re: [Python-Dev] Rewrite @contextlib.contextmanager in C

2016-08-09 Thread Serhiy Storchaka
On 09.08.16 00:59, Chris Angelico wrote: class TooSimpleContextManager: """Now this time you've gone too far.""" def __init__(self, func): self.func = func def __call__(self): self.gen = self.func() return self def __enter__(self): next(self.gen)