[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.10, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26816 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28404 ___ Python tracker ___

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread sbougnoux
sbougnoux added the comment: Thanks for your prompt answer. Don't you think it should be the default? It seems like unneeded precision. Just if you want to check one don't miss a value, but in that case, one can use 'allow_no_value=False'. -- ___

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently regrtest supports two ways of collecting and running tests in module. 1. If the module contains the "test_main" function, regrtest just calls it. This function usually calls run_unittest() with a list of test classes, composed manually, it can

[issue45120] Windows cp encodings "UNDEFINED" entries update

2021-09-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Just to be clear: The Python code page encodings are (mostly) taken from the unicode.org set of mappings (ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/). This is our standards body for such mappings, where possible. In some cases, the Unicode consortium

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +26817 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28405 ___ Python tracker ___

[issue44848] Upgrade macOS and Windows installers to use SQLite 3.36.0

2021-09-17 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Steve. I'll pull in main and see how the CI fares. -- ___ Python tracker ___ ___ Pytho

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 28405 contains simple changes for 60 test files. It does not cover files which use complex code for generating list of test classes and running doctests (because there are subtle differences between running doctests with run_doctest() and via DocTestSui

[issue45230] Something wrong when Calculate "3==3 is not True"

2021-09-17 Thread Wang Bingchao
New submission from Wang Bingchao <819576...@qq.com>: I use python3.7 python3.6 python2.7, and run the following code: print(3==3 is not True) print(3==3 is True) print(3==2 is not True) print(3==2 is True) I got the same results as follow: True False False False but I don't think it is a reas

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Some tests in test_socket are not run, test.test_ssl.TestEnumerations is not run ___ Python tracker ___

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +26819 pull_request: https://github.com/python/cpython/pull/28407 ___ Python tracker ___ __

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +26818 pull_request: https://github.com/python/cpython/pull/28406 ___ Python tracker _

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 773319545ba60577bc140aa46eac83b360240b7a by Serhiy Storchaka in branch 'main': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/773319545ba60577bc140aa46eac83b360240b7a ---

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26820 pull_request: https://github.com/python/cpython/pull/28408 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26821 pull_request: https://github.com/python/cpython/pull/28409 ___ Python tracker ___

[issue45230] Something wrong when Calculate "3==3 is not True"

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: No, it is a feature. Python allows you to chain comparison operations, so you can write 0 < x <= 10 which is equivalent to (0 < x) and (x <= 10). And "is" is a comparison operation. So `3==3 is not True` is equivalent to `(3==3) and (3 is not True)` which

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 62c74f34e7541cf5c9780661b260c53617291804 by Miss Islington (bot) in branch '3.10': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/62c74f34e7541cf5c9780661b260c53617291804 -

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b2b035a949eff1dc54b5bafe2bc9ce72b4d24438 by Serhiy Storchaka in branch 'main': bpo-5846: Fix deprecations for obsolete unittest functions and add tests. (GH-28382) https://github.com/python/cpython/commit/b2b035a949eff1dc54b5bafe2bc9ce72b4d24

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- versions: +Python 3.11 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 98fef200bbfd8adec27799265deb200ab5e4513e by Miss Islington (bot) in branch '3.9': bpo-45228: Fix stack buffer overflow in parsing J1939 address (GH-28404) https://github.com/python/cpython/commit/98fef200bbfd8adec27799265deb200ab5e4513e --

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: _makeLoader is not deprecated yet, so we might keep this open a little bit more. -- ___ Python tracker ___

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: It's no longer possible to build Python from a different directory. Example: git clean -fdx mkdir build cd build/ ../configure --with-pydebug make It fails with: ../Programs/_freeze_module importlib._bootstrap ../Lib/importlib/_bootstrap.py ../Python/frozen

[issue45227] Control reaches end of non-void function in specialize.c

2021-09-17 Thread Ken Jin
Ken Jin added the comment: Please see https://bugs.python.org/issue45203. A fix is available at https://github.com/python/cpython/pull/28357 or https://github.com/python/cpython/pull/28386. But we're waiting for Windows CI to pass. -- nosy: +kj _

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
New submission from STINNER Victor : "make regen-frozen" changes PCbuild/_freeze_module.vcxproj and PCbuild/_freeze_module.vcxproj.filters changes files end of line on Linux. I'm working on a fix. When Python is built out of the source free, "make regen-pegen" changes Parser/parser.c and Too

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: There is also a minor issue, "make regen-frozen" changes the end of line of two PCbuild/ files: see bpo-45231. -- ___ Python tracker ___ ___

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +26822 pull_request: https://github.com/python/cpython/pull/28410 ___ Python tracker ___ __

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: See also my PR 28410 which fix Python built out of the source tree. -- ___ Python tracker ___ ___

[issue43219] shutil.copy raises IsADirectoryError when the directory does not actually exist

2021-09-17 Thread Alex Grund
Alex Grund added the comment: The changelog wrongfully links to https://bugs.python.org/issue41928 instead of this issue. Also the fix introduced a regression: Trying to copy a directory now raises a FileNotFoundError -- nosy: +Alex Grund ___ Pyt

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +26823 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28411 ___ Python tracker ___ _

[issue45203] Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR

2021-09-17 Thread Ken Jin
Ken Jin added the comment: New changeset 4857e53890408fd5a8ee0e83c0250dd5355b3de3 by Ken Jin in branch 'main': bpo-45203: fix compiler warnings (GH-28357) https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3 -- ___ Py

[issue45227] Control reaches end of non-void function in specialize.c

2021-09-17 Thread Ken Jin
Ken Jin added the comment: Fixed in https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Ken Jin
Ken Jin added the comment: @neonene Thanks for the truly excellent investigation! @Raymond and @Steve, If I understood OP (neonene) properly, changing Py_DECREF to a macro won't get back the entire 7% lost performance in pyperformance. neonene's investigations suggest that the entire eval fu

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: No, it shouldn't be the default. It never was before (this is a library that we've maintained for 20+ years now) and changing it now would mean that existing applications would stop validating their configuration in the way they did up to now. .ini files are u

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset ce59ac93626004894c2b291ec599a36cfa9fb0be by Serhiy Storchaka in branch '3.10': [3.10] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28409) https://github.com/python/cpython/commit/ce59ac93626004894c2b291ec599a

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 10c3cf78518f4b31e1527c2795694b1bcb092696 by Serhiy Storchaka in branch '3.9': [3.9] bpo-45212: Fix dangling threads in skipped tests in test_socket (GH-28361) (GH-28408) https://github.com/python/cpython/commit/10c3cf78518f4b31e1527c2795694b1

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: We can add a comment to the effect that "the wait here needs to be longer than the client-side (0.01s)". Since you already merged the change to `main`, it will be easiest to merge the backports as well and add the comment in a follow-up series. -- nosy

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: Haha, which you just did. Cool. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +26824 pull_request: https://github.com/python/cpython/pull/28412 ___ Python tracker _

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 0361335b80b435ca3694981b41f8269e390eb892 by Serhiy Storchaka in branch 'main': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/0361335b80b435ca3694981b41f8269e390eb892 -- nosy: +luka

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +26825 pull_request: https://github.com/python/cpython/pull/28413 ___ Python tracker ___ _

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26826 pull_request: https://github.com/python/cpython/pull/28414 ___ Python tracker ___

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have merged the backported PRs because they are blockers for my other PR which is a blocker for my other PR which is a blocker for my other PR and several future PRs. -- ___ Python tracker

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b by Serhiy Storchaka in branch 'main': bpo-45162: Remove many old deprecated unittest features (GH-28268) https://github.com/python/cpython/commit/b0a6ede3d0bd6fa4ffe413ab4dfc1059201df25b -- _

[issue45162] Remove old deprecated unittest features

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread miss-islington
miss-islington added the comment: New changeset 5a5684a14b1417fea27af6b6a89eb7faec7fb80a by Miss Islington (bot) in branch '3.10': bpo-45187: Collect test_socket tests using unittest (GH-28317) https://github.com/python/cpython/commit/5a5684a14b1417fea27af6b6a89eb7faec7fb80a -- ___

[issue45107] Improve LOAD_METHOD specialization

2021-09-17 Thread Ken Jin
Ken Jin added the comment: New changeset 70bed6f9936c811472b376edd93c37bcf8f06f35 by Ken Jin in branch 'main': bpo-45107: Make LOAD_METHOD_CLASS safer and faster, clean up comments (GH-28177) https://github.com/python/cpython/commit/70bed6f9936c811472b376edd93c37bcf8f06f35 -- _

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset cb07838ab756564988b1ffd23871f1222a832446 by Nikita Sobolev in branch 'main': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) https://github.com/python/cpython/commit/cb07838ab756564988b1ffd23871f1222a832446 --

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26827 pull_request: https://github.com/python/cpython/pull/28416 ___ Python tracker _

[issue45219] Expose indexing and other simple operations on dict-keys in internal API

2021-09-17 Thread Mark Shannon
Mark Shannon added the comment: New changeset 064464fc38269e70f7e3a34cb25fc9085ab85782 by Mark Shannon in branch 'main': bpo-45219: Factor dictkey indexing (GH-28389) https://github.com/python/cpython/commit/064464fc38269e70f7e3a34cb25fc9085ab85782 -- __

[issue45219] Expose indexing and other simple operations on dict-keys in internal API

2021-09-17 Thread Mark Shannon
Change by Mark Shannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44211] Duplicate '.bmp' key in mimetypes.py, maps to both 'image/bmp' and 'image/x-ms-bmp'

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is not clear whether we want to backport this change. -- ___ Python tracker ___ ___ Python-b

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +26828 pull_request: https://github.com/python/cpython/pull/28418 ___ Python tracker ___ __

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 3ea1c4b66887e7ca920db487f6ffc5f1db3c873f by Miss Islington (bot) in branch '3.9': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) (GH-28416) https://github.com/python/cpython/commit/3ea1c4b66887e7ca920db487f6ffc

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: > the entire eval function is now too big for PGO on MSVC I don't think that the issue is specific to MSVC. If a function becomes too big, it becomes less efficient for CPU caches. One idea would be to move the least common opcodes into a slow-path, in a se

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0f4449ecb0d678984b1343d60c070dcb1bd62e56 by Łukasz Langa in branch '3.9': [3.9] bpo-45187: Collect test_socket tests using unittest (GH-28317) (GH-28413) https://github.com/python/cpython/commit/0f4449ecb0d678984b1343d60c070dcb1bd62e56 --

[issue45228] Stack buffer overflow in parsing J1939 network address

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue5846] Deprecate obsolete functions in unittest

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is an internal function. We can remove it without deprecation. -- ___ Python tracker ___ ___

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6b413551284a94cfe31377c9c607ff890aa06c26 by Victor Stinner in branch 'main': bpo-45116: Add the Py_ALWAYS_INLINE macro (GH-28390) https://github.com/python/cpython/commit/6b413551284a94cfe31377c9c607ff890aa06c26 -- ___

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: I added Py_ALWAYS_INLINE to run benchmarks more easily. Even if Py_INCREF() is converted back to a macro, there are now multiple static inline functions which are short and performance critical. Using Py_ALWAYS_INLINE *may* speed up the Python debug builds a

[issue45120] Windows cp encodings "UNDEFINED" entries update

2021-09-17 Thread Eryk Sun
Eryk Sun added the comment: > From Eryk's description it sounds like we should always add > WC_NO_BEST_FIT_CHARS as an option to MultiByteToWideChar() > in order to make sure it doesn't use best fit variants > unless explicitly requested. The concept of a "best fit" encoding is unrelated to

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Olivier Delhomme
New submission from Olivier Delhomme : $ python3 --version Python 3.6.4 Setting LANG to en_US.UTF8 works like a charm $ export LANG=en_US.UTF8 $ python3 Python 3.6.4 (default, Jan 11 2018, 16:45:55) [GCC 4.8.5] on linux Type "help", "copyright", "credits" or "license" for more information.

[issue45233] Allow split key dictionaries with values owned by other objects.

2021-09-17 Thread Mark Shannon
New submission from Mark Shannon : Currently, if a dictionary is split, then the dictionary owns the memory for the values. Unless the values is the unique empty-values array. In order to support lazily created dictionaries for objects (see https://github.com/faster-cpython/ideas/issues/72#is

[issue45233] Allow split key dictionaries with values owned by other objects.

2021-09-17 Thread Mark Shannon
Mark Shannon added the comment: An alternative placement for the flag bits: Stride bits in the dictkeys. Ownership bits in the low bits of ma_used. This would still allow us to remove the version tag at some point. -- ___ Python tracker

[issue10611] sys.exit() in a test causes a test run to die

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 4.0 -> 5.0 pull_requests: +26829 pull_request: https://github.com/python/cpython/pull/28180 ___ Python tracker _

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset a10726d3141d8f52a108c4daf70eefa29401e2fc by Miss Islington (bot) in branch '3.10': bpo-45217: adds note that `allow_no_value` in `configparser` is optional (GH-28396) (GH-28418) https://github.com/python/cpython/commit/a10726d3141d8f52a108c4daf70e

[issue45217] ConfigParser does not accept "No value" reversely to the doc

2021-09-17 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for the patch, Nikita! ✨ 🍰 ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue10611] sys.exit() in a test causes a test run to die

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: -26829 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Yes, this is intended. ASCII is used as fallback in case Python cannot determine the I/O encoding to use during startup. This is also the reason why later changes to the environment have no affect on this - the determination of the encoding has already been

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 54a1760cde7bb01e5574734c389c0746762218fd by Serhiy Storchaka in branch 'main': bpo-45212: Add a comment for time.sleep() in tests (GH-28414) https://github.com/python/cpython/commit/54a1760cde7bb01e5574734c389c0746762218fd -- __

[issue45212] Dangling threads in skipped tests in test_socket

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30511] shutil.make_archive should not need to chdir (alternatively: make shutil.make_archive thread-safe)

2021-09-17 Thread Filipe Laíns
Change by Filipe Laíns : -- nosy: +FFY00 nosy_count: 8.0 -> 9.0 pull_requests: +26830 pull_request: https://github.com/python/cpython/pull/28271 ___ Python tracker ___ _

[issue45229] Always use unittest for collecting tests in regrtests

2021-09-17 Thread Zachary Ware
Zachary Ware added the comment: See also bpo-16748 -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Olivier Delhomme
Olivier Delhomme added the comment: Hi Marc-Andre, Please note that setting PYTHONUTF8 with "export PYTHONUTF8=1": * Is external to the program and user dependent * It does not seems to work on my use case: $ unset LANG $ export PYTHONUTF8=1 $ python3 Python 3.6.4 (default, Jan 11 20

[issue43413] tuple subclasses allow arbitrary kwargs

2021-09-17 Thread Jason R. Coombs
Jason R. Coombs added the comment: >> Subclass of set can now define > Is there any use case for this? Is your concern about a use-case for the general concept or for set specifically? I appreciate that Serhiy has taken the time to evaluate the specific concern I raised and extrapolate it t

[issue43413] tuple subclasses allow arbitrary kwargs

2021-09-17 Thread Jason R. Coombs
Jason R. Coombs added the comment: Oh, and I see now Serhiy has proposed a change that looks reasonable. -- ___ Python tracker ___

[issue45234] copy_file raises FileNotFoundError when src is a directory

2021-09-17 Thread Alex Grund
New submission from Alex Grund : After https://bugs.python.org/issue43219 was resolved the function now shows faulty behavior when the source is a directory: `copy_file('/path/to/dir', '/target')` throws a FileNotFoundError while previously it was a IsADirectoryError which is clearly correct.

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 17.09.2021 15:45, Olivier Delhomme wrote: > > Olivier Delhomme added the comment: > > Hi Marc-Andre, > > Please note that setting PYTHONUTF8 with "export PYTHONUTF8=1": > > * Is external to the program and user dependent > * It does not seems to work

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +26831 pull_request: https://github.com/python/cpython/pull/28419 ___ Python tracker ___ __

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Olivier Delhomme
Olivier Delhomme added the comment: >> Hi Marc-Andre, >> >> Please note that setting PYTHONUTF8 with "export PYTHONUTF8=1": >> >> * Is external to the program and user dependent >> * It does not seems to work on my use case: >> >>$ unset LANG >>$ export PYTHONUTF8=1 >>$ python3 >>

[issue45235] argparse does not preserve namespace with subparser defaults

2021-09-17 Thread Adam Schwalm
New submission from Adam Schwalm : The following snippet demonstrates the problem. If a subparser flag has a default set, argparse will override the existing value in the provided 'namespace' if the flag does not appear (e.g., if the default is used): import argparse parser = argparse

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Marc-Andre Lemburg
Change by Marc-Andre Lemburg : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Py

[issue45235] argparse does not preserve namespace with subparser defaults

2021-09-17 Thread Adam Schwalm
Change by Adam Schwalm : -- keywords: +patch pull_requests: +26832 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28420 ___ Python tracker ___ ___

[issue45234] copy_file raises FileNotFoundError when src is a directory

2021-09-17 Thread Andrei Kulakov
Change by Andrei Kulakov : -- keywords: +patch nosy: +andrei.avk nosy_count: 1.0 -> 2.0 pull_requests: +26833 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28421 ___ Python tracker

[issue45234] copy_file raises FileNotFoundError when src is a directory

2021-09-17 Thread Andrei Kulakov
Andrei Kulakov added the comment: Alex: thanks for the report! I've added a PR that should fix this. -- ___ Python tracker ___ ___

[issue45232] ascii codec is used by default when LANG is not set

2021-09-17 Thread Eryk Sun
Eryk Sun added the comment: Python 3.7+ doesn't need to explicitly enable UTF-8 mode in this case on POSIX systems. If the locale encoding is the "POSIX" or "C" locale, and "C" locale coercion is not disabled via LC_ALL or PYTHONCOERCECLOCALE=0, the interpreter tries to coerce the LC_CTYPE l

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Right now, I'm not sure. The heuristic to decide > if a function is inlined or not seems to depend > a lot on the compiler and the compiler options. That is exactly correct. And it is why we should use the macro form which is certain to be inlined. Ple

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: Pablo, should this be a release blocker? -- nosy: +lemburg, pablogsal ___ Python tracker ___ _

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: FWIW: Back in the days of Python 1.5.2, the ceval loop was too big for CPU caches as well and one of the things I experimented with at the time was rearranging the opcodes based on how often they were used and splitting the whole switch statement we had

[issue45103] IDLE: make configdialog font page survive font failures

2021-09-17 Thread E. Paine
E. Paine added the comment: https://core.tcl-lang.org/tk/tktview/0338867c742 IMO this should be closed as third-party, since there is very little we can / should do (yes we could remove the offending characters from the preview if the user has the font installed, but this is a lot of extra

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Pablo, should this be a release blocker? How severe is the regression? If is severe enough we can mark it as a release blocker, but a conclusion needs to be reached ASAP because I don't want to change a fundamental macro a few days before the releas

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread Ken Jin
Ken Jin added the comment: > How severe is the regression? OP provided pyperformance of current 3.10 vs their patched version at https://bugs.python.org/file50280/310rc2_benchmarks.txt. The patch is at https://bugs.python.org/msg401743. -- ___ Py

[issue45231] make regen-all changes files on Linux

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset c5a677da9e7b2b2aa43b0b6dfb3813c0212379c0 by Victor Stinner in branch 'main': bpo-45231: update_file.py preserves end of line (GH-28411) https://github.com/python/cpython/commit/c5a677da9e7b2b2aa43b0b6dfb3813c0212379c0 -- _

[issue45020] Freeze all modules imported during startup.

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset 41551ee7e24fb6c58846836d3655dbb212281206 by Victor Stinner in branch 'main': bpo-45020: Fix build out of source tree (GH-28410) https://github.com/python/cpython/commit/41551ee7e24fb6c58846836d3655dbb212281206 -- _

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +26834 pull_request: https://github.com/python/cpython/pull/28422 ___ Python tracker ___

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

2021-09-17 Thread STINNER Victor
STINNER Victor added the comment: Raymond: "Please do as Steve asked and revert back to the previous stable, reliable code." Is this issue really about Py_INCREF() being a static inline macro? Or is it more about the increased size of the _PyEval_EvalFrameDefault() function? neonene's anal

[issue43232] Prohibit previously deprecated operations on asyncio.trsock.TransportSocket

2021-09-17 Thread John Snow
John Snow added the comment: Without sendmsg(), is there any other way to send SCM_RIGHTS ancillary messages over an asyncio-managed UNIX socket? (Is there a better place to discuss this? Kindly point me in the right direction if so.) -- nosy: +jnsnow __

[issue21627] Concurrently closing files and iterating over the open files directory is not well specified

2021-09-17 Thread Dan Snider
Dan Snider added the comment: On Android, if os.close_range closes the file descriptor of the scandir iterator, the interpreter immediately crashes eg: >>> import os >>> os.scandir() >>> os.closerange(3,) fdsan: attempted to close file descriptor 3, expected to be unowned, actually owne

[issue45187] Some tests in test_socket are not run

2021-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 51ebb7f4f5e9bdcf8279a1d91be9569706f6bead by Serhiy Storchaka in branch 'main': bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422) https://github.com/python/cpython/commit/51ebb7f4f5e9bdcf8279a1d91be9569706f6b

  1   2   >