[Numpy-discussion] Re: Add diagonal offset argument to all functions that are missing it

2025-02-11 Thread Ralf Gommers via NumPy-Discussion
On Sun, Feb 9, 2025 at 6:34 PM Carlos Martin wrote: > The following functions accept a diagonal offset argument: > - https://numpy.org/doc/stable/reference/generated/numpy.diag.html > - https://numpy.org/doc/stable/reference/generated/numpy.diagflat.html > - https://numpy.org/doc/stable/reference

[Numpy-discussion] Re: Add diagonal offset argument to all functions that are missing it

2025-02-11 Thread Lucas Colley via NumPy-Discussion
Ralf Gommers wrote: > This sounds quite reasonable to me. The `k=0` keyword is quite badly named, > which is my one concern. Especially when tacking it on at the end of a > signature with already 3-4 keywords, it's not a good name. How about > something like `diag_offset`? FWIW, we chose `offset`

[Numpy-discussion] Re: Add diagonal offset argument to all functions that are missing it

2025-02-11 Thread Ralf Gommers via NumPy-Discussion
On Tue, Feb 11, 2025 at 10:55 AM Lucas Colley via NumPy-Discussion < numpy-discussion@python.org> wrote: > Ralf Gommers wrote: > > This sounds quite reasonable to me. The `k=0` keyword is quite badly > named, > > which is my one concern. Especially when tacking it on at the end of a > > signature