Re: [I] [MS10] Log4j API generalization #1 (logging-log4j2)

2024-03-13 Thread via GitHub
grobmeier commented on issue #2273: URL: https://github.com/apache/logging-log4j2/issues/2273#issuecomment-1994980963 Confirmed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
erikmav commented on code in PR #123: URL: https://github.com/apache/logging-log4net/pull/123#discussion_r1523826184 ## src/log4net/Repository/Hierarchy/Logger.cs: ## @@ -329,12 +306,12 @@ public virtual void RemoveAllAppenders() /// on the appender removed. ///

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on code in PR #123: URL: https://github.com/apache/logging-log4net/pull/123#discussion_r1523959729 ## src/log4net/Repository/Hierarchy/Logger.cs: ## @@ -329,12 +306,12 @@ public virtual void RemoveAllAppenders() /// on the appender removed. ///

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1995964665 @erikmav Thank you very much (especially for adding the tests). After adding the one missing test (RemoveAppender(IAppender) we are ready to merge. -- This is an automated m

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-13 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1995977044 @erikmav @fluffynuts I've created issue #124 for those improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[I] Improve logging context integration [logging-log4j-kotlin]

2024-03-13 Thread via GitHub
rocketraman opened a new issue, #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71 Using log4j2 context kind of sucks. The assumption that context will always be set at the Thread or coroutine level is IMO false, and sometimes we just want to set context for a particular blo

Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-13 Thread via GitHub
rgoers commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1996359179 @ppkarwasz @vy I agree that the below is not ideal or what I would recommend but the exception does need to log it as a parameter. Changing this behavior now under the cov

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
vy commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997010610 I think this is related to [apache/logging-log4j2#2213]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [BUG] Exception stack works ok with logback , but a lot of the exception stack is gone with log4j2. (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1997032784 @SeasonPanPan, thanks so much for the report. This issue is more convoluted than it meets the eye: 1. `formatTo()` behaviour of `ParameterizedMessage` and `ReusableParamete

[PR] Bump actions/setup-java from 4.1.0 to 4.2.0 [logging-parent]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/logging-parent/pull/135 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.1.0 to 4.2.0. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j

Re: [PR] Bump actions/setup-java from 4.1.0 to 4.2.0 [logging-parent]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #135: URL: https://github.com/apache/logging-parent/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Bump com.palantir.javaformat:palantir-java-format from 2.40.0 to 2.41.0 [logging-parent]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #136: URL: https://github.com/apache/logging-parent/pull/136 Bumps [com.palantir.javaformat:palantir-java-format](https://github.com/palantir/palantir-java-format) from 2.40.0 to 2.41.0. Release notes Sourced from https://github.com/palan

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.40.0 to 2.41.0 [logging-parent]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #136: URL: https://github.com/apache/logging-parent/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[I] Log messages with partially missing parameters (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz opened a new issue, #2380: URL: https://github.com/apache/logging-log4j2/issues/2380 Log4j version `2.20.0` did also log messages with missing parameters. A call like: ```java logger.info("{}, {} and {}", 1, 2); ``` resulted in a partially replaced message: `1,

Re: [PR] Bump org.apache.groovy:groovy-bom from 4.0.19 to 4.0.20 (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2376: URL: https://github.com/apache/logging-log4j2/pull/2376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump guava.version from 33.0.0-jre to 33.1.0-jre (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #2375: Bump guava.version from 33.0.0-jre to 33.1.0-jre URL: https://github.com/apache/logging-log4j2/pull/2375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump spring-framework.version from 5.3.32 to 5.3.33 (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2378: URL: https://github.com/apache/logging-log4j2/pull/2378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz opened a new pull request, #2381: URL: https://github.com/apache/logging-log4j2/pull/2381 The semantics used to determine the `Throwable` attached to a log event changed in Logback 1.1.0 (in the fix to [LOGBACK-873](https://jira.qos.ch/browse/LOGBACK-873)). When there are n

[PR] Bump org.springframework:spring-framework-bom from 5.3.32 to 5.3.33 [logging-log4j-audit-sample]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #43: URL: https://github.com/apache/logging-log4j-audit-sample/pull/43 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.32 to 5.3.33. Release notes Sourced from https://github.

Re: [PR] Bump guava.version from 33.0.0-jre to 33.1.0-jre (logging-log4j2)

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #2377: URL: https://github.com/apache/logging-log4j2/pull/2377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-1997240044 @SeasonPanPan, As Volkan mentioned, solving your migration issues require 3 ingredients that we will try to incorporate into `2.24.0`: - [ ] #2381 - [ ] #2

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.32 to 5.3.33 [logging-log4j-audit-sample]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #43: URL: https://github.com/apache/logging-log4j-audit-sample/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997613964 > I think this is related to [[apache/logging-log4j2#2213](https://github.com/apache/logging-log4j2/issues/2213)]. @vy It seems so, but I'm unsatisfied by the an

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
vy commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1997814563 @rocketraman, AFAIC, the problem is the lack of a dynamically scoped variable (you might be familiar with this concept if you have ever used a Lisp dialect), and hence, we use t

[I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-14 Thread via GitHub
erikmav opened a new issue, #125: URL: https://github.com/apache/logging-log4net/issues/125 There are numerous parts of the code that are marked with [Deprecated] attributes. Additionally there is code that may or may not any longer be in use, such as NDC (src/log4net/NDC.cs). Ideally with

[PR] Bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [logging-log4j-audit]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #129: URL: https://github.com/apache/logging-log4j-audit/pull/129 Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.0.0-jre to 33.1.0-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.goog

Re: [PR] Bump com.google.guava:guava from 33.0.0-jre to 33.1.0-jre [logging-log4j-audit]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #129: URL: https://github.com/apache/logging-log4j-audit/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525178892 ## log4j-1.2-api/src/main/java/org/apache/log4j/bridge/LogEventWrapper.java: ## @@ -109,12 +110,17 @@ public Instant getInstant() { } @Override -publi

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1998055009 > Am I missing something? @vy Yes, I think so. Or I am :-) If you look back at my example, logging in `R` is not (only) *thread-scoped*, it is both *thread

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-14 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-1998067762 I think the ideal solution for this would look something like this, and could leverage the solution we come up with for https://github.com/apache/logging-log4j-kotlin/i

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525347864 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MementoLogEvent.java: ## @@ -72,50 +73,37 @@ public MementoLogEvent(final LogEvent event) {

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on code in PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#discussion_r1525347314 ## log4j-core/src/main/java/org/apache/logging/log4j/core/impl/MementoLogEvent.java: ## @@ -72,50 +73,37 @@ public MementoLogEvent(final LogEvent event) {

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-14 Thread via GitHub
vy commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1525322283 ## log4j-api-test/src/test/java/org/apache/logging/log4j/spi/ThreadContextMapTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz commented on PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329#issuecomment-1998305974 > 1. Since the `Message` is already populated with a `loggerFqcn` and that is enough to resolve the `location` in the `LogEvent`, we don't need to resolve the location in `Ab

Re: [PR] Make location computation and message formatting more lazy (logging-log4j2)

2024-03-14 Thread via GitHub
ppkarwasz merged PR #2329: URL: https://github.com/apache/logging-log4j2/pull/2329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Bump org.springframework:spring-framework-bom from 6.1.4 to 6.1.5 [logging-log4j-jakarta]

2024-03-14 Thread via GitHub
github-actions[bot] merged PR #24: URL: https://github.com/apache/logging-log4j-jakarta/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.33 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #119: URL: https://github.com/apache/logging-log4j-samples/pull/119 Bumps [org.springframework:spring-framework-bom](https://github.com/spring-projects/spring-framework) from 5.3.31 to 5.3.33. Release notes Sourced from https://github.com

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] commented on PR #116: URL: https://github.com/apache/logging-log4j-samples/pull/116#issuecomment-1998707018 Superseded by #119. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 [logging-log4j-samples]

2024-03-14 Thread via GitHub
dependabot[bot] closed pull request #116: Bump org.springframework:spring-framework-bom from 5.3.31 to 5.3.32 URL: https://github.com/apache/logging-log4j-samples/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1999156517 @erikmav did you see my comment regarding the missing test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] Bump actions/setup-java from 4.2.0 to 4.2.1 [logging-parent]

2024-03-15 Thread via GitHub
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/logging-parent/pull/137 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.0 to 4.2.1. Release notes Sourced from https://github.com/actions/setup-java/releases";>actions/setup-j

Re: [PR] Bump actions/setup-java from 4.2.0 to 4.2.1 [logging-parent]

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #137: URL: https://github.com/apache/logging-parent/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-1999398844 I agree with removing the obsolete classes and methods. I'm not sure about NDC. Looking at the code it seems to be explicitly un-deprecated and there are many uses

Re: [PR] Bump spring-framework.version from 6.1.4 to 6.1.5 (logging-log4j2)

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #2382: URL: https://github.com/apache/logging-log4j2/pull/2382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[I] Split off XML configuration into its own module or internal package (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz opened a new issue, #2383: URL: https://github.com/apache/logging-log4j2/issues/2383 Since `java.xml` is an **optional** module in Log4j Core 3.x, we need to protect the users from linkage errors like the one reported in [LOG4J2-3681](https://issues.apache.org/jira/browse/LOG4J2-3

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-1999873939 Misunderstood the comment. Working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
JyotiSathe opened a new issue, #2384: URL: https://github.com/apache/logging-log4j2/issues/2384 ## Description I have spring boot project, recently upgraded to version 3.2.2 from 3.1.0. We are using dependency "org.apache.logging.log4j:log4j-spring-boot" in our project. After

[PR] Bump org.postgresql:postgresql from 42.7.2 to 42.7.3 [logging-log4j-audit]

2024-03-15 Thread via GitHub
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/logging-log4j-audit/pull/130 Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.2 to 42.7.3. Release notes Sourced from https://github.com/pgjdbc/pgjdbc/releases";>org.postgre

Re: [PR] Bump org.postgresql:postgresql from 42.7.2 to 42.7.3 [logging-log4j-audit]

2024-03-15 Thread via GitHub
github-actions[bot] merged PR #130: URL: https://github.com/apache/logging-log4j-audit/pull/130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz closed issue #2384: log4j-spring-boot gives error URL: https://github.com/apache/logging-log4j2/issues/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-291619 @JyotiSathe, Which Spring Boot 3.x artifact depends on `org.apache.logging.log4j:log4j-spring-boot`? The functionality of `log4j-spring-boot` is embedded into

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
JyotiSathe commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2000110589 If I remove the dependency log4j-spring-boot then I get below exception. **ERROR StatusConsoleListener Resolver failed to lookup spring:spring.application.name j

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #123: URL: https://github.com/apache/logging-log4net/pull/123#issuecomment-2000186414 Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Nullable and modernization part 2 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil merged PR #123: URL: https://github.com/apache/logging-log4net/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[I] SpringProfile arbiter fails without a Spring's environment (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz opened a new issue, #1783: URL: https://github.com/apache/logging-log4j2/issues/1783 ## Description In a Spring Boot application Log4j Core is initialized **at least** twice: - the first initialization is the static Log4j Core initialization (Spring's [`Environment`](ht

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2000228751 @JyotiSathe, The stack trace you deleted seems like a problem with Spring Boot's version of our lookup. Unlike our version it fails if there is no environment.

[PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav opened a new pull request, #126: URL: https://github.com/apache/logging-log4net/pull/126 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000331267 For #124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
fluffynuts commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-2000341731 I agree - something marked `[Obsolete]` can go, something that still works, even if it's only for a few users, can stay. And we should be very judicial about deprecations -

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
erikmav commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000343172 @FreeAndNil Important to closely review `ReadOnlyPropertiesDictionary` and `PropertiesDictionary`. I selected the most backward compatible option, which is to coerce the `this[]` ge

Re: [PR] Nullability and modernization updates, part 3 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on PR #126: URL: https://github.com/apache/logging-log4net/pull/126#issuecomment-2000364779 Thanks. I will review on Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Remove deprecated code for 3.0 (logging-log4net)

2024-03-15 Thread via GitHub
FreeAndNil commented on issue #125: URL: https://github.com/apache/logging-log4net/issues/125#issuecomment-2000480599 OK. I would propose releasing the first 3.0.0 preview with the obsolete classes, so that we could deploy this version in our company and to other "willing" users. Then we r

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-15 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527118053 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java: ## @@ -43,40 +43,30 @@ public class DefaultThreadContextMap implements T

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-16 Thread via GitHub
SeasonPanPan commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2001921715 @ppkarwasz @vy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-16 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527192000 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -20,39 +20,135 @@ import java.net.URL; import java.util.Properties; import org.

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-16 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527192823 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -97,127 +217,266 @@ public String getVersions() { /** * Gets the prio

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-16 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527193084 ## log4j-api/src/main/java/org/apache/logging/log4j/spi/Provider.java: ## @@ -97,127 +217,266 @@ public String getVersions() { /** * Gets the prio

Re: [PR] Centralize initialization in `Provider` class (logging-log4j2)

2024-03-16 Thread via GitHub
ppkarwasz commented on code in PR #2374: URL: https://github.com/apache/logging-log4j2/pull/2374#discussion_r1527196204 ## log4j-api/src/main/java/org/apache/logging/log4j/util/ProviderUtil.java: ## @@ -163,6 +172,88 @@ static void lazyInit() { } } +/** +

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-16 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2002079852 @SeasonPanPan, Thank you for your proposal. #2379 might be a little bit Log4j specific, but I can assign you #2380 if it interests you. -- This is an automated mes

[PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-16 Thread via GitHub
rgoers opened a new pull request, #2385: URL: https://github.com/apache/logging-log4j2/pull/2385 This adds support for a ScopedContext as requested in kotlin/#74 and similar to #2214 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002375125 > If you look back at my example, logging in `R` is not (only) _thread-scoped_, it is both _thread-scoped_ AND _class-scoped_. In other words, I want all logging in `R` t

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-17 Thread via GitHub
SeasonPanPan commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2002400761 > @SeasonPanPan, > > Thank you for your proposal. #2379 might be a little bit Log4j specific, but I can assign you #2380 if it interests you. @ppkarwasz OK,

Re: [I] Add Logback's throwable-consuming semantics as an option (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #2363: URL: https://github.com/apache/logging-log4j2/issues/2363#issuecomment-2002444711 Not sure how this works on Github. Maybe you need to comment on the issue, for me to be able to assign it to you. -- This is an automated message from the Apache Git Serv

Re: [I] Log messages with partially missing parameters (logging-log4j2)

2024-03-17 Thread via GitHub
SeasonPanPan commented on issue #2380: URL: https://github.com/apache/logging-log4j2/issues/2380#issuecomment-2002451427 I will work on this issue #2380 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002452904 @rgoers I think you missed the class-scoped (*not* thread-scoped) context in my example. @ppkarwasz Ah interesting -- if I could bind `Property` dynamically then

Re: [I] Log messages with partially missing parameters (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on issue #2380: URL: https://github.com/apache/logging-log4j2/issues/2380#issuecomment-2002453940 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[I] Enable building log4net with docker container (logging-log4net)

2024-03-17 Thread via GitHub
FreeAndNil opened a new issue, #127: URL: https://github.com/apache/logging-log4net/issues/127 Provide the following convenience for PMC members to review the project: ``` git checkout docker build -t log4net-builder . docker run log4net-builder ``` That is, a convenience t

[PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-17 Thread via GitHub
FreeAndNil opened a new pull request, #128: URL: https://github.com/apache/logging-log4net/pull/128 Enable building log4net with docker container #127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rgoers commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002548717 @rocketraman I guess I am not grasping at all what you want. With my PR you can now do: ``` class T { private static final Logger log = LogManger.getLogger(T.

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rocketraman commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002565293 @rgoers Yes, in my original post I proposed a method `withContextMap` that would be used in Kotlin the same way as `ScopedContext` (though its a bit nicer in Kotlin).

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-17 Thread via GitHub
rgoers commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2002582832 @rocketraman Again, I don't understand. ScopedContext IS a builder. Each where method adds a new key/value pair to the context. The run and call methods are, in essence, the

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-17 Thread via GitHub
vy commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r1527612300 ## Dockerfile: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# dis

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527614991 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527626489 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527630234 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2002643187 @ppkarwasz For some reason I cannot reply to your original comment directly. > At a first glance, I would probably prefer to see a wrapper like this: > > public class Co

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527630234 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
ppkarwasz commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527614991 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527643984 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527643984 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-17 Thread via GitHub
JyotiSathe closed issue #2384: log4j-spring-boot gives error URL: https://github.com/apache/logging-log4j2/issues/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] log4j-spring-boot gives error (logging-log4j2)

2024-03-17 Thread via GitHub
JyotiSathe commented on issue #2384: URL: https://github.com/apache/logging-log4j2/issues/2384#issuecomment-2003015836 Yes after removing log4j-spring-boot and renaming log4j-spring.xml issue is resolved. Thanks for the help. -- This is an automated message from the Apache Git Service. T

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-17 Thread via GitHub
rgoers commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1527909612 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [I] Improve logging context integration [logging-log4j-kotlin]

2024-03-18 Thread via GitHub
ppkarwasz commented on issue #71: URL: https://github.com/apache/logging-log4j-kotlin/issues/71#issuecomment-2003349991 I think we should discuss it in `dev@logging`. I started a [thread dedicated to this subject](https://lists.apache.org/thread/ossk8ckz4yy59z88l8hhbb3k87hbbk0r). -- Thi

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-18 Thread via GitHub
ppkarwasz commented on PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#issuecomment-2003350474 I think we should discuss it in `dev@logging`. I started a [thread dedicated to this subject](https://lists.apache.org/thread/ossk8ckz4yy59z88l8hhbb3k87hbbk0r). -- This is an

Re: [PR] 2214 - Add support for ScopedContext (logging-log4j2)

2024-03-18 Thread via GitHub
ppkarwasz commented on code in PR #2385: URL: https://github.com/apache/logging-log4j2/pull/2385#discussion_r1528224543 ## log4j-api/src/main/java/org/apache/logging/log4j/ScopedContext.java: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-18 Thread via GitHub
FreeAndNil commented on code in PR #128: URL: https://github.com/apache/logging-log4net/pull/128#discussion_r152831 ## Dockerfile: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE fil

Re: [PR] Bump org.apache.activemq:activemq-broker from 6.0.1 to 6.1.0 (logging-log4j2)

2024-03-18 Thread via GitHub
github-actions[bot] merged PR #2387: URL: https://github.com/apache/logging-log4j2/pull/2387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.awaitility:awaitility from 4.2.0 to 4.2.1 (logging-log4j2)

2024-03-18 Thread via GitHub
github-actions[bot] merged PR #2386: URL: https://github.com/apache/logging-log4j2/pull/2386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Enable building log4net with docker container #127 (logging-log4net)

2024-03-18 Thread via GitHub
FreeAndNil commented on PR #128: URL: https://github.com/apache/logging-log4net/pull/128#issuecomment-2003614301 @vy I've updated the dockerfile, the scripts and https://github.com/apache/logging-log4net/blob/Feature/127-docker-build/doc/BUILDING.md Please take a look. @fluffyn

  1   2   3   4   5   6   7   8   9   10   >