[GitHub] [groovy] daniellansun commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page

2023-01-25 Thread via GitHub
daniellansun commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404152201 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [groovy] paulk-asert merged pull request #1847: Minor improvements to 'Differences with Java' documentation page

2023-01-25 Thread via GitHub
paulk-asert merged PR #1847: URL: https://github.com/apache/groovy/pull/1847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page

2023-01-25 Thread via GitHub
paulk-asert commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404610210 Merged, thanks! I did some very minor additional tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [groovy] paulk-asert commented on pull request #1847: Minor improvements to 'Differences with Java' documentation page

2023-01-25 Thread via GitHub
paulk-asert commented on PR #1847: URL: https://github.com/apache/groovy/pull/1847#issuecomment-1404633200 Results can be seen here: https://docs.groovy-lang.org/docs/groovy-5.0.0-SNAPSHOT/html/documentation/#_differences_with_java -- This is an automated message from the Apache Gi

[GitHub] [groovy] paulk-asert opened a new pull request, #1848: GROOVY-10916: Provide min/max closure/comparator variants for primiti…

2023-01-26 Thread via GitHub
paulk-asert opened a new pull request, #1848: URL: https://github.com/apache/groovy/pull/1848 …ve arrays -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [groovy] paulk-asert opened a new pull request, #1849: GROOVY-7319: Add primitive array min() and max()

2023-01-26 Thread via GitHub
paulk-asert opened a new pull request, #1849: URL: https://github.com/apache/groovy/pull/1849 Inspiration from Yu Kobayashi (https://github.com/groovy/groovy-core/pull/616 from 2015) Currently IntBinaryOperator and IntUnaryOperator are used instead of introducing the proposed IntComparator

[GitHub] [groovy] paulk-asert commented on pull request #1849: GROOVY-7319: Add primitive array min() and max()

2023-01-26 Thread via GitHub
paulk-asert commented on PR #1849: URL: https://github.com/apache/groovy/pull/1849#issuecomment-1404989751 I'll tweak and reissue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [groovy] paulk-asert closed pull request #1849: GROOVY-7319: Add primitive array min() and max()

2023-01-26 Thread via GitHub
paulk-asert closed pull request #1849: GROOVY-7319: Add primitive array min() and max() URL: https://github.com/apache/groovy/pull/1849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [groovy] paulk-asert merged pull request #1850: Groovy7319

2023-01-28 Thread via GitHub
paulk-asert merged PR #1850: URL: https://github.com/apache/groovy/pull/1850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert merged pull request #1848: GROOVY-10916: Provide min/max closure/comparator variants for primiti…

2023-01-28 Thread via GitHub
paulk-asert merged PR #1848: URL: https://github.com/apache/groovy/pull/1848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] codecov-commenter commented on pull request #1851: GROOVY-10921: Optimised variants for AGM#each

2023-01-29 Thread via GitHub
codecov-commenter commented on PR #1851: URL: https://github.com/apache/groovy/pull/1851#issuecomment-1407652928 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1851?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] paulk-asert commented on pull request #1843: Add `asBoolean` extension methods to `File` and `Path`

2023-02-01 Thread via GitHub
paulk-asert commented on PR #1843: URL: https://github.com/apache/groovy/pull/1843#issuecomment-1411957968 This PR doesn't look bad, but just by way of feedback, the idea has been considered in the past and, while many thought such functionality might be useful, there was also debate about

[GitHub] [groovy] paulk-asert opened a new pull request, #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…

2023-02-05 Thread via GitHub
paulk-asert opened a new pull request, #1854: URL: https://github.com/apache/groovy/pull/1854 …e final fields in constructor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] paulk-asert commented on pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3

2023-02-05 Thread via GitHub
paulk-asert commented on PR #1852: URL: https://github.com/apache/groovy/pull/1852#issuecomment-1417583098 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] dependabot[bot] commented on pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3

2023-02-05 Thread via GitHub
dependabot[bot] commented on PR #1852: URL: https://github.com/apache/groovy/pull/1852#issuecomment-1417583900 Looks like com.gradle.enterprise is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [groovy] dependabot[bot] closed pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3

2023-02-05 Thread via GitHub
dependabot[bot] closed pull request #1852: Bump com.gradle.enterprise from 3.12.2 to 3.12.3 URL: https://github.com/apache/groovy/pull/1852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [groovy] codecov-commenter commented on pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…

2023-02-05 Thread via GitHub
codecov-commenter commented on PR #1854: URL: https://github.com/apache/groovy/pull/1854#issuecomment-1417595522 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1854?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1

2023-02-07 Thread via GitHub
dependabot[bot] opened a new pull request, #1855: URL: https://github.com/apache/groovy/pull/1855 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depe

[GitHub] [groovy] paulk-asert closed pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…

2023-02-07 Thread via GitHub
paulk-asert closed pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat… URL: https://github.com/apache/groovy/pull/1854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [groovy] paulk-asert commented on pull request #1854: GROOVY-10925: @TupleConstructor namedVariant breaks on setting privat…

2023-02-07 Thread via GitHub
paulk-asert commented on PR #1854: URL: https://github.com/apache/groovy/pull/1854#issuecomment-1422086123 I'll close this and work on a more comprehensive PR (or two) to improve consistency in several places. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [groovy] eric-milles commented on pull request #1696: Groovy 3: Gradle 7.2 for Java 16+

2023-02-11 Thread via GitHub
eric-milles commented on PR #1696: URL: https://github.com/apache/groovy/pull/1696#issuecomment-1426795508 Now I see that you can use one JDK to build and another to test using `-Ptarget.java.home=...` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] eric-milles closed pull request #1696: Groovy 3: Gradle 7.2 for Java 16+

2023-02-11 Thread via GitHub
eric-milles closed pull request #1696: Groovy 3: Gradle 7.2 for Java 16+ URL: https://github.com/apache/groovy/pull/1696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [groovy] codecov-commenter commented on pull request #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1

2023-02-12 Thread via GitHub
codecov-commenter commented on PR #1855: URL: https://github.com/apache/groovy/pull/1855#issuecomment-1427185491 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1855?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] daniellansun merged pull request #1855: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.0 to 4.31.1

2023-02-12 Thread via GitHub
daniellansun merged PR #1855: URL: https://github.com/apache/groovy/pull/1855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2

2023-02-15 Thread via GitHub
dependabot[bot] opened a new pull request, #1856: URL: https://github.com/apache/groovy/pull/1856 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/build-info) from 4.31.1 to 4.31.2. Changelog Sourced from https://github.com/jfrog/build-info/blob/mas

[GitHub] [groovy] codecov-commenter commented on pull request #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2

2023-02-15 Thread via GitHub
codecov-commenter commented on PR #1856: URL: https://github.com/apache/groovy/pull/1856#issuecomment-1432381637 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] daniellansun merged pull request #1856: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.1 to 4.31.2

2023-02-15 Thread via GitHub
daniellansun merged PR #1856: URL: https://github.com/apache/groovy/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3

2023-02-16 Thread via GitHub
dependabot[bot] opened a new pull request, #1857: URL: https://github.com/apache/groovy/pull/1857 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depe

[GitHub] [groovy] codecov-commenter commented on pull request #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3

2023-02-16 Thread via GitHub
codecov-commenter commented on PR #1857: URL: https://github.com/apache/groovy/pull/1857#issuecomment-1434007770 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] daniellansun merged pull request #1857: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.2 to 4.31.3

2023-02-16 Thread via GitHub
daniellansun merged PR #1857: URL: https://github.com/apache/groovy/pull/1857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] codecov-commenter commented on pull request #1858: Defer more task configurations

2023-02-18 Thread via GitHub
codecov-commenter commented on PR #1858: URL: https://github.com/apache/groovy/pull/1858#issuecomment-1435757057 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] Goooler opened a new pull request, #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
Goooler opened a new pull request, #1859: URL: https://github.com/apache/groovy/pull/1859 Ref: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/extension.html https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/name-without-ex

[GitHub] [groovy] codecov-commenter commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
codecov-commenter commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435771833 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] paulk-asert merged pull request #1858: Defer more task configurations

2023-02-18 Thread via GitHub
paulk-asert merged PR #1858: URL: https://github.com/apache/groovy/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
paulk-asert commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435914481 I like the idea behind these extensions. Can you create a corresponding Jira issue? Also, some minor points: - I think using `getExtension` rather than `extension` would b

[GitHub] [groovy] paulk-asert commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
paulk-asert commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915335 @royteeuwen Should we close this now given the alternative fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [groovy] royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment URL: https://github.com/apache/groovy/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [groovy] royteeuwen commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
royteeuwen commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915627 > @royteeuwen Should we close this now given the alternative fix? Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [groovy] Goooler commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
Goooler commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435915780 GROOVY-10942 1. Agreed. 2. I misjudged `Path.getFileName()` to return a non-null String, will fix it later. 3. Will add a `getBaseName()`. -- This is an automated message fr

[GitHub] [groovy] Goooler commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-19 Thread via GitHub
Goooler commented on code in PR #1859: URL: https://github.com/apache/groovy/pull/1859#discussion_r187417 ## subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java: ## @@ -101,6 +101,36 @@ public static long size(Path self) throws IOExceptio

[GitHub] [groovy] paulk-asert commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-19 Thread via GitHub
paulk-asert commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435923221 Can you elaborate what you mean by "too implicit"? (Just checking I understood) You mean "too obscure" whereas the longer one is "more self-describing"? I guess the shorter one relies

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-19 Thread via GitHub
paulk-asert commented on code in PR #1859: URL: https://github.com/apache/groovy/pull/1859#discussion_r190501 ## subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java: ## @@ -101,6 +101,36 @@ public static long size(Path self) throws IOExce

[GitHub] [groovy] Goooler commented on a diff in pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-19 Thread via GitHub
Goooler commented on code in PR #1859: URL: https://github.com/apache/groovy/pull/1859#discussion_r190774 ## subprojects/groovy-nio/src/main/java/org/apache/groovy/nio/extensions/NioExtensions.java: ## @@ -101,6 +101,36 @@ public static long size(Path self) throws IOExceptio

[GitHub] [groovy] Goooler commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-19 Thread via GitHub
Goooler commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435925146 Renamed to `getBaseName`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929

2023-02-19 Thread via GitHub
dependabot[bot] opened a new pull request, #1860: URL: https://github.com/apache/groovy/pull/1860 Bumps org.sonarqube from 3.5.0.2730 to 4.0.0.2929. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.sonarqube&

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6

2023-02-19 Thread via GitHub
dependabot[bot] opened a new pull request, #1861: URL: https://github.com/apache/groovy/pull/1861 Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 1.0.5 to 1.0.6. Release notes Sourced from https://github.com/gradle/wrapper-validat

[GitHub] [groovy] codecov-commenter commented on pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6

2023-02-19 Thread via GitHub
codecov-commenter commented on PR #1861: URL: https://github.com/apache/groovy/pull/1861#issuecomment-1436255968 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] codecov-commenter commented on pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929

2023-02-19 Thread via GitHub
codecov-commenter commented on PR #1860: URL: https://github.com/apache/groovy/pull/1860#issuecomment-1436259279 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] paulk-asert merged pull request #1859: GROOVY-10942 Add `extension` & `baseName` extension methods

2023-02-20 Thread via GitHub
paulk-asert merged PR #1859: URL: https://github.com/apache/groovy/pull/1859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4

2023-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1863: URL: https://github.com/apache/groovy/pull/1863 Bumps [org.jfrog.buildinfo:build-info-extractor-gradle](https://github.com/jfrog/build-info) from 4.31.3 to 4.31.4. Changelog Sourced from https://github.com/jfrog/build-info/blob/mas

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0

2023-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #1862: URL: https://github.com/apache/groovy/pull/1862 Bumps com.github.ben-manes.versions from 0.45.0 to 0.46.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gi

[GitHub] [groovy] codecov-commenter commented on pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4

2023-02-20 Thread via GitHub
codecov-commenter commented on PR #1863: URL: https://github.com/apache/groovy/pull/1863#issuecomment-1437773633 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1863?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] codecov-commenter commented on pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0

2023-02-20 Thread via GitHub
codecov-commenter commented on PR #1862: URL: https://github.com/apache/groovy/pull/1862#issuecomment-1437773892 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1862?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability

2023-02-22 Thread via GitHub
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1439931519 @daniellansun sorry for the delay. I've pushed up a commit that should fix the failing build. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] runningcode opened a new pull request, #1864: Add TestCommandLineArgumentProvider

2023-02-22 Thread via GitHub
runningcode opened a new pull request, #1864: URL: https://github.com/apache/groovy/pull/1864 This will allow test tasks to be cache-relocateable since they inputs to the test task will no longer consider the fully qualified paths of these directories. -- This is an automated message

[GitHub] [groovy] paulk-asert merged pull request #1864: Allow test task to be cache relocateable

2023-02-22 Thread via GitHub
paulk-asert merged PR #1864: URL: https://github.com/apache/groovy/pull/1864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] dependabot[bot] commented on pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929

2023-02-23 Thread via GitHub
dependabot[bot] commented on PR #1860: URL: https://github.com/apache/groovy/pull/1860#issuecomment-1442517285 Looks like org.sonarqube is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [groovy] dependabot[bot] closed pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929

2023-02-23 Thread via GitHub
dependabot[bot] closed pull request #1860: Bump org.sonarqube from 3.5.0.2730 to 4.0.0.2929 URL: https://github.com/apache/groovy/pull/1860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [groovy] dependabot[bot] commented on pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0

2023-02-23 Thread via GitHub
dependabot[bot] commented on PR #1862: URL: https://github.com/apache/groovy/pull/1862#issuecomment-1442517381 Looks like com.github.ben-manes.versions is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [groovy] dependabot[bot] closed pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0

2023-02-23 Thread via GitHub
dependabot[bot] closed pull request #1862: Bump com.github.ben-manes.versions from 0.45.0 to 0.46.0 URL: https://github.com/apache/groovy/pull/1862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [groovy] dependabot[bot] commented on pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4

2023-02-23 Thread via GitHub
dependabot[bot] commented on PR #1863: URL: https://github.com/apache/groovy/pull/1863#issuecomment-1442517961 Looks like org.jfrog.buildinfo:build-info-extractor-gradle is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [groovy] dependabot[bot] closed pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4

2023-02-23 Thread via GitHub
dependabot[bot] closed pull request #1863: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.3 to 4.31.4 URL: https://github.com/apache/groovy/pull/1863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [groovy] dependabot[bot] commented on pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6

2023-02-23 Thread via GitHub
dependabot[bot] commented on PR #1861: URL: https://github.com/apache/groovy/pull/1861#issuecomment-1442518936 Looks like gradle/wrapper-validation-action is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [groovy] dependabot[bot] closed pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6

2023-02-23 Thread via GitHub
dependabot[bot] closed pull request #1861: Bump gradle/wrapper-validation-action from 1.0.5 to 1.0.6 URL: https://github.com/apache/groovy/pull/1861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0

2023-02-23 Thread via GitHub
dependabot[bot] opened a new pull request, #1865: URL: https://github.com/apache/groovy/pull/1865 Bumps me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=me.c

[GitHub] [groovy] codecov-commenter commented on pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0

2023-02-23 Thread via GitHub
codecov-commenter commented on PR #1865: URL: https://github.com/apache/groovy/pull/1865#issuecomment-1442709405 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] paulk-asert commented on pull request #1843: Add `asBoolean` extension methods to `File` and `Path`

2023-02-23 Thread via GitHub
paulk-asert commented on PR #1843: URL: https://github.com/apache/groovy/pull/1843#issuecomment-1442779240 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [groovy] paulk-asert closed pull request #1843: Add `asBoolean` extension methods to `File` and `Path`

2023-02-23 Thread via GitHub
paulk-asert closed pull request #1843: Add `asBoolean` extension methods to `File` and `Path` URL: https://github.com/apache/groovy/pull/1843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [groovy] Goooler commented on pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0

2023-02-23 Thread via GitHub
Goooler commented on PR #1865: URL: https://github.com/apache/groovy/pull/1865#issuecomment-1442785367 This version fixed the compatibility with Gradle 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [groovy] daniellansun merged pull request #1865: Bump me.champeau.jmh:jmh-gradle-plugin from 0.6.8 to 0.7.0

2023-02-24 Thread via GitHub
daniellansun merged PR #1865: URL: https://github.com/apache/groovy/pull/1865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] paulk-asert commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-02-27 Thread via GitHub
paulk-asert commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1447527890 This covers just multi-assignment so far. Also, it leaves the underscore as a dynamic variable for dynamic Groovy. While not recommended, if you do happen to use the underscore (in a m

[GitHub] [groovy] codecov-commenter commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-02-27 Thread via GitHub
codecov-commenter commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1447538195 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability

2023-02-28 Thread via GitHub
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1448111647 @daniellansun looks like the build is green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [groovy] Goooler commented on a diff in pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-03-01 Thread via GitHub
Goooler commented on code in PR #1867: URL: https://github.com/apache/groovy/pull/1867#discussion_r1122002346 ## src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java: ## @@ -3906,13 +3906,17 @@ private void validateParameterList(final List parameterList) { for

[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability

2023-03-02 Thread via GitHub
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1451891850 @paulk-asert could you take a look at this? The build is green :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [groovy] daniellansun merged pull request #1837: Add source dependency on task to fix task cacheability

2023-03-02 Thread via GitHub
daniellansun merged PR #1837: URL: https://github.com/apache/groovy/pull/1837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun commented on pull request #1837: Add source dependency on task to fix task cacheability

2023-03-02 Thread via GitHub
daniellansun commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1451911225 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] sonatype-lift[bot] commented on pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-03-02 Thread via GitHub
sonatype-lift[bot] commented on PR #1867: URL: https://github.com/apache/groovy/pull/1867#issuecomment-1452138594 ## 🛠 Lift Auto-fix Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to

[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1867: GROOVY-10943: Consider additional use of _ as a placeholder

2023-03-02 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1867: URL: https://github.com/apache/groovy/pull/1867#discussion_r1123362375 ## src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java: ## @@ -3906,13 +3906,17 @@ private void validateParameterList(final List parameterList) {

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4

2023-03-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1869: URL: https://github.com/apache/groovy/pull/1869 Bumps com.gradle.enterprise from 3.12.3 to 3.12.4. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.ent

[GitHub] [groovy] dependabot[bot] opened a new pull request, #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5

2023-03-02 Thread via GitHub
dependabot[bot] opened a new pull request, #1870: URL: https://github.com/apache/groovy/pull/1870 Bumps org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depe

[GitHub] [groovy] codecov-commenter commented on pull request #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4

2023-03-02 Thread via GitHub
codecov-commenter commented on PR #1869: URL: https://github.com/apache/groovy/pull/1869#issuecomment-1452867536 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1869?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] codecov-commenter commented on pull request #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5

2023-03-02 Thread via GitHub
codecov-commenter commented on PR #1870: URL: https://github.com/apache/groovy/pull/1870#issuecomment-1452868824 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1870?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] daniellansun merged pull request #1869: Bump com.gradle.enterprise from 3.12.3 to 3.12.4

2023-03-02 Thread via GitHub
daniellansun merged PR #1869: URL: https://github.com/apache/groovy/pull/1869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun merged pull request #1870: Bump org.jfrog.buildinfo:build-info-extractor-gradle from 4.31.4 to 4.31.5

2023-03-02 Thread via GitHub
daniellansun merged PR #1870: URL: https://github.com/apache/groovy/pull/1870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] paulk-asert merged pull request #1866: GROOVY-10953: Extend multi-assignment type checking to Range expressions

2023-03-02 Thread via GitHub
paulk-asert merged PR #1866: URL: https://github.com/apache/groovy/pull/1866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] codecov-commenter commented on pull request #1871: GROOVY-10958: Confusing error message from GroovyScriptEngine

2023-03-02 Thread via GitHub
codecov-commenter commented on PR #1871: URL: https://github.com/apache/groovy/pull/1871#issuecomment-145299 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1871?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [groovy] paulk-asert merged pull request #1871: GROOVY-10958: Confusing error message from GroovyScriptEngine

2023-03-05 Thread via GitHub
paulk-asert merged PR #1871: URL: https://github.com/apache/groovy/pull/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 6.0.2 to 6.0.4 [groovy]

2023-12-17 Thread via GitHub
dependabot[bot] opened a new pull request, #2013: URL: https://github.com/apache/groovy/pull/2013 Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 6.0.2 to 6.0.4. Release notes Sourced from https://github.com/spotbugs

[PR] Bump actions/upload-artifact from 3 to 4 [groovy]

2023-12-17 Thread via GitHub
dependabot[bot] opened a new pull request, #2014: URL: https://github.com/apache/groovy/pull/2014 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. Release notes Sourced from https://github.com/actions/upload-artifact/releases";>actions/upload

Re: [PR] Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 6.0.2 to 6.0.4 [groovy]

2023-12-17 Thread via GitHub
Goooler merged PR #2013: URL: https://github.com/apache/groovy/pull/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

Re: [PR] Bump actions/upload-artifact from 3 to 4 [groovy]

2023-12-17 Thread via GitHub
Goooler merged PR #2014: URL: https://github.com/apache/groovy/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groov

[PR] GROOVY-11253: Identity variants for DGM#countBy [groovy]

2023-12-18 Thread via GitHub
paulk-asert opened a new pull request, #2016: URL: https://github.com/apache/groovy/pull/2016 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] GROOVY-11252: StringGroovyMethods should have a getCodePoints method [groovy]

2023-12-18 Thread via GitHub
paulk-asert merged PR #2015: URL: https://github.com/apache/groovy/pull/2015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] GROOVY-11253: Identity variants for DGM#countBy [groovy]

2023-12-18 Thread via GitHub
paulk-asert merged PR #2016: URL: https://github.com/apache/groovy/pull/2016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[PR] Partial cleanup of ReflectionCache [groovy]

2023-12-20 Thread via GitHub
blackdrag opened a new pull request, #2018: URL: https://github.com/apache/groovy/pull/2018 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Partial cleanup of ReflectionCache [groovy]

2023-12-20 Thread via GitHub
daniellansun commented on PR #2018: URL: https://github.com/apache/groovy/pull/2018#issuecomment-1865295756 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] make use of Runtime.version().feature() [groovy]

2023-12-21 Thread via GitHub
blackdrag opened a new pull request, #2019: URL: https://github.com/apache/groovy/pull/2019 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] make use of Runtime.version().feature() [groovy]

2023-12-21 Thread via GitHub
daniellansun commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-1866587431 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] make use of Runtime.version().feature() [groovy]

2023-12-21 Thread via GitHub
eric-milles commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-188230 Can you just quickly explain the different return values between old `VMPlugin.getJavaVersion()` and `Runtime.version().feature()`? Do we want to make capture of non-`IOException

  1   2   3   4   5   6   7   8   9   10   >