ectory
Cannot remove namespace file "/run/netns/vm-2": No such file or directory
Redirect it to /dev/null like other commands in the cleanup function
to reduce confusion.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/test_vxlan_under_vrf.sh | 2 +-
1 file changed, 1 insertion(+
ectory
Cannot remove namespace file "/run/netns/vm-2": No such file or directory
Redirect it to /dev/null like other commands in the cleanup function
to reduce confusion.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/test_vxlan_under_vrf.sh | 2 +-
1 file changed, 1 insertion(+
On Tue, Nov 10, 2020 at 2:09 AM Jakub Kicinski wrote:
>
> On Mon, 9 Nov 2020 11:42:33 +0800 Po-Hsu Lin wrote:
> > On Sun, Nov 8, 2020 at 7:02 AM Jakub Kicinski wrote:
> > >
> > > On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote:
> > > > This te
This test uses return code 2 as a hard-coded skipped state, let's use
the kselftest framework skip code variable $ksft_skip instead to make
it more readable and easier to maintain.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 64 ++-
test will be marked as PASSED
if nothing goes wrong and not all the tests were skipped.
Po-Hsu Lin (2):
selftests: pmtu.sh: use $ksft_skip for skipped return code
selftests: pmtu.sh: improve the test result processing
tools/testing/selftests/net/pmtu.sh | 79
either passed or skipped, the overall
result will be PASS
* If any of them has failed with return code 1 or anything bad
happened (e.g. return code 127 for command not found), the
overall result will be FAIL
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 15
when the next test calls check_xfrm().
With this fix, the final return value will be 1. Make it easier for
testers to spot this failure.
Fixes: 39aa6928d462d0 ("xfrm: policy: fix netlink/pf_key policy lookups")
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/xfrm_policy.sh
-Hsu Lin
---
tools/testing/selftests/net/udpgro.sh | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tools/testing/selftests/net/udpgro.sh
b/tools/testing/selftests/net/udpgro.sh
index ac2a30b..f8a19f5 100755
--- a/tools/testing/selftests/net/udpgro.sh
+++ b
On Sat, Oct 17, 2020 at 7:32 AM Jakub Kicinski wrote:
>
> On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote:
> > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> > needs the fou module to work. Otherwise it will fail with:
> >
> > $ ip netns
U into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 5 +
2 files changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/confi
either passed or skipped, the overall
result will be PASS
* If any of them has failed, the overall result will be FAIL
* Treat other return codes (e.g. 127 for command not found) as FAIL
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 19 ++-
1 file
test will be marked as PASSED
if nothing goes wrong and not all the tests were skipped.
Po-Hsu Lin (2):
selftests: pmtu.sh: use $ksft_skip for skipped return code
selftests: pmtu.sh: improve the test result processing
tools/testing/selftests/net/pmtu.sh | 83
This test uses return code 2 as a hard-coded skipped state, let's use
the kselftest framework skip code variable $ksft_skip instead to make
it more readable and easier to maintain.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/pmtu.sh | 64 ++-
On Sun, Nov 8, 2020 at 7:02 AM Jakub Kicinski wrote:
>
> On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote:
> > This test will treat all non-zero return codes as failures, it will
> > make the pmtu.sh test script being marked as FAILED when some
> > sub-test got skip
s/ns1": File exists
It might affect the outcome of other tests as well.
Move the netns cleanup code into an exit trap so that we can ensure
these namespace files will be removed after the test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/xfrm_policy.sh | 7 +--
1 file
U into the config file as well.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 6 ++
2 files changed, 7 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools/testing/selftests/net/config
index 3b42c06
On Sat, Aug 15, 2020 at 7:43 AM David Miller wrote:
>
> From: Po-Hsu Lin
> Date: Thu, 13 Aug 2020 12:44:22 +0800
>
> > diff --git a/tools/testing/selftests/net/config
> > b/tools/testing/selftests/net/config
> > index 3b42c06b..96d2763 100644
> > ---
On Tue, Sep 8, 2020 at 4:12 AM Jakub Kicinski wrote:
>
> On Mon, 7 Sep 2020 11:50:10 +0800 Po-Hsu Lin wrote:
> > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> > needs the fou module to work. Otherwise it will fail with:
> >
> > $ ip netns
Hello,
Is there any update on this patch?
Thanks!
PHLin
On Fri, Sep 18, 2020 at 6:39 PM Po-Hsu Lin wrote:
>
> Hello folks,
>
> any thoughts on this patch?
> It can make the test pass and reduce the failure numbers in
> kselftests, it will be great to have this applied.
On Mon, Oct 12, 2020 at 11:28 PM Jakub Kicinski wrote:
>
> On Mon, 12 Oct 2020 13:56:15 +0800 Po-Hsu Lin wrote:
> > Is there any update on this patch?
>
> You received feedback. Don't remove modules after tests, something else
> could be using them.
Hello Jakub,
I have
U into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 5 +
2 files changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/confi
assed.
2. The test result from two sub-tests in kci_test_encap() were not
being processed, thus they will not affect the final test result
of this test.
Po-Hsu Lin (2):
selftests: rtnetlink: correct the final return value for the test
selftests: rtnetlink: make kci_test_encap()
: bridge setup
PASS: ipv6 addrlabel
PASS: set ifalias 5b193daf-0a08-46d7-af2c-e7aadd422ded for test-dummy0
PASS: vrf
PASS: vxlan
FAIL: can't add fou port , skipping test
PASS: macsec
PASS: bridge fdb get
PASS: neigh get
$ echo $?
0
Signed-off-by: Po-Hs
ake "ret" become a local variable for all sub-tests.
Also, check the sub-test results in kci_test_rtnl() and return the
final result for this test.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/rtnetlink.sh | 65 +---
1 file changed, 43 ins
Hello folks,
any thoughts on this patch?
It can make the test pass and reduce the failure numbers in
kselftests, it will be great to have this applied.
Thanks
PHLin
On Tue, Sep 8, 2020 at 2:57 PM Po-Hsu Lin wrote:
>
> On Tue, Sep 8, 2020 at 4:12 AM Jakub Kicinski wrote:
> >
&g
Before changing this it's a bit confusing to read test output:
raw csum_off with bad offset (fails)
./psock_snd: write: Invalid argument
Change "fails" in the test case description to "expected to fail", so
that the test output can be more understandable.
Hello David,
do you need more information for this V2 patch?
Thank you
PHLin
On Mon, Aug 17, 2020 at 10:53 AM Po-Hsu Lin wrote:
>
> The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> needs the fou module to work. Otherwise it will fail with:
>
> $ ip netn
U into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 6 ++
2 files changed, 7 insertions(+)
diff --git a/tools/testing/selftests/net/confi
28 matches
Mail list logo
