Re: [lldb-dev] [cfe-dev] [RFC] Deprecate email code reviews in favor of Phabricator

2021-05-05 Thread Aaron Ballman via lldb-dev
On Tue, May 4, 2021 at 8:35 PM Mehdi AMINI wrote: > > > > On Tue, May 4, 2021 at 4:24 AM Aaron Ballman via cfe-dev > wrote: >> >> On Mon, May 3, 2021 at 1:24 PM Krzysztof Parzyszek via cfe-dev >> wrote: >> > >> > Statement: >> > >> > Our current code review policy states[1]: >> > >> > “Code rev

[lldb-dev] [Bug 50233] New: Merge 3a62d4fde88544125ce9ceff990db108ee91148a into 12.0.1

2021-05-05 Thread via lldb-dev
https://bugs.llvm.org/show_bug.cgi?id=50233 Bug ID: 50233 Summary: Merge 3a62d4fde88544125ce9ceff990db108ee91148a into 12.0.1 Product: lldb Version: 12.0 Hardware: All OS: All Status: NEW

Re: [lldb-dev] small Editline wrapper cleanup req for feedback

2021-05-05 Thread Neal Sidhwaney via lldb-dev
Sounds great. It’ll be useful to combine the function to describe EditLine commands, help text, and their callbacks with the logic to register keyboard commands for them, as well, so I’ll do both. However, I couldn’t make the member function pointer a function argument, because then the lamb