Re: [Lldb-commits] New llvm build server account request

2015-10-20 Thread Ying Chen via lldb-commits
Hello Kamil, Galina, If you would like to build LLDB with cmake and ninja, I suggest to consider the following two factory functions. Depends on what you described, I feel the first one works better for you. 1. getLLDBUbuntuCMakeBuildFactory If you only run local lldb tests, this is the factory t

Re: [Lldb-commits] New llvm build server account request

2015-10-20 Thread Ying Chen via lldb-commits
Please check again. Please note that this file needs to be included in your PATH. The rest of the scripts don't have to. Sample of test configuration file could be found here. https://android.googlesource.com/platform/external/lldb-utils/+/lldb-master-dev/buildbotScripts/testCfg/ On Tue, Oct 20, 2

Re: [Lldb-commits] New llvm build server account request

2015-10-20 Thread Ying Chen via lldb-commits
On Tue, Oct 20, 2015 at 4:46 PM, Kamil Rytarowski wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > It just appeared there. > > I took your updateScripts.sh, moved it to my $PATH. Is it everything? Please also put the test_cfg.json to this location, /home/motus/build/build/. A dumm

Re: [Lldb-commits] New llvm build server account request

2015-10-20 Thread Ying Chen via lldb-commits
Submitted the change, http://reviews.llvm.org/rL250871 The problem you mentioned has been resolved. But clang is missing from your system. You need to make sure the system is able to build and test lldb. Follow this http://lldb.llvm.org/build.html#BuildingLldbOnLinux. On Tue, Oct 20, 2015 at 5:4

[Lldb-commits] [lldb] r252980 - Revert "Another little stepping optimization: if any of the source step commands are running through a range "

2015-11-12 Thread Ying Chen via lldb-commits
Author: chying Date: Thu Nov 12 18:31:21 2015 New Revision: 252980 URL: http://llvm.org/viewvc/llvm-project?rev=252980&view=rev Log: Revert "Another little stepping optimization: if any of the source step commands are running through a range " - Revert because this commit introduce several failu

Re: [Lldb-commits] [lldb] r252963 - Another little stepping optimization: if any of the source step commands are running through a range

2015-11-12 Thread Ying Chen via lldb-commits
I reverted this patch for now. Please resubmit if you have a fix. Thanks, Ying On Thu, Nov 12, 2015 at 4:36 PM, Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > If you can debug a failing case, and do whatever step operation got you to > the wrong place, then run up to that st

[Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-13 Thread Ying Chen via lldb-commits
chying created this revision. chying added a reviewer: jingham. chying added a subscriber: lldb-commits. - expectedFailureAll takes single compiler name rather than compiler list because it also takes version which only apply to single compiler - Don't try to access self.debug_info if debug_info

Re: [Lldb-commits] [lldb] r253106 - Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll to reverse

2015-11-13 Thread Ying Chen via lldb-commits
Hello Jim, It seems this patch breaks the tests that are decorated by expectedFailureAll. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8441 I had a patch to fix it, could you help to review? http://reviews.llvm.org/D14673 Thanks, Ying On Fri, Nov 13, 2015 at 4:20 PM,

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-13 Thread Ying Chen via lldb-commits
chying added a comment. In http://reviews.llvm.org/D14673#289408, @zturner wrote: > I guess this is ok. I don't like raising the `None` check outside the > function, but I don't see another way that isn't more convoluted. > > However, I think you still need to fix the grouping of the parenthese

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-16 Thread Ying Chen via lldb-commits
chying added a comment. The compiler None check is because inside of check_list_or_lambda function, it checks for "value in list_or_lamda", which will throw exception if value is None I agree that the code will be cleaner if debug_info is initialized to None. Will try to upload another patch soon

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-16 Thread Ying Chen via lldb-commits
chying updated this revision to Diff 40347. chying added a comment. Recommit r253106 - Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ... Initialize self.debug_info in Base::setUp() Check for None before calling "value in list" http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-16 Thread Ying Chen via lldb-commits
chying added a comment. In http://reviews.llvm.org/D14673#290556, @zturner wrote: > Ahh, sorry. I litearlly just committed a change to the same function. You > may have to do a merge, sorry about that. Ahh, I see, will merge again. http://reviews.llvm.org/D14673

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-16 Thread Ying Chen via lldb-commits
chying updated this revision to Diff 40353. chying added a comment. Rebase on the latest commit. http://reviews.llvm.org/D14673 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoins/TestConsecutiveBreakpoints.py packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [lldb] r253272 - Re-Apply "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ..." with fix

2015-11-16 Thread Ying Chen via lldb-commits
Author: chying Date: Mon Nov 16 17:41:02 2015 New Revision: 253272 URL: http://llvm.org/viewvc/llvm-project?rev=253272&view=rev Log: Re-Apply "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ..." with fix Summary: - Re-Commit r253106 - Initialize self.deb

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

2015-11-16 Thread Ying Chen via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253272: Re-Apply "Add a "not_in()" function you can apply to the list type arguments… (authored by chying). Changed prior to commit: http://reviews.llvm.org/D14673?vs=40353&id=40357#toc Repository: r

Re: [Lldb-commits] New llvm build server account request

2015-11-17 Thread Ying Chen via lldb-commits
Done. Please let me know if it works for you. Thanks, Ying On Tue, Nov 17, 2015 at 3:34 AM, Kamil Rytarowski wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hello Ying, > > Regarding the NetBSD buildbot for LLDB one NetBSD we need a tweak. > > Please test for the existence (only

[Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-17 Thread Ying Chen via lldb-commits
chying created this revision. chying added a reviewer: ovyalov. chying added a subscriber: lldb-commits. http://reviews.llvm.org/D14765 Files: packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Index: packages/Python/lldbsuite/te

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-17 Thread Ying Chen via lldb-commits
chying updated this revision to Diff 40469. chying added a comment. Herald added subscribers: srhines, danalbert, tberghammer. Address comments. http://reviews.llvm.org/D14765 Files: packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testca

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-17 Thread Ying Chen via lldb-commits
chying marked 2 inline comments as done. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:69 @@ -66,1 +68,3 @@ +scheme, host = re.match(url_pattern, lldb.platform_url).groups() +if lldb.remote_platform_name == 'remote-andr

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-18 Thread Ying Chen via lldb-commits
chying marked an inline comment as done. chying added a comment. http://reviews.llvm.org/D14765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253488 - Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-18 Thread Ying Chen via lldb-commits
Author: chying Date: Wed Nov 18 13:03:20 2015 New Revision: 253488 URL: http://llvm.org/viewvc/llvm-project?rev=253488&view=rev Log: Support unix-abstract-connect scheme as platform url in lldb testsuite Reviewers: ovyalov Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org

Re: [Lldb-commits] [PATCH] D14765: Support unix-abstract-connect scheme as platform url in lldb testsuite

2015-11-18 Thread Ying Chen via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253488: Support unix-abstract-connect scheme as platform url in lldb testsuite (authored by chying). Changed prior to commit: http://reviews.llvm.org/D14765?vs=40469&id=40535#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D21159: [zorg] Add a step to run unit tests to the scripted LLDB builder

2016-06-08 Thread Ying Chen via lldb-commits
chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. thanks for making the changes, look good. http://reviews.llvm.org/D21159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

Re: [Lldb-commits] [PATCH] D22097: [zorg] Remove flunkOnFailure=False from the scripted LLDB builder

2016-07-07 Thread Ying Chen via lldb-commits
chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D22097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

2016-08-30 Thread Ying Chen via lldb-commits
chying added a comment. Could you also set haltOnFailure=False, so that build continues if this step fails? https://reviews.llvm.org/D24062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

Re: [Lldb-commits] [PATCH] D24062: Removed warnOnFailure flag for the step for running NDK update script.

2016-08-30 Thread Ying Chen via lldb-commits
chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. looks good. https://reviews.llvm.org/D24062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] r257228 - Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc

2016-01-08 Thread Ying Chen via lldb-commits
Author: chying Date: Fri Jan 8 17:10:56 2016 New Revision: 257228 URL: http://llvm.org/viewvc/llvm-project?rev=257228&view=rev Log: Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc - fix buildbot breakage after r257186 - move declaration outside

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Ying Chen via lldb-commits
Hello Enrico, The new test has been failing on Ubuntu buildbot. But it's passing on some offline Ubuntu machines, I don't understand what caused the difference. Could you please help to take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299 Thanks, Ying On We

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Ying Chen via lldb-commits
Please see attached log file. Thanks, Ying On Wed, Jan 13, 2016 at 5:39 PM, Enrico Granata wrote: > From the buildbot log it’s quite hard to tell what could be going on > > Is there any chance you guys could run the test by hand with the “-t -v” > flags to the dotest.py driver and attach the ou

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

2016-03-02 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. Seems this patch breaks OSX build. I guess the new files were not added to xcode project file. Could you please take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/8892/steps/ninja%20build%20local/logs/stdio ht

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

2016-03-02 Thread Ying Chen via lldb-commits
chying added a comment. Yes, it is fixed now. Thank you! http://reviews.llvm.org/D17363 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm

2016-03-25 Thread Ying Chen via lldb-commits
chying created this revision. chying added reviewers: chaoren, zturner. chying added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer, rengolin, aemerson. xfail TestCallUserAnonTypedef.test for -mthumb, TestReturnValue.test_with_python for hard fp, TestLldbGdbServer.s

Re: [Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm

2016-03-25 Thread Ying Chen via lldb-commits
chying added a comment. In http://reviews.llvm.org/D18481#383718, @zturner wrote: > Couldn't we have a way to say in the Makefile "never use these flags", then > the test suite could check the environment and remove them if they are > present. This woudl allow the test to run. > > architecture

Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

2016-04-06 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. TestRegisters.py and TestDebugBreak.py are broken after this change. Could you take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13090 Repository: rL LLVM http://reviews.llvm.org/D18819 _

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

2015-08-11 Thread Ying Chen via lldb-commits
chying added a comment. Could you add the related bug to comments or argument? llvm.org/pr24302 http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

2015-08-11 Thread Ying Chen via lldb-commits
chying accepted this revision. chying added a comment. This revision is now accepted and ready to land. Sorry I mean in the code, like, @expectedFailureDarwin('llvm.org/pr24302') Otherwise, looks good to me. http://reviews.llvm.org/D11962 ___ lldb-c

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

2015-08-20 Thread Ying Chen via lldb-commits
chying added a subscriber: chying. chying added a comment. It seems a bunch of darwin->android_arm tests are broken after this patch. Could you take a look? Here is the first build after this patch. http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4977/steps/test7/logs/stdio Rep

[Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

2015-09-02 Thread Ying Chen via lldb-commits
chying created this revision. chying added a reviewer: tberghammer. chying added a subscriber: lldb-commits. - send empty line for multiple commands to complete http://reviews.llvm.org/D12584 Files: test/functionalities/completion/TestCompletion.py Index: test/functionalities/completion/TestC

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

2015-09-03 Thread Ying Chen via lldb-commits
chying added a comment. Based on experiment I had, we need to send empty lines the same times as the number of lines in original commands on Darwin. But on Linux, only one empty line is needed for multiple lines of commands. It seems on Darwin, lldb doesn't automatically execute commands separate

Re: [Lldb-commits] [PATCH] D12584: Fix TestCompletion.py failure on Darwin after r246639

2015-09-03 Thread Ying Chen via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246791: Fix TestCompletion.py failure on Darwin after r246639 (authored by chying). Changed prior to commit: http://reviews.llvm.org/D12584?vs=33898&id=33960#toc Repository: rL LLVM http://reviews.l

[Lldb-commits] [lldb] r246791 - Fix TestCompletion.py failure on Darwin after r246639

2015-09-03 Thread Ying Chen via lldb-commits
Author: chying Date: Thu Sep 3 13:29:27 2015 New Revision: 246791 URL: http://llvm.org/viewvc/llvm-project?rev=246791&view=rev Log: Fix TestCompletion.py failure on Darwin after r246639 Summary: - send empty line for multiple commands to complete Reviewers: tberghammer Subscribers: lldb-commit

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

2015-09-03 Thread Ying Chen via lldb-commits
chying added a comment. Sorry, coming late to this thread. This change works ok on linux and darwin systems. But it has some problem on Windows, the main code has to be protected with the following statement on Windows, if __name__ == '__main__': Otherwise it creates subprocesses recursively.

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

2015-09-03 Thread Ying Chen via lldb-commits
chying added a comment. Sorry, coming late to this thread. This change works ok on linux and darwin systems. But it has some problem on Windows, the main code has to be protected with the following statement on Windows, if __name__ == '__main__': Otherwise it creates subprocesses recursively.

Re: [Lldb-commits] [PATCH] D12612: Fix dotest on Windows after multiprocessing refactor

2015-09-03 Thread Ying Chen via lldb-commits
chying accepted this revision. chying added a comment. This patch works for me. Although I thought we could put less code in main() function. Then have if __name__ == "__main__": main() But that will require some more work to refactor the code. Probably that could wait for Todd's clean up.

[Lldb-commits] [PATCH] D13114: Check existence of SIGHUP before using it

2015-09-23 Thread Ying Chen via lldb-commits
chying created this revision. chying added a reviewer: tfiala. chying added a subscriber: lldb-commits. -SIGHUP doesn't exist on Windows http://reviews.llvm.org/D13114 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.

[Lldb-commits] [lldb] r248434 - Check existence of SIGHUP before using it

2015-09-23 Thread Ying Chen via lldb-commits
Author: chying Date: Wed Sep 23 16:53:18 2015 New Revision: 248434 URL: http://llvm.org/viewvc/llvm-project?rev=248434&view=rev Log: Check existence of SIGHUP before using it Summary: -SIGHUP doesn't exist on Windows Reviewers: tfiala Subscribers: lldb-commits Differential Revision: http://rev

Re: [Lldb-commits] [PATCH] D13114: Check existence of SIGHUP before using it

2015-09-23 Thread Ying Chen via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248434: Check existence of SIGHUP before using it (authored by chying). Changed prior to commit: http://reviews.llvm.org/D13114?vs=35543&id=35557#toc Repository: rL LLVM http://reviews.llvm.org/D131