https://github.com/svs-quic created
https://github.com/llvm/llvm-project/pull/83234
We weren't checking to see if the partial_path was empty before adding
completions and this led to crashes when the class object and a variable both
start with the same substring.
Fixes [#81536](https://githu
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From 87c442c0911fd4671da1ae03c5d967857fd363d1 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH] [LLDB] Fix crash when using tab completion on class varia
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH] [LLDB] Fix crash when using tab completion on class varia
https://github.com/svs-quic ready_for_review
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/2] [LLDB] Fix crash when using tab completion on class
https://github.com/svs-quic updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/3] [LLDB] Fix crash when using tab completion on class
svs-quic wrote:
> Change itself is fine. But could you please add a test in
> `lldb/test/API/functionalities/completion/TestCompletion.py`? Specifically in
> `do_test_variable_completion`
Done
https://github.com/llvm/llvm-project/pull/83234
___
lldb
svs-quic wrote:
> lgtm thanks!
Thanks. I dont think I have commit access . Would you be able to merge this for
me?
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -60,10 +60,12 @@ def test_dwim_print(self):
def do_test_variable_completion(self, command):
self.complete_from_to(f"{command} fo", f"{command} fooo")
-self.complete_from_to(f"{command} fooo.", f"{command} fooo.")
+self.complete_from_to(f"{command
https://github.com/svs-quic created
https://github.com/llvm/llvm-project/pull/83406
Missed adding a . in the test check
>From 1e686b765ba8a456f6a53731a2de2f28d41f6a9c Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Thu, 29 Feb 2024 16:20:35 +0530
Subject: [PATCH] [LLDB] Fix test fail
https://github.com/svs-quic ready_for_review
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
svs-quic wrote:
@Michael137 could you please help merge this one as well.
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
svs-quic wrote:
Please add a test for this.
https://github.com/llvm/llvm-project/pull/124475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
svs-quic wrote:
> A test for this would be finding the tests that check basic reads of
> registers, and adding reads with the new names. There should be one for core
> files and one for live processes.
Basic support was added in
https://github.com/llvm/llvm-project/commit/847de9c332775d1841fe
14 matches
Mail list logo
