[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

jkorous added a comment. Hi Greg, this looks interesting! I got curious about your patch since I am dealing with another protocol from the same "family" - LSP. Comment at: tools/lldb-vscode/lldb-vscode.cpp:1424 +//---

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

jkorous added inline comments. Comment at: llvm/include/llvm/Support/FileCollector.h:40 + +protected: + void AddFileImpl(StringRef src_path); TLDR: private? I'm just wondering if we could make the class safer or the correct use more obvious for classes derivin

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:143 /// - llvm::StringMap SeenDirEntries; + llvm::StringMap, llvm::BumpPtrAllocator> + SeenDirEntries; Maybe we could replace this with some type that has hard-to-use-incorre

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:240 +auto File = SourceMgr.getFileManager().getFile(FilePath); +if (!File) + return SourceLocation(); Previously we'd hit the assert in `translateFile()` called fro

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

jkorous accepted this revision. jkorous marked an inline comment as done. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for all the work here! Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(temp