[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2016-12-29 Thread Aetf via Phabricator via lldb-commits
aetf added a comment. Hi, sorry for the long delay. It has been a busy semester. Added unit tests are - `MiGdbSetShowTestCase.test_lldbmi_gdb_set_disassembly_flavor` for disassembly flavor settings. Note this one doesn't pass currently due to https://llvm.org/bugs/show_bug.cgi?id=31485 - `MiEn

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2016-12-29 Thread Aetf via Phabricator via lldb-commits
aetf updated this revision to Diff 82654. aetf marked an inline comment as done. aetf added a comment. Add unit tests, add error checking for SetInternalVariable https://reviews.llvm.org/D24711 Files: packages/Python/lldbsuite/test/tools/lldb-mi/TestMiEnvironmentCd.py packages/Python/lldbsu

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2017-01-04 Thread Aetf via Phabricator via lldb-commits
aetf marked 2 inline comments as done. aetf added a comment. What do I do next? Could you help me commit and push this? since I don't have write access. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22 { -int a = 10; +int a = 10; + ---