It's really frustrating how the email discussion doesn't always make it to
Phabricator.
The Windowsy thing to do is what Zach said: Check the directory that
contains the .dmp for the .pdb. It's the first place the VS debugger looks
when opening a minidump. It's less sensitive to the user's envi
I believe the PDB is searched for in the EXE directory before the symbol
search path is used. At least, that's what it used to do, back when I used
VS debugger for post-mortem debugging. It was the only sane way to ensure
it would find the right version of the PDB if you didn't have a local
symbo
> But here, we're talking about a situation where there is no EXE, only a
minidump. If there is a minidump and no EXE then neither WinDbg nor VS
will search the minidump folder for the PDB.
For the record, the experiments do not bear this out. VS will indeed
search in the minidump folder for th
Can you post your patch to https://reviews.llvm.org/ ?
On Thu, May 31, 2018 at 10:36 AM, Leonard Mosescu via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> If anyone's working on this I'd suggest adding a test case for the "split
> code" case as well (where even a single function is split i
I have some concerns about this change.
1. strlcpy is not a C++ standard function, so it's not available for
non-POSIX targets. As far as I can tell, this is the first use of strlcpy
in LLVM.
2. In some of the changed calls, the buffer size argument still has a -1,
which is redundant with what
Author: amccarth
Date: Mon Feb 12 11:19:04 2018
New Revision: 324925
URL: http://llvm.org/viewvc/llvm-project?rev=324925&view=rev
Log:
Remove dead code for handling DWARF pubnames
Summary:
LLDB doesn't use this code, the code has no tests, and the code does suspicious
things like hashing pointers
Author: amccarth
Date: Wed Feb 14 15:16:36 2018
New Revision: 325188
URL: http://llvm.org/viewvc/llvm-project?rev=325188&view=rev
Log:
Supply missing break in case statement.
Summary:
All the tests pass without hitting the situation mentioned in the FIXME, so,
per Aaron Smith's suggestion, this c
Author: amccarth
Date: Wed Feb 21 10:08:23 2018
New Revision: 325704
URL: http://llvm.org/viewvc/llvm-project?rev=325704&view=rev
Log:
Fix TestBreakpointInGlobalConstructor for Windows
Summary:
This test was failing on Windows because it expected the breakpoint in the
dynamic library to be resolv
Author: amccarth
Date: Thu Feb 22 14:47:14 2018
New Revision: 325835
URL: http://llvm.org/viewvc/llvm-project?rev=325835&view=rev
Log:
Fix TestSBData.py on Windows
Ensure that the test data is an array of bytes rather than a string that gets
encoded differently between Python 2 and Python 3.
Dif
Author: amccarth
Date: Thu Feb 22 14:47:47 2018
New Revision: 325836
URL: http://llvm.org/viewvc/llvm-project?rev=325836&view=rev
Log:
Fix TestMoveNearest on Windows
The header file for the DLL tried to declare inline functions and a local
function as dllexport which broke the compile and link.
Author: amccarth
Date: Mon Feb 26 07:53:31 2018
New Revision: 326095
URL: http://llvm.org/viewvc/llvm-project?rev=326095&view=rev
Log:
Fix tabs/spaces indentation problem in TestUnicodeSymbols.py
Differential Revision: https://reviews.llvm.org/D43705
Modified:
lldb/trunk/packages/Python/lld
Author: amccarth
Date: Mon Feb 26 13:22:39 2018
New Revision: 326130
URL: http://llvm.org/viewvc/llvm-project?rev=326130&view=rev
Log:
Partial fix for TestConflictingSymbol.py on Windows
Without this fix, the test ERRORs because the link of the inferior fails. This
patch adds the LLDB_TEST_API ma
Author: amccarth
Date: Thu Apr 19 11:31:57 2018
New Revision: 330354
URL: http://llvm.org/viewvc/llvm-project?rev=330354&view=rev
Log:
Fix narrowing warning by appending `f` to literal constant.
Modified:
lldb/trunk/unittests/Core/ScalarTest.cpp
Modified: lldb/trunk/unittests/Core/ScalarTest
Actually, Windows does have `struct timespec`. It's defined in ``
and ``.
https://msdn.microsoft.com/en-us/library/mt633792.aspx
I suspect somebody had suppressed it for some reason.
On Tue, Apr 18, 2017 at 2:47 PM, Chris Bieneman via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author
Author: amccarth
Date: Thu Sep 7 11:29:48 2017
New Revision: 312735
URL: http://llvm.org/viewvc/llvm-project?rev=312735&view=rev
Log:
Fix for bug 34510 - Minidump target does not resolve new symbols correctly
Even though the content of the minidump does not change in a debugging session,
frames
Author: amccarth
Date: Wed Sep 13 15:57:11 2017
New Revision: 313210
URL: http://llvm.org/viewvc/llvm-project?rev=313210&view=rev
Log:
Fix for bug 34532 - A few rough corners related to post-mortem debugging
(core/minidump)
The main change is to avoid setting the process state as running when
de
Author: amccarth
Date: Mon Sep 18 08:59:44 2017
New Revision: 313540
URL: http://llvm.org/viewvc/llvm-project?rev=313540&view=rev
Log:
Revert "Fix for bug 34532 - A few rough corners related to post-mortem
debugging (core/minidump)"
Broke Windows and FreeBSD (at least).
This reverts commit 628c
Author: amccarth
Date: Tue Sep 19 11:07:33 2017
New Revision: 313655
URL: http://llvm.org/viewvc/llvm-project?rev=313655&view=rev
Log:
Re-land r313210 - Fix for bug 34532 - A few rough corners related to
post-mortem debugging (core/minidump)
The main change is to avoid setting the process state
Author: amccarth
Date: Wed Sep 20 11:09:39 2017
New Revision: 313785
URL: http://llvm.org/viewvc/llvm-project?rev=313785&view=rev
Log:
Fix the SIGINT handlers
1. Fix a data race (g_interrupt_sent flag usage was not thread safe, signals
can be handled on arbitrary threads)
2. exit() is not signal
Author: amccarth
Date: Thu Sep 21 12:36:52 2017
New Revision: 313904
URL: http://llvm.org/viewvc/llvm-project?rev=313904&view=rev
Log:
[LLDB] Implement interactive command interruption
The core of this change is the new CommandInterpreter::m_command_state, which
models the state transitions for i
Author: amccarth
Date: Thu Feb 28 11:14:02 2019
New Revision: 355121
URL: http://llvm.org/viewvc/llvm-project?rev=355121&view=rev
Log:
Improve process launch comments for Windows
The existing comment about over-allocating the command line was incorrect. The
contents of the command line may be ch
Author: amccarth
Date: Tue Mar 12 10:40:51 2019
New Revision: 355943
URL: http://llvm.org/viewvc/llvm-project?rev=355943&view=rev
Log:
Correcting some comments in PdbIndex.cpp [NFC]
ICF can cause multiple symbols to start at the same virtual address.
I plan to handle this shortly, but I wanted to
Author: amccarth
Date: Wed Apr 3 12:49:14 2019
New Revision: 357626
URL: http://llvm.org/viewvc/llvm-project?rev=357626&view=rev
Log:
Fix and simplify PrepareCommandsForSourcing
Spotted some problems in the Driver's PrepareCommandsForSourcing while
helping a colleague track another problem.
1.
amccarth added inline comments.
Comment at: source/Host/common/FileSpec.cpp:550
+ (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != "."))
+return *this;
Do we have to worry about an unnecessary single dot in the directory, like
`/foo/
amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:340
std::map reg_values;
+ reg_values[lldb_rax_x86_64] = 0x;
It seems a shame
amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added a comment.
This revision is now accepted and ready to land.
I like that this keeps the WoW64 detection and support. That's a very
Windows-specific thing, and I was concerned that doing generic minidump parsing
amccarth added a comment.
I started testing the new plugin on Windows yesterday, and it doesn't work (all
the tests fail). I'm planning to debug today, and, once I get it working, I'd
be happy to switch it over.
https://reviews.llvm.org/D26393
__
amccarth added a comment.
In https://reviews.llvm.org/D26393#589421, @labath wrote:
> In https://reviews.llvm.org/D26393#589363, @amccarth wrote:
>
> > I started testing the new plugin on Windows yesterday, and it doesn't work
> > (all the tests fail). I'm planning to debug today, and, once I g
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Problem was at my end. This patch works fine for me now.
I'm planning to do some more minidump work, so I'd be happy to take over with
eliminating the old Windows-specific implementation.
Author: amccarth
Date: Thu Nov 10 11:21:22 2016
New Revision: 286476
URL: http://llvm.org/viewvc/llvm-project?rev=286476&view=rev
Log:
Un-XFail test on Windows. Has been in "unexpected success" mode for a while.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTy
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
On Windows, where we use Python 3 for testing, we have to be more explicit
about converting between binary and string representations. I believe this
should still work for Python 2, bu
Author: amccarth
Date: Mon Nov 14 17:53:45 2016
New Revision: 286909
URL: http://llvm.org/viewvc/llvm-project?rev=286909&view=rev
Log:
Fix TestMiniDumpNew.py test for Python 2/3 issue
On Windows, where we use Python 3 for testing, we have to be more explicit
about converting between binary and s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286909: Fix TestMiniDumpNew.py test for Python 2/3 issue
(authored by amccarth).
Changed prior to commit:
https://reviews.llvm.org/D26643?vs=77900&id=77907#toc
Repository:
rL LLVM
https://reviews.ll
amccarth created this revision.
amccarth added reviewers: labath, zturner.
amccarth added a subscriber: lldb-commits.
Herald added subscribers: modocache, mgorny.
With the cross-platform minidump plugin working, the Windows-specific one is no
longer needed. This eliminates the unnecessary code.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287113: Remove Windows-specific minidump plugin (authored by
amccarth).
Changed prior to commit:
https://reviews.llvm.org/D26697?vs=78065&id=78194#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: amccarth
Date: Wed Nov 16 10:04:14 2016
New Revision: 287113
URL: http://llvm.org/viewvc/llvm-project?rev=287113&view=rev
Log:
Remove Windows-specific minidump plugin
With the cross-platform minidump plugin working, the Windows-specific one is no
longer needed. This eliminates the unnece
Author: amccarth
Date: Fri Jan 27 15:42:28 2017
New Revision: 293336
URL: http://llvm.org/viewvc/llvm-project?rev=293336&view=rev
Log:
NFC: Improve comments in SymbolFilePDB.cpp
Mostly this just fixes bad wrapping caused by the reformat, with tiny
changes sprinkled here and there.
Modified:
Author: amccarth
Date: Wed Sep 30 09:57:21 2015
New Revision: 248909
URL: http://llvm.org/viewvc/llvm-project?rev=248909&view=rev
Log:
Removed an unused member variable. Affects Windows only.
Modified:
lldb/trunk/source/Plugins/Process/Windows/Live/TargetThreadWindows.h
Modified: lldb/trunk
amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.
This fixes the Windows build break introduced by r248934. I'm not sure why it
didn't break other platforms.
http://reviews.llvm.org/D13312
Files:
include/lldb/Symbol/ClangAST
amccarth abandoned this revision.
amccarth added a comment.
Same fix was already committed to fix the Linux build.
http://reviews.llvm.org/D13312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
Python uses stdio from the C runtime for file descriptors and pipes. On
Windows, by default, the CRT has a limit of 512 open file descriptors.
https://msdn.microsoft.com/en-us/library/
amccarth added a comment.
Hold off. I just got a failure even at only 32 subprocesses.
http://reviews.llvm.org/D13555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a subscriber: amccarth.
amccarth added a comment.
There was an lldb-dev thread from February 9, where it seemed to be agreed
that lldb code should be more like llvm code, in particular with the spaces
between the function names and the opening parens. I've been omitting the
spaces
There was an lldb-dev thread from February 9, where it seemed to be agreed
that lldb code should be more like llvm code, in particular with the spaces
between the function names and the opening parens. I've been omitting the
spaces in new code since then.
On Fri, Oct 9, 2015 at 10:14 AM, Greg Cla
amccarth updated this revision to Diff 36993.
amccarth added a comment.
Using the multiprocessing-pool mode seems more reliable than capping
num_threads. I'm doing it only when the number of threads is high because of
the loss of Ctrl+C support.
http://reviews.llvm.org/D13555
Files:
test/d
Author: amccarth
Date: Mon Oct 12 09:46:57 2015
New Revision: 250044
URL: http://llvm.org/viewvc/llvm-project?rev=250044&view=rev
Log:
Switch threading mode for tests on Windows when there are lots of cores.
This prevents a "too many files" error.
Differential Revision: http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250044: Switch threading mode for tests on Windows when
there are lots of cores. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D13555?vs=36993&id=37111#toc
Repository:
rL L
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
How Swig handles varargs functions changed between 3.0.2 and 3.0.5, which
causes one of our tests to fail. This fix adds a Swig directive to the
SBError::SetErrorSTringWithFormat metho
With Swig 3.0.2, non-string arguments work. I'm not sure why. Even the
Swig 1.x documentation says that what we're doing shouldn't work.
On Mon, Oct 12, 2015 at 3:49 PM, Zachary Turner wrote:
> zturner added a comment.
>
> Prior to this patch, what was the behavior of using
> SetErrorStringWit
amccarth added a subscriber: amccarth.
amccarth added a comment.
With Swig 3.0.2, non-string arguments work. I'm not sure why. Even the
Swig 1.x documentation says that what we're doing shouldn't work.
http://reviews.llvm.org/D13679
___
lldb-commi
amccarth added a comment.
Adding Greg Clayton for advice on how to proceed.
Swig documentation talked about the peril of varargs methods:
http://www.swig.org/Doc3.0/Varargs.html#Varargs
The fact that it appears to work with 3.0.2 seems to be a bug in 3.0.2.
My proposal is in this patch. An a
Author: amccarth
Date: Tue Oct 13 12:54:15 2015
New Revision: 250188
URL: http://llvm.org/viewvc/llvm-project?rev=250188&view=rev
Log:
Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.
DifferentialRevision: http://reviews.llvm.org/D13679
Modified:
lldb/trunk/scripts/interfac
Author: amccarth
Date: Tue Oct 13 12:55:58 2015
New Revision: 250189
URL: http://llvm.org/viewvc/llvm-project?rev=250189&view=rev
Log:
Xfail a watchpoint test on Windows, until Windows implements watchpoints.
Modified:
lldb/trunk/test/functionalities/watchpoint/watchpoint_on_vectors/TestValu
amccarth created this revision.
amccarth added a reviewer: tfiala.
amccarth added a subscriber: lldb-commits.
This solves problems in tearDown of individual test cases, which were
especially noticeable on Windows.
When a test throws an exception, the exception retains references to the
function
Author: amccarth
Date: Thu Oct 15 17:39:55 2015
New Revision: 250467
URL: http://llvm.org/viewvc/llvm-project?rev=250467&view=rev
Log:
Factor the execution of the test method into a separate function to ensure that
any exceptions that are thrown go out of scope and no longer hold references to
S
amccarth added a comment.
Nice catch on the comment.
Repository:
rL LLVM
http://reviews.llvm.org/D13788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL250467: Factor the execution of the test method into a
separate function to ensure… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D1
Author: amccarth
Date: Fri Oct 16 18:19:22 2015
New Revision: 250576
URL: http://llvm.org/viewvc/llvm-project?rev=250576&view=rev
Log:
Skip hanging watchpoint test on Windows (rather than just xfailing).
Modified:
lldb/trunk/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
I'm not sure why this was timing out when running on my machine, since it took
only 45 second for the tests to fail and the timeout seem to be set to 240
seconds.
Simply skipping these
Author: amccarth
Date: Wed Oct 21 09:42:10 2015
New Revision: 250899
URL: http://llvm.org/viewvc/llvm-project?rev=250899&view=rev
Log:
Skip TestMultithreaded on Windows.
Differential Revision: http://reviews.llvm.org/D13923
Modified:
lldb/trunk/test/api/multithreaded/TestMultithreaded.py
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250899: Skip TestMultithreaded on Windows. (authored by
amccarth).
Changed prior to commit:
http://reviews.llvm.org/D13923?vs=37953&id=38012#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13923
F
Author: amccarth
Date: Mon Oct 26 16:38:41 2015
New Revision: 251354
URL: http://llvm.org/viewvc/llvm-project?rev=251354&view=rev
Log:
Revert "Clang module compilation options need to be per-platform."
This reverts commit r251340.
Breaks the Windows build because Windows doesn't have getuid. Th
FYI: This broke the Windows build (which doesn't have getuid), and the fix
wasn't immediately obvious, so I reverted the change.
Adrian.
On Mon, Oct 26, 2015 at 1:33 PM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Mon Oct 26 15:33:24 2015
> New
amccarth added inline comments.
Comment at: source/Plugins/Process/Windows/Common/ProcessWindowsForward.h:20
@@ +19,1 @@
+#endif
\ No newline at end of file
zturner wrote:
> Put a newline here
Actually, this file is obsolete, so I'm deleting it instead. It was i
Author: amccarth
Date: Wed Oct 28 14:59:18 2015
New Revision: 251549
URL: http://llvm.org/viewvc/llvm-project?rev=251549&view=rev
Log:
Add check for __main__ in dotest.py to ensure problems with multiprocessing on
some Windows machines.
Modified:
lldb/trunk/test/dotest.py
Modified: lldb/tru
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Another case where sleep-and-retry avoids file access errors on Windows.
http://reviews.llvm.org/D14163
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbs
amccarth added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1823-1830
@@ -1822,3 +1822,10 @@
-os.rename(src, dst)
+try:
+os.rename(src, dst)
+except:
+
Author: amccarth
Date: Wed Nov 4 17:47:55 2015
New Revision: 252100
URL: http://llvm.org/viewvc/llvm-project?rev=252100&view=rev
Log:
Fix x64 build on Windows, which was broken by my refactor from last week.
No build bots build x64 on Windows yet, but this was spotted by another
developer who e
amccarth added a comment.
I'm not seeing this problem now that many of the other changes are in. I'm
going to hold off until I see it again.
http://reviews.llvm.org/D14163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
The old RegisterContextWinMiniDump stub is replaced with x86 and x64
implementations that derive from the common windows register contexts.
ProcessWindowsMiniDump grabs the WinAPI CONTE
amccarth marked 3 inline comments as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40
@@ +39,3 @@
+thread = self.process.GetThreadAtIndex(0)
+# The crash is in main, so there should be one frame on the stack.
Author: amccarth
Date: Thu Nov 12 15:16:15 2015
New Revision: 252950
URL: http://llvm.org/viewvc/llvm-project?rev=252950&view=rev
Log:
Implement RegisterContext for Mini Dumps.
Differential Revision: http://reviews.llvm.org/D14591
Added:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/x64
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL252950: Implement RegisterContext for Mini Dumps. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D14591?vs=39978&id=40082#toc
Reposi
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Enable the saving of a mini dump (on Windows) using the existing lldb save-core
command.
Also plumbs a new method into SBProcess, and adds a very basic test to make
sure it produces a
Author: amccarth
Date: Thu Nov 19 18:11:38 2015
New Revision: 253623
URL: http://llvm.org/viewvc/llvm-project?rev=253623&view=rev
Log:
Make skipIf support the not_in function.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/
amccarth marked 5 inline comments as done.
Comment at: include/lldb/API/SBProcess.h:344-346
@@ -343,1 +343,5 @@
+// Save the state of the process in a core file (or mini dump on Windows).
+lldb::SBError
+SaveCore(const char *file_name);
+
clayborg wr
amccarth updated this revision to Diff 40716.
amccarth marked an inline comment as done.
amccarth added a comment.
Addresses some of the comments.
http://reviews.llvm.org/D14793
Files:
include/lldb/API/SBProcess.h
include/lldb/API/SBTarget.h
packages/Python/lldbsuite/test/functionalities/
amccarth marked an inline comment as done.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:159
@@ +158,3 @@
+{
+return SaveMiniDump(process_sp, outfile, error);
+}
clayborg wrote:
> I would rather just have the code from SaveMiniDump inlined
he test TestVectorTypesFormatting, which is annotated with
>> @skipIf(compiler='gcc'), run when using GCC:
>>
>> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8661/steps/test5/logs/stdio
>>
>> On Thu, Nov 19, 2015 at 4:11 PM, Adrian
Author: amccarth
Date: Fri Nov 20 12:14:24 2015
New Revision: 253683
URL: http://llvm.org/viewvc/llvm-project?rev=253683&view=rev
Log:
Make skipIf support the not_in function (second attempt).
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Pytho
Author: amccarth
Date: Fri Nov 20 12:15:14 2015
New Revision: 253684
URL: http://llvm.org/viewvc/llvm-project?rev=253684&view=rev
Log:
FOO
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_save_core/
lldb/trunk/packages/Python/lldbsuite/test/functionalities/process
Author: amccarth
Date: Fri Nov 20 12:18:21 2015
New Revision: 253685
URL: http://llvm.org/viewvc/llvm-project?rev=253685&view=rev
Log:
Revert "FOO"
Accidentally commited before I was done.
This reverts commit 2ec2da4ee52780582d5e9c88b2e982a688fbdbe1.
Removed:
lldb/trunk/packages/Python/lld
Siva did include a link in a separate thread:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8688
Sorry about breaking this twice. I guess I'm going to have to get a Linux
box.
On Fri, Nov 20, 2015 at 1:14 PM, Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.or
amccarth marked an inline comment as not done.
amccarth added a comment.
The new files are renamed per clayborg's suggestion.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_save_core/TestProcessSaveCore.py:21
@@ +20,3 @@
+exe = os.path.join(os.getcwd
amccarth updated this revision to Diff 40835.
amccarth added a comment.
Renames the files per the suggestion and switches back to the @skipIfWindows
decorator on the tests (for now).
http://reviews.llvm.org/D14793
Files:
include/lldb/API/SBProcess.h
include/lldb/API/SBTarget.h
packages/P
Author: amccarth
Date: Fri Nov 20 17:09:11 2015
New Revision: 253734
URL: http://llvm.org/viewvc/llvm-project?rev=253734&view=rev
Log:
Enable saving of mini dumps with lldb process save-core.
Also adds SB API to save a core and tests that use it.
Differential Revision: http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253734: Enable saving of mini dumps with lldb process
save-core. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D14793?vs=40835&id=40837#toc
Repository:
rL LLVM
http://revi
Greg: Since this adds a new file and I don't have a Mac, can you update
the Xcode project?
On Fri, Nov 20, 2015 at 3:11 PM, Adrian McCarthy
wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL253734: Enable saving of mini dumps with lldb proce
amccarth added a subscriber: amccarth.
amccarth added a comment.
Nice detective work.
Comment at: include/lldb/Target/Process.h:1372
@@ +1371,3 @@
+/// @param[in] use_run_lock
+/// Whether the release the run lock after the stop.
+///
Did you mea
This revision seems to have created a hang on startup on Windows. LLDB now
hangs during global static initialization on this line:
const ConstString
RenderScriptRuntime::Element::FallbackStructName("struct");
Perhaps its an initialization order problem?
Adrian.
On Mon, Nov 30, 2015 at 2:29 AM,
amccarth created this revision.
amccarth added reviewers: EwanCrawford, zturner.
amccarth added a subscriber: lldb-commits.
A previous patch introduced a global static ConstString instance. On Windows,
this results in a hang because constructing the string pool appears to depend
on other global
amccarth added inline comments.
Comment at:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:185
@@ -184,3 +184,3 @@
-static const ConstString FallbackStructName; // Print this as the
type name of a struct Element
Author: amccarth
Date: Mon Nov 30 16:18:43 2015
New Revision: 254338
URL: http://llvm.org/viewvc/llvm-project?rev=254338&view=rev
Log:
Fix hang in global static initialization
Differential Revision: http://reviews.llvm.org/D15092
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254338: Fix hang in global static initialization (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D15092?vs=41433&id=41435#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Also tweaked process save-core to include the memory info list so that we can
see the regions in the list.
There are no commands or SBInterfaces yet that make it possible to test this
amccarth updated this revision to Diff 41828.
amccarth added a comment.
Ran clang-format and removed initialization of a local variable that was no
longer used.
Note that clang-format re-ordered the include because the change added one
include.
http://reviews.llvm.org/D15218
Files:
source/
amccarth marked 2 inline comments as done.
amccarth added a comment.
Addressed comments.
http://reviews.llvm.org/D15218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth updated this revision to Diff 41884.
amccarth added a comment.
Address comments.
Factored the decoding of the page protection bits to share that logic between
the live and mini dump debugging.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cp
amccarth updated this revision to Diff 41898.
amccarth added a comment.
After discussion with Zach, we concluded that his original logic for
IsPageReadable was better.
http://reviews.llvm.org/D15218
Files:
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp
source/Plugins/Process/Windows/
Author: amccarth
Date: Fri Dec 4 16:22:15 2015
New Revision: 254780
URL: http://llvm.org/viewvc/llvm-project?rev=254780&view=rev
Log:
Implement GetMemoryRegionInfo for mini dumps.
Differential Revision: http://reviews.llvm.org/D15218
Modified:
lldb/trunk/source/Plugins/ObjectFile/PECOFF/Win
1 - 100 of 339 matches
Mail list logo
