[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei created https://github.com/llvm/llvm-project/pull/171854 This patch introduces general summary provider for `std::string_view` and simial types. I tried to remove copy-paste between different stl implementations. I cannot check now how it works on Windows machine, b

[Lldb-commits] [lldb] 98aa840 - [lldb][Formatters] Simplify std::list libc++ formatter matching regex (#147709)

2025-12-11 Thread via lldb-commits
Author: Michael Buch Date: 2025-12-11T17:25:56Z New Revision: 98aa84075d3d2eeea4296d1e1a69c23db70edab2 URL: https://github.com/llvm/llvm-project/commit/98aa84075d3d2eeea4296d1e1a69c23db70edab2 DIFF: https://github.com/llvm/llvm-project/commit/98aa84075d3d2eeea4296d1e1a69c23db70edab2.diff LOG:

[Lldb-commits] [lldb] [lldb][Formatters] Simplify std::list libc++ formatter matching regex (PR #147709)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147709 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1b7f272 - [lldb][Module] Only log SDK search error once per debugger session (#171820)

2025-12-11 Thread via lldb-commits
Author: Michael Buch Date: 2025-12-11T17:25:45Z New Revision: 1b7f272906dee31d505ed74e0514d2c04c1b5f97 URL: https://github.com/llvm/llvm-project/commit/1b7f272906dee31d505ed74e0514d2c04c1b5f97 DIFF: https://github.com/llvm/llvm-project/commit/1b7f272906dee31d505ed74e0514d2c04c1b5f97.diff LOG:

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Sergei Druzhkov via lldb-commits
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/171854 >From ef8a0e118f394df64e14d4f399ce1246d5ab53f7 Mon Sep 17 00:00:00 2001 From: Druzhkov Sergei Date: Thu, 11 Dec 2025 18:19:30 +0300 Subject: [PATCH 1/3] [lldb] Add generic string view summary provider --- ...

[Lldb-commits] [lldb] [llvm] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/171507 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/171858 Split off from #171489. This only adds the lookup of the active type for a `std::variant` based on the head type (since PDB doesn't have template info). >From dc76f82f9b3356aac7299f1cb6e2ad77e59b53c9 Mon Sep 17

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 requested changes to this pull request. Thanks for the patch. I'm all in favour of de-duplicating the formatter code, but I'd prefer it if we kept the individual SummaryProvider's per STL. I.e., the code that extracts the data and size from the type should live in

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171854 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171854 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -119,8 +119,14 @@ bool formatters::MsvcStlVariantSummaryProvider( storage_type = storage_type.GetTypedefedType(); CompilerType active_type = storage_type.GetTypeTemplateArgument(1, true); - if (!active_type) -return false; + if (!active_type) { +// PDB: get

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM (module comment) https://github.com/llvm/llvm-project/pull/171858 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread via lldb-commits
@@ -0,0 +1,131 @@ +//===-- GenericStringView.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/171858 Unicorn! · GitHub body { background-color: #f1f1f1; margin: 0; font-family: "Helvetica Neue", Helvetica, Arial, sans-serif; } .container { margin: 50px au

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #171832)

2025-12-11 Thread Dmitry Vasilyev via lldb-commits
@@ -400,6 +400,22 @@ llvm::Error Terminal::SetHardwareFlowControl(bool enabled) { #endif // LLDB_ENABLE_TERMIOS } +bool Terminal::SupportsUnicode() { + static std::optional g_result; slydiman wrote: It seems you don't need g_result on Windows at all. Just m

[Lldb-commits] [lldb] [lldb][Formatters] Simplify std::list libc++ formatter matching regex (PR #147709)

2025-12-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/147709 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sergei Druzhkov (DrSergei) Changes This patch introduces general summary provider for `std::string_view` and simial types. I tried to remove copy-paste between different stl implementations. I cannot check now how it works on Windows machi

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Split off from #171489. This only adds the lookup of the active type for a `std::variant` based on the head type (since PDB doesn't have template info). --- Full diff: https://github.com/llvm/llvm-project/pull/1718

[Lldb-commits] [lldb] [llvm] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/171507 >From 417bf4882e9a6be920e6a728e5de1d62eedc9e38 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 8 Dec 2025 17:01:18 -0800 Subject: [PATCH 1/4] [lldb] Add WebAssembly platform This PR adds a plat

[Lldb-commits] [lldb] 7fdf800 - [LLDB] Run MSVC variant test with PDB (#171858)

2025-12-11 Thread via lldb-commits
Author: nerix Date: 2025-12-11T18:03:42+01:00 New Revision: 7fdf800a91a37dc915fec2cca2d8539ec5070d8a URL: https://github.com/llvm/llvm-project/commit/7fdf800a91a37dc915fec2cca2d8539ec5070d8a DIFF: https://github.com/llvm/llvm-project/commit/7fdf800a91a37dc915fec2cca2d8539ec5070d8a.diff LOG: [L

[Lldb-commits] [lldb] [LLDB] Run MSVC variant test with PDB (PR #171858)

2025-12-11 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/171858 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Change ObjectFile argument type (PR #171574)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/171574 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171733 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread David Spickett via lldb-commits
@@ -245,8 +245,10 @@ IOHandlerEditline::IOHandlerEditline( SetPrompt(prompt); #if LLDB_ENABLE_LIBEDIT - const bool use_editline = m_input_sp && m_output_sp && m_error_sp && -m_input_sp->GetIsRealTerminal(); + const bool use_editline = + m_i

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. I might have the details wrong but I see the overall idea. This LGTM as long as you add clarifying comments about what a file without a stream would actually represent. https://github.com/llvm/llvm-project/pull/171733 ___

[Lldb-commits] [lldb] [lldb] fix failing tests due to CI diagnostics rendering (PR #171685)

2025-12-11 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > Nothing changed > [lab.llvm.org/buildbot#/builders/197/builds/11757](https://lab.llvm.org/buildbot/#/builders/197/builds/11757) > > [lab.llvm.org/buildbot#/builders/211/builds/4494](https://lab.llvm.org/buildbot/#/builders/211/builds/4494) I reverted the changes. > Wi

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171507 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Pedantry on the settings text but otherwise LGTM. You may want to revise the existing release note for WASM debug. Perhaps adding to it "LLDB can also start a runtime for you...". https://github.com/llvm/llvm-project/pull/171507

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171507 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171507 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] Revert "[lldb] fix failing tests due to CI diagnostics rendering (PR #171791)

2025-12-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch reverts https://github.com/llvm/llvm-project/pull/171685 and https://github.com/llvm/llvm-project/pull/171491, which introduces bot failures. --- Full diff: https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] Revert "[lldb] fix failing tests due to CI diagnostics rendering (PR #171791)

2025-12-11 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit auto_merge_enabled https://github.com/llvm/llvm-project/pull/171791 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0b522d9 - Revert "[lldb] fix failing tests due to CI diagnostics rendering (#171791)

2025-12-11 Thread via lldb-commits
Author: Charles Zablit Date: 2025-12-11T10:16:01Z New Revision: 0b522d9e8e450a38fea1ac14b7ec67f682f43725 URL: https://github.com/llvm/llvm-project/commit/0b522d9e8e450a38fea1ac14b7ec67f682f43725 DIFF: https://github.com/llvm/llvm-project/commit/0b522d9e8e450a38fea1ac14b7ec67f682f43725.diff LOG

[Lldb-commits] [lldb] Revert "[lldb] fix failing tests due to CI diagnostics rendering (PR #171791)

2025-12-11 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/171791 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171797 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread David Spickett via lldb-commits
@@ -23,15 +23,15 @@ RUN:| FileCheck --check-prefix=64BIT %s 32BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.pdb 32BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.exe 32BIT: compiling foobar.c -> foo.exe-foobar.obj -32BIT: Command Line: {{.*}}\{{[Hh]ost[Xx](64|86)}}\{{(

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Confused as to where we expect to get ARM64 vs. arm64 but assuming it's just how Microsoft chose to name things, this LGTM. https://github.com/llvm/llvm-project/pull/171797 ___ lldb-commits

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread David Spickett via lldb-commits
@@ -51,12 +51,12 @@ RUN:| FileCheck --check-prefix=64BIT %s 64BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.pdb 64BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.exe 64BIT: compiling foobar.c -> foo.exe-foobar.obj -64BIT: Command Line: {{.*}}\{{[Hh]ost[Xx](64|86)}}\{{(

[Lldb-commits] [lldb] [lldb][test] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/171797 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Change ObjectFile argument type (PR #171574)

2025-12-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I didn't want to get too deep into details not directly related to this PR, > but the overall project is a mac specific one. Thanks for explaining and now you've explained, I feel justified in getting Jonas to review :) https://github.com/llvm/llvm-project/pull/171574 _

[Lldb-commits] [lldb] [lldb] fix failing tests due to CI diagnostics rendering (PR #171685)

2025-12-11 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I was able to pass the test `command-options.test` on Windows with the following regex ``` # CHECK1: {{^ *(\^|˄)(~|˜)}} # CHECK1: {{^ *.*error: unknown or ambiguous option}} ``` https://github.com/llvm/llvm-project/pull/171685 ___ lldb

[Lldb-commits] [lldb] 60b5d06 - [lldb][lldb-dap] Remove unused variable

2025-12-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-12-11T13:54:19Z New Revision: 60b5d06f7cb0a4de6417f6e6d05ed780e45d844d URL: https://github.com/llvm/llvm-project/commit/60b5d06f7cb0a4de6417f6e6d05ed780e45d844d DIFF: https://github.com/llvm/llvm-project/commit/60b5d06f7cb0a4de6417f6e6d05ed780e45d844d.diff LOG

[Lldb-commits] [lldb] 90c340a - [lldb[test] Fix compiler warning in AdbClientTest.cpp

2025-12-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-12-11T13:57:26Z New Revision: 90c340a64b1ce0fa2617994457b091e5ca4b URL: https://github.com/llvm/llvm-project/commit/90c340a64b1ce0fa2617994457b091e5ca4b DIFF: https://github.com/llvm/llvm-project/commit/90c340a64b1ce0fa2617994457b091e5ca4b.diff LOG

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 converted_to_draft https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/171820 >From fcbe4c42381cf6b895bfcf484af82f79d9f1d75f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 11 Dec 2025 12:42:10 + Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger se

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/171820 >From b31aa38353ed622285802623b26bbed7cbec2185 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 11 Dec 2025 12:42:10 + Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger se

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #171491)

2025-12-11 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: https://github.com/llvm/llvm-project/pull/171685#issuecomment-3642033568 https://github.com/llvm/llvm-project/pull/171491 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread Max Desiatov via lldb-commits
@@ -0,0 +1,19 @@ +include "../../../../include/lldb/Core/PropertiesBase.td" + +let Definition = "platformwasm" in { + def RuntimePath : Property<"runtime-path", "FileSpec">, +Global, +DefaultStringValue<"">, +Desc<"Path

[Lldb-commits] [lldb] b2dae2b - [lldb][test] Skip all of JSONTransportTest.cpp file on Windows

2025-12-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-12-11T14:04:51Z New Revision: b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b URL: https://github.com/llvm/llvm-project/commit/b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b DIFF: https://github.com/llvm/llvm-project/commit/b2dae2ba6ecaa2d424649fbd9dd6c4d3934b4f2b.diff LOG

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/171820 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Module] Only log SDK search error once per debugger session (PR #171820)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/171820 >From 8591030480b7f752e94ec289be0ba1fb306caa6f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 11 Dec 2025 12:42:10 + Subject: [PATCH] [lldb][Module] Only log SDK search error once per debugger se

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #171832)

2025-12-11 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/171832 This patch improves the way lldb checks if the terminal it's opened in (if any) supports Unicode or not. On POSIX systems, we check if `LANG` contains `UTF-8`. On Windows, we always return `true` since

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #171832)

2025-12-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This patch improves the way lldb checks if the terminal it's opened in (if any) supports Unicode or not. On POSIX systems, we check if `LANG` contains `UTF-8`. On Windows, we always return `true` si

[Lldb-commits] [lldb] [lldb] fix failing tests due to CI diagnostics rendering (PR #171685)

2025-12-11 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Thanks for looking into this! I was able to get all the tests to pass on Windows: https://github.com/llvm/llvm-project/pull/171832 I'm not sure about `lldb/test/Shell/Commands/command-expr-diagnostics.test` however, as it's XFAILed on Windows. I passes on macOS. The prev

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/171854 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/171854 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjusting the initialize/launch flow to better match the spec. (PR #171549)

2025-12-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/171549 >From 714a50cee306e1437ef38c08232700a164cdea55 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 9 Dec 2025 17:00:56 -0800 Subject: [PATCH 1/2] [lldb-dap] Adjusting the initialize/launch flow to better mat

[Lldb-commits] [lldb] [lldb-dap] Adjusting the initialize/launch flow to better match the spec. (PR #171549)

2025-12-11 Thread John Harrison via lldb-commits
@@ -21,16 +21,18 @@ using namespace lldb_dap::protocol; namespace lldb_dap { /// Launch request; value of command field is 'launch'. -Error LaunchRequestHandler::Run(const LaunchRequestArguments &arguments) const { +void LaunchRequestHandler::Run( +const LaunchRequestArgu

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Sergei Druzhkov via lldb-commits
@@ -0,0 +1,131 @@ +//===-- GenericStringView.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread Sergei Druzhkov via lldb-commits
DrSergei wrote: > Thanks for the patch. I'm all in favour of de-duplicating the formatter code, > but I'd prefer it if we kept the individual SummaryProvider's per STL. > > I.e., the code that extracts the data and size from the type should live in > the individual STL files. But the code that

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/171733 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/171733 >From cb83cdce863b25bf7eda68889cc772e1cfda8ad8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 10 Dec 2025 15:03:42 -0800 Subject: [PATCH 1/2] [lldb] Correct use_editline check in IOHandlerEditl

[Lldb-commits] [lldb] [lldb] Add generic string view summary provider (PR #171854)

2025-12-11 Thread via lldb-commits
@@ -0,0 +1,131 @@ +//===-- GenericStringView.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
@@ -245,8 +245,10 @@ IOHandlerEditline::IOHandlerEditline( SetPrompt(prompt); #if LLDB_ENABLE_LIBEDIT - const bool use_editline = m_input_sp && m_output_sp && m_error_sp && -m_input_sp->GetIsRealTerminal(); + const bool use_editline = + m_i

[Lldb-commits] [lldb] c814ac1 - [lldb] Correct use_editline check in IOHandlerEditline (#171733)

2025-12-11 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-12-11T17:24:04Z New Revision: c814ac1928b264a5bdeb98ec9035412fa37fb243 URL: https://github.com/llvm/llvm-project/commit/c814ac1928b264a5bdeb98ec9035412fa37fb243 DIFF: https://github.com/llvm/llvm-project/commit/c814ac1928b264a5bdeb98ec9035412fa37fb243.diff

[Lldb-commits] [lldb] [lldb] Correct use_editline check in IOHandlerEditline (PR #171733)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/171733 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Change ObjectFile argument type (PR #171574)

2025-12-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/171574 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8d59cca - [lldb] Add WebAssembly platform (#171507)

2025-12-11 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-12-11T11:12:26-08:00 New Revision: 8d59cca1ab9cf4e39e43bf695e415de9ccd41115 URL: https://github.com/llvm/llvm-project/commit/8d59cca1ab9cf4e39e43bf695e415de9ccd41115 DIFF: https://github.com/llvm/llvm-project/commit/8d59cca1ab9cf4e39e43bf695e415de9ccd41115.d

[Lldb-commits] [lldb] [llvm] [lldb] Add WebAssembly platform (PR #171507)

2025-12-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/171507 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix MS STL `variant` with non-trivial types and PDB (PR #171489)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -67,12 +67,18 @@ std::optional GetIndexValue(ValueObject &valobj) { ValueObjectSP GetNthStorage(ValueObject &outer, int64_t index) { // We need to find the std::_Variant_storage base class. - // -> std::_SMF_control (typedef to std::_Variant_base) - ValueObjectSP contai

[Lldb-commits] [lldb] [LLDB] Fix MS STL `variant` with non-trivial types and PDB (PR #171489)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -67,12 +67,18 @@ std::optional GetIndexValue(ValueObject &valobj) { ValueObjectSP GetNthStorage(ValueObject &outer, int64_t index) { // We need to find the std::_Variant_storage base class. - // -> std::_SMF_control (typedef to std::_Variant_base) - ValueObjectSP contai

[Lldb-commits] [lldb] [lldb][test] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread Omair Javaid via lldb-commits
@@ -23,15 +23,15 @@ RUN:| FileCheck --check-prefix=64BIT %s 32BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.pdb 32BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.exe 32BIT: compiling foobar.c -> foo.exe-foobar.obj -32BIT: Command Line: {{.*}}\{{[Hh]ost[Xx](64|86)}}\{{(

[Lldb-commits] [lldb] [lldb][test] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread Omair Javaid via lldb-commits
@@ -51,12 +51,12 @@ RUN:| FileCheck --check-prefix=64BIT %s 64BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.pdb 64BIT: Cleaning {{.*}}toolchain-msvc.test.tmp\foo.exe 64BIT: compiling foobar.c -> foo.exe-foobar.obj -64BIT: Command Line: {{.*}}\{{[Hh]ost[Xx](64|86)}}\{{(

[Lldb-commits] [lldb] c89d87a - [lldb][test] Fix toolchain-msvc.test for native ARM64 MSVC environment (#171797)

2025-12-11 Thread via lldb-commits
Author: Omair Javaid Date: 2025-12-11T16:15:10+05:00 New Revision: c89d87a512ed5b4bfeedb5d7ae22ae8cba1b123a URL: https://github.com/llvm/llvm-project/commit/c89d87a512ed5b4bfeedb5d7ae22ae8cba1b123a DIFF: https://github.com/llvm/llvm-project/commit/c89d87a512ed5b4bfeedb5d7ae22ae8cba1b123a.diff

[Lldb-commits] [lldb] [lldb] improve the heuristics for checking if a terminal supports Unicode (PR #171832)

2025-12-11 Thread via lldb-commits
github-actions[bot] wrote: # :penguin: Linux x64 Test Results * 33219 tests passed * 506 tests skipped * 3 tests failed ## Failed Tests (click on a test name to see its output) ### lldb-shell lldb-shell.Commands/command-dwim-print.test ``` Exit Code: 1 Command Output (stdout): -- # RUN: at

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -40,12 +40,21 @@ enum class UnaryOpKind { /// The type casts allowed by DIL. enum class CastKind { + eArithmetic, ///< Casting to a scalar. eEnumeration, ///< Casting from a scalar to an enumeration type eNullptr, ///< Casting to a nullptr type + ePointer,

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -43,7 +65,8 @@ static CompilerType GetBasicType(lldb::TypeSystemSP type_system, } static lldb::ValueObjectSP -ArrayToPointerConversion(ValueObject &valobj, ExecutionContextScope &ctx) { +ArrayToPointerConversion(ValueObject &valobj, ExecutionContextScope &ctx, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -99,8 +122,9 @@ Interpreter::UnaryConversion(lldb::ValueObjectSP valobj, uint32_t location) { } } + llvm::StringRef name = "result"; if (in_type.IsArrayType()) -valobj = ArrayToPointerConversion(*valobj, *m_exe_ctx_scope); +valobj = ArrayToPointerConversi

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
@@ -740,16 +764,182 @@ Interpreter::Visit(const BooleanLiteralNode *node) { return ValueObject::CreateValueObjectFromBool(m_target, value, "result"); } +llvm::Expected +Interpreter::VerifyCastType(lldb::ValueObjectSP operand, CompilerType op_type, +

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Looks better, left some more comments https://github.com/llvm/llvm-project/pull/170332 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type casting to DIL, part 2 or 3 (PR #170332)

2025-12-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/170332 ___ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid created https://github.com/llvm/llvm-project/pull/171797 This patch fixes toolchain-msvc.test on Windows ARM64 hosts running under native ARM64 environment via vcvarsarm64.bat. Our lab buildbot recently switched from using cross vcvarsamd64_arm64.bat environment to

[Lldb-commits] [lldb] Fix toolchain-msvc.test for native ARM64 MSVC environment (PR #171797)

2025-12-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Omair Javaid (omjavaid) Changes This patch fixes toolchain-msvc.test on Windows ARM64 hosts running under native ARM64 environment via vcvarsarm64.bat. Our lab buildbot recently switched from using cross vcvarsamd64_arm64.bat environment t

  1   2   >