https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/142875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
Looks good. Just a couple of tweaks.
https://github.com/llvm/llvm-project/pull/142875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,3 +57,50 @@ def test_platform_process_connect(self):
self.assertEqual(frame.GetFunction().GetName(), "main")
self.assertEqual(frame.FindVariable("argc").GetValueAsSigned(), 2)
process.Continue()
+
+@skipIfRemote
+@expectedFailureAll(hostos
https://github.com/DavidSpickett commented:
I resolved all the comments that are done, I have a few left open that need
addressing.
Then decide with @bulbazord what you do or don't do with the finer details.
Everything else is looking good.
https://github.com/llvm/llvm-project/pull/138031
___
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
The failure is unrelated, ignore it.
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
> The failure is unrelated, ignore it.
Thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/142932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/142984.diff
1 Files Affected:
- (modified) lldb/include/lldb/Core/Telemetry.h (+11)
``diff
diff --git a/lldb/include/lldb/Core/Telemetry.h
ashgti wrote:
I see some of this has been reverted.
Should I undo the revert and add that to my other PR or should I rebase my
changes on HEAD and we can take another stab at updating the stepInTargets
request?
https://github.com/llvm/llvm-project/pull/142831
_
da-viper wrote:
I think the latter is better.
That way we don't have to revert both of them
https://github.com/llvm/llvm-project/pull/142831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142831
>From 0824e3c626ad5e8c2ce37f2fdfcf0c2fa47b7b1d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 4 Jun 2025 11:03:37 -0700
Subject: [PATCH 1/5] [lldb-dap] Creating a 'capabilities' event helper.
This adds
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142831
>From 0824e3c626ad5e8c2ce37f2fdfcf0c2fa47b7b1d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 4 Jun 2025 11:03:37 -0700
Subject: [PATCH 1/6] [lldb-dap] Creating a 'capabilities' event helper.
This adds
ashgti wrote:
Done, rebased on main.
https://github.com/llvm/llvm-project/pull/142831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
@jimingham is the updated description for `max-children-count` sufficient?
https://github.com/llvm/llvm-project/pull/140938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142831
>From 0824e3c626ad5e8c2ce37f2fdfcf0c2fa47b7b1d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 4 Jun 2025 11:03:37 -0700
Subject: [PATCH 1/4] [lldb-dap] Creating a 'capabilities' event helper.
This adds
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142510
>From 3a16210ba7643608dd0bd6a1ff4a76b4e72c74e3 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 2 Jun 2025 18:07:52 -0700
Subject: [PATCH 1/6] [lldb-dap] Migrating 'threads' request to structured
types.
https://github.com/DavidSpickett approved this pull request.
LGTM with the UNSUPPORTED changed to apply to any system.
https://github.com/llvm/llvm-project/pull/138032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
DavidSpickett wrote:
Do that for the rest of the tests as well.
https://github.com/llvm/llvm-project/pull/138032
__
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
DavidSpickett wrote:
`UNSUPPORTED: *` should disable it everywhere.
Saves someone on FreeBSD getting an unpleasant surprise.
https://githu
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/138032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,504 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,504 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,502 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,107 @@
+//===-- RPCCommon.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ayush Sahay (ayushsahay1837)
Changes
The standard RISC-V ISA sets aside a 12-bit encoding space for up to 4,096
CSRs. However, many of these may remain unutilized and needn't be saved in core
dump images. To address this, we've come up wit
@@ -999,9 +999,13 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
case llvm::Triple::OpenBSD:
return parseOpenBSDNotes(*notes_or_error);
default:
-return llvm::make_error(
-"Don't know how to parse core file. Unsupported OS.",
-ll
https://github.com/DavidSpickett commented:
I'll leave the proper review to the RISC-V interested parties, just some high
level points:
* The csrs that have names, are all the ones here from the RISC-V standard? Do
they include any names allocated for custom extensions or do you plan to do
any
DavidSpickett wrote:
@AlexeyMerzlyakov worked on RV64 core file support in the past, might have some
comments.
https://github.com/llvm/llvm-project/pull/142932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/142952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/142952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Two things. First off, adding the -I 0 option did indeed fix a failure.
In the first run you cited, three tests failed:
FAIL: LLDB (/b/s/w/ir/x/w/cipd/clang/bin/clang-x86_64) ::
test_stop_hooks_scripted_auto_continue
(TestStopHookScripted.TestStopHooks.test_stop_hooks_script
ashgti wrote:
Working on an update rebased on HEAD.
https://github.com/llvm/llvm-project/pull/142831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/142952
>From 7d2a6406b8069b6c23611860d937db1275fb33ef Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 5 Jun 2025 12:02:17 +0100
Subject: [PATCH] [lldb][Format] Add [inlined] marker to names of inlined
frames
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This was removed in https://github.com/llvm/llvm-project/pull/135343 in favour
of making it a format variable, which we do here. This follows the precedent of
the `[opt]` and `[artificial]` markers.
rdar:
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/142952
This was removed in https://github.com/llvm/llvm-project/pull/135343 in favour
of making it a format variable, which we do here. This follows the precedent of
the `[opt]` and `[artificial]` markers.
rdar://
tedwoodward wrote:
> I'll leave the proper review to the RISC-V interested parties, just some high
> level points:
>
> * The csrs that have names, are all the ones here from the RISC-V
> standard? Do they include any names allocated for custom extensions or do you
> plan to do anything li
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/142952
>From 7d2a6406b8069b6c23611860d937db1275fb33ef Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 5 Jun 2025 12:02:17 +0100
Subject: [PATCH 1/2] [lldb][Format] Add [inlined] marker to names of inlined
fr
@@ -54,12 +57,67 @@ struct RegisteredPluginInfo {
bool enabled = false;
};
+// Define some data structures to describe known plugin "namespaces".
+// The PluginManager is organized into a series of static functions
+// that operate on different types of plugins. For example
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -0,0 +1,52 @@
+# This test validates the plugin list command.
+# Currently it works only for system-runtime plugins and we only have one
+# system runtime plugin so testing is a bit limited.
+#
+# Note that commands that return errors will stop running a script, so we
+# have n
Author: Michael Buch
Date: 2025-06-05T17:41:37+01:00
New Revision: 5a918923f37e49b426f117c691c83d29df8c955d
URL:
https://github.com/llvm/llvm-project/commit/5a918923f37e49b426f117c691c83d29df8c955d
DIFF:
https://github.com/llvm/llvm-project/commit/5a918923f37e49b426f117c691c83d29df8c955d.diff
ashgti wrote:
#142831 should fix the failing test on macOS. Should I revert this revert and
add that to my other PR or should I rebase my changes on HEAD and we can take
another stab at updating the stepInTargets request?
https://github.com/llvm/llvm-project/pull/142891
___
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/142952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
nb this PR is causing a failure on the x86_64 macOS CI bot
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/ in
TestUniversal.py where `image list -t -b` returns a triple name of
`x86_64-apple-macosx10.9.0-macho` instead of `x86_64-apple-macosx10.9.0` and
t
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142831
>From 0824e3c626ad5e8c2ce37f2fdfcf0c2fa47b7b1d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 4 Jun 2025 11:03:37 -0700
Subject: [PATCH 1/6] [lldb-dap] Creating a 'capabilities' event helper.
This adds
jasonmolenda wrote:
Aha, I see. Any call to llvm's `setObjectFormat` is going to add this to the
triple string if there is no environ set:
```
1608 void Triple::setObjectFormat(ObjectFormatType Kind) {
1609 if (Environment == UnknownEnvironment)
-> 1610 return setEnvironmentName(ge
jasonmolenda wrote:
In `ArchSpec::SetArchitecture` if we passed in the vendor in addition to the
architecture, that would set the ObjectFile to MachO correctly *without*
calling `Triple::setObjectFormat` which adds the object file name to the triple
as an environment, if there is no environmen
Author: Jason Molenda
Date: 2025-06-05T16:24:31-07:00
New Revision: f961d6a89abe5a6fb70afc043f33b2efcec77536
URL:
https://github.com/llvm/llvm-project/commit/f961d6a89abe5a6fb70afc043f33b2efcec77536
DIFF:
https://github.com/llvm/llvm-project/commit/f961d6a89abe5a6fb70afc043f33b2efcec77536.diff
jasonmolenda wrote:
I've reverted this commit on main for now,
```
commit f961d6a89abe5a6fb70afc043f33b2efcec77536
Author: Jason Molenda
Date: Thu Jun 5 16:23:27 2025 -0700
Revert "[lldb] Set default object format to `MachO` in `ObjectFileMachO`
(#142704)"
```
Until we can find a way t
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/142875
>From 196837389c032a59f47dd0acf98bfd18bbaa0ae3 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Wed, 4 Jun 2025 09:40:51 -0700
Subject: [PATCH] Minor fix to connect-url to support unix-connect sockets on
loc
@@ -800,7 +800,11 @@ std::string PlatformRemoteGDBServer::MakeUrl(const char
*scheme,
const char *hostname,
uint16_t port, const char *path) {
StreamString result;
- result.Printf("%s:
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/142831
>From 0824e3c626ad5e8c2ce37f2fdfcf0c2fa47b7b1d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 4 Jun 2025 11:03:37 -0700
Subject: [PATCH 1/7] [lldb-dap] Creating a 'capabilities' event helper.
This adds
https://github.com/satyajanga edited
https://github.com/llvm/llvm-project/pull/142875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,3 +57,50 @@ def test_platform_process_connect(self):
self.assertEqual(frame.GetFunction().GetName(), "main")
self.assertEqual(frame.FindVariable("argc").GetValueAsSigned(), 2)
process.Continue()
+
+@skipIfRemote
+@expectedFailureAll(hostos
ashgti wrote:
I also added some unit tests for the new 'CapabilitiesEventBody' serialization
logic. But I have a style question.
The existing `Capabilities` type doesn't initialize its fields, so if I use the
aggregate I have to include all the fields. However, we could initialize the
values
https://github.com/Prabhuk created
https://github.com/llvm/llvm-project/pull/143048
`TestStopHookScripted.py` Was failing for cases where -I 0 was not passed to
stop-hook add calls.
>From caba21d891cf799aecd98a038dc74458e6078867 Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Thu, 5 Jun 2025 2
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Prabhu Rajasekaran (Prabhuk)
Changes
`TestStopHookScripted.py` Was failing for cases where -I 0 was not passed to
stop-hook add calls.
---
Full diff: https://github.com/llvm/llvm-project/pull/143048.diff
1 Files Affected:
- (modified)
Prabhuk wrote:
> Two things. First off, adding the -I 0 option did indeed fix a failure.
>
> In the first run you cited, three tests failed:
>
> FAIL: LLDB (/b/s/w/ir/x/w/cipd/clang/bin/clang-x86_64) ::
> test_stop_hooks_scripted_auto_continue
> (TestStopHookScripted.TestStopHooks.test_stop_h
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
``
https://github.com/satyajanga converted_to_draft
https://github.com/llvm/llvm-project/pull/142875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/142875
>From 41aa3b5c467a7ff07894060b11613c450e7804c5 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Thu, 5 Jun 2025 17:07:08 -0700
Subject: [PATCH] update the "Usage: error message" for socket-file
---
lldb/to
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/142875
>From 196837389c032a59f47dd0acf98bfd18bbaa0ae3 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Wed, 4 Jun 2025 09:40:51 -0700
Subject: [PATCH] Minor fix to connect-url to support unix-connect sockets on
loc
https://github.com/satyajanga ready_for_review
https://github.com/llvm/llvm-project/pull/142875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2025-06-05T17:47:04-07:00
New Revision: 7730093596b898fa2773003f396da4b3ad1f3c0a
URL:
https://github.com/llvm/llvm-project/commit/7730093596b898fa2773003f396da4b3ad1f3c0a
DIFF:
https://github.com/llvm/llvm-project/commit/7730093596b898fa2773003f396da4b3ad1f3c0a.diff
jasonmolenda wrote:
NB I reverted this on main because it depends on
https://github.com/llvm/llvm-project/pull/142704
which I also reverted as it adds "-macho" to every Module's Triple string, and
we need to find a way to mark the object file as MachO without doing that.
https://github.com/llvm
jimingham wrote:
One other thing, if I set a custom value and want to get the default behavior
back, how do I do that? I think that `defaults clear max-children-count`
should do it, but it would be worth checking. If it does, it might be worth
giving that hint in the help, since that's not o
@@ -0,0 +1,52 @@
+# This test validates the plugin list command.
+# Currently it works only for system-runtime plugins and we only have one
+# system runtime plugin so testing is a bit limited.
+#
+# Note that commands that return errors will stop running a script, so we
+# have n
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,12 +57,67 @@ struct RegisteredPluginInfo {
bool enabled = false;
};
+// Define some data structures to describe known plugin "namespaces".
+// The PluginManager is organized into a series of static functions
+// that operate on different types of plugins. For example
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
Author: John Harrison
Date: 2025-06-05T15:58:30-07:00
New Revision: 52075f01a70990ce5e4b89f825d417a903a8dbe6
URL:
https://github.com/llvm/llvm-project/commit/52075f01a70990ce5e4b89f825d417a903a8dbe6
DIFF:
https://github.com/llvm/llvm-project/commit/52075f01a70990ce5e4b89f825d417a903a8dbe6.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/142510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
In `ObjectFileMachO::GetAllArchSpecs()`, we call `ArchSpec::SetArchitecture()`,
```
base_arch.SetArchitecture(eArchTypeMachO, header.cputype, header.cpusubtype);
```
given a `mach_header`. This does
```
890 m_triple.setArchName(llvm::StringRef(core_def->name));
https://github.com/jimingham approved this pull request.
I still don't understand the failures that triggered this patch - stopping at
the entry point somehow is at a place where both the function name filter for
`main` and `step_into_me` pass - even though that should be the same stop-point
f
concussious wrote:
*nudges*
https://github.com/llvm/llvm-project/pull/133148
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/142984
None
>From 9ae263cc0ffc6dc95d4a5b44d58462c1a22f1294 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 5 Jun 2025 10:55:38 -0400
Subject: [PATCH] [LLDB][NFC]Add missing getKind/classof methods for ClientInfo
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/142984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-06-05T11:00:39-04:00
New Revision: eb6577d54f53715e8917cf8a91eb68c8b47d489f
URL:
https://github.com/llvm/llvm-project/commit/eb6577d54f53715e8917cf8a91eb68c8b47d489f
DIFF:
https://github.com/llvm/llvm-project/commit/eb6577d54f53715e8917cf8a91eb68c8b47d489f.diff
LOG
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/134418
>From e240bda8fcea9db4d9c456929ba811feb8d4152b Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Tue, 11 Mar 2025 13:02:14 -0700
Subject: [PATCH 01/23] Add commands to list/enable/disable plugins
This commit a
https://github.com/Prabhuk closed
https://github.com/llvm/llvm-project/pull/143048
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Prabhuk wrote:
> I still don't understand the failures that triggered this patch - stopping at
> the entry point somehow is at a place where both the function name filter for
> `main` and `step_into_me` pass - even though that should be the same
> stop-point for both checks. That seems quite o
royitaqi wrote:
> the correct fix for #142704
How about:
1. In `Triple`'s `getDefaultFormat`, first check if vendor is
`llvm::Triple::Apple` and return `MachO` if so. The vendor is set to `Apple` by
`ObjectFileMachO::GetAllArchSpecs` calling `base_arch.SetArchitecture`, which
calls `m_triple.
royitaqi wrote:
> NB I reverted this on main because it depends on #142704 which I also
> reverted as it adds "-macho" to every Module's Triple string, and we need to
> find a way to mark the object file as MachO without doing that.
Hi @jasonmolenda,
I appreciate you actively trying to make t
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/143048
>From d1371371fbcfd6f8113e2d04707f80a7c439d287 Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Thu, 5 Jun 2025 22:52:24 +
Subject: [PATCH 1/2] [lldb] Fix linux x64 test
Test was failing for cases where -I 0 w
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/23971
Here is the relevant piece of the build log
royitaqi wrote:
@jasonmolenda I appreciate the details. IIRC I ran `ninja check-lldb` both
before and after rebasing the patch onto #142704, but from what you said I must
have not done that. Let me double check on my side.
https://github.com/llvm/llvm-project/pull/139170
__
royitaqi wrote:
You are right, `lldb/test/Shell/Breakpoint/case-sensitive.test` failed on my
arm64 macOS, too. So what I did must be that I tested before switching to using
`isAppleMachO()`, then never tested it again until rebased on top of #142704.
Thank you for catching this and the revert.
jasonmolenda wrote:
I'll admit I didn't debug it very far, but when I reverted the
ObjectFileMachO.cpp change, `lldb/test/Shell/Breakpoint/case-sensitive.test`
started failing on the bots. When I built main myself and ran it, it failed on
my desktop. When I used the built lldb on the `case-s
jasonmolenda wrote:
Ultimately I expect
```
// Don't create a debug map if the object file isn't a Mach-O.
if (!objfile_sp->GetArchitecture().GetTriple().isAppleMachO())
```
was not succeeding for this binary. I didn't debug what was special about this
binary; the compile command in the sh
jasonmolenda wrote:
e.g. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/27150/
but it reproduced on my arm64 macOS desktop no problem when I did `ninja
check-lldb-shell`
https://github.com/llvm/llvm-project/pull/139170
___
lldb-c
Author: Prabhu Rajasekaran
Date: 2025-06-05T19:26:17-07:00
New Revision: 0a1fdbe4df326a237e775c81de37aa9ddbb714e0
URL:
https://github.com/llvm/llvm-project/commit/0a1fdbe4df326a237e775c81de37aa9ddbb714e0
DIFF:
https://github.com/llvm/llvm-project/commit/0a1fdbe4df326a237e775c81de37aa9ddbb714e0.
jasonmolenda wrote:
FTR I suspect the correct fix for
https://github.com/llvm/llvm-project/pull/142704 is
1. This Triple object file setting should be done in ArchSpec::SetArchitecture,
so it doesn't depending on hitting an LC_BUILD load command, if anything is
going to depend on it.
2. There
96 matches
Mail list logo
