[Lldb-commits] [lldb] [lldb] Use llvm::any_of (NFC) (PR #141443)

2025-05-26 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/141443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] DisassembleRequestHandler: use a better invalid instruction (PR #141463)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes DisassembleRequestHandler: use a better invalid instruction value that fits VSCode client --- Full diff: https://github.com/llvm/llvm-project/pull/141463.diff 2 Files Affected: - (modified) lldb/tools/lldb-d

[Lldb-commits] [lldb] [lldb][lldb-dap] Use the default disassembly flavour if none is provided. (PR #141424)

2025-05-26 Thread Ebuka Ezike via lldb-commits
@@ -2039,7 +2039,17 @@ lldb::SBInstructionList SBTarget::ReadInstructions(lldb::SBAddress base_addr, const size_t bytes_read = target_sp->ReadMemory(*addr_ptr, data.GetBytes(), data.GetByteSize(), error, force_live_memory, &load_

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-26 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-26 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-26 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Aiden Grossman via lldb-commits
https://github.com/boomanaiden154 commented: Do we want to do the initialization here or inside the struct definition in `ProtocolTypes.h`? https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Walter Lee via lldb-commits
https://github.com/googlewalt created https://github.com/llvm/llvm-project/pull/141537 Tested with lldb and lldb-dap test suites. >From d1d4ea56e970caf92ed1e5dd5848c974e6d0b795 Mon Sep 17 00:00:00 2001 From: Walter Lee Date: Mon, 26 May 2025 21:15:07 -0400 Subject: [PATCH] Initialize field to

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Lee (googlewalt) Changes Tested with lldb and lldb-dap test suites. --- Full diff: https://github.com/llvm/llvm-project/pull/141537.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp (+1)

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Walter Lee via lldb-commits
googlewalt wrote: I can do that. It's probably better, though currently nothing in the struct is initialized. https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Walter Lee via lldb-commits
googlewalt wrote: > Do we want to do the initialization here or inside the struct definition in > `ProtocolTypes.h`? Done. https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [lldb] add missing cmake build type argument (PR #141427)

2025-05-26 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/141427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Walter Lee via lldb-commits
https://github.com/googlewalt updated https://github.com/llvm/llvm-project/pull/141537 >From d1d4ea56e970caf92ed1e5dd5848c974e6d0b795 Mon Sep 17 00:00:00 2001 From: Walter Lee Date: Mon, 26 May 2025 21:15:07 -0400 Subject: [PATCH 1/2] Initialize field to appease msan Tested with lldb and lldb-

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) Changes It seem that #140107 changed the default argument of `disableASLR` of related functions from `False` to `True`. libc++ CI has been stably failing for `TestDAP_subtleFrames.py` (in bootstrapping-build) s

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-26 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/141543 It seem that #140107 changed the default argument of `disableASLR` of related functions from `False` to `True`. libc++ CI has been stably failing for `TestDAP_subtleFrames.py` (in bootstrapping-build) s

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initialize field to appease msan (PR #141537)

2025-05-26 Thread Walter Lee via lldb-commits
https://github.com/googlewalt closed https://github.com/llvm/llvm-project/pull/141537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b75d8bd - Initialize field to appease msan (#141537)

2025-05-26 Thread via lldb-commits
Author: Walter Lee Date: 2025-05-27T00:18:40-04:00 New Revision: b75d8bdd4eb242e3936357beaf7f9407ba71d9f1 URL: https://github.com/llvm/llvm-project/commit/b75d8bdd4eb242e3936357beaf7f9407ba71d9f1 DIFF: https://github.com/llvm/llvm-project/commit/b75d8bdd4eb242e3936357beaf7f9407ba71d9f1.diff LO

[Lldb-commits] [lldb] 85cbf74 - [lldb] Use llvm::any_of (NFC) (#141443)

2025-05-26 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-26T09:13:17-07:00 New Revision: 85cbf742f9dab78808c0093ca85031acbf55e250 URL: https://github.com/llvm/llvm-project/commit/85cbf742f9dab78808c0093ca85031acbf55e250 DIFF: https://github.com/llvm/llvm-project/commit/85cbf742f9dab78808c0093ca85031acbf55e250.diff L

[Lldb-commits] [lldb] [lldb] Use llvm::any_of (NFC) (PR #141443)

2025-05-26 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/141443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/141516 This commit adjusts the pretty printer for `std::corotoutine_handle` based on recent personal experiences with debugging C++20 coroutines: 1. It adds the `coro_frame` member. This member exposes the comple

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit adjusts the pretty printer for `std::corotoutine_handle` based on recent personal experiences with debugging C++20 coroutines: 1. It adds the `coro_frame` member. This member exposes t

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/141516 >From 733f6321bc7020281ea33dd6dad0a2409e248ccd Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 23 May 2025 01:20:46 + Subject: [PATCH] [lldb] Show coro_frame in `std::coroutine_handle` pre

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/DataFormatters/TypeSynthetic.h l

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: CC @ChuanqiXu9 @hokein, since I know that the both of you also looked into debuggability of C++20 coroutines earlier CC @labath @adrian-prantl as reviewers of the latest significant changes in this area (https://reviews.llvm.org/D132624, https://reviews.llvm.org/D132735, ht

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/141516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/141516 >From 4132dcd234438ec710061b498b7c5778637026d5 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 23 May 2025 01:20:46 + Subject: [PATCH] [lldb] Show coro_frame in `std::coroutine_handle` pre

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/141516 >From 35e18fc22abfb1daff2b08413f34f258e922fd5f Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 23 May 2025 01:20:46 + Subject: [PATCH] [lldb] Show coro_frame in `std::coroutine_handle` pre

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes When a target thread returned an empty but not `nullptr` string as its name, the thread would show up with an empty name in lldb-dap. I don't know how this works on macOS and Linux, but on Windows, [`TargetThreadWi

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-26 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/141529 When a target thread returned an empty but not `nullptr` string as its name, the thread would show up with an empty name in lldb-dap. I don't know how this works on macOS and Linux, but on Windows, [`TargetThr

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Jan Finis via lldb-commits
@@ -141,76 +127,76 @@ lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() { if (frame_ptr_addr == 0 || frame_ptr_addr == LLDB_INVALID_ADDRESS) return lldb::ChildCacheState::eRefetch; - auto ast_ctx = valobj_sp->GetCompilerType().GetTypeSystem();

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Jan Finis via lldb-commits
@@ -43,11 +43,17 @@ def do_test(self, stdlib_type): ValueCheck(name="current_value", value="-1"), ], ), +# We don not check any members inside the `coro_frame`, JFinis wrote: ```sugges

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/141516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-26 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/141516 >From 35e18fc22abfb1daff2b08413f34f258e922fd5f Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Fri, 23 May 2025 01:20:46 + Subject: [PATCH 1/2] [lldb] Show coro_frame in `std::coroutine_handle`

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akash Agrawal (akashagrwl) Changes A few files of lldb dir & few other files had duplicate headers included. This patch removes those redundancies. --- Full diff: https://github.com/llvm/llvm-project/pull/141478.diff 15 Files Affected:

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via lldb-commits
https://github.com/akashagrwl created https://github.com/llvm/llvm-project/pull/141478 A few files of lldb dir & few other files had duplicate headers included. This patch removes those redundancies. >From 72ce442847fe03dd489938eff0eee06c65f53e90 Mon Sep 17 00:00:00 2001 From: Akash Agrawal D

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/InstallAPI/FileList.cpp compiler-rt/lib/sa

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via lldb-commits
https://github.com/akashagrwl updated https://github.com/llvm/llvm-project/pull/141478 >From 72ce442847fe03dd489938eff0eee06c65f53e90 Mon Sep 17 00:00:00 2001 From: Akash Agrawal Date: Mon, 26 May 2025 16:54:21 +0530 Subject: [PATCH 1/2] [LLVM] [NFC] - Remove duplicate #include headers from the

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-26 Thread Akash Agrawal via lldb-commits
akashagrwl wrote: Adding @iajbar @androm3da @svs-quic for review. https://github.com/llvm/llvm-project/pull/141478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits