[Lldb-commits] [lldb] 9147569 - [lldb][test] Rename reverse-execution/TestReverseContinueNotSupported.py

Author: Michael Buch Date: 2025-04-25T14:26:50+01:00 New Revision: 9147569c7fc996555af81916ce81a53ad7625d7d URL: https://github.com/llvm/llvm-project/commit/9147569c7fc996555af81916ce81a53ad7625d7d DIFF: https://github.com/llvm/llvm-project/commit/9147569c7fc996555af81916ce81a53ad7625d7d.diff

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

@@ -319,3 +320,255 @@ TEST(MangledTest, NameIndexes_FindFunctionSymbols) { EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeBase)); EXPECT_EQ(0, Count("undemangable", eFunctionNameTypeMethod)); } + +TEST(MangledTest, DemangledNameInfo_SetMangledResets) { + Mangled mangl

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

kuilpd wrote: @labath Should I move the check for `void *` to `TypeSystemClang::GetDereferencedType` in the other PR? https://github.com/llvm/llvm-project/pull/134428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The function was always trying to dereference both the synthetic and non-synthetic view of the object. This is wrong as the caller should be able to determine which view of the object it wants to access, as is

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/137311 The function was always trying to dereference both the synthetic and non-synthetic view of the object. This is wrong as the caller should be able to determine which view of the object it wants to access, as is d

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Target/StackFrame.cpp lldb/source/ValueOb

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

slydiman wrote: Still failed https://lab.llvm.org/buildbot/#/builders/195/builds/8109 https://lab.llvm.org/buildbot/#/builders/197/builds/4470 https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/137311 >From a295fdb31c59050f9b6d9fc9ba4e0156a7e35c1b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 25 Apr 2025 11:21:52 +0200 Subject: [PATCH] [lldb] Make ValueObject::Dereference less aggressive The function

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: @labath this is what it looks like at the bottom right  https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

labath wrote: I see, so it's one of those popups that don't require interaction and disappear on their own after a while. I'm still somewhat worried, as these errors tend to be bursty. Like, if there's something wrong with the debug info, we could get dozens (or more) of errors of the kind I

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

labath wrote: I kinda like how the (highlighted) PC value creates a column. What would you say to highlighting both? (I know I can change this locally if I want to, so this is really a question what's a better default => don't change this just because I said so) https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: this does not catch https://github.com/llvm/llvm-project/blob/d775b911c90e631f5cc332c07474f7121564e25b/lldb/tools/lldb-dap/DAP.cpp#L215-L219 for example if you add the initcommand of `breakpoint set --file=main.c --line=2 --command "bogus"` it is not sent to the important categ

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

da-viper wrote: Maybe we limit it to only Errors. as on linux if lldb is not built with lzma support it will spam warning messages like. ``` warning: 45F7FBFE-9455-A458-4A50-347C4A5BC883/libsync.so No LZMA support found for reading .gnu_debugdata section warning: 8E2F4272-9D82-2CEF-A46D-C69D

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

Michael137 wrote: > I kinda like how the (highlighted) PC value creates a column. What would you > say to highlighting both? > > (I know I can change this locally if I want to, so this is really a question > what's a better default => don't change this just because I said so) This is what it

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/137301 >From eac7bbaa47715c053c711ed6469f4dd9d3b55b4a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 25 Apr 2025 10:25:51 +0100 Subject: [PATCH] [lldb] Highlight basenames in backtraces instead of PC value

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

adrian-prantl wrote: > > I kinda like how the (highlighted) PC value creates a column. What would > > you say to highlighting both? > Maybe we could use a different color? Don't have strong opinions on this. We could try a less aggressive color like the one used for the file names. I'm wonder

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

tromey wrote: Thank you for the test case. I sent a gdb fix: https://sourceware.org/pipermail/gdb-patches/2025-April/217513.html https://github.com/llvm/llvm-project/pull/137123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/25] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

eronnen wrote: @JDevlieghere any chance to merge? https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

oontvoo wrote: Thanks all, for the feedback! I'll merge this EOD today, if there's no objection! :) https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id); lldb::SBEnvironment GetEnvironmentFromArguments(const llvm::json::Object &arguments); +/// Helper for sending telemetry to lldb server, if client-telemetry is enabled. +#ifndef SWIG oontvoo

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

@@ -117,6 +118,9 @@ static void EventThreadFunction(DAP &dap) { lldb::SBEvent event; lldb::SBListener listener = dap.debugger.GetListener(); dap.broadcaster.AddListener(listener, eBroadcastBitStopEventThread); + dap.debugger.GetBroadcaster().AddListener( + listener,

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/137280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

Michael137 wrote: Here's a version where the PC value is cyan (like the filename): https://github.com/user-attachments/assets/d9e90fc7-9f06-4044-8500-2a6f5a4926d2"; /> You still get the colored column, but it feels less difficult on the eyes than having both yellow https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/137301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

DavidSpickett wrote: You could adapt commands from https://github.com/llvm/llvm-project/tree/main/lldb/scripts/lldb-test-qemu, if you have an existing Ubuntu system of some other architecture. https://lldb.llvm.org/resources/qemu-testing.html https://github.com/llvm/llvm-project/pull/115408 _

[Lldb-commits] [lldb] [lldb] Rename reverse-continue/TestReverseContinueNotSupported.py (NFC) (PR #137262)

https://github.com/DavidSpickett approved this pull request. Also noticed this trying to reproduce a failure on Windows with lldb-dotest.py, LGTM. https://github.com/llvm/llvm-project/pull/137262 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

DavidSpickett wrote: > The instruction emulation plugins are used to implement software > single-stepping on architectures without (reliably present) hardware support. > AFAIK aarch64 is not one of those. I think it's also used in unwinding for some basic prologue/epilogue instructions, but I

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

slydiman wrote: Ok, thanks. Then I will close this PR. https://github.com/llvm/llvm-project/pull/137267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add InstructionARM64 to lldb-server (PR #137267)

https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/137267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

@@ -156,6 +158,52 @@ uint32_t GetLLDBFrameID(uint64_t dap_frame_id); lldb::SBEnvironment GetEnvironmentFromArguments(const llvm::json::Object &arguments); +/// Helper for sending telemetry to lldb server, if client-telemetry is enabled. +#ifndef SWIG labath w

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a267225 - [lldb][Mangled] Retrieve and cache demangled name info (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: a2672250be871bdac18c1a955265a98704434218 URL: https://github.com/llvm/llvm-project/commit/a2672250be871bdac18c1a955265a98704434218 DIFF: https://github.com/llvm/llvm-project/commit/a2672250be871bdac18c1a955265a98704434218.diff

[Lldb-commits] [lldb] 8b91b44 - [lldb][Format] Introduce new frame-format variables for function parts (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: 8b91b44a3be680788f914af72f38f90d35925c23 URL: https://github.com/llvm/llvm-project/commit/8b91b44a3be680788f914af72f38f90d35925c23 DIFF: https://github.com/llvm/llvm-project/commit/8b91b44a3be680788f914af72f38f90d35925c23.diff

[Lldb-commits] [lldb] d555b9f - [lldb][CPlusPlus] Add plugin.cplusplus.display.function-name-format setting (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: d555b9f9a01705097edf2434cf897e351095e5c9 URL: https://github.com/llvm/llvm-project/commit/d555b9f9a01705097edf2434cf897e351095e5c9 DIFF: https://github.com/llvm/llvm-project/commit/d555b9f9a01705097edf2434cf897e351095e5c9.diff

[Lldb-commits] [lldb] 9c830ce - [lldb] Implement TrackingOutputBuffer to track demangled name information (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: 9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05 URL: https://github.com/llvm/llvm-project/commit/9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05 DIFF: https://github.com/llvm/llvm-project/commit/9c830cef3d7c2f1adfadcc0026a73ba2cdbeef05.diff

[Lldb-commits] [lldb] f220ea2 - [lldb][Mangled] Add API to force re-demangling a Mangled object (#131836)

Author: Michael Buch Date: 2025-04-25T10:04:27+01:00 New Revision: f220ea2947b9c8b1e33db65b008086d47fa72af3 URL: https://github.com/llvm/llvm-project/commit/f220ea2947b9c8b1e33db65b008086d47fa72af3 DIFF: https://github.com/llvm/llvm-project/commit/f220ea2947b9c8b1e33db65b008086d47fa72af3.diff

[Lldb-commits] [lldb] 5a64510 - [lldb] Remove redundant DemangledNameInfo::operator==

Author: Michael Buch Date: 2025-04-25T10:18:33+01:00 New Revision: 5a645109c3a965dcaab08e3485f2fa505e44cde3 URL: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3 DIFF: https://github.com/llvm/llvm-project/commit/5a645109c3a965dcaab08e3485f2fa505e44cde3.diff

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

JDevlieghere wrote: > @JDevlieghere any chance to merge? There's a conflict in `StackTraceRequestHandler.cpp`, let me know once you've resolved that and I'm happy to go ahead and merge this. https://github.com/llvm/llvm-project/pull/136494 ___ lldb-

[Lldb-commits] [lldb] 480f1a4 - [lldb-dap] fix wrong assembly line number x64 (#136486)

Author: Ely Ronnen Date: 2025-04-25T09:34:17-07:00 New Revision: 480f1a4980de4d1a3691329bbe0b5b9e4321a3f3 URL: https://github.com/llvm/llvm-project/commit/480f1a4980de4d1a3691329bbe0b5b9e4321a3f3 DIFF: https://github.com/llvm/llvm-project/commit/480f1a4980de4d1a3691329bbe0b5b9e4321a3f3.diff LO

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

@@ -182,3 +191,20 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +llvm::Expected> +DomainSocket::FromBoundNativeSocket(NativeSocket sockfd, bool should_close) { +#ifdef __linux__ + // Check

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

https://github.com/emrekultursay edited https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX emrekultursay wrote: Done. https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

https://github.com/emrekultursay commented: Thanks. PTAL. https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

@@ -339,6 +342,48 @@ TEST_F(SocketTest, DomainGetConnectURI) { } #endif +#if LLDB_ENABLE_POSIX +TEST_F(SocketTest, DomainSocketFromBoundNativeSocket) { + // Generate a name for the domain socket. + llvm::SmallString<64> name; + std::error_code EC = llvm::sys::fs::createUniq

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137280 >From 93f3b75bab631deeeccb4d90491ce482d9adb825 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 24 Apr 2025 17:59:29 -0700 Subject: [PATCH 1/3] [lldb] Emit diagnostics as "important" output Hand

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137280 >From 93f3b75bab631deeeccb4d90491ce482d9adb825 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 24 Apr 2025 17:59:29 -0700 Subject: [PATCH 1/4] [lldb] Emit diagnostics as "important" output Hand

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/106271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

@@ -37,14 +39,12 @@ MakeArgv(const llvm::ArrayRef &strs) { return argv; } -static uint32_t SetLaunchFlag(uint32_t flags, const llvm::json::Object *obj, - llvm::StringRef key, lldb::LaunchFlags mask) { - if (const auto opt_value = GetBoolean(obj,

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/133624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 51dc0cc - [lldb-dap] Handle stack frames without a module (#136777)

Author: Ely Ronnen Date: 2025-04-25T09:30:09-07:00 New Revision: 51dc0cc7a43a4aef98a62bae93e758083f92b6f4 URL: https://github.com/llvm/llvm-project/commit/51dc0cc7a43a4aef98a62bae93e758083f92b6f4 DIFF: https://github.com/llvm/llvm-project/commit/51dc0cc7a43a4aef98a62bae93e758083f92b6f4.diff LO

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

@@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid, Status ProcessWindows::DoResume(RunDirection direction) { Log *log = GetLog(WindowsLog::Process); llvm::sys::ScopedLock lock(m_mutex); - Status error; if (direction == RunDirection::eRunRev

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134722 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating the 'stepOut' request to use typed RequestHandler. (PR #137362)

https://github.com/JDevlieghere approved this pull request. This looks pretty straightforward. LGTM. https://github.com/llvm/llvm-project/pull/137362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces instead of the PC value (PR #137301)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/137301 >From eac7bbaa47715c053c711ed6469f4dd9d3b55b4a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 25 Apr 2025 10:25:51 +0100 Subject: [PATCH 1/2] [lldb] Highlight basenames in backtraces instead of PC va

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

@@ -190,6 +190,7 @@ void CommandObjectDisassemble::CommandOptions::OptionParsingStarting( // architecture. For now GetDisassemblyFlavor is really only valid for x86 // (and for the llvm assembler plugin, but I'm papering over that since that // is the only disass

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

kazutakahirata wrote: @GeorgeHuyubo I've reverted this PR. I'm happy to try your revised patch. Thanks! https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

@@ -174,12 +174,21 @@ struct StatisticsOptions { return !GetSummaryOnly(); } + void SetIncludePlugins(bool value) { m_include_plugins = value; } + bool GetIncludePlugins() const { +if (m_include_plugins.has_value()) + return m_include_plugins.value(); +//

[Lldb-commits] [lldb] [lldb-dap] Fix formatting chrono::seconds warning. (PR #137371)

https://github.com/ashgti reopened https://github.com/llvm/llvm-project/pull/137371 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137388 When building with MSVC 2019 using `std::future` causes a compile time build error. ``` C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\future(196): error C22

[Lldb-commits] [lldb] [lldb-dap] Mitigate a build error on Windows. (PR #137388)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes When building with MSVC 2019 using `std::future` causes a compile time build error. ``` C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\include\future(

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/137379 >From 2c2de66f4ea47716452c2deafbef6e2bfa7113fa Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 22 Apr 2025 19:37:05 -0700 Subject: [PATCH] Add symbol locator time for each module in statistics --- lld

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/137379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

@@ -164,3 +164,20 @@ def test_exit_status_message_ok(self): console_output, "Exit status does not contain message 'exited with status'", ) + +def test_diagnositcs(self): +program = self.getBuildArtifact("a.out") +self.build_an

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

@@ -239,15 +239,15 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid, Status ProcessWindows::DoResume(RunDirection direction) { Log *log = GetLog(WindowsLog::Process); llvm::sys::ScopedLock lock(m_mutex); - Status error; if (direction == RunDirection::eRunRev

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

github-actions[bot] wrote: @eronnen Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

@@ -116,7 +116,25 @@ void DisassembleRequestHandler::operator()( const auto inst_count = GetInteger(arguments, "instructionCount").value_or(0); - lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count); + + std::string flavor_string{}; + const

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

@@ -116,7 +116,25 @@ void DisassembleRequestHandler::operator()( const auto inst_count = GetInteger(arguments, "instructionCount").value_or(0); - lldb::SBInstructionList insts = dap.target.ReadInstructions(addr, inst_count); + + std::string flavor_string{};

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

@@ -117,6 +118,9 @@ static void EventThreadFunction(DAP &dap) { lldb::SBEvent event; lldb::SBListener listener = dap.debugger.GetListener(); dap.broadcaster.AddListener(listener, eBroadcastBitStopEventThread); + dap.debugger.GetBroadcaster().AddListener( + listener,

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

[Lldb-commits] [lldb] [lldb][lldb-dap] Respect x86 disassembly flavor setting (PR #134722)

https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/134722 >From ababee38bf0dae6c12e09225bf84ec2bf03e7982 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 7 Apr 2025 20:43:30 +0100 Subject: [PATCH 1/3] [lldb][lldb-dap] Respect x86 disassembly flavor setting Ensur

[Lldb-commits] [lldb] 332e181 - [lldb] Fix error that lead Windows to think it could reverse execute (#137351)

Author: David Spickett Date: 2025-04-25T18:04:08+01:00 New Revision: 332e1817667827c242422e91c4de1b27fb573a0b URL: https://github.com/llvm/llvm-project/commit/332e1817667827c242422e91c4de1b27fb573a0b DIFF: https://github.com/llvm/llvm-project/commit/332e1817667827c242422e91c4de1b27fb573a0b.diff

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH 1/5] Fix connecting via abstract socket Commit 82ee31f an

[Lldb-commits] [lldb] [lldb-dap] Fix TestDap_attach.py flakiness (PR #137278)

@@ -374,6 +374,12 @@ def wait_for_event(self, filter=None, timeout=None): ) return None +def wait_for_process_and_initialized(self, timeout=None): dmpots wrote: You are taking `timeout` as a parameter here, but not passing it down to

[Lldb-commits] [lldb] [lldb] Emit diagnostics as "important" output (PR #137280)

JDevlieghere wrote: > I also think this LZMA message is important enough to see -- but once, not > once for each module. So I can imagine a setup where the first of these > messages would cause a popup and the rest would be squirrelled away somewhere > -- but for that we'd need a better mechan

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes * Fix broken tests that use commanEscapePrefix="", in my case `TestDAP_stackTraceMissingModule.test_missingModule` --- Full diff: https://github.com/llvm/llvm-project/pull/137384.diff 1 Files Affected: - (m

[Lldb-commits] [lldb] [lldb-dap] Fix broken tests with commanEscapePrefix="" (PR #137384)

https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/137384 * Fix broken tests that use commanEscapePrefix="", in my case `TestDAP_stackTraceMissingModule.test_missingModule` >From c496d0ec97db4a1bcb4717afb7427648e0c371ec Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From caf6db4c4ef8caea027bb7909a723bf24ff881ad Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH] fallback to assembly when source code is not available fix TestDAP

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/137383 The instructions to build LLDB standalone contain a CMake configure step to build LLVM standalone. This configure step needs to also have the CMake build type in order to work. >From c12f01f83d6849023635

[Lldb-commits] [lldb] [lldb-dap] Support the Module Event (PR #137380)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/137380 >From 681beb0f851d20896456b53c51b8ee84382a1254 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 25 Apr 2025 10:40:45 -0700 Subject: [PATCH 1/2] [lldb-dap] Support the Module Event The module eve

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #137379)

GeorgeHuyubo wrote: > I've locally applied your change on the top of tree, but I still get: > > ``` > lldb/source/Target/Statistics.cpp:75:39: error: use of undeclared identifier > 'num_symbols_loaded' > module.try_emplace("symbolsLoaded", num_symbols_loaded); >

[Lldb-commits] [lldb] [lldb] Make ValueObject::Dereference less aggressive (PR #137311)

https://github.com/kuilpd edited https://github.com/llvm/llvm-project/pull/137311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix error that lead Windows to think it could reverse execute (PR #137351)

rocallahan wrote: Thanks!!! https://github.com/llvm/llvm-project/pull/137351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

slydiman wrote: https://lab.llvm.org/buildbot/#/builders/141 is also broken. https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 488eeb3 - Fix connecting via abstract socket (#136466)

Author: Emre Kultursay Date: 2025-04-25T14:11:19-07:00 New Revision: 488eeb3ae508221f8e476bbc9d2e9f014542862e URL: https://github.com/llvm/llvm-project/commit/488eeb3ae508221f8e476bbc9d2e9f014542862e DIFF: https://github.com/llvm/llvm-project/commit/488eeb3ae508221f8e476bbc9d2e9f014542862e.diff

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

JDevlieghere wrote: > 2. Would you like me to create a cherry-pick into release/20.x branch, or is > there a separate process for cherry-picks (e.g., wait some time to validate, > submit a cherry-pick request somewhere, etc.)? Please file and issue (here's an example: https://github.com/llvm/

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

llvmbot wrote: >> 2. Would you like me to create a cherry-pick into release/20.x branch, or is >> there a separate process for cherry-picks (e.g., wait some time to validate, >> submit a cherry-pick request somewhere, etc.)? > >Please file and issue (here's an example: >https://github.com/llv

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

llvmbot wrote: >> 2. Would you like me to create a cherry-pick into release/20.x branch, or is >> there a separate process for cherry-picks (e.g., wait some time to validate, >> submit a cherry-pick request somewhere, etc.)? > >Please file and issue (here's an example: >https://github.com/llv

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

emrekultursay wrote: Thanks folks: 1. Can you please squash-and-merge this PR? (I don't have write permissions) 2. Would you like me to create a cherry-pick into release/20.x branch, or is there a separate process for cherry-picks (e.g., wait some time to validate, submit a cherry-pick request

[Lldb-commits] [lldb] b571aa4 - [lldb][NFC] Add missing newline between function definitions

Author: Michael Buch Date: 2025-04-25T22:52:05+01:00 New Revision: b571aa49b1e07908b22bba3494461799e2f5c493 URL: https://github.com/llvm/llvm-project/commit/b571aa49b1e07908b22bba3494461799e2f5c493 DIFF: https://github.com/llvm/llvm-project/commit/b571aa49b1e07908b22bba3494461799e2f5c493.diff

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

emrekultursay wrote: We're getting `SetSockAddr` error which can only fail if the path is too long. The path generated by `createUniqueDirectory` is an absolute path to a temporary directory. I guess it can be longer than 107 bytes on the CI machines. All the other DomainSocket related tests s

  1   2   3   >