Author: Jacob Lalonde
Date: 2025-03-29T15:21:51-07:00
New Revision: 2f5c836e08164ce8835d520001042efe93caf950
URL:
https://github.com/llvm/llvm-project/commit/2f5c836e08164ce8835d520001042efe93caf950
DIFF:
https://github.com/llvm/llvm-project/commit/2f5c836e08164ce8835d520001042efe93caf950.diff
https://github.com/bulbazord approved this pull request.
One minor suggestion. Otherwise lgtm
https://github.com/llvm/llvm-project/pull/133539
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
ashgti wrote:
Sure I’ll convert it to that in a follow up patch
https://github.com/llvm/llvm-project/pull/133542
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/132783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -468,7 +468,23 @@ class CommandObjectProcessContinue : public
CommandObjectParsed {
case 'b':
m_run_to_bkpt_args.AppendArgument(option_arg);
m_any_bkpts_specified = true;
- break;
+break;
+ case 'F':
+if (m_base_direction == l
vogelsgesang wrote:
We probably also want to test that
* reverse-continue on a non-reverse-capable process gives a decent error message
* `process continue -F` also work for non-reverse-capable processes
https://github.com/llvm/llvm-project/pull/132783
___
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/133527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> I suppose we need to add documentation for this but I'm not sure where...
Afaict, your code change should already be sufficient such that `help processor
continue` also lists the new -F and -R flags.
In addition, I guess we would eventually want to also document more gene
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This converts a number of json::Value's into well defined types that are used
throughout lldb-dap and updates the 'launch' command to use the new well
defined types.
---
Patch is 68.84 KiB, truncated to 20.
mizvekov wrote:
@alexfh should be fixed by https://github.com/llvm/llvm-project/pull/133613
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/133622
Small tweak to the previous patch to make the enums in `lldb_dap::protocol`
typed to work with types like `llvm::DenseSet` found by ubsan.
>From b7ecaef75b0e059b11761eea4a640e6a68f3d2d6 Mon Sep 17 00:00:00 2001
@@ -744,6 +744,10 @@ let Command = "process continue" in {
Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to,
temporarily "
"ignoring other breakpoints. Can be specified more than once. "
"The continue action will be done synchronously if this o
https://github.com/JDevlieghere approved this pull request.
Nice improvement!
Not sure how hard it would be to extend this even more, but Python's
[rich](https://rich.readthedocs.io/en/stable/progress.html) package has a
progress bar that allows you to write:
```
for i in track(range(20), de
JDevlieghere wrote:
> Neat! While I don't love the reverse video, is there an easier way to update
> the status line color other than setting the entire format like so?
>
> ```
> settings set statusline-format "${ansi.bg.blue}{${target.file.basename}}{ |
> ${line.file.basename}:${line.number}:
https://github.com/JDevlieghere commented:
I think using `FLAGS_ENUM` here is misleading: these are not flags which you
can mask. Could we instead just add a type like `enum Message: unsinged` or
`enum Message: uint64_t` to make UBSan happy?
https://github.com/llvm/llvm-project/pull/133542
__
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/132043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with Alex' suggestion.
https://github.com/llvm/llvm-project/pull/133539
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -0,0 +1,142 @@
+//===-- WriteMemoryRequestHandler.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
Jlalond wrote:
> > Neat! While I don't love the reverse video, is there an easier way to
> > update the status line color other than setting the entire format like so?
> > ```
> > settings set statusline-format "${ansi.bg.blue}{${target.file.basename}}{ |
> > ${line.file.basename}:${line.number
Jlalond wrote:
> Nice improvement!
>
> Not sure how hard it would be to extend this even more, but Python's
> [rich](https://rich.readthedocs.io/en/stable/progress.html) package has a
> progress bar that allows you to write:
>
> ```
> for i in track(range(20), description="Processing..."):
>
20 matches
Mail list logo