labath wrote:
> Moving out only 1 function `CPlusPlusLanguage::IsCPPMangledName()` is not
> enough anymore to reduce the size of lldb-server. But this patch works fine
> because moves all code used by Module.cpp.
I still don't think we should be doing this, and this is the reason why. It's
no
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/132923
All uses have been replaced by GetAddressRange*s* or GetAddress.
Also fix two internal uses of the range member.
>From 511d6027e952ed6a675bd899dffa07de934a080e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
All uses have been replaced by GetAddressRange*s* or GetAddress.
Also fix two internal uses of the range member.
---
Full diff: https://github.com/llvm/llvm-project/pull/132923.diff
2 Files Affected:
- (mod
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/132718
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132905
ThreadMemory attempts to be a class abstracting the notion of a "fake" Thread
that is backed by a "real" thread. According to its documentation, it is meant
to be a class forwarding most methods to the b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
ThreadMemory attempts to be a class abstracting the notion of a "fake" Thread
that is backed by a "real" thread. According to its documentation, it is meant
to be a class forwarding most
felipepiovezan wrote:
This was reviewed and approved in
https://github.com/llvm/llvm-project/pull/132734
But, in order to preserve the small commits, I'm merging through separate PRs.
https://github.com/llvm/llvm-project/pull/132905
___
lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2025-03-25T06:50:52-03:00
New Revision: 65ad02b882ba545dafbfc195a78e204c218e93ed
URL:
https://github.com/llvm/llvm-project/commit/65ad02b882ba545dafbfc195a78e204c218e93ed
DIFF:
https://github.com/llvm/llvm-project/commit/65ad02b882ba545dafbfc195a78e204c2
Author: Felipe de Azevedo Piovezan
Date: 2025-03-25T06:52:07-03:00
New Revision: 07c82b1622de1c5c4329ffb769bef7fef1b07429
URL:
https://github.com/llvm/llvm-project/commit/07c82b1622de1c5c4329ffb769bef7fef1b07429
DIFF:
https://github.com/llvm/llvm-project/commit/07c82b1622de1c5c4329ffb769bef7fef
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
This was reviewed and approved in
https://github.com/llvm/llvm-project/pull/132734
But, in order to preserve the small commits, I'm merging through separate PRs.
https://github.com/llvm/llvm-project/pull/132906
___
lldb-commits m
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This commit makes ThreadMemory a real "forwarder" class by implementing the
missing queue methods: they will just call the corresponding backing thread
method.
To make this patch NFC(*)
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132906
This commit makes ThreadMemory a real "forwarder" class by implementing the
missing queue methods: they will just call the corresponding backing thread
method.
To make this patch NFC(*) and not change t
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/132910
These weren't rendering properly (mostly mis-use the syntax for commenting
member variables).
>From f50582268aca77a5f5c807b7a03e5ea20c67bcb6 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 25 Mar 202
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
These weren't rendering properly (mostly mis-use the syntax for commenting
member variables).
---
Full diff: https://github.com/llvm/llvm-project/pull/132910.diff
8 Files Affected:
- (modified) lldb/inc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
The regex we use to find the compiler-rt library is already Darwin-specific, so
no need to run this on non-Darwin platforms.
---
Full diff: https://github.com/llvm/llvm-project/pull/132911.diff
1 Files A
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/132911
The regex we use to find the compiler-rt library is already Darwin-specific, so
no need to run this on non-Darwin platforms.
>From 219355ada6f01f2c5e1a0654a2dc6231e70340ad Mon Sep 17 00:00:00 2001
From: Mich
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/11] [LLDB][Telemetry] Collect telemetry from client when
allowed.
slydiman wrote:
@bulbazord
> swiftlang#3240
Looks good.
> SwiftLanguageRuntime::MethodName::Parse(). Specifically, as it parses a name,
> there are some codepaths that cause it to think some names are valid swift
> method names.
It seems one solution might be to sort language plugins.
But
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/132688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
This seems ok to me. I think a good follow-up might be to stop handing out row
pointers in case somebody tries to store one in the future. The pointers won't
be stable as the vector resizes, but rows in unique_ptrs seems like a poor use
@@ -77,6 +77,27 @@ enum class PacketStatus {
enum class ReplMode { Variable = 0, Command, Auto };
+class Gotos {
+public:
+ /// \return the line_entry corresponding with \p id
+ ///
+ /// If \p id is invalid std::nullopt is returned.
+ std::optional GetLineEntry(uint64_t
slydiman wrote:
> I'm similarly confused about how moving these method definitions into a
> separate CU makes a difference.
Please note Module.cpp uses only few functions which have no dependencies.
After this patch the new CU CPlusPlusLanguageMethod.cpp with only necessary
functions is linke
slydiman wrote:
Note `-ffunction-sections -fdata-sections` are added in HandleLLVMOptions.cmake
and `-Wl,--gc-sections` is added in AddLLVM.cmake by default. But unused
functions will be kept anyway if they contain linker gc roots.
A lot of functions in CPlusPlusLanguage.cpp contain static va
Author: Jan Svoboda
Date: 2025-03-25T12:29:08-07:00
New Revision: bdbad3e4320509f632ae8b511d563136343d87d7
URL:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7
DIFF:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7.diff
L
real-mikhail wrote:
Thanks folks. I agree that approach with the option is the best (will see what
looks better, something like `target.process.expressions-flush-memory-cache` or
flag in `SBExpressionOptions`). Since this flag will affect very low-level code
maybe global flag (in `target.proce
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/130503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/133007
>From b6850bfee90229c8da5ffa5359023c682b574954 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 25 Mar 2025 14:58:03 -0700
Subject: [PATCH] [lldb-dap] Migrating DAP 'initialize' to new typed
RequestHandle
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/13] [LLDB][Telemetry] Collect telemetry from client when
allowed.
@@ -962,28 +962,43 @@ llvm::json::Value CreateThreadStopped(DAP &dap,
lldb::SBThread &thread,
body.try_emplace("reason", "step");
break;
case lldb::eStopReasonBreakpoint: {
-ExceptionBreakpoint *exc_bp = dap.GetExceptionBPFromStopReason(thread);
+const auto *
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/14] [LLDB][Telemetry] Collect telemetry from client when
allowed.
wizardengineer wrote:
This is taking longer than expected, I'm encountering a lot of linker bugs
unrelated the patches I've made. Even after create a fresh clone of llvm
without the patches. I'm still encountering issues.
One them being
https://github.com/llvm/llvm-project/issues/132845#issu
bulbazord wrote:
I'm similarly confused about how moving these method definitions into a
separate CU makes a difference. +1 to Jonas's suggestion, properly refactoring
Module to use language plugins.
For reference, I attempted this a few years ago (albeit on Apple's swift fork)
and had troubl
felipepiovezan wrote:
Should this also change the interface of DWAFExpressionList?
```
DWARFExpressionList(lldb::ModuleSP module_sp,
const plugin::dwarf::DWARFUnit *dwarf_cu,
lldb::addr_t func_file_addr)
: m_module_wp(module_sp), m_dwarf_cu(dwa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 01/12] [LLDB][Telemetry] Collect telemetry from client when
allowed.
oontvoo wrote:
> I'm not really sure what to think about this. You call it "client telemetry",
> which sounds generic, but the implementation (mainly, the "request" field)
> sounds very specific to lldb-dap (not every lldb "client" needs to have a
> "request", or even if it has, the term "requ
felipepiovezan wrote:
This type of patch also slightly worries me in that it could make it harder to
unify the LLDB dwarf data structures with the LLVM ones
https://github.com/llvm/llvm-project/pull/131645
___
lldb-commits mailing list
lldb-commits@li
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This adds new types and helpers to support the 'initialize' request with the
new typed RequestHandler. While working on this I found there were a few cases
where we incorrectly treated initialize arguments as
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/131404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,10 +61,17 @@ void LinuxSignals::Reset() {
AddSignal(5, "SIGTRAP", true, true, true, "trace trap (not
reset when caught)");
AddSignal(6, "SIGABRT", false,true, true, "abort()/IOT
trap", "SIGIOT");
- AddSignal(7, "SIGBUS",
Author: jimingham
Date: 2025-03-25T09:56:58-07:00
New Revision: 870463519bab45acf8590d41d9f2a161c37f26d5
URL:
https://github.com/llvm/llvm-project/commit/870463519bab45acf8590d41d9f2a161c37f26d5
DIFF:
https://github.com/llvm/llvm-project/commit/870463519bab45acf8590d41d9f2a161c37f26d5.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/132846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> MIPS changed the SIGBUS signal number to be the same as other architectures.
But your change appears to use different numbers for MIPS, which looks like the
opposite.
Also please cite in the PR description the changes in the Linux Kernel that did
this.
Also I'm pretty
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/132911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-03-25T15:50:20Z
New Revision: 1bb755fdcd61695c748d925ee756fc3cba4f15ae
URL:
https://github.com/llvm/llvm-project/commit/1bb755fdcd61695c748d925ee756fc3cba4f15ae
DIFF:
https://github.com/llvm/llvm-project/commit/1bb755fdcd61695c748d925ee756fc3cba4f15ae.diff
LOG:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/7] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/8] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/9] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
@@ -119,6 +125,53 @@ llvm::Error TelemetryManager::preDispatch(TelemetryInfo
*entry) {
return llvm::Error::success();
}
+void TelemetryManager::DispatchClientTelemetry(
+const lldb_private::StructuredDataImpl &entry, Debugger *debugger) {
+ if (!m_config->enable_client
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/6] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
@@ -0,0 +1,165 @@
+//===-- GoToTargetsRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: David Peixotto
Date: 2025-03-19T08:17:59-07:00
New Revision: 58027fa989391451d7eaa21fe24c135bcad52e79
URL:
https://github.com/llvm/llvm-project/commit/58027fa989391451d7eaa21fe24c135bcad52e79
DIFF:
https://github.com/llvm/llvm-project/commit/58027fa989391451d7eaa21fe24c135bcad52e79.diff
@@ -40,6 +35,31 @@ class DWARFUnit;
/// location expression or a location list and interprets it.
class DWARFExpression {
public:
+ class Delegate {
+ public:
+Delegate() = default;
+virtual ~Delegate() = default;
+
+virtual uint16_t GetVersion() const = 0;
+v
@@ -19,7 +19,9 @@
#include
#include
#include
+#ifndef _AIX
#include
+#endif
labath wrote:
Let's try deleting this. AFAICT, the file does not actually depend on the
header (anymore).
```suggestion
```
https://github.com/llvm/llvm-project/pull/132718
___
slydiman wrote:
@labath What do you suggest for a solution? Reducing lldb-server size from 17MB
to 8MB is the significant reason to do something.
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
labath wrote:
https://github.com/llvm/llvm-project/pull/132274#issuecomment-2742168197
https://github.com/llvm/llvm-project/pull/132274#issuecomment-2743008635
https://github.com/llvm/llvm-project/issues/129543#issuecomment-2728697037
https://github.com/llvm/llvm-project/pull/132274
__
@@ -19,7 +19,9 @@
#include
#include
#include
+#ifndef _AIX
#include
+#endif
DhruvSrivastavaX wrote:
Done, checked compilation on linux as well.
https://github.com/llvm/llvm-project/pull/132718
___
lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/132718
>From c6392f75d270467300c5cf6cdbcfae088d1e48eb Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 24 Mar 2025 06:44:24 -0500
Subject: [PATCH 1/2] Minor AIX specific changes
---
lldb/source/Hos
felipepiovezan wrote:
In order to preserve the two separate commits (and not squash them) I've merged
this into two separate PRs:
https://github.com/llvm/llvm-project/pull/132905
https://github.com/llvm/llvm-project/pull/132906
So I'll close this now.
https://github.com/llvm/llvm-project/pull/
https://github.com/dfukalov closed
https://github.com/llvm/llvm-project/pull/106810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
62 matches
Mail list logo
