https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/7] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
https://github.com/dmpots updated
https://github.com/llvm/llvm-project/pull/132053
>From efde68cf06da2f668f4d2ecd638b826c7f4c5b70 Mon Sep 17 00:00:00 2001
From: David Peixotto
Date: Wed, 19 Mar 2025 08:44:59 -0700
Subject: [PATCH 1/3] [lldb] Change test paths to resolve symlinks
This commit mo
https://github.com/dmpots edited
https://github.com/llvm/llvm-project/pull/132053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/132255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
> Anyway, what I had in mind when I read your RFC and was doing the
> RequestHandler work, triggered by a question from @labath, is that instead of
> having one RequestHandler instance per command (which is what we have today),
> we could instantiate a RequestHandler per incoming
dmpots wrote:
> Resolving the symlink is not the right thing to do in some cases (such as
> when you symlinks define the actual/expected layout of the directory tree and
> the real paths are meaningless (e.g. nodes in some CAS storage). I would very
> much like to see solution that applies the
Author: Jason Molenda
Date: 2025-03-20T13:32:52-07:00
New Revision: ad5cac3b06c3cb41397acc1fc96beae9b460f20c
URL:
https://github.com/llvm/llvm-project/commit/ad5cac3b06c3cb41397acc1fc96beae9b460f20c
DIFF:
https://github.com/llvm/llvm-project/commit/ad5cac3b06c3cb41397acc1fc96beae9b460f20c.diff
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
JDevlieghere wrote:
I'm not sure I can work around this with the version of SWIG installed on the
bots. I've created an RFC about bumping the SWIG version:
https://discourse.llvm.org/t/rfc-bumping-the-minimum-swig-version-to-4-1-0/85377
https://github.com/llvm/llvm-project/pull/131404
__
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/132280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building
`clang-tools-extra,clang,lldb` at step 7 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/30/builds/180
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
@@ -142,6 +142,13 @@ class MinidumpFileBuilder {
lldb_private::Status AddDirectory(llvm::minidump::StreamType type,
uint64_t stream_size);
lldb::offset_t GetCurrentDataEndOffset() const;
+
+ // Read a memory region from the process and w
JDevlieghere wrote:
> My logic behind the `lldb_dap::protocol` types was to keep them as POD data
> and to not have much (if any) logic in them so that if we need to move the
> data between threads or queues we can be relatively confident that we're not
> dealing data races. In swift terms (I'
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/132128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/132255
The `DAPError` can be used to craft an error message that is displayed to a
user (with showUser=true).
Any request handler implementation using subclassing `RequestHandler<>` should
be able to use this.
I upda
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
The `DAPError` can be used to craft an error message that is displayed to a
user (with showUser=true).
Any request handler implementation using subclassing `RequestHandler<>`
should be able to use this.
I u
@@ -96,7 +115,7 @@ Expected> Transport::Read() {
return createStringError(
formatv("invalid content length {0}", *raw_length).str());
- Expected raw_json = ReadFull(*input, length);
ashgti wrote:
> I don't know if this helps you (since you still
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/132255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/7] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
@@ -0,0 +1,55 @@
+//===-- CancelRequestHandler.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,55 @@
+//===-- CancelRequestHandler.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -777,28 +798,134 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) {
return ToError(error);
}
+template
+static std::optional getArgumentsIfRequest(const protocol::Message &pm,
+ llvm::StringLiteral command) {
+ auto *co
https://github.com/JDevlieghere commented:
(looks like I didn't submit my comments yesterday)
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
cmtice wrote:
I've fixed all the style/format requests.
I ran into some difficulties with the structured error handling requests:
- DiagnosticError has only one constructor, which only takes an error code. On
examning how it's called/used in other places, it doesn't look like it's
designed to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 17b4be8f63a9a2c17290c8540d84f17a370b1915
223d85c6b2f5509f704d598bae974a98e5bf6bcb --e
@@ -0,0 +1,147 @@
+//===-- WriteMemoryRequestHandler.cpp
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,118 @@
+//===-- GoToRequestHandler.cpp --===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
vogelsgesang wrote:
Good point.
Currently, we are usi
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
da-viper wrote:
are the protocol types meant to follow
@@ -0,0 +1,11 @@
+%extend lldb::SBLock {
+#ifdef SWIGPYTHON
+%pythoncode %{
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+self.Unlock()
JDevlieghere wrote:
Can you think of a
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131519
>From ea0a08e60f472c518c98db0acf7e32ec328146d1 Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Sun, 16 Mar 2025 14:08:57 +
Subject: [PATCH] [lldb] Use correct path for lldb-server executab
@@ -0,0 +1,46 @@
+//===-- SBLock.h
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/132043
>From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Mar 2025 10:44:12 -0400
Subject: [PATCH 1/6] Reapply "[LLDB][Telemetry]Define TargetInfo for
collecting data
https://github.com/kastiglione approved this pull request.
https://github.com/llvm/llvm-project/pull/132127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Resolving the symlink is not the right thing to do in some cases (such as when
you symlinks define the actual/expected layout of the directory tree and the
real paths are meaningless (e.g. nodes in some CAS storage). I would very much
like to see solution that applies the fixes l
@@ -0,0 +1,273 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,104 @@
+//===-- DILParser.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,273 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath commented:
Okay, at this I don't think I have any more comments about functionality. The
remaining comments are either stylistic (which should be self-explanatory) or
about error handling (which I'm going to write about here).
For the error handling, I missed the fact
@@ -0,0 +1,248 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,273 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,104 @@
+//===-- DILParser.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,31 @@
+"""
+Make sure 'frame var' using DIL parser/evaultor works for local variables.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test import lldbutil
+
+import os
+import shutil
+import time
+
+
+
@@ -0,0 +1,273 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,29 @@
+"""
+Make sure 'frame var' using DIL parser/evaultor works for local variables.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test import lldbutil
+
+import os
+import shutil
+import time
+
+
+
yuvald-sweet-security wrote:
> Not exactly. I my use case, `lldb-server` would be a symlink to something
> like `/cas/dead/beef/baadf00d`. The symlink value is supposed to be an
> implementation detail of the CAS system. While the user could execute that
> directly, it wouldn't be totally surp
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/132193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/132193
…errors when reading exception data
We've been dealing with UBSAN issues around this code for some time now (see
`9c36859b33b386fbfa9599646de1e2ae01158180` and
`1a2122e9e9d1d495fdf337a4a9445b61ca56df6f`). O
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/132193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
vogelsgesang wrote:
please rebase on `main`, and make
https://github.com/labath commented:
I think there's a race in the cancellation handling:
1. request handling thread sets active_seq (but doesn't start executing the
request yet)
2. cancellation request comes in, queue_reader sets the interrupt flag
3. request handling thread begins handling the
@@ -0,0 +1,51 @@
+"""
+Make sure 'frame var' using DIL parser/evaultor works for local variables.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test import lldbutil
+
+import os
+import shutil
+import time
+
+
+
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/132128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/129262
>From 7ab3d3ac41e3aadda9c96dc5c5ea2551be7113c4 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Fri, 28 Feb 2025 11:08:25 -0500
Subject: [PATCH 01/13] allow providing debug adapter arguments
---
lld
@@ -0,0 +1,11 @@
+%extend lldb::SBLock {
+#ifdef SWIGPYTHON
+%pythoncode %{
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+self.Unlock()
vogelsgesang wrote:
Sounds good. If we
@@ -0,0 +1,103 @@
+import * as vscode from "vscode";
+import * as child_process from "child_process";
+import * as util from "util";
+import { LLDBDapServer } from "./lldb-dap-server";
+import { createDebugAdapterExecutable } from "./debug-adapter-factory";
+import { ConfigureButt
@@ -1594,6 +1594,10 @@ static uint64_t bits(uint64_t value, uint32_t msbit,
uint32_t lsbit) {
m_sent_interrupt_signo);
}
} else {
+ // We've requested that the process stop anew; if we had recorded this
+ // requested stop as being
ashgti wrote:
> If we want to support cancellation before moving all the request over to the
> protocol class, can we _temporarily_ store both the JSON and the Protocol in
> the class we instantiate per request (whether that's the RequestHandler
> itself, or a class wrapping it) and use whiche
@@ -90,117 +99,119 @@ async function getDAPExecutable(
return foundPath;
}
- return undefined;
+ throw new ErrorWithNotification(
+"Unable to find the path to the LLDB debug adapter executable.",
+new OpenSettingsButton("lldb-dap.executable-path"),
+ );
}
-
@@ -0,0 +1,33 @@
+//===-- DAPError.h
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/132127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-03-20T09:18:40+01:00
New Revision: b3b5527baaeceb923e9bb698f52883a1506f1b25
URL:
https://github.com/llvm/llvm-project/commit/b3b5527baaeceb923e9bb698f52883a1506f1b25
DIFF:
https://github.com/llvm/llvm-project/commit/b3b5527baaeceb923e9bb698f52883a1506f1b25.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/131388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
yuvald-sweet-security wrote:
> > Ah, turns out there's a HostInfo::GetProgramFileSpec() function which
> > solves both these issues.
>
> I am aware of that function. The reason I did not suggest it is because
> `GetProgramFileSpec` (on linux) returns the canonical path (with all symlinks
> re
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/131293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > > Ah, turns out there's a HostInfo::GetProgramFileSpec() function which
> > > solves both these issues.
> >
> >
> > I am aware of that function. The reason I did not suggest it is because
> > `GetProgramFileSpec` (on linux) returns the canonical path (with all
> > symlinks
@@ -1692,6 +1692,21 @@ class Target : public
std::enable_shared_from_this,
}
};
+/// The private implementation backing SBLock.
+class APILock {
+public:
+ APILock(std::shared_ptr mutex_sp)
+ : m_mutex(std::move(mutex_sp)), m_lock(*m_mutex) {}
+
+ void Unlock() { m_l
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/131404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> So having a way to indicate you need the faster vrs. the more bullet-proof
> behavior might be an acceptable solution. You might even argue that the
> setting should be "bullet-proof behavior" by default. If you are shipping a
> data formatter that benefits from this setting, y
@@ -0,0 +1,273 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,46 @@
+//===-- SBLock.h
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,11 @@
+%extend lldb::SBLock {
+#ifdef SWIGPYTHON
+%pythoncode %{
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+self.Unlock()
vogelsgesang wrote:
It's a bit unfortu
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
vogelsgesang wrote:
@da-viper for your Pull Request, I
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
labath wrote:
> > Kind of yes, but the two issues are related. The issue with symlinks is
> > that once you resolve them, there's no way to go back. I'm asking why (in
> > the scenario you describe in that PR) does
> > `GetModuleFileSpecForHostAddress` return "lldb-server-19" (instead of
> >
Michael137 wrote:
> > Essentially you're suggesting going back to pre-#90663, but only if we have
> > ObjC/ObjC++ CUs in the current module? Seems sensible to me. Will also help
> > prevent similar issues from creeping up in the future
>
> Yes, I think that is the best approach do to do defini
labath wrote:
I was imagining storing this in the ClangASTMetadata class (that's where the
forceful completion bit is)?
I don't know if it can be done without increasing the class size, but I guess
that doesn't matter for the purpose of determining feasibility.
https://github.com/llvm/llvm-pr
@@ -96,7 +115,7 @@ Expected> Transport::Read() {
return createStringError(
formatv("invalid content length {0}", *raw_length).str());
- Expected raw_json = ReadFull(*input, length);
labath wrote:
> Closing a file descriptor does not interrupt in
yuvald-sweet-security wrote:
> Kind of yes, but the two issues are related. The issue with symlinks is that
> once you resolve them, there's no way to go back. I'm asking why (in the
> scenario you describe in that PR) does `GetModuleFileSpecForHostAddress`
> return "lldb-server-19" (instead o
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
> Okay, at this I don't think I have any more comments about functionality. The
> remaining comments are either stylistic (which should be self-explanatory) or
> about error handling (which I'm going to write about here).
>
> For the error handling, I missed the fact that your ne
yuvald-sweet-security wrote:
I wrote something, lets see if it works
>Process(Launch)Info has a [GS]etArg0 method, but it looks like
>ProcessLauncherPosixFork doesn't actually make use of it
It looks like nothing makes use of it except for the qemu launcher; the posix
launcher just uses the f
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127661
>From 22c489dbd334fb84b8d81deac8e7e6c5590fc6d9 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 18 Feb 2025 16:14:30 +0100
Subject: [PATCH 1/2] [lldb] s/ValidRange/ValidRanges in UnwindPlan
To be able to d
@@ -0,0 +1,165 @@
+//===-- GoToTargetsRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
labath wrote:
It's close, but it's not the same thing. Notice your arrow points into the
error message:
```
(lldb) v externGlobalVar
error: externGlobalVar
˄
╰─ error: use of undeclared identifier 'externGlobalVar'
```
While for `expr`, it points directly into the command:
```
(ll
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/131597
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-03-20T16:01:24+01:00
New Revision: fdeb2ff30407afbfc3596aaf417a2a91cdff20c9
URL:
https://github.com/llvm/llvm-project/commit/fdeb2ff30407afbfc3596aaf417a2a91cdff20c9
DIFF:
https://github.com/llvm/llvm-project/commit/fdeb2ff30407afbfc3596aaf417a2a91cdff20c9.diff
https://github.com/yuvald-sweet-security updated
https://github.com/llvm/llvm-project/pull/131519
>From ea0a08e60f472c518c98db0acf7e32ec328146d1 Mon Sep 17 00:00:00 2001
From: Yuval Deutscher
Date: Sun, 16 Mar 2025 14:08:57 +
Subject: [PATCH 1/2] [lldb] Use correct path for lldb-server exec
erichkeane wrote:
Clang stuff is unchanged, correct? If so I'm fine when the LLDB folks are
happy.
https://github.com/llvm/llvm-project/pull/132234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::String
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/130503
>From 7bad765585b2ae96faf2d2558b099f4b965d2791 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 9 Mar 2025 12:46:54 +
Subject: [PATCH 01/21] [lldb-dap] implement jump to cursor.
---
lldb/cmake/module
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131404
>From ab4700b007becba1dfe63310bbb2a627214b6a60 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 19 Mar 2025 10:39:50 -0700
Subject: [PATCH 1/2] [lldb] Expose the Target API lock through the SB AP
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
We've been dealing with UBSAN issues around this code for some time now (see
`9c36859b33b386fbfa9599646de1e2ae01158180` and
`1a2122e9e9d1d495fdf337a4a9445b61ca56df6f`). On recent macOS versions, a
UBSAN-e
@@ -113,6 +113,20 @@ class ExceptionInfoRequestHandler : public RequestHandler {
void operator()(const llvm::json::Object &request) const override;
};
+class GoToRequestHandler : public RequestHandler {
da-viper wrote:
There is an issue with the way to new
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/132193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,11 @@
+%extend lldb::SBLock {
+#ifdef SWIGPYTHON
+%pythoncode %{
+def __enter__(self):
+return self
+
+def __exit__(self, exc_type, exc_value, traceback):
+self.Unlock()
JDevlieghere wrote:
What I can make wo
1 - 100 of 108 matches
Mail list logo
