[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: In any case, I think it might be useful to remand the patch once, so we can inspect the failure log on the bot, since the bot logs have been recycled since the last time this landed. https://github.com/llvm/llvm-project/pull/123945 _

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-02-20 Thread Dhruv Srivastava via lldb-commits
@@ -8,3 +8,4 @@ add_subdirectory(OpenBSD) add_subdirectory(POSIX) add_subdirectory(QemuUser) add_subdirectory(Windows) +add_subdirectory(AIX) DhruvSrivastavaX wrote: Yeay! 🙂 https://github.com/llvm/llvm-project/pull/121273 ___

[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-02-20 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,193 @@ +//===-- PlatformAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-02-20 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,72 @@ +//===-- PlatformAIX.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-02-20 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,193 @@ +//===-- PlatformAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/127961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
https://github.com/foxtran updated https://github.com/llvm/llvm-project/pull/127974 >From d36ed841386fbc0662d120eefca076df16bdd880 Mon Sep 17 00:00:00 2001 From: "Igor S. Gerasimov" Date: Thu, 20 Feb 2025 10:04:13 +0100 Subject: [PATCH] Fix GCC's -Wreturn-type warning --- lldb/source/DataForm

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: The default clause prevents the "uncovered enumerator" from firing is a new value is added to the enum (and it's actually against the [coding standards](https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumer

[Lldb-commits] [lldb] [lldb] Renaissance LineTable sequences (PR #127800)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/127800 >From b82a233736efc391aaa408513cbea257871ab7b5 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 19 Feb 2025 15:03:40 +0100 Subject: [PATCH] [lldb] Renaissance LineTable sequences LineSeqeunce is basically

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self): ) self.match("register read s31", ["s31 = 128"]) +@skipIfXmlSupportMissing +@skipIfRemote +@skipIfLLVMTargetMissing("RISCV") +def test_riscv64_regs(self): +"""Test grabbing various riscv64 regi

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Address the two new comments and this'll be good to go. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,37 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
https://github.com/foxtran updated https://github.com/llvm/llvm-project/pull/127974 >From d36ed841386fbc0662d120eefca076df16bdd880 Mon Sep 17 00:00:00 2001 From: "Igor S. Gerasimov" Date: Thu, 20 Feb 2025 10:04:13 +0100 Subject: [PATCH 1/2] Fix GCC's -Wreturn-type warning --- lldb/source/Data

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Pavel Labath via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Pavel Labath via lldb-commits
labath wrote: > I'm trying to figure out how to get that linked only when tests are running > and not to the LLDB binary all the time. I don't think you can do that without building another lldb binary. We actually have something like that in the form of the [lldb-test binary](https://github

[Lldb-commits] [lldb] [lldb] Store the return SBValueList in the CommandReturnObject (PR #127566)

2025-02-20 Thread Pavel Labath via lldb-commits
labath wrote: > > That sort of makes sense, but it doesn't sound like you're planning to do > > that soon, so I'm asking about what should we do until (and if) that > > happens. The reason I suggested stderr is because that made sense for the > > commands I'm thinking of. For example, the expr

[Lldb-commits] [lldb] 2c022e3 - [lldb] Replace LineTable::upper_bound with GetLineEntryIndexRange (#127806)

2025-02-20 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-20T10:17:44+01:00 New Revision: 2c022e3617ec9bab3c9ab17464610843563ed9ed URL: https://github.com/llvm/llvm-project/commit/2c022e3617ec9bab3c9ab17464610843563ed9ed DIFF: https://github.com/llvm/llvm-project/commit/2c022e3617ec9bab3c9ab17464610843563ed9ed.diff

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread Michael Buch via lldb-commits
@@ -58,6 +58,8 @@ std::string TypeSummaryImpl::GetSummaryKindName() { return "c++"; case Kind::eBytecode: return "bytecode"; + case default: +return "unknown"; Michael137 wrote: this (and the other case) should probably be `__llvm_unreachable()`

[Lldb-commits] [lldb] [lldb] Replace LineTable::upper_bound with GetLineEntryIndexRange (PR #127806)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/127806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
https://github.com/foxtran edited https://github.com/llvm/llvm-project/pull/127974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e264317 - [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (#127059)

2025-02-20 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-20T10:25:59+01:00 New Revision: e264317b45163f5c3ba7fc5375dcdecd827fce95 URL: https://github.com/llvm/llvm-project/commit/e264317b45163f5c3ba7fc5375dcdecd827fce95 DIFF: https://github.com/llvm/llvm-project/commit/e264317b45163f5c3ba7fc5375dcdecd827fce95.diff

[Lldb-commits] [lldb] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (PR #127059)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/127059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
https://github.com/foxtran updated https://github.com/llvm/llvm-project/pull/127974 >From c51a54691108320a41037c12473ad2b5c2a7be34 Mon Sep 17 00:00:00 2001 From: "Igor S. Gerasimov" Date: Thu, 20 Feb 2025 10:04:13 +0100 Subject: [PATCH] Fix GCC's -Wreturn-type warning --- lldb/source/DataForm

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
@@ -58,6 +58,8 @@ std::string TypeSummaryImpl::GetSummaryKindName() { return "c++"; case Kind::eBytecode: return "bytecode"; + case default: +return "unknown"; foxtran wrote: Wow! Thank you! It is much better :-) https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 5ecce45ea2980aff35d1283d4dd3feb8f74de16c...02dcf893c3b777acc3b5989c421fda0df3596bba lldb/

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > greendragon probably does build debugserver, but tests use Xcode's > debugserver for proper codesigning, not the built debugserver. Are you sure? My recollection is that we went out of our way to make code signing work on those bots. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [llvm] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-20 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/124059 >From f404df6b2ac7b7ab33e3baadd3830154904a Mon Sep 17 00:00:00 2001 From: Ray Wang Date: Thu, 23 Jan 2025 12:13:32 +0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-

[Lldb-commits] [lldb] [llvm] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-20 Thread via lldb-commits
@@ -0,0 +1,35 @@ +int main() { + asm volatile("li.w $r1, 1\n\t" wangleiat wrote: Thanks. https://github.com/llvm/llvm-project/pull/124059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/9] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +

[Lldb-commits] [lldb] 89e80ab - [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo`

2025-02-20 Thread via lldb-commits
Author: wanglei Date: 2025-02-21T10:59:27+08:00 New Revision: 89e80abbc58b5d92f3a0eaa393a0b095aac11ec2 URL: https://github.com/llvm/llvm-project/commit/89e80abbc58b5d92f3a0eaa393a0b095aac11ec2 DIFF: https://github.com/llvm/llvm-project/commit/89e80abbc58b5d92f3a0eaa393a0b095aac11ec2.diff LOG:

[Lldb-commits] [lldb] [llvm] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-20 Thread via lldb-commits
https://github.com/wangleiat closed https://github.com/llvm/llvm-project/pull/124059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/8] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread via lldb-commits
@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData if len(self.threads) == 2: self.threads[len(self.threads) - 1].is_stopped = True -corefile_module = self.get_module_with_name( -self.co

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread via lldb-commits
@@ -165,7 +165,7 @@ Status ScriptedProcess::DoLoadCore() { Status ScriptedProcess::DoLaunch(Module *exe_module, ProcessLaunchInfo &launch_info) { LLDB_LOGF(GetLog(LLDBLog::Process), "ScriptedProcess::%s launching process", __FUNCTION__); -

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread via lldb-commits
@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData if len(self.threads) == 2: self.threads[len(self.threads) - 1].is_stopped = True -corefile_module = self.get_module_with_name( -self.co

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread Med Ismail Bennani via lldb-commits
@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData if len(self.threads) == 2: self.threads[len(self.threads) - 1].is_stopped = True -corefile_module = self.get_module_with_name( -self.co

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/127974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/127696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
oontvoo wrote: > However, it's use tends to be somewhat cumbersome because you have to write > some code do something, and then also drive that code from the command line. > I would recommend trying to test as much as possible via the unit tests > (which are basically can do anything that lld

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread via lldb-commits
https://github.com/kper edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Pavel Labath via lldb-commits
labath wrote: @adrian-prantl, any chance you or someone could take a look at this? The problem really appears to be specific to that buildbot (my guess: something about the debugserver version on that bot), as I've run the tests locally both with arm64 and x86_64-via-rosetta, both with the sys

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread via lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self): ) self.match("register read s31", ["s31 = 128"]) +@skipIfXmlSupportMissing +@skipIfRemote +@skipIfLLVMTargetMissing("RISCV") +def test_riscv64_regs(self): +"""Test grabbing various riscv64 regi

[Lldb-commits] [lldb] [lldb] Fixing edge cases in "source list" (PR #126526)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/126526 >From fda9035cddce78e2109462c9cec176bcb96392d8 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 10 Feb 2025 15:20:05 +0100 Subject: [PATCH 1/3] [lldb] Fixing edge cases in "command source" While looking at

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,141 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [lldb] Fixing edge cases in "source list" (PR #126526)

2025-02-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d7784a649e80d346ba57ccc39f5e2a3e2f7e0a51 27d7bedee0de54abb9ec900c4d21eff6a8e7084a --e

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM thanks for fixing this and doing all the leg work to verify it. I will merge once the CI passes, or anyone else can if they have the rights to. https://github.com/llvm/llvm-project/pull/124475

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Well, those BOLT failures are unrelated. So if Windows shows the same ones, this can be merged. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread via lldb-commits
kper wrote: @DavidSpickett thank you for your patience with me :) https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Np. Strangely no BOLT failures on Windows perhaps it doesn't run there, one other lld test but unrelated to this. https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c48e0c1 - [lldb][RISC-V] Extended if conditions to support alias names for registers (#124475)

2025-02-20 Thread via lldb-commits
Author: kper Date: 2025-02-20T16:23:53Z New Revision: c48e0c182c5a9e19062677cbca17c89ea586e033 URL: https://github.com/llvm/llvm-project/commit/c48e0c182c5a9e19062677cbca17c89ea586e033 DIFF: https://github.com/llvm/llvm-project/commit/c48e0c182c5a9e19062677cbca17c89ea586e033.diff LOG: [lldb][R

[Lldb-commits] [lldb] 81bc28d - [lldb] Update PlatformDarwin list of libraries with thread functions (#127922)

2025-02-20 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-02-20T08:26:47-08:00 New Revision: 81bc28d0bcaca3e7386ced2138566e4d0a838ad5 URL: https://github.com/llvm/llvm-project/commit/81bc28d0bcaca3e7386ced2138566e4d0a838ad5 DIFF: https://github.com/llvm/llvm-project/commit/81bc28d0bcaca3e7386ced2138566e4d0

[Lldb-commits] [lldb] [lldb] Update PlatformDarwin list of libraries with thread functions (PR #127922)

2025-02-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/127922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread via lldb-commits
rchamala wrote: @jimingham @medismailben Can you please let me know if you have more questions regarding the problem and solution ? Right now, I have conditionally ignored the modules which are not created and only loaded the successful ones, if needed I can always load the successfully create

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread via lldb-commits
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475 >From 4feaf723ff8f879bd82bb82108d9e6bac4b90026 Mon Sep 17 00:00:00 2001 From: Kevin Per Date: Sun, 26 Jan 2025 17:34:17 + Subject: [PATCH] [lldb] Extended if conditions to support alias names for registers ---

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/127961 >From d8c91ab0d401384f2724a8c2c67c12e9c9446af7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 19 Feb 2025 21:24:29 -0800 Subject: [PATCH 1/2] [lldb] Store StreamAsynchronousIO in a unique_ptr (

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread Jacob Lalonde via lldb-commits
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) { done = true; } } else { -uint64_t progress_id = 0; -uint64_t completed = 0; -uint64_t total = 0; -bool is_debugger_specific = false; -const char *m

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/7] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] [llvm] [lldb][RISC-V] Extended if conditions to support alias names for registers (PR #124475)

2025-02-20 Thread David Spickett via lldb-commits
@@ -0,0 +1,141 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: ra = 0x1 +# CHECK-DAG: sp = 0x2 +# CHECK-DAG: gp = 0x3 +# CHECK-DAG: tp =

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
@@ -58,12 +58,13 @@ const char DEV_NULL[] = "/dev/null"; namespace lldb_dap { -DAP::DAP(llvm::StringRef path, std::ofstream *log, ReplMode repl_mode, - StreamDescriptor input, StreamDescriptor output) -: debug_adaptor_path(path), log(log), input(std::move(input)),

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/127974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/7] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/127829 >From 1aabc8a93ffac06755cbaf5e6c1fa8913cd63729 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 19 Feb 2025 12:47:30 + Subject: [PATCH 1/3] [lldb][TypeSystemClang] Create MainFileID for TypeSystemC

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1c6cecdbdd2470292ce0b508922d807e3100f85c a05a2ca8f8bcf3fb9017d54248fbd32b2e4797b3 --e

[Lldb-commits] [lldb] 78d82d3 - [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (#127961)

2025-02-20 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-20T11:13:46-08:00 New Revision: 78d82d3ae7ac99833e1b9c0b529c256f90b6c6cc URL: https://github.com/llvm/llvm-project/commit/78d82d3ae7ac99833e1b9c0b529c256f90b6c6cc DIFF: https://github.com/llvm/llvm-project/commit/78d82d3ae7ac99833e1b9c0b529c256f90b6c6cc.d

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/127961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-20 Thread via lldb-commits
Da-Viper wrote: Is there any that needs to be done one the PR? https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: >From a quick check of the logs, green dragon seems to be set up to build >debugserver, too. https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Store the return SBValueList in the CommandReturnObject (PR #127566)

2025-02-20 Thread via lldb-commits
jimingham wrote: > On Feb 20, 2025, at 1:52 AM, Pavel Labath ***@***.***> wrote: > > > labath > left a comment > (llvm/llvm-project#127566) > That sort of makes sense, but it doesn't sound like you're planning to do > that soon, so I'm asking about what should we do until (and if) that hap

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -73,6 +147,10 @@ class TelemetryManager : public llvm::telemetry::Manager { private: std::unique_ptr m_config; + // Each debugger is assigned a unique ID (session_id). + // All TelemetryInfo entries emitted for the same debugger instance + // will get the same session_

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127696 >From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 18 Feb 2025 15:58:08 -0500 Subject: [PATCH 1/4] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related metho

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-02-20 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > From a quick check of the logs, green dragon seems to be set up to build > debugserver, too. greendragon probably does build debugserver, but tests use Xcode's debugserver for proper codesigning, not the built debugserver. https://github.com/llvm/llvm-project/pull/123945

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > @jimingham @medismailben Can you please let me know if you have more > questions regarding the problem and solution ? Right now, I have > conditionally ignored the modules which are not created and only loaded the > successful ones, if needed I can always load the success

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-02-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From e3df7eb885bc27464f6ba3cddd47147fa48f60f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement a statusline in LLDB MIME-Version: 1.0

[Lldb-commits] [lldb] 58571c8 - [lldb] Un-XFAIL TestDeadStrip.py on windows

2025-02-20 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-20T13:23:03+01:00 New Revision: 58571c82ef93b32cd0ea757e23ec4ff83f8fc3c0 URL: https://github.com/llvm/llvm-project/commit/58571c82ef93b32cd0ea757e23ec4ff83f8fc3c0 DIFF: https://github.com/llvm/llvm-project/commit/58571c82ef93b32cd0ea757e23ec4ff83f8fc3c0.diff

[Lldb-commits] [lldb] [llvm] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-20 Thread via lldb-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/124059 >From f404df6b2ac7b7ab33e3baadd3830154904a Mon Sep 17 00:00:00 2001 From: Ray Wang Date: Thu, 23 Jan 2025 12:13:32 +0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-

[Lldb-commits] [lldb] [llvm] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-20 Thread via lldb-commits
wangleiat wrote: > Please add a test like `lldb/test/Shell/Register/aarch64-gp-read.test` which > tests the normal and alias names using a live process. > > Note that the main "trick" of that test is to manually insert a breakpoint > instruction: > > ``` > asm volatile( > "ldp x0,

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. sorry for the late review, this LGTM I suggested refactoring main a bit. If you can do it, it would be great, but all good if you don't. But next time we add more stuff to main, it would be good simplify that function a bit https:

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
https://github.com/foxtran created https://github.com/llvm/llvm-project/pull/127974 This patch fixes `-Wreturn-type` warnings which happens if LLVM is built with GCC compiler (14.1 is used for detecting) Warnings: ``` llvm-project/lldb/source/ValueObject/DILLexer.cpp: In static member function

[Lldb-commits] [lldb] [lldb] Fix GCC's `-Wreturn-type` warnings (PR #127974)

2025-02-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (foxtran) Changes This patch fixes `-Wreturn-type` warnings which happens if LLVM is built with GCC compiler (14.1 is used for detecting) Warnings: ``` llvm-project/lldb/source/ValueObject/DILLexer.cpp: In static member function ‘sta

[Lldb-commits] [lldb] 367ecc6 - [lldb] Renaissance LineTable sequences (#127800)

2025-02-20 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-20T12:17:11+01:00 New Revision: 367ecc63338da1ff98d63a41bafc9b54d5c3eb6d URL: https://github.com/llvm/llvm-project/commit/367ecc63338da1ff98d63a41bafc9b54d5c3eb6d DIFF: https://github.com/llvm/llvm-project/commit/367ecc63338da1ff98d63a41bafc9b54d5c3eb6d.diff

[Lldb-commits] [lldb] [lldb] Renaissance LineTable sequences (PR #127800)

2025-02-20 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/127800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/116392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-20 Thread Walter Erquinigo via lldb-commits
@@ -4952,6 +4895,29 @@ static int DuplicateFileDescriptor(int fd) { #endif } +static llvm::Expected> +validateConnection(llvm::StringRef conn) { + auto uri = lldb_private::URI::Parse(conn); + + if (uri && (uri->scheme == "tcp" || uri->scheme == "connect" || + !u

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-20 Thread Vy Nguyen via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +