labath wrote:
This is not specific to linux. I've now figured out how to scroll the green
dragon output, and I've found
[at](https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9537/)
[least](https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9474/)
[three](h
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
labath wrote:
> That being said, if there is something we can do to this PR to make it easy
> for you (Pavel) to implement this feature, we can make those changes. Like I
> think it would be fair to change all `PeekMemory/DoPeekMemory` over a virtual
> `ReadMemory/DoReadMemory` that returns a
@@ -174,6 +177,84 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(lldb_private::ConstString name,
+
@@ -174,6 +177,84 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(lldb_private::ConstString name,
+
@@ -145,15 +148,34 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+ConstString CXXFunctionSummaryFormat::GetName() {
+ return ConstString(m_description);
+}
+
+ConstString CXXFunctionSummaryFormat::GetImplType() {
+ retu
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ virtual ConstString GetName() = 0;
+ virtual ConstString GetImplType() = 0;
Michael137 wrote:
Could we use something more descriptive for the name? My expectation fro
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -174,6 +177,84 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(lldb_private::ConstString name,
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
DavidSpickett wrote:
ping?
If there's no objections in a few days I'll just land this. Folks can fish the
Phab usernames out of the git history if they really need them.
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
l
labath wrote:
> > Just to be clear, if I'm understanding the packet we'll be getting back, we
> > have no indication that we hit the breakpoint, we only show that we are
> > stopped at an address which has a breakpoint. Current lldb stepping
> > behavior will work -- because the rule is, when
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -142,6 +164,15 @@ MinidumpFile::create(MemoryBufferRef Source) {
continue;
}
+// We treat exceptions differently here because the LLDB minidump
+// makes some assumptions about uniqueness, all the streams other than
+// exceptions are lists. But except
@@ -53,6 +53,27 @@ Expected MinidumpFile::getString(size_t Offset)
const {
return Result;
}
+Expected>
+MinidumpFile::getExceptionStreams() const {
labath wrote:
This looks like a job for an (non-fallible) input iterator returning an
`Expected`. (non-fall
https://github.com/labath commented:
If other readers can handle these kinds of minidumps, then I guess this is
fine. Like in the other patch, I think it'd be best to split out the llvm part
into its own PR.
https://github.com/llvm/llvm-project/pull/97470
__
@@ -142,6 +164,15 @@ MinidumpFile::create(MemoryBufferRef Source) {
continue;
}
+// We treat exceptions differently here because the LLDB minidump
+// makes some assumptions about uniqueness, all the streams other than
labath wrote:
I'm not
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
xusheng6 wrote:
> > > Just to be clear, if I'm understanding the packet we'll be getting back,
> > > we have no indication that we hit the breakpoint, we only show that we
> > > are stopped at an address which has a breakpoint. Current lldb stepping
> > > behavior will work -- because the rule
@@ -0,0 +1,560 @@
+//===-- DILAST.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
cmtice wrote:
> Even though you've removed the smart pointer checking function (the most
> obvious example of language-specific behavior), I'm still worried about
> whether the overall design of this code will allow you to avoid it.
>
I believe I have fixed all the code to avoid any need to to
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/104041
The only change vs. the first version of the patch is that I've made
DWARFUnit linking thread-safe/unit. This was necessary because, during the
indexing step, two skeleton units could attempt to associate themselv
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The only change vs. the first version of the patch is that I've made
DWARFUnit linking thread-safe/unit. This was necessary because, during the
indexing step, two skeleton units could attempt to associate themse
@@ -0,0 +1,158 @@
+"""
+Test lldb breakpoint with symlinks/realpath and source-map.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil, lldbplatformutil
+
+
+class BreakpointTestCase(TestBase):
+
@@ -0,0 +1,158 @@
+"""
+Test lldb breakpoint with symlinks/realpath and source-map.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil, lldbplatformutil
+
+
+class BreakpointTestCase(TestBase):
+
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
Hi @jimingham and @labath ,
Could you do a final pass and see if everything looks good? I'm hoping to
merge this today/tomorrow if possible.
Thanks,
Roy
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing li
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/103458
>From 656486aa0854db82ace6bee0639ca1d94f7b4fc5 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Tue, 13 Aug 2024 17:09:38 -0400
Subject: [PATCH] [LLDB][OSX] Add a fallback support exe directory
LL
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ virtual ConstString GetName() = 0;
+ virtual ConstString GetImplType() = 0;
Jlalond wrote:
@Michael137 I also prefer `KindName`, but there is also an existing `Kind`
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ virtual ConstString GetName() = 0;
+ virtual ConstString GetImplType() = 0;
+
Jlalond wrote:
Phew,
I 100% agree, this was getting quite messy
https://github.com/llv
@@ -174,6 +177,84 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(lldb_private::ConstString name,
+
@@ -174,6 +177,84 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(lldb_private::ConstString name,
+
mbucko wrote:
> > That being said, if there is something we can do to this PR to make it easy
> > for you (Pavel) to implement this feature, we can make those changes. Like
> > I think it would be fair to change all `PeekMemory/DoPeekMemory` over a
> > virtual `ReadMemory/DoReadMemory` that re
Author: Walter Erquinigo
Date: 2024-08-14T12:41:19-04:00
New Revision: cce2271eab8173f5c27c1e99863a056a9430c252
URL:
https://github.com/llvm/llvm-project/commit/cce2271eab8173f5c27c1e99863a056a9430c252
DIFF:
https://github.com/llvm/llvm-project/commit/cce2271eab8173f5c27c1e99863a056a9430c252.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/103458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,15 +148,34 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+std::string CXXFunctionSummaryFormat::GetName() {
+ return m_description;
+}
+
+std::string CXXFunctionSummaryFormat::GetSummaryKindName() {
+ return "c+
walter-erquinigo wrote:
@vogelsgesang , Mr. Bird, I'm swamped this week with work, but I'll look into
this before saturday for sure.
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 1/7] Initial attempt at new classes Summary statistics in
Summary
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 1/7] Initial attempt at new classes Summary statistics in
Summary
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 1/7] Initial attempt at new classes Summary statistics in
Summary
clayborg wrote:
Yes, this is primarily for performance of C++ coroutine detection where we must
search memory for magic values.
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
Jlalond wrote:
@labath Agree on all counts, I'll split this into a different PR. With what I
learned from our obj2yaml adventure I would like to do it better anyway.
https://github.com/llvm/llvm-project/pull/97470
___
lldb-commits mailing list
lldb-co
https://github.com/bulbazord approved this pull request.
Seems ok to me. I don't see what we gain from having a map from Phabricator
name to contributor information for just maintainers, many changes are were
made by people not on this list.
https://github.com/llvm/llvm-project/pull/102590
___
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,15 +148,34 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+std::string CXXFunctionSummaryFormat::GetName() {
+ return m_description;
+}
+
+std::string CXXFunctionSummaryFormat::GetSummaryKindName() {
+ return "c+
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
@@ -174,6 +177,82 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name,
+
@@ -615,7 +615,15 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl
*summary_ptr,
m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on
// the synthetic children being
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -615,7 +615,15 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl
*summary_ptr,
m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on
// the synthetic children being
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -258,6 +258,9 @@ class TypeSummaryImpl {
virtual std::string GetDescription() = 0;
+ virtual ConstString GetName() = 0;
+ virtual ConstString GetImplType() = 0;
Jlalond wrote:
I ended up just going with kind name
https://github.com/llvm/llvm-project/
slydiman wrote:
After this patch it is very hard to build lldb on Windows. We got the errors
like the following
```
D:\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\Interfaces\ScriptedThreadPlanPythonInterface\ScriptedThreadPlanPythonInterface.cpp:
fatal error C1041: cannot open pr
https://github.com/feg208 created
https://github.com/llvm/llvm-project/pull/104109
To create elf core files there are multiple notes in the core file that contain
these structs as the note. These populate methods take a Process and produce
fully specified structures that can be used to fill th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Fred Grim (feg208)
Changes
To create elf core files there are multiple notes in the core file that contain
these structs as the note. These populate methods take a Process and produce
fully specified structures that can be used to fill the
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/104193
None
>From d9517b19db12de3530fea967ae6d577317d1c5a2 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 14 Aug 2024 19:58:27 +0200
Subject: [PATCH] [WIP] memory find speedup+bugfix
---
lldb/source/Target/Pr
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/104195
This PR fixes a potential race condition in
https://github.com/llvm/llvm-project/pull/90930.
This race can happen because the original code set `m_info->m_isAlive = true`
**after** the timer thread is cr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
This PR fixes a potential race condition in
https://github.com/llvm/llvm-project/pull/90930.
This race can happen because the original code set `m_info->m_isAlive =
true` **after** the timer thread is created.
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/104195
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
The GDB packet log is very useful (especially with a good run log at the top to
compare).
I read with @clayborg . The log indicates that
"self.thread.StepOver(lldb.eOnlyThisThread)" sent a "$vCont;c:p1a24.1a24" to
continue single thread at the end but lacking a "\x03" asy
labath wrote:
> The purpose of this it to make the `find memory` faster for post mortem
> processes. This patch gives us nearly 100x speed up based on my tests.
I see. And do you have an idea of how load-bearing that number is? For example,
would you settle for a 18x speedup? That's what I got
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/104109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
https://github.com/labath commented:
I like how you've made a separate patch out of these functions. Just a couple
of random improvements I noticed.
https://github.com/llvm/llvm-project/pull/104109
___
lldb-commits mailing list
lldb-commits@lists.llvm
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
@@ -0,0 +1,162 @@
+//===-- ThreadElfCoreTest.cpp *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
vogelsgesang wrote:
No worries. I will have to rework this commit anyway.
In the meantime, a proposal was merged upstream and also already implemented in
VS-Code. However, there were still larger changes which will require a complete
rewrite of this commit
https://github.com/llvm/llvm-project
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/104238
Listen to gdbserver-port, accept the connection and run `lldb-server gdbserver
--fd` on all platforms. Added acceptor_gdb and gdb_thread to lldb-platform.cpp
SharedSocket has been moved to ConnectionFileDescri
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Listen to gdbserver-port, accept the connection and run `lldb-server gdbserver
--fd` on all platforms. Added acceptor_gdb and gdb_thread to lldb-platform.cpp
SharedSocket has been moved to ConnectionFileD
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d550ada5ab6cd6e49de71ac4c9aa27ced4c11de0
46808aacc7f79cd5220651ff5976780e3aec3d3e --e
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104238
>From 5732bda3558a0d55f2f7b9d1a3722d11458a2360 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 14 Aug 2024 22:36:52 +0400
Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server
Listen t
https://github.com/walter-erquinigo approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/103482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/104109
>From 8f2f84294ea3875c88ce36a4980fd3a3afce01de Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Tue, 18 Jun 2024 10:38:09 -0700
Subject: [PATCH 1/2] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and
ELFLinuxPrS
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
@@ -394,6 +420,114 @@ Status ELFLinuxPrPsInfo::Parse(const DataExtractor &data,
return error;
}
+std::optional
+ELFLinuxPrPsInfo::Populate(const lldb::ProcessSP &process_sp) {
+ ELFLinuxPrPsInfo prpsinfo{};
+ prpsinfo.pr_pid = process_sp->GetID();
+ ProcessInstanceInfo in
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 1/8] Initial attempt at new classes Summary statistics in
Summary
@@ -25,6 +26,7 @@ namespace lldb_private {
using StatsClock = std::chrono::high_resolution_clock;
using StatsTimepoint = std::chrono::time_point;
+using Duration = std::chrono::duration;
Jlalond wrote:
Originally I had this passed down to the invocation as we
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/102708
>From c0a7286b0107d3161b18de8f05d4d016150e96a5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 8 Aug 2024 08:58:52 -0700
Subject: [PATCH 1/9] Initial attempt at new classes Summary statistics in
Summary
@@ -0,0 +1,162 @@
+//===-- ThreadElfCoreTest.cpp *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -25,6 +26,7 @@ namespace lldb_private {
using StatsClock = std::chrono::high_resolution_clock;
using StatsTimepoint = std::chrono::time_point;
+using Duration = std::chrono::duration;
Michael137 wrote:
If it's unused in this PR, I'd rather remove it here.
@@ -174,6 +177,86 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
@@ -174,6 +177,86 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
@@ -0,0 +1,35 @@
+// Test that the lldb command `statistics` works.
Michael137 wrote:
All this lock-talk makes me think we should have a test that exercises
accessing the summary stats map from multiple threads. That way TSAN will help
us in the test-suite.
ht
jasonmolenda wrote:
> > To (preemtively) fix that, you should probably change lldb to recognize the
> > gdb response (`swbreak`) and treat it the same way as the one from
> > lldb-server. Ideally, you should also add a test to make sure this works
> > (and stays working) -- for that, you coul
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/104317
Adds support for the `readMemory` request which allows VS-Code to inspect
memory. Also, add `memoryReference` to variablesa and `evaluate` responses,
such that the binary view can be opened from the variab
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
Adds support for the `readMemory` request which allows VS-Code to inspect
memory. Also, add `memoryReference` to variablesa and `evaluate` responses,
such that the binary view can be opened from t
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 82ee31f75ac1316006fa9e21dddfddec37cf7072
e01ea18961bbae0fb747b312670946bd768c5d73 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
82ee31f75ac1316006fa9e21dddfddec37cf7072...e01ea18961bbae0fb747b312670946bd768c5d73
lldb/
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From a5b4f6e7e105d36b82f9de588d2705ad3d622953 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH] [lldb-dap] Support inspecting memory
Adds support fo
walter-erquinigo wrote:
@clayborg you'll be happy to review this
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@vogelsgesang can you share a screenshot?
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
https://github.com/user-attachments/assets/f1ec37fe-414e-41ee-ad10-a213570d3e5f
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
1 - 100 of 148 matches
Mail list logo
