[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/98330 >From a25b3c8a6a36326730d00d1060ff84181bece26e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 10 Jul 2024 15:37:45 +0100 Subject: [PATCH 1/6] [WIP][lldb][test] Add a layout simulator test for std::uni

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/98330 >From a25b3c8a6a36326730d00d1060ff84181bece26e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 10 Jul 2024 15:37:45 +0100 Subject: [PATCH 1/5] [WIP][lldb][test] Add a layout simulator test for std::uni

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-12 Thread Michael Buch via lldb-commits
Michael137 wrote: I removed the new compressed_pair layouts from this patch so we can land it in isolation. I'll open a separate PR that introduces those back which we can then land once libc++ actually introduces those new layouts in-tree. https://github.com/llvm/llvm-project/pull/98330 _

[Lldb-commits] [lldb] [lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/98330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/98330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

2024-07-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/98464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fe97671 - [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (#98464)

2024-07-12 Thread via lldb-commits
Author: David Spickett Date: 2024-07-12T09:30:33+01:00 New Revision: fe9767105af65f0a7345afb6bb2f14e5d4404a15 URL: https://github.com/llvm/llvm-project/commit/fe9767105af65f0a7345afb6bb2f14e5d4404a15 DIFF: https://github.com/llvm/llvm-project/commit/fe9767105af65f0a7345afb6bb2f14e5d4404a15.diff

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread David Spickett via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread David Spickett via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 4f9774916d3d31f31c810d0930f7961bf348802c Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
https://github.com/beetrees edited https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/98616 Sice #98335 clang adds DW_AT_type, unless strict DWARF is requested. >From 6b21c9e4dc4735dbd1be8c1b125e35c3ee01bbf7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 12 Jul 2024 10:29:31 + Subje

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/98616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Since #98335 clang adds DW_AT_type, unless strict DWARF is requested. --- Full diff: https://github.com/llvm/llvm-project/pull/98616.diff 1 Files Affected: - (modified) lldb/test/API/commands/expre

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/98616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

2024-07-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Without this fix, a frameless function that faults in a firmware environment > (that's where we've seen this issue most commonly) hasn't spilled lr to > stack, so we need to retrieve it from the fault handler's > full-register-context to find the caller of the frameless

[Lldb-commits] [lldb] [llvm] [DRAFT][llvm]Added lib/Telemetry (PR #98528)

2024-07-12 Thread Vy Nguyen via lldb-commits
oontvoo wrote: > Why does any part of this need to be in llvm/ at all? Please see comments on the rfc at https://discourse.llvm.org/t/rfc-lldb-telemetry-metrics/64588/15 TL;DR : A few people feel that Telemetry is not something unique to LLDB and that other tools might be interested in having

[Lldb-commits] [lldb] c471d36 - [lldb][test] Narrow enum test xfail to clang < 19.0 (#98616)

2024-07-12 Thread via lldb-commits
Author: David Spickett Date: 2024-07-12T13:12:35+01:00 New Revision: c471d3650aa3c6c1ddab64c029b7b89b12d18938 URL: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938 DIFF: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938.diff

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/98616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/98623 Seemingly, #96256 removed the only call to Platform::GetCachedExecutable, which broke the resolution of executable modules in the remote debugging mode (https://github.com/llvm/llvm-project/issues/97410). Thi

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Seemingly, #96256 removed the only call to Platform::GetCachedExecutable, which broke the resolution of executable modules in the remote debugging mode (https://github.com/llvm/llvm-project/issues/9

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Could you take a peak if this solves your issue? https://github.com/llvm/llvm-project/pull/98623 https://github.com/llvm/llvm-project/pull/98581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c471d3650aa3c6c1ddab64c029b7b89b12d18938 3f8a4164ddc06a3faffe61d95e5023d367d757f0 --e

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/98623 >From b86d6f9ea1b54cbd5ac54b8aae8971862c6536b5 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Thu, 11 Jul 2024 17:53:08 +0200 Subject: [PATCH] [LLDB] Fix remote executables load and caching Seeming

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jimingham wrote: What is going to happen in this mode if I have 5 threads stop at breakpoints, and each have a breakpoint command that prints "I hit breakpoint X on thread Y". I'll see that in the console for all the threads that hit breakpoints. But what will I see when I look at the stop r

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jeffreytan81 wrote: > What is going to happen in this mode if I have 5 threads stop at breakpoints, > and each have a breakpoint command that prints "I hit breakpoint X on thread > Y". I'll see that in the console for all the threads that hit breakpoints. > But what will I see when I look at t

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/98568 >From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 11 Jul 2024 17:24:41 -0700 Subject: [PATCH 1/3] Support single stopped event in lldb-dap --- .../test/t

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: That was an oversight. Thanks for restoring this. LGTM. https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: CC @clayborg as this probably explains the Android debugging regression. https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jimingham wrote: If I have a program with lots of threads - particularly if they are running in a small set of work functions - it's very common to have multiple breakpoint hits at the same time. And if there are lots of threads, then in this mode I'm going to end up having to scroll down the

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

2024-07-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Testing this is in theory possible, tricky bit is guaranteeing a frameless > function. There is the naked attribute but it's not portable > https://godbolt.org/z/s9117Gr7a. Or you could write the function in an > assembly file, or define and call it inside an inline asse

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

2024-07-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/98566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread Alex Langford via lldb-commits
@@ -443,11 +474,17 @@ def test_shadow_listener(self): # Put in a counter to make sure we don't spin forever if there is some # error in the logic. counter = 0 +run_wo_stop = False bulbazord wrote: Doesn't look like this is used?

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
jimingham wrote: That was actually from a debugging session using the test. I got rid of all the other evidence of that experiment in the test case, but missed this one. Jim > On Jul 12, 2024, at 10:34 AM, Alex Langford ***@***.***> wrote: > > > @bulbazord commented on this pull request. >

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-12 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/96687 >From 02f06f90a40cc7ed18a9744918acf4daf6212486 Mon Sep 17 00:00:00 2001 From: kendal Date: Mon, 24 Jun 2024 14:01:31 -0700 Subject: [PATCH 1/2] Fix test assertions in TestDAP_stepInTargets.py --- .../step

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-12 Thread Kendal Harland via lldb-commits
@@ -55,14 +55,23 @@ def test_basic(self): self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets") # Verify the target names are correct. -self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()") -self.assertEqual(step

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-12 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/96687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fd42417 - [lldb] Allow fetching of RA register when above fault handler (#98566)

2024-07-12 Thread via lldb-commits
Author: Jason Molenda Date: 2024-07-12T10:44:18-07:00 New Revision: fd424179dcb3417fc0675f77d2bf06c750dd1c33 URL: https://github.com/llvm/llvm-project/commit/fd424179dcb3417fc0675f77d2bf06c750dd1c33 DIFF: https://github.com/llvm/llvm-project/commit/fd424179dcb3417fc0675f77d2bf06c750dd1c33.diff

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

2024-07-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/98566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: @dzhidzhoev Yes, https://github.com/llvm/llvm-project/pull/98623 fixed the ResolveExecutableModule issue, thank you! https://github.com/llvm/llvm-project/pull/98581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack closed https://github.com/llvm/llvm-project/pull/98581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread Med Ismail Bennani via lldb-commits
@@ -4248,7 +4248,21 @@ bool Process::ProcessEventData::ShouldStop(Event *event_ptr, return still_should_stop; } +bool Process::ProcessEventData::ForwardEventToPendingListeners(Event *event_ptr) { + // STDIO and the other async event notifications should always be forwarde

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: Verified this fixed the ResolveExecutableModule issue with Android target reported in https://github.com/llvm/llvm-project/pull/98581 https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/98571 >From fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 11 Jul 2024 17:50:08 -0700 Subject: [PATCH 1/2] Fix a bug where process events were being delivered to the se

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/98571 >From fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 11 Jul 2024 17:50:08 -0700 Subject: [PATCH 1/3] Fix a bug where process events were being delivered to the se

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack approved this pull request. https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
@@ -4248,7 +4248,21 @@ bool Process::ProcessEventData::ShouldStop(Event *event_ptr, return still_should_stop; } +bool Process::ProcessEventData::ForwardEventToPendingListeners(Event *event_ptr) { + // STDIO and the other async event notifications should always be forwarde

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, jimingham wrote: exectue

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, + /// the Process plugin should call SetT

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, + /// the Process plugin should call SetT

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -128,6 +128,9 @@ class Thread : public std::enable_shared_from_this, register_backup_sp; // You need to restore the registers, of course... uint32_t current_inlined_depth; lldb::addr_t current_inlined_pc; +lldb::addr_t stopped_at_unexecuted_bp; // Set to

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -1311,6 +1334,16 @@ class Thread : public std::enable_shared_from_this, bool m_should_run_before_public_stop; // If this thread has "stop others" // private work to do, then it will // set

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jeffreytan81 wrote: > If I have a program with lots of threads - particularly if they are running > in a small set of work functions - it's very common to have multiple > breakpoint hits at the same time. And in this mode I'm going to end up having > to scroll down the list - which if I have l

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] 73dad7a - [LLDB] Fix remote executables load and caching (#98623)

2024-07-12 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-07-12T20:43:08+02:00 New Revision: 73dad7a765226bd7ade98f85d050e80f411f6dad URL: https://github.com/llvm/llvm-project/commit/73dad7a765226bd7ade98f85d050e80f411f6dad DIFF: https://github.com/llvm/llvm-project/commit/73dad7a765226bd7ade98f85d050e80f411f6da

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/98361 >From 37b6878b9125c314c75053f7d5b0ba520111e9a3 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 9 Jul 2024 15:28:19 -0700 Subject: [PATCH 1/3] Reapply [lldb][DWARF] Delay struct/class/union definition DIE se

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( +const lldb_private::plugin::dwarf::DWARFDIE &decl_die, +const lldb_private::plugin::dwarf::DWARFDIE &def_die)

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( +const lldb_private::plugin::dwarf::DWARFDIE &decl_die, +const lldb_private::plugin::dwarf::DWARFDIE &def_die)

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -4,8 +4,8 @@ // REQUIRES: lld -// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-a.o -g -gsimple-template-names -DFILE_A -// RUN: %clang --target=x86_64-pc-linux -c %s -o %t-b.o -g -gsimple-template-names -DFILE_B ZequanWu wrote: Added another set of

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -824,6 +824,36 @@ DWARFASTParserClang::GetDIEClassTemplateParams(const DWARFDIE &die) { return {}; } +void DWARFASTParserClang::MappingDeclDIEToDefDIE( ZequanWu wrote: Done. https://github.com/llvm/llvm-project/pull/98361 __

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -1631,27 +1638,49 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { return true; } - DWARFDIE dwarf_die = GetDIE(die_it->getSecond()); - if (dwarf_die) { -// Once we start resolving this type, remove it from the forward -// declaration ma

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-12 Thread Zequan Wu via lldb-commits
@@ -1603,41 +1633,76 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE &die) { TypeSP DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, - const DWARFDIE &decl_die, +

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] jimingham wrote: This table is great, but it deserves a line saying what it is. https://

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -607,6 +575,18 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( target ? target->GetArchitecture().GetMachine() : llvm::Triple::UnknownArch; + ProcessSP process_sp(thread.GetProcess()); + RegisterContextSP reg_ctx_sp(thread.GetRe

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/98690 Currently, if we execute 'process load' with remote debugging, it uses the host's path delimiter to look up files on a target machine. If we run remote debugging of Linux target on Windows and execute process

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Currently, if we execute 'process load' with remote debugging, it uses the host's path delimiter to look up files on a target machine. If we run remote debugging of Linux target on Windows and exec

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/98690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 73dad7a765226bd7ade98f85d050e80f411f6dad 98b75927878e35ca556ecbbecb1125621a63fea9 --e

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 73dad7a765226bd7ade98f85d050e80f411f6dad...98b75927878e35ca556ecbbecb1125621a63fea9 lldb/

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/98690 >From aee177b86c61ab8a3ad1b2c4d1fa32239875e10f Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Tue, 23 Apr 2024 05:44:49 + Subject: [PATCH] [LLDB] Make 'process load' take remote os path delimite

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/98694 The test expects 'libstdc++' or 'libc++' SO module in the module list. In case when static linking with libc++ is on by default, none of them may be present. Thus, USE_SYSTEM_STDLIB is added to ensure the pre

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes The test expects 'libstdc++' or 'libc++' SO module in the module list. In case when static linking with libc++ is on by default, none of them may be present. Thus, USE_SYSTEM_STDLIB is added to ens

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r bee240367cc48bbc93fe5eb57d537968dfe4419f...e98b2f73269ba4e8f1a980ffb2b2765d1de5f655 lldb/

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev converted_to_draft https://github.com/llvm/llvm-project/pull/98694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/96260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > @dzhidzhoev Yes, #98623 fixed the ResolveExecutableModule issue, thank you! May I ask you: are there any public builders available for remote Android lldb testing? It will come in handy to know if there are any. https://github.com/llvm/llvm-project/pull/98581 __

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -1880,60 +1849,40 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo( StopInfo::CreateStopReasonVForkDone(*thread_sp)); handled = true; } - } else if (!signo) { -addr_t pc = thread_sp->GetRegisterContext()->GetPC(); -lldb::Br

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -229,6 +229,17 @@ bool ScriptedThread::CalculateStopInfo() { LLVM_PRETTY_FUNCTION, "Failed to get scripted thread stop info.", error, LLDBLog::Thread); + // If we're at a BreakpointSite, mark that we stopped there and jimingham wrote: Is

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

2024-07-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/80368 >From d7c77e6ae69449985300c3909e835e35be3ba3e9 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 25 Jan 2024 11:05:02 + Subject: [PATCH 1/5] [lldb] Add frame recognizer for __builtin_verbose_trap Thi

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,91 @@ +""" +Test lldb-dap setBreakpoints request +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import lldbdap_testcase +from lldbsuite.test import lldbutil + + +class TestDAP_stopEvents(lldbdap_testcase.DAPTestCaseBase): +@s

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/98701 --whole-archive and --allow-multiple-definition options has been added to linker flags of these import-std-module tests in order to make them pass with libcxx static linking enabled. Darwin has been excluded

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes --whole-archive and --allow-multiple-definition options has been added to linker flags of these import-std-module tests in order to make them pass with libcxx static linking enabled. Darwin has be

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/98701 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread Michael Buch via lldb-commits
@@ -1,5 +1,8 @@ -# FIXME: once the expression evaluator can handle std libraries with debug -# info, change this to USE_LIBCPP=1 -USE_SYSTEM_STDLIB := 1 Michael137 wrote: Is this related to the linker flag changes in any way? We rely on this on the macOS bots, s

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread Michael Buch via lldb-commits
@@ -1,3 +1,8 @@ USE_LIBCPP := 1 CXX_SOURCES := main.cpp + +ifneq ($(OS),Darwin) + LD_EXTRAS := -Xlinker --whole-archive -Xlinker --allow-multiple-definition Michael137 wrote: Can you elaborate on why this is necessary? Example test failures would be grea

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

2024-07-12 Thread Dan Liew via lldb-commits
https://github.com/delcypher requested changes to this pull request. Looks pretty good. I had a few minor comments https://github.com/llvm/llvm-project/pull/80368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

2024-07-12 Thread Dan Liew via lldb-commits
@@ -0,0 +1,122 @@ +#include "lldb/Target/VerboseTrapFrameRecognizer.h" + +#include "lldb/Core/Module.h" +#include "lldb/Symbol/Function.h" +#include "lldb/Symbol/SymbolContext.h" +#include "lldb/Target/Process.h" +#include "lldb/Target/StackFrameRecognizer.h" +#include "lldb/Targe

  1   2   >