https://github.com/PortalPete edited
https://github.com/llvm/llvm-project/pull/76111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,76 @@
+//===-- Breakpoint.cpp --*- C++
-*-===//
JDevlieghere wrote:
Nit: you don't need the `*- C++ -*` in source files as emacs can tell it's C++
by the extension, unlike in the header.
https://github.com/ll
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
https://github.com/JDevlieghere approved this pull request.
LGTM with comments addressed.
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -0,0 +1,39 @@
+#ifndef LLDB_TARGET_VERBOSETRAPFRAMERECOGNIZER_H
JDevlieghere wrote:
Missing license header.
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
@@ -0,0 +1,9 @@
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out
+# RUN: %lldb -b -s %s %t.out | FileCheck %s
+run
+# CHECK: thread #{{.*}}stop reason = Runtime Error: Function is not implemented
delcypher wrote:
`Runtime Error:` is pretty generic.
adrian-prantl wrote:
Should the Doxygen comment of GetStackFrameCount warn that this is an expensive
operation?
https://lldb.llvm.org/cpp_reference/classlldb__private_1_1Thread.html#afc54feef950a58b625bbb198dc4cf57c
https://github.com/llvm/llvm-project/pull/80918
___
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/81018
None
>From 4f5b30fcb038c942df6a2fce975678c5b7ee1725 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 7 Feb 2024 08:43:14 -0800
Subject: [PATCH] [lldb] Remove duplicate else-if branch (NFC)
---
lldb/sourc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81018.diff
1 Files Affected:
- (modified) lldb/source/Core/FormatEntity.cpp (-3)
``diff
diff --git a/lldb/source/Core/FormatEntity.cpp
b
clayborg wrote:
> Should the Doxygen comment of GetStackFrameCount warn that this is an
> expensive operation?
> https://lldb.llvm.org/cpp_reference/classlldb__private_1_1Thread.html#afc54feef950a58b625bbb198dc4cf57c
It might be nice to add a "std::optional max_frame_count" to this
function t
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
never mind, I see the slight difference
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione reopened
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81018
>From f9d4abddb0f93d27ed14278566796babad9f7f4e Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 7 Feb 2024 10:17:51 -0800
Subject: [PATCH] [lldb] Add comment to ParseInternal in FormatEntity
---
lldb/sour
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
Does this setting only apply to the downloading of symbols that are auto
downloaded for stack traces? Or does it apply to any other areas that auto
download stuff? Do we want a setting to control the auto downloading of symbols
to clarify? Something like:
```
(lldb) settings se
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
jimingham wrote:
> > Should the Doxygen comment of GetStackFrameCount warn that this is an
> > expensive operation?
> > https://lldb.llvm.org/cpp_reference/classlldb__private_1_1Thread.html#afc54feef950a58b625bbb198dc4cf57c
>
> It might be nice to add a "std::optional max_frame_count" to this
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81018
>From f9d4abddb0f93d27ed14278566796babad9f7f4e Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 7 Feb 2024 10:17:51 -0800
Subject: [PATCH 1/2] [lldb] Add comment to ParseInternal in FormatEntity
---
lldb/
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/81018
>From f9d4abddb0f93d27ed14278566796babad9f7f4e Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 7 Feb 2024 10:17:51 -0800
Subject: [PATCH 1/3] [lldb] Add comment to ParseInternal in FormatEntity
---
lldb/
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/81026
As part of the effort to improve progress reporting in LLDB
(https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we
want a way to keep track of progress reports to see if they're ongoin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
As part of the effort to improve progress reporting in LLDB
(https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we
want a way to keep track of progress reports to see if they'r
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a8ab8306069e8e53b5148ceec7624d7d36ffb459
d10c1c494972429eb5c42ccb8a1dfcbff5d7bfcd --
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2204,7 +2204,9 @@ static Status ParseInternal(llvm::StringRef &format,
Entry &parent_entry,
return error;
}
} else if (FormatManager::GetFormatFromCString(
- entry.printf_format.c_str(), true, entr
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/80753
>From c4b767909a9ffc2a3015dc9021e4c265da0d877d Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Mon, 5 Feb 2024 17:26:48 -0500
Subject: [PATCH 1/3] [lldb-dap][NFC] Add Breakpoint struct to share common
logic.
--
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81026
>From a80637fe2471c3f1adc2b353cef41887bcd55a3c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 6 Feb 2024 10:48:39 -0800
Subject: [PATCH] [lldb][progress][NFC] Add groundwork to keep track of
p
@@ -608,11 +608,10 @@ static bool Evaluate_DW_OP_entry_value(std::vector
&stack,
StackFrameSP parent_frame = nullptr;
addr_t return_pc = LLDB_INVALID_ADDRESS;
uint32_t current_frame_idx = current_frame->GetFrameIndex();
- uint32_t num_frames = thread->GetStackFrameCount
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/80918
>From c76edeec5c7430cd352c4d0ca977445800c55666 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Tue, 6 Feb 2024 17:30:17 -0800
Subject: [PATCH 1/2] Don't count all the frames just to skip the current
inlined on
jimingham wrote:
> Should the Doxygen comment of GetStackFrameCount warn that this is an
> expensive operation?
> https://lldb.llvm.org/cpp_reference/classlldb__private_1_1Thread.html#afc54feef950a58b625bbb198dc4cf57c
I added something to that effect.
https://github.com/llvm/llvm-project/pul
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben requested changes to this pull request.
I think the progress map should be held by the debugger instance, not a static
member of the Progress class, since some progress reports could be targeting a
specific debugger.
https://github.com/llvm/llvm-project/pull/810
@@ -55,6 +56,10 @@ namespace lldb_private {
class Progress {
public:
+ enum {
+eProgressLinearReports,
medismailben wrote:
Please comment what each enum value means
https://github.com/llvm/llvm-project/pull/81026
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -117,6 +127,7 @@ class Progress {
/// to ensure that we don't send progress updates after progress has
/// completed.
bool m_complete = false;
+ bool m_type;
medismailben wrote:
This is confusing, why would you store your enum value in a `bool`
http
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -55,6 +56,10 @@ namespace lldb_private {
class Progress {
public:
+ enum {
+eProgressLinearReports,
+eProgressCoalecseReports,
medismailben wrote:
```suggestion
eProgressCoalesceReports,
```
https://github.com/llvm/llvm-project/pull/81026
___
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/81041
mach-o object files never have separate debug info, and in a big app there can
be quite a large number of object files, so even a few stats per object file
can slow launches considerably.
This patch avoids thi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
mach-o object files never have separate debug info, and in a big app there can
be quite a large number of object files, so even a few stats per object file
can slow launches considerably.
This patch avoids this sea
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 369b82218419a0218400e7483255523b8dfd6cf0
787d48cd3e2af5478f05986268e91d1bfb5a4c30 --
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/81041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
So I added comments on fixes to the current implementation in inline comments.
A few questions I have:
- do we really want each progress to select if it should be coalesced as a
`Progress` constructor arguments? Or do we want a global setting on how
progr
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -38,6 +46,13 @@ Progress::~Progress() {
std::lock_guard guard(m_mutex);
if (!m_completed)
m_completed = m_total;
+
+ if (m_type == Progress::eProgressCoalecseReports) {
+--g_map.at(m_title);
+if (g_map.at(m_title) == 0)
+ g_map.erase(m_title);
-
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
--
@@ -55,6 +56,10 @@ namespace lldb_private {
class Progress {
public:
+ enum {
+eProgressLinearReports,
+eProgressCoalecseReports,
+ };
clayborg wrote:
Should we add a new setting for this? Something like:
```
(lldb) settings set progress-report [ind
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
medismailben wrote:
By making the refcount static, it's shared across all the `Progress` instances,
but IIUC, you want this ref
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -117,6 +127,7 @@ class Progress {
/// to ensure that we don't send progress updates after progress has
/// completed.
bool m_complete = false;
+ bool m_type;
chelcassanova wrote:
Holdover from when I used a bool for this value before switching an enu
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/81041
>From 787d48cd3e2af5478f05986268e91d1bfb5a4c30 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Wed, 7 Feb 2024 13:00:55 -0800
Subject: [PATCH 1/2] Don't search for separate debug files for mach-o object
files
Author: jimingham
Date: 2024-02-07T14:25:51-08:00
New Revision: 50ffc53e4708f3484939ef82e7b0309600a8e19f
URL:
https://github.com/llvm/llvm-project/commit/50ffc53e4708f3484939ef82e7b0309600a8e19f
DIFF:
https://github.com/llvm/llvm-project/commit/50ffc53e4708f3484939ef82e7b0309600a8e19f.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/81041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
JDevlieghere wrote:
> A few questions I have:
>
> * do we really want each progress to select if it should be coalesced as a
> `Progress` constructor arguments? Or do we want a global setting on how
> progress events should be delivered?
My understanding is that the constructor conveys whethe
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/80918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> > A few questions I have:
> >
> > * do we really want each progress to select if it should be coalesced as a
> > `Progress` constructor arguments? Or do we want a global setting on how
> > progress events should be delivered?
>
> My understanding is that the constructor conv
JDevlieghere wrote:
> > My understanding is that the constructor conveys whether something is an
> > "aggregate" progress event or not and they're broadcast differently so that
> > the listener can decide how they want to receive these "aggregate" events.
>
> My idea is the user decides how to
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/81067
When using split DWARF we can run into many different ways to store debug info:
- lldb loads "" which contains skeleton DWARF and needs to find ".dwp"
- lldb loads "" which is stripped but has .gnu_debuglink poin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
When using split DWARF we can run into many different ways to store debug info:
- lldb loads "" which contains skeleton DWARF and needs to find
".dwp"
- lldb loads "" which is stripped but has
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/81067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ayermolo wrote:
Will this now work with .dwp files not having UUID?
https://github.com/llvm/llvm-project/pull/81067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
> Will this now work with .dwp files not having UUID?
The lack of UUID is kinda why this is so important. The connection is strictly
based on the filename. This just expands the variety of filenames that can be
supported. One thing that's helpful is that the .gnu_debuglink can
clayborg wrote:
> Will this now work with .dwp files not having UUID?
No. If binairies have UUIDs (GNU build IDs), they need to match right now. That
is larger fix that involves adding a "enum UUIDFlavor" to the UUIDs so we can
ensure we aren't comparing two different things.
What Alexander i
ayermolo wrote:
> > Will this now work with .dwp files not having UUID?
>
> No. If binairies have UUIDs (GNU build IDs), they need to match right now.
> That is larger fix that involves adding a "enum UUIDFlavor" to the UUIDs so
> we can ensure we aren't comparing two different things.
>
> Wh
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/81075
debugserver will not compress small packets; the overhead of the compression
header makes this useful for larger packets. I default to 384 bytes in
debugserver, and added an option for lldb to request a di
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
debugserver will not compress small packets; the overhead of the compression
header makes this useful for larger packets. I default to 384 bytes in
debugserver, and added an option for lldb to request
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/81078
This formatter
https://github.com/llvm/llvm-project/pull/78609
was originally passing the signed seconds (which can refer to times in the
past) with an unsigned printf formatter, and had tests that expected
jasonmolenda wrote:
Created a new PR with my proposed fix
https://github.com/llvm/llvm-project/pull/81078
https://github.com/llvm/llvm-project/pull/78609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
This formatter
https://github.com/llvm/llvm-project/pull/78609
was originally passing the signed seconds (which can refer to times in the
past) with an unsigned printf formatter, and had tests that expec
https://github.com/bulbazord approved this pull request.
Makes sense to me. If the test suite is happy then I think this is fine.
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/bulbazord approved this pull request.
LGTM. I also noticed there's no tests for this functionality...
https://github.com/llvm/llvm-project/pull/81075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
jasonmolenda wrote:
Thanks for the review. Yeah, testing isn't simple today because debugserver
only enables compression on always-remote systems (iOS, watchOS, etc) (which
may even be communicating over Bluetooth/Wifi), it doesn't enable this on
macOS. We could have a mode to enable it on m
Author: Jason Molenda
Date: 2024-02-07T18:55:24-08:00
New Revision: 2df42fe0efd92a89ae191a598e2727c7b63de80b
URL:
https://github.com/llvm/llvm-project/commit/2df42fe0efd92a89ae191a598e2727c7b63de80b
DIFF:
https://github.com/llvm/llvm-project/commit/2df42fe0efd92a89ae191a598e2727c7b63de80b.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/81075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 103 matches
Mail list logo
