[Lldb-commits] [lldb] 6e3572c - [lldb] Use llvm::erase_if (NFC)

2023-10-20 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2023-10-20T00:20:30-07:00 New Revision: 6e3572ccd896573a4eb32e3fa1c874a3d947b143 URL: https://github.com/llvm/llvm-project/commit/6e3572ccd896573a4eb32e3fa1c874a3d947b143 DIFF: https://github.com/llvm/llvm-project/commit/6e3572ccd896573a4eb32e3fa1c874a3d947b143.diff L

[Lldb-commits] [lldb] [lldb][AArch64] Read mte_ctrl register from core files (PR #69689)

2023-10-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69689 This register reports the configuration of the AArch64 Linux tagged address ABI, part of which is the memory tagging (MTE) settings. It will always be present in core files because even without MTE, there

[Lldb-commits] [lldb] [lldb][AArch64] Read mte_ctrl register from core files (PR #69689)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This register reports the configuration of the AArch64 Linux tagged address ABI, part of which is the memory tagging (MTE) settings. It will always be present in core files because even without MTE, t

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

2023-10-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69696 There are some uses of "vscode" in `lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py` where I'm not sure if it's referring to the adapter or VS Code itself, so those remain. >From f84ecb7a5

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes There are some uses of "vscode" in `lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py` where I'm not sure if it's referring to the adapter or VS Code itself, so those remain. --- Full d

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-10-20 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add isAArch64SMEFA64 check to SME testing (PR #68094)

2023-10-20 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. https://github.com/llvm/llvm-project/pull/68094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-10-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bb82695 - [lldb][AArch64] Add release notes and documentation for SME (#66767)

2023-10-20 Thread via lldb-commits
Author: David Spickett Date: 2023-10-20T14:06:06+01:00 New Revision: bb826951dcf35628cf73235e0e96a0d8ac9c0c49 URL: https://github.com/llvm/llvm-project/commit/bb826951dcf35628cf73235e0e96a0d8ac9c0c49 DIFF: https://github.com/llvm/llvm-project/commit/bb826951dcf35628cf73235e0e96a0d8ac9c0c49.diff

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

2023-10-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/69726 Patches now go to PRs, mention the Discord server as well as the forum. >From 08c246316c2daa7dde701d5c4beb1de77021520a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 20 Oct 2023 14:45:06 +0100 Su

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

2023-10-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: I thought I saw that the mailing lists would be closed but I must have imagined it, so I left them in. https://github.com/llvm/llvm-project/pull/69726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Patches now go to PRs, mention the Discord server as well as the forum. --- Full diff: https://github.com/llvm/llvm-project/pull/69726.diff 1 Files Affected: - (modified) lldb/docs/index.rst (+6-3)

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

2023-10-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/69696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2a32afd - [lldb] Remove more references to lldb-vscode (#69696)

2023-10-20 Thread via lldb-commits
Author: David Spickett Date: 2023-10-20T15:08:37+01:00 New Revision: 2a32afddf5594b7ca8c6aa67a5731612134f29f9 URL: https://github.com/llvm/llvm-project/commit/2a32afddf5594b7ca8c6aa67a5731612134f29f9 DIFF: https://github.com/llvm/llvm-project/commit/2a32afddf5594b7ca8c6aa67a5731612134f29f9.diff

[Lldb-commits] [lldb] [lldb] Remove more references to lldb-vscode (PR #69696)

2023-10-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update contributing links (PR #69726)

2023-10-20 Thread Med Ismail Bennani via lldb-commits
@@ -102,10 +102,13 @@ Additionally it builds: See the :doc:`LLDB Build Page ` for build instructions. Discussions about LLDB should go to the `LLDB forum -`__. Commit +`__ or the ``ll

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-20 Thread Alex Langford via lldb-commits
@@ -7183,7 +7183,8 @@ GetNthTemplateArgument(const clang::ClassTemplateSpecializationDecl *decl, // (including the ones preceding the parameter pack). const auto &pack = args[last_idx]; const size_t pack_idx = idx - last_idx; - assert(pack_idx < pack.pack_size() && "par

[Lldb-commits] [lldb] [lldb-vscode] Allow specifying a custom escape prefix for LLDB commands (PR #69238)

2023-10-20 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @clayborg , friendly ping :) https://github.com/llvm/llvm-project/pull/69238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Implement llvm-style RTTI for DWARFASTParser (PR #69762)

2023-10-20 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/69762 None >From 2cc3dc43d5ef705a016b8b7b3c23d99d5f01a5d8 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Fri, 20 Oct 2023 12:42:52 -0700 Subject: [PATCH] [lldb][NFC] Implement llvm-style RTTI for DWARFASTPar

[Lldb-commits] [lldb] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser (PR #69764)

2023-10-20 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/69764 None >From c97e0b62a2df5309db707861b5f1fd2c223ac50b Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Fri, 20 Oct 2023 12:59:00 -0700 Subject: [PATCH] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser

[Lldb-commits] [lldb] [lldb][NFC] Move GetTypeForDIE from to DWARFASTParser (PR #69764)

2023-10-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1d4601a1ef84e4ffe2db84d17b53953b25699eef c97e0b62a2df5309db707861b5f1fd2c223ac50b --

[Lldb-commits] [lldb] Improve dwo path in missing dwo error when relative (PR #69783)

2023-10-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/69783 When the debug info refers to a dwo with relative `DW_AT_comp_dir` and `DW_AT_dwo_name`, we only print the `DW_AT_comp_dir` in our error message if we can't find it. This often isn't very helpful, especially when t

[Lldb-commits] [lldb] [lldb] improve dwo path in missing dwo error when relative (PR #69783)

2023-10-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/69783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] improve dwo path in missing dwo error when relative (PR #69783)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Tom Yang (zhyty) Changes When the debug info refers to a dwo with relative `DW_AT_comp_dir` and `DW_AT_dwo_name`, we only print the `DW_AT_comp_dir` in our error message if we can't find it. This often isn't very helpful, especially when t

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty converted_to_draft https://github.com/llvm/llvm-project/pull/69517 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/69517 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-20 Thread Tom Yang via lldb-commits
zhyty wrote: > Because SymbolFile is holding onto the function pointer as a static member, > this is a global setting that you can't apply to only just one `SBDebugger` > object. It's an all-or-nothing thing. Maybe that's what you want, but LLDB > already has architectural issues with certain

[Lldb-commits] [lldb] [lldb] improve dwo path in missing dwo error when relative (PR #69783)

2023-10-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/69783 >From bee3e22c2b2c57d2a6710741f8a78dff0d8d71e1 Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Thu, 19 Oct 2023 15:36:22 -0700 Subject: [PATCH] improve dwo path in missing dwo error Summary: Test Plan: Reviewers:

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-10-20 Thread Dan McGregor via lldb-commits
dankm wrote: No _good_ particular reason. I got hung up on the formatting issues then ran out of steam, and busy with $job. I just ran clang-format on this change and it came up clean. And now that I've done that the only reason I have left is I'm unable to merge my own changes. Would you min

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-10-20 Thread Dan McGregor via lldb-commits
dankm wrote: Hm. I have "fixup" commits in this branch, should I rebase those, or can we squash merge as-is? https://github.com/llvm/llvm-project/pull/65812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] improve dwo path in missing dwo error when relative (PR #69783)

2023-10-20 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/69783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

2023-10-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/69793 The underlying timezone classes are being reimplemented in Swift, and these strings will be Swift strings, without the ObjC `@` prefix. Leaving off the `@` makes these tests usable both before and after the

[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes The underlying timezone classes are being reimplemented in Swift, and these strings will be Swift strings, without the ObjC `@` prefix. Leaving off the `@` makes these tests usable both before and after the r

[Lldb-commits] [lldb] [LLDB] Update breakpoint-command.test to use string instead of number. (PR #69796)

2023-10-20 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/69796 lldb/test/Shell/Breakpoint/breakpoint-command.test adds a python command, to be executed when a breakpoint hits, that writes out a number. It then runs, hits the breakpoint and checks that the number is present e

[Lldb-commits] [lldb] [LLDB] Update breakpoint-command.test to use string instead of number. (PR #69796)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes lldb/test/Shell/Breakpoint/breakpoint-command.test adds a python command, to be executed when a breakpoint hits, that writes out a number. It then runs, hits the breakpoint and checks that the number is present exactl

[Lldb-commits] [lldb] [LLDB] Update breakpoint-command.test to use string instead of number. (PR #69796)

2023-10-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/69796 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update breakpoint-command.test to use string instead of number. (PR #69796)

2023-10-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. What an interesting failure condition 🙂 Some arbitrary string with spaces seems a lot less likely to be a false positive compared to a number. https://github.com/llvm/llvm-project/pull/69796 ___

[Lldb-commits] [lldb] [LLDB] Update breakpoint-command.test to use string instead of number. (PR #69796)

2023-10-20 Thread Alex Langford via lldb-commits
@@ -1,7 +1,7 @@ # REQUIRES: lua || python # RUN: %build %p/Inputs/dummy-target.c -o %t.out -# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' | FileCheck %s +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(

[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

2023-10-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice https://github.com/llvm/llvm-project/pull/69793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

2023-10-20 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/69793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Turn ObjC string literals to C-style literals (NFC) (PR #69793)

2023-10-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/69793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3b5d59a - [lldb][test] Turn ObjC string literals to C-style literals (NFC) (#69793)

2023-10-20 Thread via lldb-commits
Author: Dave Lee Date: 2023-10-20T19:24:53-07:00 New Revision: 3b5d59ab55f885f1e12a9d306de351b798552426 URL: https://github.com/llvm/llvm-project/commit/3b5d59ab55f885f1e12a9d306de351b798552426 DIFF: https://github.com/llvm/llvm-project/commit/3b5d59ab55f885f1e12a9d306de351b798552426.diff LOG:

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

2023-10-20 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/69815 This patch adds the value to enumerator dump, e.g. `Enumerator` now dumped as `Enumerator(0)`. There are not-so-uncommon cases when value of enumerator is no less important than its name. One example can be foun

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

2023-10-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vlad Serebrennikov (Endilll) Changes This patch adds the value to enumerator dump, e.g. `Enumerator` now dumped as `Enumerator(0)`. There are not-so-uncommon cases when value of enumerator is no less important than its name. One example ca

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

2023-10-20 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69815 >From 886c627b8675886cfa09745c2441e3ab4aaadaea Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sat, 21 Oct 2023 09:18:24 +0300 Subject: [PATCH 1/2] [lldb] Add number to enumerator dump --- .../TypeSyste

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

2023-10-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4aae5387a874a55ee491f5dc23ce0506c5cdc678 886c627b8675886cfa09745c2441e3ab4aaadaea --

[Lldb-commits] [lldb] [lldb] Add value to enumerator dump (PR #69815)

2023-10-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 4aae5387a874a55ee491f5dc23ce0506c5cdc678..886c627b8675886cfa09745c2441e3ab4aaadaea lldb/