[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread Ed Maste via lldb-commits
emaste wrote: Needs to be adapted for f2d32ddcec82c20582c6aa32558b82ca7c3d3c50, `lldb/source/{Core => Host/common}/StreamFile.cpp` (I've applied the change locally for testing, and will just fold it into the patch series if otherwise ready to go.) https://github.com/llvm/llvm-project/pull/67

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/5] feat: add DynamicLoaderFreeBSDKernel --- .../Plugins/DynamicLoa

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread via lldb-commits
https://github.com/aokblast resolved https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread via lldb-commits
aokblast wrote: Excuse me. If the code works well now, I want to ask if I need to modify the commit message by myself so the message looks tidy, or let somebody landing this pull request modify the message? https://github.com/llvm/llvm-project/pull/67106 ___

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/7] [lldb] add command start --- lldb/

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
@@ -38,7 +39,36 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntry); break; - + case 'm': // Stop at user entry point + { +TargetSP target_sp = +execution_cont

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl resolved https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread José Lira Junior via lldb-commits
junior-jl wrote: What are your thoughts on creating an alias for `process launch --stop-at-user-entry` such as the intended `start` (or `begin`, or even `run -m`). Also, if I wanted to do that, the only change would be an `AddAlias` in `CommandInterpreter.cpp`? Or there's something else? ht

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread Ed Maste via lldb-commits
emaste wrote: > Excuse me. If the code works well now, I want to ask if I need to modify the > commit message by myself so the message looks tidy, or let somebody landing > this pull request modify the message? This will be the first substantial change I'd land after LLVM moved to use pull re

[Lldb-commits] [lldb] e8ea476 - [lldb] Implement thread local storage for linux (#67470)

2023-09-27 Thread via lldb-commits
Author: jeffreytan81 Date: 2023-09-27T09:14:40-07:00 New Revision: e8ea47602bdb74a88c707d289fc241f7670e1483 URL: https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483 DIFF: https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483.diff

[Lldb-commits] [lldb] [lldb] Implement thread local storage for linux (PR #67470)

2023-09-27 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/67470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-27 Thread via lldb-commits
aokblast wrote: Thanks, maybe aokblast is more suitable. XD https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Move functionality for getting unsupported DW_FORM values (PR #67579)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67579 The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all the DW_FORM values that have been parsed but are unsupported or otherwise unknown. AFAICT this functionality does not exist in LLV

[Lldb-commits] [lldb] [lldb][NFCI] Move functionality for getting unsupported DW_FORM values (PR #67579)

2023-09-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all the DW_FORM values that have been parsed but are unsupported or otherwise unknown. AFAICT this functionality does not exist in LLVM at all. Since my primary goa

[Lldb-commits] [lldb] [lldb][NFCI] Move functionality for getting unsupported DW_FORM values (PR #67579)

2023-09-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/67579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SetValueFromCString API to SyntheticFronend (PR #67309)

2023-09-27 Thread via lldb-commits
jimingham wrote: First off, note that the case of std::strings is slightly orthogonal to what you are doing here, because the thing that provides the "semantic" value for a std::string is the std::string Summary Formatter. std::string doesn't actually have a synthetic front end provider. So

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-09-27 Thread via lldb-commits
=?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: We try to only add really frequently used aliases to the default lldb set. In

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/67599 Add the ability to get a C++ vtable ValueObject from another ValueObject. This patch adds the ability to ask a ValueObject for a ValueObject that represents the virtual function table for a C++ class. If the Va

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Add the ability to get a C++ vtable ValueObject from another ValueObject. This patch adds the ability to ask a ValueObject for a ValueObject that represents the virtual function table for a C++ class. If the ValueObject is not a C++ class

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -374,6 +374,34 @@ class LLDB_API SBValue { lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write, SBError &error); + /// If this value represents a C++ class that has a vtable, return an value + /// that represent

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -374,6 +374,34 @@ class LLDB_API SBValue { lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write, SBError &error); + /// If this value represents a C++ class that has a vtable, return an value + /// that represent

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
jeffreytan81 wrote: Looks good in general to me. Several scenarios to test: * Make sure command works when the vtable symbol can be found but the vtable exists in another binary which do not have any symbols/debug info (which we have seen failure from lldb before) * Is vtable pointer guarante

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
jimingham wrote: This is an oft-requested feature so thanks for doing this! My only real complaint is that the code that determines the C++ "dynamic type" does much of the work that the ValueObjectVTable has to do to find the vtable pointer, and it's enough code that it seems a shame to have t

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
jimingham wrote: It might also be good to write a test that scribbles on the VTable and make sure that we present that usefully. That is a significant use case for this feature. https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailin

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-09-27 Thread via lldb-commits
@@ -1696,6 +1696,40 @@ TEST(Support, ReplacePathPrefix) { EXPECT_EQ(Path, "C:\\old/foo\\bar"); } +TEST(Support, FindProgramName) { + StringRef WindowsProgName = + path::program_name("C:\\Test\\foo.exe", path::Style::windows); + EXPECT_EQ(WindowsProgName, "foo"); + +

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -374,6 +374,34 @@ class LLDB_API SBValue { lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write, SBError &error); + /// If this value represents a C++ class that has a vtable, return an value + /// that represent

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
https://github.com/jimingham resolved https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
clayborg wrote: > This is an oft-requested feature so thanks for doing this! > > My only real complaint is that the code that determines the C++ "dynamic > type" does much of the work that the ValueObjectVTable has to do to find the > vtable pointer, and it's enough code that it seems a shame

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
clayborg wrote: > Looks good in general to me. > > Several scenarios to test: > > * Make sure command works when the vtable symbol can be found but the vtable > exists in another binary which do not have any debug info (which we have seen > failure from lldb before) Good idea. I tried to tes

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread via lldb-commits
jimingham wrote: > > This is an oft-requested feature so thanks for doing this! > > My only real complaint is that the code that determines the C++ "dynamic > > type" does much of the work that the ValueObjectVTable has to do to find > > the vtable pointer, and it's enough code that it seems a

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Overall I think this is fine, just a few comments here or there. I like the idea a lot, thanks for working on this. https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,65 @@ +//===-- ValueObjectVTable.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,325 @@ +//===-- ValueObjectVTable.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/67621 We just forget to check for interrupt while waiting for the answer to the prompt. But if we are in the interrupt state then the lower layers of the EditLine code just eat all characters so we never get out of

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes We just forget to check for interrupt while waiting for the answer to the prompt. But if we are in the interrupt state then the lower layers of the EditLine code just eat all characters so we never get out of the query prompt. You're prett

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 22433cc541ff706d9e845774ef1c8c959dc67799..fab5e1f67433a29a5d54198d83960d7e608dc480 lldb/t

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, thanks! Please fix the python formatting before landing. https://github.com/llvm/llvm-project/pull/67621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
jimingham wrote: > LGTM, thanks! > > Please fix the python formatting before landing. Seriously, we're enforcing "" vrs. ''? This is silly. https://github.com/llvm/llvm-project/pull/67621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] 0f339e6 - Fix a bug in handling ^C at the "y/n/a" completion prompt.

2023-09-27 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2023-09-27T17:20:48-07:00 New Revision: 0f339e6567bffb290e409ef5de272fb75ce70234 URL: https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234 DIFF: https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234.diff LO

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
jimingham wrote: I pushed this from the repro, going through the PR hoops was too much work just for uglification... https://github.com/llvm/llvm-project/pull/67621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] Fix a bug in handling ^C at the "y/n/a" completion prompt. (PR #67621)

2023-09-27 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/67621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread River Riddle via lldb-commits
https://github.com/River707 created https://github.com/llvm/llvm-project/pull/67628 LLDB_EXPORT_ALL_SYMBOLS is useful when building out-of-tree plugins and extensions that rely on LLDB's internal symbols. For example, this is how the Mojo language provides its REPL and debugger support. Suppo

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread River Riddle via lldb-commits
https://github.com/River707 updated https://github.com/llvm/llvm-project/pull/67628 >From 5174dcdd77567cc4e0dd063f6e5b7fce18dd767b Mon Sep 17 00:00:00 2001 From: River Riddle Date: Wed, 27 Sep 2023 18:59:53 -0700 Subject: [PATCH] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS LLDB_EXPO

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes LLDB_EXPORT_ALL_SYMBOLS is useful when building out-of-tree plugins and extensions that rely on LLDB's internal symbols. For example, this is how the Mojo language provides its REPL and debugger support. Supporting this on windows is kind

[Lldb-commits] [lldb] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

2023-09-27 Thread Shafik Yaghmour via lldb-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67514 >From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 26 Sep 2023 18:55:44 -0700 Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default a

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-09-27 Thread Greg Clayton via lldb-commits
clayborg wrote: I am implementing the fixes in the LanguageRuntime stuff. I have it working. Stay tuned to updates to this patch. https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. Other than a few nits, this is awesome! https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

2023-09-27 Thread Walter Erquinigo via lldb-commits
@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] 34ee53c - [lldb][test] Fix TestCallBuiltinFunction.py

2023-09-27 Thread Fangrui Song via lldb-commits
Author: Fangrui Song Date: 2023-09-27T22:37:24-07:00 New Revision: 34ee53c9e390019d757b453ceba9cc3e47ab0df1 URL: https://github.com/llvm/llvm-project/commit/34ee53c9e390019d757b453ceba9cc3e47ab0df1 DIFF: https://github.com/llvm/llvm-project/commit/34ee53c9e390019d757b453ceba9cc3e47ab0df1.diff