[Lldb-commits] [lldb] c308534 - [lldb] Rate limit progress reports -- different approach [WIP-ish]

Author: Pavel Labath Date: 2023-06-16T08:28:29+02:00 New Revision: c30853460da7446f92bc1e516f9cbe2c5df6e136 URL: https://github.com/llvm/llvm-project/commit/c30853460da7446f92bc1e516f9cbe2c5df6e136 DIFF: https://github.com/llvm/llvm-project/commit/c30853460da7446f92bc1e516f9cbe2c5df6e136.diff

[Lldb-commits] [lldb] 244fcec - [lldb] Fix MainLoopTest for changes in D152712

Author: Pavel Labath Date: 2023-06-16T09:05:27+02:00 New Revision: 244fcecb90fa7a3fb710ca5768d3bae9af5868cc URL: https://github.com/llvm/llvm-project/commit/244fcecb90fa7a3fb710ca5768d3bae9af5868cc DIFF: https://github.com/llvm/llvm-project/commit/244fcecb90fa7a3fb710ca5768d3bae9af5868cc.diff

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc30853460da7: [lldb] Rate limit progress reports -- different approach [WIP-ish] (authored by labath). Repository: rG L

[Lldb-commits] [lldb] afe8f20 - Revert "[lldb] Rate limit progress reports -- different approach [WIP-ish]"

Author: Pavel Labath Date: 2023-06-16T09:09:56+02:00 New Revision: afe8f20bb8dd1808cae542eb7ba0fc11a7886918 URL: https://github.com/llvm/llvm-project/commit/afe8f20bb8dd1808cae542eb7ba0fc11a7886918 DIFF: https://github.com/llvm/llvm-project/commit/afe8f20bb8dd1808cae542eb7ba0fc11a7886918.diff

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

labath reopened this revision. labath added a comment. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152364/new/ https://reviews.llvm.org/D152364 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

DavidSpickett added a comment. I assume https://github.com/llvm/llvm-project/commit/244fcecb90fa7a3fb710ca5768d3bae9af5868cc already fixed this. It fixed the bot and there's no failures currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1531

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

DavidSpickett added a comment. Sure, what name and email address should go on the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153060/new/ https://reviews.llvm.org/D153060 ___ lldb-commits maili

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

splhack abandoned this revision. splhack added a comment. @DavidSpickett thanks for the heads up, and thanks @labath to the commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153102/new/ https://reviews.llvm.org/D153102 _

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

Michael137 added a comment. Looks like this is failing on the Darwin x86_64 buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ Exit Code: 1 Command Output (stderr): -- clang: warning: argument unused during compilation: '-fmodules-cache-

[Lldb-commits] [lldb] af35be5 - [lldb] Remove unused directive from test for D153043

Author: Jaroslav Sevcik Date: 2023-06-16T12:46:21+02:00 New Revision: af35be55c032a5af93e235ca8347fffeb68b788e URL: https://github.com/llvm/llvm-project/commit/af35be55c032a5af93e235ca8347fffeb68b788e DIFF: https://github.com/llvm/llvm-project/commit/af35be55c032a5af93e235ca8347fffeb68b788e.dif

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin added a comment. In D153043#4427660 , @Michael137 wrote: > Looks like this is failing on the Darwin x86_64 buildbots: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ > > Exit Code: 1 > > Command Outp

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 532146. DavidSpickett added a comment. This revision is now accepted and ready to land. Move if up to before SVE registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152516/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 532156. DavidSpickett added a comment. Always add the TLS regset mask value. It worked on my QEMU setup because it also had the other extensions, but an armv8-a machine didn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett planned changes to this revision. DavidSpickett added a comment. Also found that clang at -00 will only read tpidr once vs. the gcc I had that would read it fresh each time. I can't rely on either of those to happen, so will change the test to use assembly to directly read and writ

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 532163. splhack added a comment. removed abandoned dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileEL

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 532165. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h lldb/include/lldb/U

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 532196. splhack added a comment. - s/AdbClientSP/AdbClientUP/g - Updated `Status &error` arg to `GetAdbClient` - Added error checks in AndroidPlatform for `GetAdbClient` - Added DownloadModuleSliceWithAdbClientError test for the GetAdbClient error Repository

[Lldb-commits] [lldb] 4c8b6fa - [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

Author: Alex Langford Date: 2023-06-16T10:44:55-07:00 New Revision: 4c8b6fae4437f9a5b17ddc146592aec0e4c78e02 URL: https://github.com/llvm/llvm-project/commit/4c8b6fae4437f9a5b17ddc146592aec0e4c78e02 DIFF: https://github.com/llvm/llvm-project/commit/4c8b6fae4437f9a5b17ddc146592aec0e4c78e02.diff

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b6fae4437: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

russelltg added a comment. Name: Russell Greene Email: russellgree...@gmail.com Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153060/new/ https://reviews.llvm.org/D153060 ___ lldb-commits m

[Lldb-commits] [lldb] 193c7d1 - [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

Author: Alex Langford Date: 2023-06-16T10:50:15-07:00 New Revision: 193c7d10cb30d846d35085a462f8a6c8ad226f1f URL: https://github.com/llvm/llvm-project/commit/193c7d10cb30d846d35085a462f8a6c8ad226f1f DIFF: https://github.com/llvm/llvm-project/commit/193c7d10cb30d846d35085a462f8a6c8ad226f1f.diff

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG193c7d10cb30: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 0b90d09 - [lldb][NFCI] Remove use of ConstString in ProcessStructReader

Author: Alex Langford Date: 2023-06-16T10:53:24-07:00 New Revision: 0b90d09898cadc89105c3caf0d01f09e66c49993 URL: https://github.com/llvm/llvm-project/commit/0b90d09898cadc89105c3caf0d01f09e66c49993 DIFF: https://github.com/llvm/llvm-project/commit/0b90d09898cadc89105c3caf0d01f09e66c49993.diff

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b90d09898ca: [lldb][NFCI] Remove use of ConstString in ProcessStructReader (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152968/new

[Lldb-commits] [lldb] 4493049 - [lldb][NFCI] Remove unused method Properties::GetSubProperty

Author: Alex Langford Date: 2023-06-16T10:55:01-07:00 New Revision: 44930490124d29c07b9538fb08fc6c7713cd74dc URL: https://github.com/llvm/llvm-project/commit/44930490124d29c07b9538fb08fc6c7713cd74dc DIFF: https://github.com/llvm/llvm-project/commit/44930490124d29c07b9538fb08fc6c7713cd74dc.diff

[Lldb-commits] [lldb] f2a1320 - [lldb] De-virtualize applicable functions in ValueObject (NFC)

Author: Dave Lee Date: 2023-06-16T11:12:15-07:00 New Revision: f2a1320c2ff5be9b3280eb926d3f10dc86f56d7f URL: https://github.com/llvm/llvm-project/commit/f2a1320c2ff5be9b3280eb926d3f10dc86f56d7f DIFF: https://github.com/llvm/llvm-project/commit/f2a1320c2ff5be9b3280eb926d3f10dc86f56d7f.diff LOG:

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2a1320c2ff5: [lldb] De-virtualize applicable functions in ValueObject (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 532243. splhack added a comment. Rename it to platform.plugin.remote-android.package-name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

splhack updated this revision to Diff 532245. splhack added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins/Platform/Android/CMakeLists.txt

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 __

[Lldb-commits] [lldb] 7d30878 - [lldb][NFCI] Avoid a few unnecessary ConstString constructions in StructuredDataDarwinLog

Author: Alex Langford Date: 2023-06-16T14:19:13-07:00 New Revision: 7d30878bf8586a991264c5ca9095a7b5a5234a42 URL: https://github.com/llvm/llvm-project/commit/7d30878bf8586a991264c5ca9095a7b5a5234a42 DIFF: https://github.com/llvm/llvm-project/commit/7d30878bf8586a991264c5ca9095a7b5a5234a42.diff

[Lldb-commits] [lldb] f1bb534 - [lldb] Simplify logging in Process settings (NFC)

Author: Jonas Devlieghere Date: 2023-06-16T14:46:46-07:00 New Revision: f1bb534b0ab53fab501fa92c4ef0f5eaf75c6bd6 URL: https://github.com/llvm/llvm-project/commit/f1bb534b0ab53fab501fa92c4ef0f5eaf75c6bd6 DIFF: https://github.com/llvm/llvm-project/commit/f1bb534b0ab53fab501fa92c4ef0f5eaf75c6bd6.d

[Lldb-commits] [lldb] ab85553 - [lldb] Fix Python test formatting (NFC)

Author: Jonas Devlieghere Date: 2023-06-16T14:51:14-07:00 New Revision: ab855530f797bbc113f75f833a4ca5711749d7c8 URL: https://github.com/llvm/llvm-project/commit/ab855530f797bbc113f75f833a4ca5711749d7c8 DIFF: https://github.com/llvm/llvm-project/commit/ab855530f797bbc113f75f833a4ca5711749d7c8.d

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString's benefits are not being utilized here, StringRef is