[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

labath added a comment. The patch description could definitely use more details about the motivation for the change, and a description of how it works. Apart from the fact that it uses the raSearch feature I introduced a while back, I don't know much about how it works (and given the planned ch

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's pretty much what I had in mind. Thanks. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:76 // Constructors and Destructors - SymbolFile(lldb::ObjectFileSP o

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added a comment. Thanks, for your patience. Overall, I'd say this looks pretty clean now -- much cleaner than I originally thought it could be. I don't have any further comments here. Does anyone else have any thoughts? Comment at: lldb/source/Core/Module.cpp:474 +

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

DavidSpickett added a comment. Bunch of random nits. Looks like a great addition. I know debug load time is a common annoyance. Comment at: lldb/docs/use/ondemand.rst:1 +On Demand Symbols += If you can find a logical place for it, maybe define

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

clayborg added a comment. Thanks Pavel for taking the time to review this thoroughly. I am fine with this as I have been working with Jeffrey on this, so anyone else please chime in if you have any comments! A few follow up patches I would love to see after this goes in: - add a command that a

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

clayborg added a comment. In D124198#3466889 , @labath wrote: > The patch description could definitely use more details about the motivation > for the change, and a description of how it works. Apart from the fact that > it uses the raSearch feature I i

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

clayborg added a comment. If anyone wants to see the "sbt" python command, I am happy to share it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124198/new/ https://reviews.llvm.org/D124198 ___ lldb-commi

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

clayborg added a comment. "sbt" == stack back trace Just looks at the stack for things that look like code and tries to make something that looks like a backtrace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124198/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

jingham added a comment. I also wonder if this shouldn't require a separate flag to turn on this search, or be a separate command in the way Greg did. People rely on backtraces being accurate. It's fine to add something more like a desperation play - something is sometimes better than nothing

[Lldb-commits] [lldb] fd14646 - [LLDB] Applying clang-tidy modernize-use-override over LLDB

Author: Shafik Yaghmour Date: 2022-04-22T13:29:47-07:00 New Revision: fd1464604367f2259614b66c886db16598b5be6b URL: https://github.com/llvm/llvm-project/commit/fd1464604367f2259614b66c886db16598b5be6b DIFF: https://github.com/llvm/llvm-project/commit/fd1464604367f2259614b66c886db16598b5be6b.dif

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd1464604367: [LLDB] Applying clang-tidy modernize-use-override over LLDB (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace marked 13 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:265 +class TraceEventsUtils { +public: jj10306 wrote: > nit: maybe this will change in the future to where this will have data and > in

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

wallace updated this revision to Diff 424658. wallace marked 3 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/ https://reviews.llvm.org/D123982 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: LLDB. This fixes the stand-alone build configuration where LLVM_MAIN_SRC_DIR does not exist. Repository: rG LLVM Github Monorepo