[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

omjavaid added a comment. In D118794#3405724 , @DavidSpickett wrote: > Switch to removing non-address bits in lldb instead of lldb-server. > > The breakpoint issues I mention only really happen if you try to break on a > tagged > function pointer. Which

[Lldb-commits] [lldb] 5560b9e - [lldb] [CMake] Disable GCC's -Wstringop-truncation warning. NFC.

Author: Martin Storsjö Date: 2022-04-07T12:09:01+03:00 New Revision: 5560b9e88423dbe044f4e82d4dc3d4b6dbd0e678 URL: https://github.com/llvm/llvm-project/commit/5560b9e88423dbe044f4e82d4dc3d4b6dbd0e678 DIFF: https://github.com/llvm/llvm-project/commit/5560b9e88423dbe044f4e82d4dc3d4b6dbd0e678.diff

[Lldb-commits] [PATCH] D123254: [lldb] Disable GCC's -Wstringop-truncation warning. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5560b9e88423: [lldb] [CMake] Disable GCC's -Wstringop-truncation warning. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [lldb] 3031fa8 - [lldb] Fix building standalone LLDB on Windows.

Author: Mehdi Chinoune Date: 2022-04-07T12:30:33+03:00 New Revision: 3031fa88f01e59dcacb0a3020fb9a27ccf2b7615 URL: https://github.com/llvm/llvm-project/commit/3031fa88f01e59dcacb0a3020fb9a27ccf2b7615 DIFF: https://github.com/llvm/llvm-project/commit/3031fa88f01e59dcacb0a3020fb9a27ccf2b7615.diff

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett added a comment. > Do you have any explanation on this from AARM Yes I do. linux arch/arm64/kernel/ptrace.c: /* * The PAC bits can differ across data and instruction pointers * depending on TCR_EL1.TBID*, which we may make use of in future, so * we expose separ

[Lldb-commits] [lldb] e22a60b - Revert "Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON"""

Author: Nico Weber Date: 2022-04-07T10:07:07-04:00 New Revision: e22a60b1c898a760a73417fa225c2fbe0609a69f URL: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f DIFF: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f.diff LO

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

jj10306 added a comment. Overall looks good, just a couple cosmetic things and comments about the plan for multi-buffer, single thread decoding Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:41 + +/// Class that decodes a raw buffer for a single thread using

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

jj10306 added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:265 + lldb::tid_t tid, llvm::StringRef kind, + std::function data)> callback); + typedef the callback to be cleaner and make the intention more clear? Comment

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. Thanks for enabling the test, great to see support for this outside Linux. Comment at: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp:817 + return address_mask; +} + I was going to suggest deduping this and the Linux function

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

JDevlieghere updated this revision to Diff 421256. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/packages/Python/lld

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:265 + lldb::tid_t tid, llvm::StringRef kind, + std::function data)> callback); + jj10306 wrote: > typedef the callback to be cleaner and make the intention more clear? good idea

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

wallace added a comment. thanks for the gotchas Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:41 + +/// Class that decodes a raw buffer for a single thread using the low level +/// libipt library. jj10306 wrote: > "for a single thread" > thin

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu updated this revision to Diff 421281. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122943/new/ https://reviews.llvm.org/D122943 Files: lldb/source/Plugins/Sym

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:54 struct FindMembersSize : public TypeVisitorCallbacks { - FindMembersSize(std::vector> &members_info, + FindMembersSize(llvm::SmallVector> &members_info, TpiS

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

wallace updated this revision to Diff 421283. wallace marked 6 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123106/new/ https://reviews.llvm.org/D123106 Files: lldb/source/Plugi

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Pretty straightforward, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

wallace updated this revision to Diff 421291. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123281/new/ https://reviews.llvm.org/D123281 Files: lldb/include/lldb/Target/Trace.h lldb/source/Plugins/Trac

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

teemperor accepted this revision. teemperor added a comment. This is beautiful CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] ee2d9b8 - [lldb] Add Python bindings to print stack traces on crashes.

Author: Jonas Devlieghere Date: 2022-04-07T11:21:02-07:00 New Revision: ee2d9b8723561fb6a81b9c2c4fd7a93300c6154f URL: https://github.com/llvm/llvm-project/commit/ee2d9b8723561fb6a81b9c2c4fd7a93300c6154f DIFF: https://github.com/llvm/llvm-project/commit/ee2d9b8723561fb6a81b9c2c4fd7a93300c6154f.d

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee2d9b872356: [lldb] Add Python bindings to print stack traces on crashes. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/ne

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

labath added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:215-216 + llvm::EnablePrettyStackTrace(); + // We don't have a meaningful argv[0] to use, so use "SBDebugger" as a + // substitute. + llvm::sys::PrintStackTraceOnErrorSignal("SBDebugger"); --

[Lldb-commits] [lldb] f42f217 - [lldb][gui] handle Ctrl+C to stop a running process

Author: Luboš Luňák Date: 2022-04-07T21:58:37+02:00 New Revision: f42f21746cb8b940518bf37e5917d61542d278b7 URL: https://github.com/llvm/llvm-project/commit/f42f21746cb8b940518bf37e5917d61542d278b7 DIFF: https://github.com/llvm/llvm-project/commit/f42f21746cb8b940518bf37e5917d61542d278b7.diff L

[Lldb-commits] [lldb] c29a51b - [lldb][gui] remove the "expand" diamond for variables where expanding fails

Author: Luboš Luňák Date: 2022-04-07T21:59:18+02:00 New Revision: c29a51b3a257908aebc01cd7c4655665db317d66 URL: https://github.com/llvm/llvm-project/commit/c29a51b3a257908aebc01cd7c4655665db317d66 DIFF: https://github.com/llvm/llvm-project/commit/c29a51b3a257908aebc01cd7c4655665db317d66.diff L

[Lldb-commits] [PATCH] D123015: handle Ctrl+C to stop a running process

This revision was automatically updated to reflect the committed changes. Closed by commit rGf42f21746cb8: [lldb][gui] handle Ctrl+C to stop a running process (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123015/new/ https://re

[Lldb-commits] [PATCH] D123008: remove the "expand" diamond for variables where expanding fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGc29a51b3a257: [lldb][gui] remove the "expand" diamond for variables where expanding fails (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak abandoned this revision. llunak added a comment. In D123020#3426867 , @JDevlieghere wrote: > FWIW the official policy is outlined here: > https://llvm.org/docs/CodeReview.html I'm aware of it, but as far as I can judge I was following it. Even r

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437246 , @llunak wrote: > In D123020#3426867 , @JDevlieghere > wrote: > >> FWIW the official policy is outlined here: >> https://llvm.org/docs/CodeReview.html > > I'm aw

[Lldb-commits] [lldb] 8ece6b7 - [lldb] Use getMainExecutable in SBDebugger::PrintStackTraceOnError

Author: Jonas Devlieghere Date: 2022-04-07T13:53:23-07:00 New Revision: 8ece6b78c0425ba587c34bbb046d1cb6529a4569 URL: https://github.com/llvm/llvm-project/commit/8ece6b78c0425ba587c34bbb046d1cb6529a4569 DIFF: https://github.com/llvm/llvm-project/commit/8ece6b78c0425ba587c34bbb046d1cb6529a4569.d

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

shafik created this revision. shafik added reviewers: labath, JDevlieghere, aprantl. Herald added a project: All. shafik requested review of this revision. Herald added a subscriber: aheejin. Applied clang-tidy `modernize-use-override` over LLDB and added it to the LLDB `.clang-tidy` config. ht

[Lldb-commits] [PATCH] D123092: [LLDB][NativePDB] Fix inline line info in line table

zequanwu updated this revision to Diff 421352. zequanwu added a comment. Modity inline_sites.test to do non-live test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123092/new/ https://reviews.llvm.org/D123092 Files: lldb/source/Plugins/SymbolFi

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

clayborg added a comment. So the setting should take care of everything and we should be able to increase it when running with valgrind right? I would rather not have code all over LLDB making valgrind tests and doing something in response if possible Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

JDevlieghere added a comment. In D123020#3437512 , @clayborg wrote: > So the setting should take care of everything and we should be able to > increase it when running with valgrind right? I would rather not have code > all over LLDB making valgrind tes

[Lldb-commits] [PATCH] D123340: Applying clang-tidy modernize-use-override over LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the redundant comment Comment at: lldb/unittests/Target/RemoteAwarePlatformTest.cpp:40 const ModuleSpec &module_spec, lldb::ModuleSP &exe_modul

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Target/Trace.h:386-396 + llvm::DenseMap> m_live_thread_data; + /// data kind -> size std::unordered_map m_live_process_data;

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:386-396 + llvm::DenseMap> m_live_thread_data; + /// data kind -> size std::unordered_map m_live_process_data; + /// \} + jj10306 wrote: > Why not change all the maps to Den

[Lldb-commits] [PATCH] D123106: [trace][intel pt] Create a class for the libipt decoder wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG6423b5023521: [trace][intel pt] Create a class for the libipt decoder wrapper (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D123281: [trace][intel pt] Create a common accessor for live and postmortem data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0cfe20ad2fb: [trace][intel pt] Create a common accessor for live and postmortem data (authored by Walter Erquinigo ). Repository:

[Lldb-commits] [lldb] e0cfe20 - [trace][intel pt] Create a common accessor for live and postmortem data

Author: Walter Erquinigo Date: 2022-04-07T15:58:44-07:00 New Revision: e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f URL: https://github.com/llvm/llvm-project/commit/e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f DIFF: https://github.com/llvm/llvm-project/commit/e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f.di

[Lldb-commits] [lldb] 6423b50 - [trace][intel pt] Create a class for the libipt decoder wrapper

Author: Walter Erquinigo Date: 2022-04-07T15:58:34-07:00 New Revision: 6423b50235212db4c3a2e673b2b59fa5f6e07ec0 URL: https://github.com/llvm/llvm-project/commit/6423b50235212db4c3a2e673b2b59fa5f6e07ec0 DIFF: https://github.com/llvm/llvm-project/commit/6423b50235212db4c3a2e673b2b59fa5f6e07ec0.di

[Lldb-commits] [PATCH] D123356: add task timer

wallace created this revision. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123356 Files: lldb/so

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

wallace created this revision. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm adding two new classes that can be used to measure the duration of long tasks as proc

[Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size

wallace created this revision. wallace added reviewers: jj10306, zrthxn. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Something ugly I did was to report the trace buffer size to the DecodedThread, whi