[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

labath added inline comments. Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t& INOUT { uint64_t& completed }; +%apply uint64_t& INOUT { uint64_t& total }; +%apply bool& INOUT { bool& is_d

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c267e0c9d9: [lldb] Fix race condition between lldb-vscode and stop hooks executor (authored by ilya-nozhkin, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] a2c267e - [lldb] Fix race condition between lldb-vscode and stop hooks executor

Author: Ilya Nozhkin Date: 2022-02-22T12:53:55+01:00 New Revision: a2c267e0c9d9b9963f4022caf455327a7d96dfbf URL: https://github.com/llvm/llvm-project/commit/a2c267e0c9d9b9963f4022caf455327a7d96dfbf DIFF: https://github.com/llvm/llvm-project/commit/a2c267e0c9d9b9963f4022caf455327a7d96dfbf.diff

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. Committed. Thanks for the great patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ilya-nozhkin created this revision. ilya-nozhkin added reviewers: labath, clayborg. Herald added a subscriber: pengfei. ilya-nozhkin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `SetValueFromCString` and `SetData` methods return false if

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath created this revision. labath added reviewers: mgorny, DavidSpickett. labath requested review of this revision. Herald added a project: LLDB. Our SIGTSTP handler was working, but that was mostly accidental. The reason it worked is because lldb is multithreaded for most of its lifetime and

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. Accept a function object instead of a raw pointer. This avoids a bunch of boilerplate typically needed to pass arguments t

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. The class is using an incredibly elaborate setup to create and destroy an NSAutoreleasePool object. We can do it in a much simpler way by making thos

[Lldb-commits] [lldb] 126a260 - [lldb] Remove HostProcess:GetMainModule

Author: Pavel Labath Date: 2022-02-22T16:00:58+01:00 New Revision: 126a2607a8458c7928aa1da880d45c36560017a6 URL: https://github.com/llvm/llvm-project/commit/126a2607a8458c7928aa1da880d45c36560017a6 DIFF: https://github.com/llvm/llvm-project/commit/126a2607a8458c7928aa1da880d45c36560017a6.diff

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

kastiglione added a comment. @jasonmolenda one advantage this has over grepping is that the python specific extensions to SB are visible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292 _

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

kastiglione added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re oh,

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re kastiglione

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

kastiglione added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re mib

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added inline comments. Comment at: lldb/bindings/python/python-extensions.swig:528-533 +def find(pattern, flags=re.I): +""" +Find matching SB methods/properties. See also Python's builtin `help()`. +""" +import lldb +import re kastiglione

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

jasonmolenda added a comment. In D120292#3338155 , @kastiglione wrote: > @jasonmolenda one advantage this has over grepping is that the python > specific extensions to SB are visible. That's true too. I mostly meant my comment as in, "I find this feat

[Lldb-commits] [PATCH] D120322: [lldb] Simplify HostThreadMacOSX

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm:17-20 + NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; + lldb::thread_result_t result = HostThreadPosix::ThreadCreateTrampoline(arg); + [pool drain]; + return resul

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice cleanup Comment at: lldb/source/Host/common/HostNativeThreadBase.cpp:55-56 HostNativeThreadBase::ThreadCreateTrampoline(lldb::thread_arg_t arg) { - ThreadL

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 410679. zequanwu added a comment. - Use `-show-variable-ranges/-R single/all` to dump single addres range that contains the querying address or all address ranges. It seeme like I can't use non-printable character like `\\x01` to omit short option when it t

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x