[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

2022-01-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. Interesting solution to the problem. I'm not sure how long will the diff files remain applicable, but I would've accepted this even without them so I think all is fine.

[Lldb-commits] [lldb] ca271f4 - [lldb-server/linux] Fix waitpid for multithreaded forks

2022-01-03 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-03T14:27:52+01:00 New Revision: ca271f4ef5a2a4bf115ac11ada70bbd7c737d77d URL: https://github.com/llvm/llvm-project/commit/ca271f4ef5a2a4bf115ac11ada70bbd7c737d77d DIFF: https://github.com/llvm/llvm-project/commit/ca271f4ef5a2a4bf115ac11ada70bbd7c737d77d.diff

[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

2022-01-03 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca271f4ef5a2: [lldb-server/linux] Fix waitpid for multithreaded forks (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116372/new/ https:

[Lldb-commits] [lldb] 862fffd - [lldb/qemu] Set qemu's "ld prefix" based on the platform sysroot

2022-01-03 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-03T14:48:13+01:00 New Revision: 862fffd8231c8c44a8ea8071041eac8919aed346 URL: https://github.com/llvm/llvm-project/commit/862fffd8231c8c44a8ea8071041eac8919aed346 DIFF: https://github.com/llvm/llvm-project/commit/862fffd8231c8c44a8ea8071041eac8919aed346.diff

[Lldb-commits] [lldb] a8ae682 - [lldb] Delete GDBRemoteCommunicationReplayServer

2022-01-03 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-03T16:13:57+01:00 New Revision: a8ae6828a98dcd5ea083eb07be8ad6db77b688a2 URL: https://github.com/llvm/llvm-project/commit/a8ae6828a98dcd5ea083eb07be8ad6db77b688a2 DIFF: https://github.com/llvm/llvm-project/commit/a8ae6828a98dcd5ea083eb07be8ad6db77b688a2.diff

[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection

2022-01-03 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: mgorny, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Previously we would persist the flags indicating whether the remote side supports a particular feature across reconnects, which is obviously not a goo

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Kadir Cetinkaya via Phabricator via lldb-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Sam McCall via Phabricator via lldb-commits
sammccall added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void ProcessOverloadCandidates(Sema &S, unsigned CurrentArg, O

[Lldb-commits] [lldb] 92417ea - [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Sam McCall via lldb-commits
Author: Sam McCall Date: 2022-01-03T20:14:59+01:00 New Revision: 92417eaf3329dc823c905ec6a608b83ac62b4f7c URL: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c DIFF: https://github.com/llvm/llvm-project/commit/92417eaf3329dc823c905ec6a608b83ac62b4f7c.diff LO

[Lldb-commits] [PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Sam McCall via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92417eaf3329: [CodeCompletion] Signature help for braced constructor calls (authored by sammccall). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

2022-01-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. I see now this isn't valid as written. The address range and rwx permissions printed by `memory region` are for the segment not the section. I think it would be helpful to print the section too, but as this change is written now, it could appear that all the info is

[Lldb-commits] [lldb] 67c937f - [lldb] Use std::move in StringList (NFC)

2022-01-03 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2022-01-03T15:36:19-08:00 New Revision: 67c937f846b18e3113e126c37c69a222c0e99c1c URL: https://github.com/llvm/llvm-project/commit/67c937f846b18e3113e126c37c69a222c0e99c1c DIFF: https://github.com/llvm/llvm-project/commit/67c937f846b18e3113e126c37c69a222c0e99c1c.diff LOG:

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

2022-01-03 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D116211#3211319 , @labath wrote: > What happened to the test case? I didn't think of a way of constructing one very easily with what we have r.n. :/ The closest would be a gdb_remote_client test, but we need a binary th