[Lldb-commits] [lldb] a2363c0 - Reland "[lldb] Set return status to failed when adding a command error"

2021-06-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-06-14T09:19:25Z New Revision: a2363c0cf9b6a9a81c76ac652da667f73845d38b URL: https://github.com/llvm/llvm-project/commit/a2363c0cf9b6a9a81c76ac652da667f73845d38b DIFF: https://github.com/llvm/llvm-project/commit/a2363c0cf9b6a9a81c76ac652da667f73845d38b.diff LOG

[Lldb-commits] [lldb] 0f94d68 - [lldb] Add missing changes to a2363c0cf9b6a9a81c76ac652da667f73845d38b

2021-06-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-06-14T09:23:30Z New Revision: 0f94d68a2e15d50796439f20bcb508b95931d2ae URL: https://github.com/llvm/llvm-project/commit/0f94d68a2e15d50796439f20bcb508b95931d2ae DIFF: https://github.com/llvm/llvm-project/commit/0f94d68a2e15d50796439f20bcb508b95931d2ae.diff LOG

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

2021-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Relanded in https://reviews.llvm.org/rGa2363c0cf9b6 / https://reviews.llvm.org/rG0f94d68a2e15 (because I have a case of the Monday Mornings). If this does the trick there are 2/3 other tests that use this tactic to check for AVX so I can update those too. Reposi

[Lldb-commits] [lldb] f583029 - [lldb] Correct "else if" to "elif" in TestRegisters

2021-06-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-06-14T09:36:00Z New Revision: f583029da3d6dbabe82f48b160227eb0120abd33 URL: https://github.com/llvm/llvm-project/commit/f583029da3d6dbabe82f48b160227eb0120abd33 DIFF: https://github.com/llvm/llvm-project/commit/f583029da3d6dbabe82f48b160227eb0120abd33.diff LOG

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 351819. teemperor added a comment. - Make language more uniform - Point out anonymous struct is a GNU extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103454/new/ https://reviews.llvm.org/D103454 Files: lldb/bindings/interface/SBType.i

[Lldb-commits] [lldb] 11e2922 - [lldb][docs] Document SBType

2021-06-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-06-14T13:19:19+02:00 New Revision: 11e2922bb7adbbca17c3a0f44779aa87dbc64b42 URL: https://github.com/llvm/llvm-project/commit/11e2922bb7adbbca17c3a0f44779aa87dbc64b42 DIFF: https://github.com/llvm/llvm-project/commit/11e2922bb7adbbca17c3a0f44779aa87dbc64b42.dif

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11e2922bb7ad: [lldb][docs] Document SBType (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] ac031c8 - Revert "[lldb] Set return status to failed when adding a command error" (and fixups)

2021-06-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-06-14T12:09:42Z New Revision: ac031c8db2ce454a9b08f23192ce698e8bde4447 URL: https://github.com/llvm/llvm-project/commit/ac031c8db2ce454a9b08f23192ce698e8bde4447 DIFF: https://github.com/llvm/llvm-project/commit/ac031c8db2ce454a9b08f23192ce698e8bde4447.diff LOG

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. HostInfoBase has a deleted dtor/ctor so there is no need to do the same

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

2021-06-14 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104221/new/ https://reviews.llvm.org/D104221 _

[Lldb-commits] [lldb] 31b9aca - Reland "[lldb] Set return status to failed when adding a command error"

2021-06-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2021-06-14T14:26:47+01:00 New Revision: 31b9acaec5797e409afb83d665fc8816d8a37940 URL: https://github.com/llvm/llvm-project/commit/31b9acaec5797e409afb83d665fc8816d8a37940 DIFF: https://github.com/llvm/llvm-project/commit/31b9acaec5797e409afb83d665fc8816d8a37940.diff

[Lldb-commits] [lldb] e3d5e31 - [lldb][docs] Fix section name for InputReaderGranularity

2021-06-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-06-14T16:21:40+02:00 New Revision: e3d5e3193fd5a202a58652d28115f71d0a04a479 URL: https://github.com/llvm/llvm-project/commit/e3d5e3193fd5a202a58652d28115f71d0a04a479 DIFF: https://github.com/llvm/llvm-project/commit/e3d5e3193fd5a202a58652d28115f71d0a04a479.dif

[Lldb-commits] [lldb] d94ce1a - [lldb][docs] Add the missing rst anchors to the Python enum docs

2021-06-14 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-06-14T16:31:28+02:00 New Revision: d94ce1a391cbc85dab13ac6b6c4afbaef7684eec URL: https://github.com/llvm/llvm-project/commit/d94ce1a391cbc85dab13ac6b6c4afbaef7684eec DIFF: https://github.com/llvm/llvm-project/commit/d94ce1a391cbc85dab13ac6b6c4afbaef7684eec.dif

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. teemperor requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SBHostOS implements a threading framework that allows creating and manipulating OS threads in the current process.

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 351882. teemperor added a comment. Herald added a subscriber: JDevlieghere. - Remove the deprecation attribute that got inserted by accident. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104231/new/ https://reviews.llvm.org/D104231 Files: lldb

[Lldb-commits] [PATCH] D104231: [lldb] Deprecate the threading functionality in SBHostOS

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Not sure what else we should do to properly deprecate an API. LLVM's approach would be to put `[[deprecated("bla")]]` the C++ APIs (which would mean you need a C++14 compiler to use the SB API) and there is also the `lldb-versioning.h` header (which seems to be reserv

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Not sure what happened to my accept, but I'll LGTM this again. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104041/new/ https://reviews.llvm.org/D104041 __

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

2021-06-14 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. I am sure I could find a bunch of other ends and odds but perhaps you have other checks that will cover these coming up. Comment at: lldb/include/lldb/Core/ThreadSafeValue.h:21 // Constructors and Destructors ThreadSafeValue() : m_value(), m_mute

[Lldb-commits] [PATCH] D104176: [libunwind] Define and use portable macro for checking for presence of ASAN

2021-06-14 Thread Daniel Levin via Phabricator via lldb-commits
daniel-levin updated this revision to Diff 351707. daniel-levin added a comment. Herald added subscribers: lldb-commits, dexonsmith, pengfei, delcypher, hiraditya, mgorny. Herald added a project: LLDB. [libunwind] Use most appropriate macro for checking for presence of ASan. Repository: rG LL

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

2021-06-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104221/new/ https://reviews.llvm.org/D104221 ___ lldb-commits mailin

[Lldb-commits] [lldb] 03841ed - Allow signposts to take advantage of deferred string substitution

2021-06-14 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2021-06-14T14:19:41-07:00 New Revision: 03841edde7eee21d1d450041ab9a113a7e1be869 URL: https://github.com/llvm/llvm-project/commit/03841edde7eee21d1d450041ab9a113a7e1be869 DIFF: https://github.com/llvm/llvm-project/commit/03841edde7eee21d1d450041ab9a113a7e1be869.diff

[Lldb-commits] [lldb] 7a7c007 - Revert "Allow signposts to take advantage of deferred string substitution"

2021-06-14 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2021-06-14T16:09:04-07:00 New Revision: 7a7c00761f6294dc21c40cbe1737354e655cda9b URL: https://github.com/llvm/llvm-project/commit/7a7c00761f6294dc21c40cbe1737354e655cda9b DIFF: https://github.com/llvm/llvm-project/commit/7a7c00761f6294dc21c40cbe1737354e655cda9b.diff

[Lldb-commits] [lldb] 035217f - Allow signposts to take advantage of deferred string substitution

2021-06-14 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2021-06-14T16:53:41-07:00 New Revision: 035217ff515b8ecdc871e39fa840f3cba1b9cec7 URL: https://github.com/llvm/llvm-project/commit/035217ff515b8ecdc871e39fa840f3cba1b9cec7 DIFF: https://github.com/llvm/llvm-project/commit/035217ff515b8ecdc871e39fa840f3cba1b9cec7.diff

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

2021-06-14 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. The Windows buildbot does not like signposts: https://lab.llvm.org/buildbot/#/builders/83/builds/7271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

2021-06-14 Thread Siger Young via Phabricator via lldb-commits
siger-young created this revision. Herald added a subscriber: arphaman. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a basic reference page for Lua scripting, as a counterpart to section "Python Reference". Repository:

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

2021-06-14 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Instead of copying the text from the Python page, I was actually thinking whether we should make the 'scripting' page more generic and just add the language-specific examples for Python and Lua there. I am not sure what's the best way to do that visually though with R