teemperor accepted this revision.
teemperor added a comment.
I think this can just land as an optimisation. If we can read the size from
DWARF (e.g., just returning the stored size int) then that's much better than
computing the layout for some type.
CHANGES SINCE LAST ACTION
https://reviews
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
I think the test files should go in
`test/API/functionalities/ptrauth_diagnostics/` instead.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/ptrauth_diagnostics/BLRAA_error/blraa.c:1
vsk updated this revision to Diff 345513.
vsk added a comment.
Address code review feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102428/new/
https://reviews.llvm.org/D102428
Files:
lldb/include/lldb/Core/Address.h
lldb/include/lldb/C
vsk added a comment.
Thanks for the review!
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/ptrauth_diagnostics/BLRAA_error/blraa.c:19
+
+// Before:
+#if 0
DavidSpickett wrote:
> What is the purpose of the `// Before:` blocks here? Simply to gi
kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Document how to complete command line suggestions provided by
`show-autosuggestion`.
Repository:
rG L
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
I think fish shell (where I got that idea from) calls this "*accepting* a
suggestion" which seems clearer than "completing a suggestion".
Otherwise this LGTM, thanks!
Repository:
rG
