[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

2020-09-20 Thread António Afonso via Phabricator via lldb-commits
aadsm added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:520 std::vector m_lldb_cu_to_dwarf_unit; + lldb::addr_t m_first_code_address = LLDB_INVALID_ADDRESS; }; labath wrote: > clayborg wrote: > > A lengthy comment woul

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

2020-09-20 Thread António Afonso via Phabricator via lldb-commits
aadsm added a comment. > Why would we be doing something (particularly a thing which will be hard to > do in a cross-platform manner, and will very likely border on, or downright > cross into, undefined behavior territory), if we get that from vscode for > free? I'm not sure what you mean with