[Lldb-commits] [lldb] a4a0844 - [lldb] Don't use static locals for return value storage in some *AsCString functions

Author: Raphael Isemann Date: 2020-07-30T12:17:42+02:00 New Revision: a4a0844248d4a68a866b9c4e18ae89fa49a83ec0 URL: https://github.com/llvm/llvm-project/commit/a4a0844248d4a68a866b9c4e18ae89fa49a83ec0 DIFF: https://github.com/llvm/llvm-project/commit/a4a0844248d4a68a866b9c4e18ae89fa49a83ec0.dif

[Lldb-commits] [PATCH] D84505: [lldb] Don't use static locals for return value storage in some *AsCString functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a0844248d4: [lldb] Don't use static locals for return value storage in some *AsCString… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG L

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. I'm not hitting the same bug here, but I do hit a different bug. If I have a autosuggestion and then type another character that causes a shorter autosuggestion to display, then the old text of the autosuggestion is not deleted from the terminal. For example: > ./

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth added a comment. Thanks. Working on a test. I found a description of how the Windows debuggers look for PDBs, and it's different than what I expected: 1. The directory that contains the binary 2. The build path embedded in the binary 3. (if enabled) The symbol server cache 4. (if enab

[Lldb-commits] [lldb] b6635b5 - [lldb] Add SBCommandInterpreterRunOptions to LLDB.h

Author: Jonas Devlieghere Date: 2020-07-30T08:46:19-07:00 New Revision: b6635b5b15cb1c160776493a982302a854df332e URL: https://github.com/llvm/llvm-project/commit/b6635b5b15cb1c160776493a982302a854df332e DIFF: https://github.com/llvm/llvm-project/commit/b6635b5b15cb1c160776493a982302a854df332e.d

[Lldb-commits] [lldb] 09cb6f2 - [lldb][NFC][test] Fix comment referring to FileCheck instead of yaml2obj

Author: Jordan Rupprecht Date: 2020-07-30T09:47:44-07:00 New Revision: 09cb6f233d3d18cb17ba00188cbc32a414ec0c82 URL: https://github.com/llvm/llvm-project/commit/09cb6f233d3d18cb17ba00188cbc32a414ec0c82 DIFF: https://github.com/llvm/llvm-project/commit/09cb6f233d3d18cb17ba00188cbc32a414ec0c82.di

[Lldb-commits] [lldb] be198e0 - [lldb][test] Move registers-target-xml-reading target to the correct test location.

Author: Jordan Rupprecht Date: 2020-07-30T10:28:32-07:00 New Revision: be198e03ebba264baadfd2ed383b1725633c43ea URL: https://github.com/llvm/llvm-project/commit/be198e03ebba264baadfd2ed383b1725633c43ea DIFF: https://github.com/llvm/llvm-project/commit/be198e03ebba264baadfd2ed383b1725633c43ea.di

[Lldb-commits] [lldb] 41909e9 - [lldb] Add copy ctor/assignment operator to SBCommandInterpreterRunOptions

Author: Jonas Devlieghere Date: 2020-07-30T10:39:30-07:00 New Revision: 41909e96824b73162431e84cbba071b1ff4f6341 URL: https://github.com/llvm/llvm-project/commit/41909e96824b73162431e84cbba071b1ff4f6341 DIFF: https://github.com/llvm/llvm-project/commit/41909e96824b73162431e84cbba071b1ff4f6341.d

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: jingham. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Target clears watchpoints hit count but doesn't do the same for

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Trying to kill exited/detached process in not error

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: asmith. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Don't report an error, just log this happened. This fixes a lot o

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

ted created this revision. ted added reviewers: clayborg, jingham, labath. Herald added a project: LLDB. ted requested review of this revision. Herald added a subscriber: JDevlieghere. On Hexagon, breakpoints need to be on the first instruction of a packet. When the LLVM disassembler for Hexagon r

[Lldb-commits] [PATCH] D84955: Report an error if a CLI option lacks an argument

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Thanks for fixing this. I do have a few comments but the logic looks good. Comment at: lldb/test/Shell/Driver/TestError.test:1 +RUN: not %lldb --arch 2>

[Lldb-commits] [lldb] 3bb4889 - [lldb/Test] Use self.assertIn in TestGdbRemoteTargetXmlPacket

Author: Jonas Devlieghere Date: 2020-07-30T11:48:35-07:00 New Revision: 3bb48898bc8af58884d4aa6279d4281938c07e76 URL: https://github.com/llvm/llvm-project/commit/3bb48898bc8af58884d4aa6279d4281938c07e76 DIFF: https://github.com/llvm/llvm-project/commit/3bb48898bc8af58884d4aa6279d4281938c07e76.d

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

clayborg added a comment. LGTM after fixing clang format related changes seen in "Lint: Pre-merge checks" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84966/new/ https://reviews.llvm.org/D84966 ___ lldb

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aelitashen requested review of this revision. Herald added a subscriber: JDevlieghere. When turn on "Launch In Terminal" in IDE, the debugee will

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. This is very good for a first implementation. You need to write a test for this as well. Once this works, you have to work on the launcher helper Greg and I mentioned to you that w

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha updated this revision to Diff 282030. tatyana-krasnukha added a comment. TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8c1a31d - [lldb/Docs] Add lldb-arm-ubuntu to the list of bots

Author: Jonas Devlieghere Date: 2020-07-30T13:47:21-07:00 New Revision: 8c1a31d83313e4d43509177193f1de14cf897c05 URL: https://github.com/llvm/llvm-project/commit/8c1a31d83313e4d43509177193f1de14cf897c05 DIFF: https://github.com/llvm/llvm-project/commit/8c1a31d83313e4d43509177193f1de14cf897c05.d

[Lldb-commits] [lldb] 02c1bba - [lldb/Docs] Remove stale bot on GreenDragon and add reproducer one

Author: Jonas Devlieghere Date: 2020-07-30T13:51:16-07:00 New Revision: 02c1bba67009041a999220f370e81376883d7a65 URL: https://github.com/llvm/llvm-project/commit/02c1bba67009041a999220f370e81376883d7a65 DIFF: https://github.com/llvm/llvm-project/commit/02c1bba67009041a999220f370e81376883d7a65.d

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide updated this revision to Diff 282073. davide added a comment. Added the check that Jason requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 Files: lldb/tools/debugserver/source/DNB.cpp lldb/tools/debugserver/source/debugserver

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Reviewed by Jason privately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___ lldb-commits mai

[Lldb-commits] [lldb] 5760575 - [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

Author: Davide Italiano Date: 2020-07-30T16:21:05-07:00 New Revision: 57605758b5de3726eec1d6e587de1003af1ab5b7 URL: https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7 DIFF: https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7.dif

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

clayborg requested changes to this revision. clayborg added a comment. So there is a fundamental change needed for this patch to work. I tried to fully detail this in the inline comments. Let me know if you have any questions. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1576 +} +void response_runInTerminal(const llvm::json::Object &reverseRequest) { + g_vsc.is_attach = true; wallace wrote: > mention here that VSCode doesn't respond back the pid o

[Lldb-commits] [lldb] abf546d - debguserver's type sniffer to only treat .app things that end in .app

Author: Jason Molenda Date: 2020-07-30T21:14:33-07:00 New Revision: abf546dd4f8326b821244b67eaa79ada7757d877 URL: https://github.com/llvm/llvm-project/commit/abf546dd4f8326b821244b67eaa79ada7757d877 DIFF: https://github.com/llvm/llvm-project/commit/abf546dd4f8326b821244b67eaa79ada7757d877.diff